)]}'
{"setup.cfg":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"8be5cc12085cfe7360672bf6f187c41b82fcc29e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"     vnf_chain_list \u003d tackerclient.osc.v1.nfvo.vnffg:ListSFC"},{"line_number":82,"context_line":"     vnf_chain_show \u003d tackerclient.osc.v1.nfvo.vnffg:ShowSFC"},{"line_number":83,"context_line":"     vnfpack_create \u003d tackerclient.osc.v1.vnfpkgm.vnf_package:CreateVnfPackage"},{"line_number":84,"context_line":"     vnfpack_list \u003d tackerclient.osc.v1.vnfpkgm.vnf_package:ListVnfPackage"},{"line_number":85,"context_line":"     vnfpack_show \u003d tackerclient.osc.v1.vnfpkgm.vnf_package:ShowVnfPackage"},{"line_number":86,"context_line":"     vnfpack_delete \u003d tackerclient.osc.v1.vnfpkgm.vnf_package:DeleteVnfPackage"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"[build_releasenotes]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"5faad753_01525914","line":86,"range":{"start_line":84,"start_character":5,"end_line":86,"end_character":19},"updated":"2019-09-09 11:00:24.000000000","message":"vnf_package_list\nvnf_package_show\nvnf_package_delete","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"5cab02095d5a1b73a5ebedb38b1f4c7c80ef5a30","unresolved":false,"context_lines":[{"line_number":81,"context_line":"     vnf_chain_list \u003d tackerclient.osc.v1.nfvo.vnffg:ListSFC"},{"line_number":82,"context_line":"     vnf_chain_show \u003d tackerclient.osc.v1.nfvo.vnffg:ShowSFC"},{"line_number":83,"context_line":"     vnfpack_create \u003d tackerclient.osc.v1.vnfpkgm.vnf_package:CreateVnfPackage"},{"line_number":84,"context_line":"     vnfpack_list \u003d tackerclient.osc.v1.vnfpkgm.vnf_package:ListVnfPackage"},{"line_number":85,"context_line":"     vnfpack_show \u003d tackerclient.osc.v1.vnfpkgm.vnf_package:ShowVnfPackage"},{"line_number":86,"context_line":"     vnfpack_delete \u003d tackerclient.osc.v1.vnfpkgm.vnf_package:DeleteVnfPackage"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"[build_releasenotes]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"5faad753_d75c024d","line":86,"range":{"start_line":84,"start_character":5,"end_line":86,"end_character":19},"in_reply_to":"5faad753_01525914","updated":"2019-09-09 13:31:46.000000000","message":"Done","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"}],"tackerclient/osc/v1/vnfpkgm/vnf_package.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"a1e637b7dbd528391b2da9b33521d7abf082ff76","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_attr_map \u003d ("},{"line_number":30,"context_line":"    (\u0027id\u0027, \u0027id\u0027, tacker_osc_utils.LIST_BOTH),"},{"line_number":31,"context_line":"    (\u0027onboardingState\u0027, \u0027onboarding_state\u0027, tacker_osc_utils.LIST_BOTH),"},{"line_number":32,"context_line":"    (\u0027usageState\u0027, \u0027usage_state\u0027, tacker_osc_utils.LIST_BOTH),"},{"line_number":33,"context_line":"    (\u0027operationalState\u0027, \u0027operational_state\u0027, tacker_osc_utils.LIST_BOTH),"},{"line_number":34,"context_line":"    (\u0027userDefinedData\u0027, \u0027user_defined_data\u0027, tacker_osc_utils.LIST_BOTH)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_5c7ee16b","line":31,"updated":"2019-09-10 09:21:56.000000000","message":"I want to add (\u0027vnfProductName\u0027, \u0027VNF_Product_Name\u0027, tacker_osc_utils.LIST_BOTH) next to id.","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4334be86f0f1bccf65ac8874521d66c099c4e5a7","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_attr_map \u003d ("},{"line_number":30,"context_line":"    (\u0027id\u0027, \u0027id\u0027, tacker_osc_utils.LIST_BOTH),"},{"line_number":31,"context_line":"    (\u0027onboardingState\u0027, \u0027onboarding_state\u0027, tacker_osc_utils.LIST_BOTH),"},{"line_number":32,"context_line":"    (\u0027usageState\u0027, \u0027usage_state\u0027, tacker_osc_utils.LIST_BOTH),"},{"line_number":33,"context_line":"    (\u0027operationalState\u0027, \u0027operational_state\u0027, tacker_osc_utils.LIST_BOTH),"},{"line_number":34,"context_line":"    (\u0027userDefinedData\u0027, \u0027user_defined_data\u0027, tacker_osc_utils.LIST_BOTH)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_e29e0462","line":31,"in_reply_to":"5faad753_5c7ee16b","updated":"2019-09-12 13:45:18.000000000","message":"Done","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"a1e637b7dbd528391b2da9b33521d7abf082ff76","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def _get_columns(vnf_package_obj, action\u003d\"create\"):"},{"line_number":46,"context_line":"    column_map \u003d {"},{"line_number":47,"context_line":"        \u0027_links\u0027: \u0027links\u0027,"},{"line_number":48,"context_line":"        \u0027onboardingState\u0027: \u0027onboarding_state\u0027,"},{"line_number":49,"context_line":"        \u0027operationalState\u0027: \u0027operational_state\u0027,"},{"line_number":50,"context_line":"        \u0027usageState\u0027: \u0027usage_state\u0027,"},{"line_number":51,"context_line":"        \u0027userDefinedData\u0027: \u0027user_defined_data\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_7ccf1db0","line":48,"updated":"2019-09-10 09:21:56.000000000","message":"Also, I want to add (\u0027vnfProductName\u0027, \u0027VNF_Product_Name\u0027, tacker_osc_utils.LIST_BOTH) as a regular column.","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"7cf52707582b53abe44687cdd6a59d7652f03d27","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def _get_columns(vnf_package_obj, action\u003d\"create\"):"},{"line_number":46,"context_line":"    column_map \u003d {"},{"line_number":47,"context_line":"        \u0027_links\u0027: \u0027links\u0027,"},{"line_number":48,"context_line":"        \u0027onboardingState\u0027: \u0027onboarding_state\u0027,"},{"line_number":49,"context_line":"        \u0027operationalState\u0027: \u0027operational_state\u0027,"},{"line_number":50,"context_line":"        \u0027usageState\u0027: \u0027usage_state\u0027,"},{"line_number":51,"context_line":"        \u0027userDefinedData\u0027: \u0027user_defined_data\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_f872e7ac","line":48,"in_reply_to":"5faad753_224bbc2b","updated":"2019-09-13 04:47:21.000000000","message":"I got it, thanks.","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4334be86f0f1bccf65ac8874521d66c099c4e5a7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def _get_columns(vnf_package_obj, action\u003d\"create\"):"},{"line_number":46,"context_line":"    column_map \u003d {"},{"line_number":47,"context_line":"        \u0027_links\u0027: \u0027links\u0027,"},{"line_number":48,"context_line":"        \u0027onboardingState\u0027: \u0027onboarding_state\u0027,"},{"line_number":49,"context_line":"        \u0027operationalState\u0027: \u0027operational_state\u0027,"},{"line_number":50,"context_line":"        \u0027usageState\u0027: \u0027usage_state\u0027,"},{"line_number":51,"context_line":"        \u0027userDefinedData\u0027: \u0027user_defined_data\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_224bbc2b","line":48,"in_reply_to":"5faad753_7ccf1db0","updated":"2019-09-12 13:45:18.000000000","message":"Jo san, If I add it as regular column then it will always be empty (because create vnf package response data do not have \u0027vnfProductname\u0027\n\nand for list command _get_columns method is not used. in that case _attr_map will be used","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"a1e637b7dbd528391b2da9b33521d7abf082ff76","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027userDefinedData\u0027: \u0027user_defined_data\u0027,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    if action \u003d\u003d \u0027show\u0027 and vnf_package_obj[\u0027onboardingState\u0027] \u003d\u003d \u0027ONBOARDED\u0027:"},{"line_number":55,"context_line":"        column_map.update({"},{"line_number":56,"context_line":"            \u0027additionalArtifacts\u0027: \u0027additional_artifacts\u0027,"},{"line_number":57,"context_line":"            \u0027checksum\u0027: \u0027checksum\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_dce65145","line":54,"range":{"start_line":54,"start_character":7,"end_line":54,"end_character":28},"updated":"2019-09-10 09:21:56.000000000","message":"I thinks this conditional expression is not needed.","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4334be86f0f1bccf65ac8874521d66c099c4e5a7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027userDefinedData\u0027: \u0027user_defined_data\u0027,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    if action \u003d\u003d \u0027show\u0027 and vnf_package_obj[\u0027onboardingState\u0027] \u003d\u003d \u0027ONBOARDED\u0027:"},{"line_number":55,"context_line":"        column_map.update({"},{"line_number":56,"context_line":"            \u0027additionalArtifacts\u0027: \u0027additional_artifacts\u0027,"},{"line_number":57,"context_line":"            \u0027checksum\u0027: \u0027checksum\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_a28a4c18","line":54,"range":{"start_line":54,"start_character":7,"end_line":54,"end_character":28},"in_reply_to":"5faad753_dce65145","updated":"2019-09-12 13:45:18.000000000","message":"Done","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"}],"tackerclient/tests/unit/osc/v1/test_vnf_package.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"a1e637b7dbd528391b2da9b33521d7abf082ff76","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            json\u003dself._vnf_package, headers\u003dself.header)"},{"line_number":109,"context_line":"        columns, data \u003d (self.list_vnf_package.take_action(parsed_args))"},{"line_number":110,"context_line":"        self.assertItemsEqual(_get_columns_vnf_package(), tuple(columns))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"@ddt.ddt"},{"line_number":114,"context_line":"class TestShowVnfPackage(TestVnfPackage):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_bc17d5a3","line":111,"updated":"2019-09-10 09:21:56.000000000","message":"Why don\u0027t you examine accuracy of `data`?","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"a73e52953bc52154cb498f04e779e7bcf097f608","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            json\u003dself._vnf_package, headers\u003dself.header)"},{"line_number":109,"context_line":"        columns, data \u003d (self.list_vnf_package.take_action(parsed_args))"},{"line_number":110,"context_line":"        self.assertItemsEqual(_get_columns_vnf_package(), tuple(columns))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"@ddt.ddt"},{"line_number":114,"context_line":"class TestShowVnfPackage(TestVnfPackage):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_ef854d5b","line":111,"in_reply_to":"5faad753_8c81824d","updated":"2019-09-12 13:47:52.000000000","message":"sorry for above comment.  will fix this issue in next patch set","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4334be86f0f1bccf65ac8874521d66c099c4e5a7","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            json\u003dself._vnf_package, headers\u003dself.header)"},{"line_number":109,"context_line":"        columns, data \u003d (self.list_vnf_package.take_action(parsed_args))"},{"line_number":110,"context_line":"        self.assertItemsEqual(_get_columns_vnf_package(), tuple(columns))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"@ddt.ddt"},{"line_number":114,"context_line":"class TestShowVnfPackage(TestVnfPackage):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_8c81824d","line":111,"in_reply_to":"5faad753_bc17d5a3","updated":"2019-09-12 13:45:18.000000000","message":"Done","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb9a9f23601470f6708cfdd50ca93b6a74d30f89","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            json\u003dself._vnf_package, headers\u003dself.header)"},{"line_number":109,"context_line":"        columns, data \u003d (self.list_vnf_package.take_action(parsed_args))"},{"line_number":110,"context_line":"        self.assertItemsEqual(_get_columns_vnf_package(), tuple(columns))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"@ddt.ddt"},{"line_number":114,"context_line":"class TestShowVnfPackage(TestVnfPackage):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_383e3f8c","line":111,"in_reply_to":"5faad753_ef854d5b","updated":"2019-09-13 05:03:09.000000000","message":"added data assertion","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"}],"tackerclient/tests/unit/osc/v1/vnf_package_fakes.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"a1e637b7dbd528391b2da9b33521d7abf082ff76","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                    \"href\": \"string\""},{"line_number":93,"context_line":"                                }"},{"line_number":94,"context_line":"                            }"},{"line_number":95,"context_line":"                            }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # Overwrite default attributes."},{"line_number":98,"context_line":"    fake_vnf_package.update(attrs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_dcc5f13d","line":95,"range":{"start_line":95,"start_character":22,"end_line":95,"end_character":28},"updated":"2019-09-10 09:21:56.000000000","message":"redundant indent","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4334be86f0f1bccf65ac8874521d66c099c4e5a7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                    \"href\": \"string\""},{"line_number":93,"context_line":"                                }"},{"line_number":94,"context_line":"                            }"},{"line_number":95,"context_line":"                            }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # Overwrite default attributes."},{"line_number":98,"context_line":"    fake_vnf_package.update(attrs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_0cb4b234","line":95,"range":{"start_line":95,"start_character":22,"end_line":95,"end_character":28},"in_reply_to":"5faad753_dcc5f13d","updated":"2019-09-12 13:45:18.000000000","message":"Done","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"a1e637b7dbd528391b2da9b33521d7abf082ff76","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        \u0027CREATED\u0027, \u0027DISABLED\u0027, \u0027NOT_IN_USE\u0027, u\"Test_key\u003d\u0027Test_value\u0027\")"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":"    data_list \u003d []"},{"line_number":114,"context_line":"    if vnf_package is not None:"},{"line_number":115,"context_line":"        for x in sorted(vnf_package.keys()):"},{"line_number":116,"context_line":"                data_list.append(vnf_package[x])"},{"line_number":117,"context_line":"    return tuple(data_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_fcd54de6","line":114,"range":{"start_line":114,"start_character":18,"end_line":114,"end_character":30},"updated":"2019-09-10 09:21:56.000000000","message":"This can be remove.","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4334be86f0f1bccf65ac8874521d66c099c4e5a7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        \u0027CREATED\u0027, \u0027DISABLED\u0027, \u0027NOT_IN_USE\u0027, u\"Test_key\u003d\u0027Test_value\u0027\")"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":"    data_list \u003d []"},{"line_number":114,"context_line":"    if vnf_package is not None:"},{"line_number":115,"context_line":"        for x in sorted(vnf_package.keys()):"},{"line_number":116,"context_line":"                data_list.append(vnf_package[x])"},{"line_number":117,"context_line":"    return tuple(data_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_ac847e5f","line":114,"range":{"start_line":114,"start_character":18,"end_line":114,"end_character":30},"in_reply_to":"5faad753_fcd54de6","updated":"2019-09-12 13:45:18.000000000","message":"Done","commit_id":"90cb262ccf0016c16f1006ed4c6ce891bc162baa"}]}