)]}'
{"tackerclient/osc/v1/vnfpkgm/vnf_package.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"ba2b95b8e7746bb4adb8f6d806d8478de653af30","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def get_parser(self, prog_name):"},{"line_number":146,"context_line":"        LOG.debug(\u0027get_parser(%s)\u0027, prog_name)"},{"line_number":147,"context_line":"        parser \u003d super(UploadVnfPackage, self).get_parser(prog_name)"},{"line_number":148,"context_line":"        parser.add_argument("},{"line_number":149,"context_line":"            \u0027vnf_package_id\u0027,"},{"line_number":150,"context_line":"            metavar\u003d\"\u003cvnf-package-id\u003e\","},{"line_number":151,"context_line":"            help\u003d_(\"Vnf package ID to upload\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_a776dea3","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":27},"updated":"2019-09-10 09:42:09.000000000","message":"We should add `required\u003dTrue` parameter.","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"8c6c8ae96fb28038d5bd634d6824279d7b3a39a7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def get_parser(self, prog_name):"},{"line_number":146,"context_line":"        LOG.debug(\u0027get_parser(%s)\u0027, prog_name)"},{"line_number":147,"context_line":"        parser \u003d super(UploadVnfPackage, self).get_parser(prog_name)"},{"line_number":148,"context_line":"        parser.add_argument("},{"line_number":149,"context_line":"            \u0027vnf_package_id\u0027,"},{"line_number":150,"context_line":"            metavar\u003d\"\u003cvnf-package-id\u003e\","},{"line_number":151,"context_line":"            help\u003d_(\"Vnf package ID to upload\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_80b2a3e5","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":27},"in_reply_to":"5faad753_a776dea3","updated":"2019-09-12 13:48:37.000000000","message":"positional argument do not accept \u0027required\u003dTrue\u0027 parameter","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"ba2b95b8e7746bb4adb8f6d806d8478de653af30","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            metavar\u003d\"\u003cvnf-package-id\u003e\","},{"line_number":151,"context_line":"            help\u003d_(\"Vnf package ID to upload\")"},{"line_number":152,"context_line":"        )"},{"line_number":153,"context_line":"        parser.add_argument("},{"line_number":154,"context_line":"            \"--upload-method\","},{"line_number":155,"context_line":"            metavar\u003d\"\u003cMETHOD\u003e\","},{"line_number":156,"context_line":"            default\u003d\u0027direct-file\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_e735b6db","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":28},"updated":"2019-09-10 09:42:09.000000000","message":"We should add \u0027choices\u0027 parameter like \u0027choices\u003d[\u0027direct-file\u0027, \u0027web-download\u0027].","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"8c6c8ae96fb28038d5bd634d6824279d7b3a39a7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            metavar\u003d\"\u003cvnf-package-id\u003e\","},{"line_number":151,"context_line":"            help\u003d_(\"Vnf package ID to upload\")"},{"line_number":152,"context_line":"        )"},{"line_number":153,"context_line":"        parser.add_argument("},{"line_number":154,"context_line":"            \"--upload-method\","},{"line_number":155,"context_line":"            metavar\u003d\"\u003cMETHOD\u003e\","},{"line_number":156,"context_line":"            default\u003d\u0027direct-file\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_d35cdb7f","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":28},"in_reply_to":"5faad753_c94af6aa","updated":"2019-09-12 13:48:37.000000000","message":"Done","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"aea5bc4182bf44ec17cbbf14b66e02fc3a99990e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            metavar\u003d\"\u003cvnf-package-id\u003e\","},{"line_number":151,"context_line":"            help\u003d_(\"Vnf package ID to upload\")"},{"line_number":152,"context_line":"        )"},{"line_number":153,"context_line":"        parser.add_argument("},{"line_number":154,"context_line":"            \"--upload-method\","},{"line_number":155,"context_line":"            metavar\u003d\"\u003cMETHOD\u003e\","},{"line_number":156,"context_line":"            default\u003d\u0027direct-file\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_c94af6aa","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":28},"in_reply_to":"5faad753_e735b6db","updated":"2019-09-11 07:08:46.000000000","message":"Instead of 2 options, --upload-method, --path, I prefer mutual exclusive option group, --path or --url.\nIs it possible to add the code like below?\n\nfile_source \u003d parser.add_mutually_exclusive_group(required\u003dTrue)\nfile_source.add_argument(\u0027--path\u0027, ... )\nfile_source.add_argument(\u0027--url\u0027, ... )","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"8c6c8ae96fb28038d5bd634d6824279d7b3a39a7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            metavar\u003d\"\u003cvnf-package-id\u003e\","},{"line_number":151,"context_line":"            help\u003d_(\"Vnf package ID to upload\")"},{"line_number":152,"context_line":"        )"},{"line_number":153,"context_line":"        parser.add_argument("},{"line_number":154,"context_line":"            \"--upload-method\","},{"line_number":155,"context_line":"            metavar\u003d\"\u003cMETHOD\u003e\","},{"line_number":156,"context_line":"            default\u003d\u0027direct-file\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_db3ace96","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":28},"in_reply_to":"5faad753_e735b6db","updated":"2019-09-12 13:48:37.000000000","message":"implemented as per below comment (mutually exclusive group). so this comment is not applicable","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"ba2b95b8e7746bb4adb8f6d806d8478de653af30","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        client \u003d self.app.client_manager.tackerclient"},{"line_number":181,"context_line":"        attrs \u003d {}"},{"line_number":182,"context_line":"        if parsed_args.upload_method \u003d\u003d \u0027direct-file\u0027:"},{"line_number":183,"context_line":"            file_data \u003d open(parsed_args.path, \u0027rb\u0027)"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            file_data \u003d None"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_47d84a7e","line":183,"range":{"start_line":183,"start_character":12,"end_line":183,"end_character":52},"updated":"2019-09-10 09:42:09.000000000","message":"The file seems never closed.","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"8c6c8ae96fb28038d5bd634d6824279d7b3a39a7","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        client \u003d self.app.client_manager.tackerclient"},{"line_number":181,"context_line":"        attrs \u003d {}"},{"line_number":182,"context_line":"        if parsed_args.upload_method \u003d\u003d \u0027direct-file\u0027:"},{"line_number":183,"context_line":"            file_data \u003d open(parsed_args.path, \u0027rb\u0027)"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            file_data \u003d None"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_3bcc4269","line":183,"range":{"start_line":183,"start_character":12,"end_line":183,"end_character":52},"in_reply_to":"5faad753_47d84a7e","updated":"2019-09-12 13:48:37.000000000","message":"Done","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"c678945d2a0bad12bff57188d899bda606505f49","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        attrs[\u0027path\u0027] \u003d parsed_args.path"},{"line_number":194,"context_line":"        attrs[\u0027upload-method\u0027] \u003d parsed_args.upload_method"},{"line_number":195,"context_line":"        client.upload_vnf_package(parsed_args.vnf_package_id, file_data,"},{"line_number":196,"context_line":"                                  **attrs)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class DeleteVnfPackage(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_64be9666","line":196,"updated":"2019-09-10 17:07:11.000000000","message":"Why there is no return output?\nPlease add as in package create,","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"8c6c8ae96fb28038d5bd634d6824279d7b3a39a7","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        attrs[\u0027path\u0027] \u003d parsed_args.path"},{"line_number":194,"context_line":"        attrs[\u0027upload-method\u0027] \u003d parsed_args.upload_method"},{"line_number":195,"context_line":"        client.upload_vnf_package(parsed_args.vnf_package_id, file_data,"},{"line_number":196,"context_line":"                                  **attrs)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class DeleteVnfPackage(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_134d9399","line":196,"in_reply_to":"5faad753_64be9666","updated":"2019-09-12 13:48:37.000000000","message":"As we are not getting response data from tacker api.\n\nI have just printed the message","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"2509e0681d98d1cfbe5f42b6a8cac4883c068e80","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        finally:"},{"line_number":200,"context_line":"            if file_data:"},{"line_number":201,"context_line":"                file_data.close()"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class DeleteVnfPackage(command.Command):"},{"line_number":205,"context_line":"    \"\"\"Vnf package delete"}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_ac543022","line":202,"updated":"2019-09-13 07:23:28.000000000","message":"we needs to return display_columns, currently there is no output display of upload command.","commit_id":"f7a3ba6137e2d3e5f814f38ac1c1e6d0aff52761"}],"tackerclient/v1_0/client.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"ba2b95b8e7746bb4adb8f6d806d8478de653af30","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    @APIParamsCall"},{"line_number":755,"context_line":"    def upload_vnf_package(self, vnf_package, file_data\u003dNone, **attrs):"},{"line_number":756,"context_line":"        username \u003d attrs.get(\u0027userName\u0027)"},{"line_number":757,"context_line":"        password \u003d attrs.get(\u0027password\u0027)"},{"line_number":758,"context_line":"        upload_method \u003d attrs.get(\u0027upload-method\u0027)"},{"line_number":759,"context_line":"        if upload_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":760,"context_line":"            json \u003d {\u0027addressInformation\u0027: attrs.get(\u0027path\u0027)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_c73afa96","line":757,"range":{"start_line":756,"start_character":0,"end_line":757,"end_character":40},"updated":"2019-09-10 09:42:09.000000000","message":"These 2 lines should be moved to just after Line 759.","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"8c6c8ae96fb28038d5bd634d6824279d7b3a39a7","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    @APIParamsCall"},{"line_number":755,"context_line":"    def upload_vnf_package(self, vnf_package, file_data\u003dNone, **attrs):"},{"line_number":756,"context_line":"        username \u003d attrs.get(\u0027userName\u0027)"},{"line_number":757,"context_line":"        password \u003d attrs.get(\u0027password\u0027)"},{"line_number":758,"context_line":"        upload_method \u003d attrs.get(\u0027upload-method\u0027)"},{"line_number":759,"context_line":"        if upload_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":760,"context_line":"            json \u003d {\u0027addressInformation\u0027: attrs.get(\u0027path\u0027)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_3b3f6226","line":757,"range":{"start_line":756,"start_character":0,"end_line":757,"end_character":40},"in_reply_to":"5faad753_c73afa96","updated":"2019-09-12 13:48:37.000000000","message":"Done","commit_id":"c2d38e021751b4e6c94ab80b6799626ec3a76c0f"}]}
