)]}'
{"tackerclient/osc/v1/vnfpkgm/vnf_package.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"6b823422e6f6f336e93c6fc829024007b8292e6f","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            default\u003d\"application/zip\","},{"line_number":288,"context_line":"            metavar\u003d\"\u003ctype\u003e\","},{"line_number":289,"context_line":"            choices\u003d[\"text/plain\", \"application/zip\", \"both\"],"},{"line_number":290,"context_line":"            help\u003d_(\" Provide text/plain when VNFD is implemented as a single \""},{"line_number":291,"context_line":"                   \"YAML file otherwise  use application/zip. If you are not \""},{"line_number":292,"context_line":"                   \"aware whether VNFD is a single or multiple yaml files, \""},{"line_number":293,"context_line":"                   \"then you can specify \u0027both\u0027 option value. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_d5e57c0c","line":290,"updated":"2020-03-20 18:40:53.000000000","message":"Is first space unnecessary?","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4af6b5eae904f0d5dcba48e68868a20f62a01552","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            default\u003d\"application/zip\","},{"line_number":288,"context_line":"            metavar\u003d\"\u003ctype\u003e\","},{"line_number":289,"context_line":"            choices\u003d[\"text/plain\", \"application/zip\", \"both\"],"},{"line_number":290,"context_line":"            help\u003d_(\" Provide text/plain when VNFD is implemented as a single \""},{"line_number":291,"context_line":"                   \"YAML file otherwise  use application/zip. If you are not \""},{"line_number":292,"context_line":"                   \"aware whether VNFD is a single or multiple yaml files, \""},{"line_number":293,"context_line":"                   \"then you can specify \u0027both\u0027 option value. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_3f97d93c","line":290,"in_reply_to":"df33271e_d5e57c0c","updated":"2020-03-30 13:10:24.000000000","message":"Done","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"6b823422e6f6f336e93c6fc829024007b8292e6f","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    def take_action(self, parsed_args):"},{"line_number":299,"context_line":"        client \u003d self.app.client_manager.tackerclient"},{"line_number":300,"context_line":"        if parsed_args.vnfd:"},{"line_number":301,"context_line":"            if sys.stdout.isatty() and not parsed_args.file and \\"},{"line_number":302,"context_line":"                    parsed_args.type !\u003d \"text/plain\":"},{"line_number":303,"context_line":"                msg \u003d (\"No redirection or local file specified for downloaded \""},{"line_number":304,"context_line":"                       \"VNFD data. Please specify a local file with --file to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_75bab0de","line":301,"updated":"2020-03-20 18:40:53.000000000","message":"OpenStack Style guideline says\n\"It is preferred to wrap long lines in parentheses and not a backslash for line continuation.\"\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4af6b5eae904f0d5dcba48e68868a20f62a01552","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    def take_action(self, parsed_args):"},{"line_number":299,"context_line":"        client \u003d self.app.client_manager.tackerclient"},{"line_number":300,"context_line":"        if parsed_args.vnfd:"},{"line_number":301,"context_line":"            if sys.stdout.isatty() and not parsed_args.file and \\"},{"line_number":302,"context_line":"                    parsed_args.type !\u003d \"text/plain\":"},{"line_number":303,"context_line":"                msg \u003d (\"No redirection or local file specified for downloaded \""},{"line_number":304,"context_line":"                       \"VNFD data. Please specify a local file with --file to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_1f9c955b","line":301,"in_reply_to":"df33271e_75bab0de","updated":"2020-03-30 13:10:24.000000000","message":"Done","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"29b550430bd01138e652d1fc9ff55ff55b1cbdb9","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"class DownloadVnfPackage(command.Command):"},{"line_number":263,"context_line":"    _description \u003d _(\"Read VNFD of an on-boarded VNF Package\")"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def get_parser(self, prog_name):"},{"line_number":266,"context_line":"        parser \u003d super(DownloadVnfPackage, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_f4f542cc","line":263,"updated":"2020-04-02 12:28:08.000000000","message":"or a whole VNF Package CSAR file.","commit_id":"ec27a743cf5154ba3cb10262f0788d299fa52fe7"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"14798aa322419078c8b0624b519996750ef42bf8","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"class DownloadVnfPackage(command.Command):"},{"line_number":263,"context_line":"    _description \u003d _(\"Read VNFD of an on-boarded VNF Package\")"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def get_parser(self, prog_name):"},{"line_number":266,"context_line":"        parser \u003d super(DownloadVnfPackage, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_3cbe5ed4","line":263,"in_reply_to":"df33271e_f4f542cc","updated":"2020-04-03 06:16:51.000000000","message":"As this patch supports read vnfd only, hence keeping as it is. But I have updated this message in its child patch (https://review.opendev.org/#/c/706244/3/tackerclient/osc/v1/vnfpkgm/vnf_package.py@263)","commit_id":"ec27a743cf5154ba3cb10262f0788d299fa52fe7"}],"tackerclient/v1_0/client.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"6b823422e6f6f336e93c6fc829024007b8292e6f","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            self.format \u003d \u0027zip\u0027"},{"line_number":210,"context_line":"        elif \u0027text/plain\u0027 \u003d\u003d resp.headers.get(\u0027Content-Type\u0027):"},{"line_number":211,"context_line":"            self.format \u003d \u0027text\u0027"},{"line_number":212,"context_line":"        else:"},{"line_number":213,"context_line":"            self.format \u003d \u0027json\u0027"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        status_code \u003d resp.status_code"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_b5d6f8c2","line":212,"updated":"2020-03-20 18:40:53.000000000","message":"Just question, is it okay to delete if statement which check content is application/json?","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4af6b5eae904f0d5dcba48e68868a20f62a01552","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            self.format \u003d \u0027zip\u0027"},{"line_number":210,"context_line":"        elif \u0027text/plain\u0027 \u003d\u003d resp.headers.get(\u0027Content-Type\u0027):"},{"line_number":211,"context_line":"            self.format \u003d \u0027text\u0027"},{"line_number":212,"context_line":"        else:"},{"line_number":213,"context_line":"            self.format \u003d \u0027json\u0027"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        status_code \u003d resp.status_code"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_df634e41","line":212,"in_reply_to":"df33271e_b5d6f8c2","updated":"2020-03-30 13:10:24.000000000","message":"last else statement is required to handle fault response properly. It is needed to print proper error message.\n\nkindly go through below link. Test case is failing when removed else statement http://paste.openstack.org/show/791330/\n\nAlso you can refer the patch \nhttps://review.opendev.org/#/c/688886/1/tackerclient/v1_0/client.py","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"6b823422e6f6f336e93c6fc829024007b8292e6f","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def deserialize(self, data, status_code):"},{"line_number":247,"context_line":"        \"\"\"Deserializes an XML or JSON string into a dictionary.\"\"\""},{"line_number":248,"context_line":"        if status_code in (204, 202) or self.format in \\"},{"line_number":249,"context_line":"                (\u0027zip\u0027, \u0027text\u0027):"},{"line_number":250,"context_line":"            return data"},{"line_number":251,"context_line":"        return serializer.Serializer(self.get_attr_metadata()).deserialize("}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_15ac048b","line":248,"updated":"2020-03-20 18:40:53.000000000","message":"is this line break unnecessary?","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4af6b5eae904f0d5dcba48e68868a20f62a01552","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def deserialize(self, data, status_code):"},{"line_number":247,"context_line":"        \"\"\"Deserializes an XML or JSON string into a dictionary.\"\"\""},{"line_number":248,"context_line":"        if status_code in (204, 202) or self.format in \\"},{"line_number":249,"context_line":"                (\u0027zip\u0027, \u0027text\u0027):"},{"line_number":250,"context_line":"            return data"},{"line_number":251,"context_line":"        return serializer.Serializer(self.get_attr_metadata()).deserialize("}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_bfaac96d","line":248,"in_reply_to":"df33271e_15ac048b","updated":"2020-03-30 13:10:24.000000000","message":"removed","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"6da860378b8eef10881a42723b78f601ba7f35bd","unresolved":false,"context_lines":[{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @APIParamsCall"},{"line_number":791,"context_line":"    def download_vnfd_from_vnf_package(self, vnf_package, accept):"},{"line_number":792,"context_line":"        \"\"\"Read VNFD of an on-boarded VNF Package"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        :param vnf_package: The value can be either the ID of a vnf package"},{"line_number":795,"context_line":"                            or a :class:`~openstack.nfv_orchestration.v1."}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_dd41b8a7","line":792,"updated":"2020-03-10 20:44:18.000000000","message":"It should be ended with a \u0027.\u0027 for the convention.","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"4af6b5eae904f0d5dcba48e68868a20f62a01552","unresolved":false,"context_lines":[{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @APIParamsCall"},{"line_number":791,"context_line":"    def download_vnfd_from_vnf_package(self, vnf_package, accept):"},{"line_number":792,"context_line":"        \"\"\"Read VNFD of an on-boarded VNF Package"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        :param vnf_package: The value can be either the ID of a vnf package"},{"line_number":795,"context_line":"                            or a :class:`~openstack.nfv_orchestration.v1."}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_df950d35","line":792,"in_reply_to":"1fa4df85_dd41b8a7","updated":"2020-03-30 13:10:24.000000000","message":"Done","commit_id":"647f3f76aa9e7df4764eec67885da487954d7609"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"29b550430bd01138e652d1fc9ff55ff55b1cbdb9","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                constants.EXT_NS: ns}"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def content_type(self, _format\u003dNone):"},{"line_number":267,"context_line":"        \"\"\"Returns the mime-type for either \u0027xml\u0027 or \u0027json\u0027."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        Defaults to the currently set format."},{"line_number":270,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_9462f6ac","line":267,"range":{"start_line":267,"start_character":37,"end_line":267,"end_character":59},"updated":"2020-04-02 12:28:08.000000000","message":"Could you update this properly?","commit_id":"ec27a743cf5154ba3cb10262f0788d299fa52fe7"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"14798aa322419078c8b0624b519996750ef42bf8","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                constants.EXT_NS: ns}"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def content_type(self, _format\u003dNone):"},{"line_number":267,"context_line":"        \"\"\"Returns the mime-type for either \u0027xml\u0027 or \u0027json\u0027."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        Defaults to the currently set format."},{"line_number":270,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_1cc1da54","line":267,"range":{"start_line":267,"start_character":37,"end_line":267,"end_character":59},"in_reply_to":"df33271e_9462f6ac","updated":"2020-04-03 06:16:51.000000000","message":"Done","commit_id":"ec27a743cf5154ba3cb10262f0788d299fa52fe7"}]}