)]}'
{"tackerclient/osc/v1/vnflcm/vnflcm.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_VNF_INSTANCE \u003d \u0027vnf_instance\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"VNF_INSTANCE_TERMINATION_TIMEOUT \u003d 300"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_columns(vnflcm_obj, action\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_f2fd643b","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":38},"updated":"2020-03-17 10:17:44.000000000","message":"I think it\u0027s better to create a new constants.py because it is more explicit that it is a constant.","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb7edaab9e22b55259d9fa810f453e752ed253c6","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_VNF_INSTANCE \u003d \u0027vnf_instance\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"VNF_INSTANCE_TERMINATION_TIMEOUT \u003d 300"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_columns(vnflcm_obj, action\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_f6044e17","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":38},"in_reply_to":"1fa4df85_f2fd643b","updated":"2020-03-19 11:20:00.000000000","message":"As these constants are used only in this module. I think we don\u0027t need constants.py","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"d521e616155764653cc738a539613e093895d236","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_VNF_INSTANCE \u003d \u0027vnf_instance\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"VNF_INSTANCE_TERMINATION_TIMEOUT \u003d 300"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_columns(vnflcm_obj, action\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_a06c5508","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":38},"in_reply_to":"1fa4df85_f2fd643b","updated":"2020-04-01 10:29:38.000000000","message":"I think it can be done but this particular constant is not used in other modules so I think keeping it in this module is more justified from developers point of view.","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":199,"context_line":"class TerminateVnfLcm(command.Command):"},{"line_number":200,"context_line":"    _description \u003d _(\"Terminate a VNF instance\")"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    VNF_TERMINATE_TIMEOUT \u003d 600"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def get_parser(self, prog_name):"},{"line_number":205,"context_line":"        parser \u003d super(TerminateVnfLcm, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_777ba6f3","line":202,"updated":"2020-03-17 10:17:44.000000000","message":"Not used.","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb7edaab9e22b55259d9fa810f453e752ed253c6","unresolved":false,"context_lines":[{"line_number":199,"context_line":"class TerminateVnfLcm(command.Command):"},{"line_number":200,"context_line":"    _description \u003d _(\"Terminate a VNF instance\")"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    VNF_TERMINATE_TIMEOUT \u003d 600"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def get_parser(self, prog_name):"},{"line_number":205,"context_line":"        parser \u003d super(TerminateVnfLcm, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_d6283287","line":202,"in_reply_to":"1fa4df85_777ba6f3","updated":"2020-03-19 11:20:00.000000000","message":"removed","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        parser.add_argument("},{"line_number":207,"context_line":"            _VNF_INSTANCE,"},{"line_number":208,"context_line":"            metavar\u003d\"\u003cvnf-instance\u003e\","},{"line_number":209,"context_line":"            help\u003d_(\"ID of VNF instance\"))"},{"line_number":210,"context_line":"        parser.add_argument("},{"line_number":211,"context_line":"            \"--termination-type\","},{"line_number":212,"context_line":"            default\u003d\u0027GRACEFUL\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_f71b1619","line":209,"range":{"start_line":209,"start_character":19,"end_line":209,"end_character":39},"updated":"2020-03-17 10:17:44.000000000","message":"I think it\u0027s better to unify with other patches as follows.\n\"VNF instance ID to terminate\"","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb7edaab9e22b55259d9fa810f453e752ed253c6","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        parser.add_argument("},{"line_number":207,"context_line":"            _VNF_INSTANCE,"},{"line_number":208,"context_line":"            metavar\u003d\"\u003cvnf-instance\u003e\","},{"line_number":209,"context_line":"            help\u003d_(\"ID of VNF instance\"))"},{"line_number":210,"context_line":"        parser.add_argument("},{"line_number":211,"context_line":"            \"--termination-type\","},{"line_number":212,"context_line":"            default\u003d\u0027GRACEFUL\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_961e3a5d","line":209,"range":{"start_line":209,"start_character":19,"end_line":209,"end_character":39},"in_reply_to":"1fa4df85_f71b1619","updated":"2020-03-19 11:20:00.000000000","message":"Done","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            \u0027--D\u0027,"},{"line_number":227,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":228,"context_line":"            default\u003dFalse,"},{"line_number":229,"context_line":"            help\u003d_(\"Delete VNF Instance subsequently after it\u0027s terminated\"),"},{"line_number":230,"context_line":"        )"},{"line_number":231,"context_line":"        return parser"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_57b78ad9","line":229,"range":{"start_line":229,"start_character":19,"end_line":229,"end_character":75},"updated":"2020-03-17 10:17:44.000000000","message":"I think it\u0027s better to unify with other patches as follows.\n\"Delete VNF Instance subsequently after it\u0027s termination.\"","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb7edaab9e22b55259d9fa810f453e752ed253c6","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            \u0027--D\u0027,"},{"line_number":227,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":228,"context_line":"            default\u003dFalse,"},{"line_number":229,"context_line":"            help\u003d_(\"Delete VNF Instance subsequently after it\u0027s terminated\"),"},{"line_number":230,"context_line":"        )"},{"line_number":231,"context_line":"        return parser"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_f67bee88","line":229,"range":{"start_line":229,"start_character":19,"end_line":229,"end_character":75},"in_reply_to":"1fa4df85_57b78ad9","updated":"2020-03-19 11:20:00.000000000","message":"Done","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            # terminate vnf will start after this timeout period."},{"line_number":274,"context_line":"            # Hence, it should wait for extra time of 10 seconds"},{"line_number":275,"context_line":"            # after this graceful_termination_timeout period."},{"line_number":276,"context_line":"            timeout \u003d graceful_timeout + 10"},{"line_number":277,"context_line":"        else:"},{"line_number":278,"context_line":"            timeout \u003d VNF_INSTANCE_TERMINATION_TIMEOUT"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_529478e8","line":276,"range":{"start_line":276,"start_character":41,"end_line":276,"end_character":43},"updated":"2020-03-17 10:17:44.000000000","message":"It\u0027s better to define this in constants.py instead of hard-coding.","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb7edaab9e22b55259d9fa810f453e752ed253c6","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            # terminate vnf will start after this timeout period."},{"line_number":274,"context_line":"            # Hence, it should wait for extra time of 10 seconds"},{"line_number":275,"context_line":"            # after this graceful_termination_timeout period."},{"line_number":276,"context_line":"            timeout \u003d graceful_timeout + 10"},{"line_number":277,"context_line":"        else:"},{"line_number":278,"context_line":"            timeout \u003d VNF_INSTANCE_TERMINATION_TIMEOUT"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_7667feea","line":276,"range":{"start_line":276,"start_character":41,"end_line":276,"end_character":43},"in_reply_to":"1fa4df85_529478e8","updated":"2020-03-19 11:20:00.000000000","message":"Done","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                        \"%(id)s\")"},{"line_number":290,"context_line":"                raise exceptions.CommandError(msg % {\u0027timeout\u0027: timeout,"},{"line_number":291,"context_line":"                                              \u0027id\u0027: vnf_instance_id})"},{"line_number":292,"context_line":"            time.sleep(1)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"class DeleteVnfLcm(command.Command):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_729734ed","line":292,"range":{"start_line":292,"start_character":23,"end_line":292,"end_character":24},"updated":"2020-03-17 10:17:44.000000000","message":"It\u0027s better to define this in constants.py instead of hard-coding.","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb7edaab9e22b55259d9fa810f453e752ed253c6","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                        \"%(id)s\")"},{"line_number":290,"context_line":"                raise exceptions.CommandError(msg % {\u0027timeout\u0027: timeout,"},{"line_number":291,"context_line":"                                              \u0027id\u0027: vnf_instance_id})"},{"line_number":292,"context_line":"            time.sleep(1)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"class DeleteVnfLcm(command.Command):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_365d0615","line":292,"range":{"start_line":292,"start_character":23,"end_line":292,"end_character":24},"in_reply_to":"1fa4df85_729734ed","updated":"2020-03-19 11:20:00.000000000","message":"Done","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            \u0027vnf_instances\u0027,"},{"line_number":308,"context_line":"            metavar\u003d\"\u003cvnf-instance\u003e\","},{"line_number":309,"context_line":"            nargs\u003d\"+\","},{"line_number":310,"context_line":"            help\u003d_(\"ID(s) of VNF instance(s)\"))"},{"line_number":311,"context_line":"        return parser"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_77d5e61a","line":310,"range":{"start_line":310,"start_character":19,"end_line":310,"end_character":45},"updated":"2020-03-17 10:17:44.000000000","message":"I think it\u0027s better to unify with other patches as follows.\n\"VNF instance ID(s) to delete\"","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb7edaab9e22b55259d9fa810f453e752ed253c6","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            \u0027vnf_instances\u0027,"},{"line_number":308,"context_line":"            metavar\u003d\"\u003cvnf-instance\u003e\","},{"line_number":309,"context_line":"            nargs\u003d\"+\","},{"line_number":310,"context_line":"            help\u003d_(\"ID(s) of VNF instance(s)\"))"},{"line_number":311,"context_line":"        return parser"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_d69b52c6","line":310,"range":{"start_line":310,"start_character":19,"end_line":310,"end_character":45},"in_reply_to":"1fa4df85_77d5e61a","updated":"2020-03-19 11:20:00.000000000","message":"Done","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        return parser"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def take_action(self, parsed_args):"},{"line_number":314,"context_line":"        del_result \u003d 0"},{"line_number":315,"context_line":"        client \u003d self.app.client_manager.tackerclient"},{"line_number":316,"context_line":"        vnf_instances \u003d parsed_args.vnf_instances"},{"line_number":317,"context_line":"        for vnf_instance in vnf_instances:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_721c1477","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":18},"updated":"2020-03-17 10:17:44.000000000","message":"It’s better to rename \u0027error_count\u0027.","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb7edaab9e22b55259d9fa810f453e752ed253c6","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        return parser"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def take_action(self, parsed_args):"},{"line_number":314,"context_line":"        del_result \u003d 0"},{"line_number":315,"context_line":"        client \u003d self.app.client_manager.tackerclient"},{"line_number":316,"context_line":"        vnf_instances \u003d parsed_args.vnf_instances"},{"line_number":317,"context_line":"        for vnf_instance in vnf_instances:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_f6a0cef6","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":18},"in_reply_to":"1fa4df85_721c1477","updated":"2020-03-19 11:20:00.000000000","message":"Done","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                          \u0027total\u0027: total})"},{"line_number":331,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":332,"context_line":"        else:"},{"line_number":333,"context_line":"            if len(vnf_instances) \u003e 1:"},{"line_number":334,"context_line":"                print(_(\u0027All specified vnf instances are deleted \u0027"},{"line_number":335,"context_line":"                        \u0027successfully\u0027))"},{"line_number":336,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_d28708b6","line":333,"range":{"start_line":333,"start_character":15,"end_line":333,"end_character":33},"updated":"2020-03-17 10:17:44.000000000","message":"It’s better to use \u0027total\u0027.","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"}],"tackerclient/tests/unit/osc/v1/vnflcm_fakes.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b23d69f01d8eb8bf0ecca5b10a62ec5d3c3b064f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"def create_vnf_instances(count\u003d2):"},{"line_number":125,"context_line":"    \"\"\"Create multiple fake vnf instances."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    :param Dictionary attrs:"},{"line_number":128,"context_line":"        A dictionary with all attributes"},{"line_number":129,"context_line":"    :param int count:"},{"line_number":130,"context_line":"        The number of vnf instances to fake"},{"line_number":131,"context_line":"    :return:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_f7f236e3","line":128,"range":{"start_line":127,"start_character":4,"end_line":128,"end_character":40},"updated":"2020-03-17 10:17:44.000000000","message":"\"attrs\" is not present in the argument.","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"eb7edaab9e22b55259d9fa810f453e752ed253c6","unresolved":false,"context_lines":[{"line_number":124,"context_line":"def create_vnf_instances(count\u003d2):"},{"line_number":125,"context_line":"    \"\"\"Create multiple fake vnf instances."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    :param Dictionary attrs:"},{"line_number":128,"context_line":"        A dictionary with all attributes"},{"line_number":129,"context_line":"    :param int count:"},{"line_number":130,"context_line":"        The number of vnf instances to fake"},{"line_number":131,"context_line":"    :return:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_767b7e27","line":128,"range":{"start_line":127,"start_character":4,"end_line":128,"end_character":40},"in_reply_to":"1fa4df85_f7f236e3","updated":"2020-03-19 11:20:00.000000000","message":"Done","commit_id":"75517a2741a74e22fc650a7ae0f925e47efcbac9"}]}