)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    information."},{"line_number":15,"context_line":"  * Add new OSC command ``vnf package artifact`` to fetch individual artifact"},{"line_number":16,"context_line":"    in an on-boarded VNF package."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id0694724f2f2e335c14824bc5ca5bf2e67ac4b96"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_d6967149","line":17,"updated":"2020-09-09 06:32:19.000000000","message":"Please add `implements` tag for the blueprint.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    information."},{"line_number":15,"context_line":"  * Add new OSC command ``vnf package artifact`` to fetch individual artifact"},{"line_number":16,"context_line":"    in an on-boarded VNF package."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id0694724f2f2e335c14824bc5ca5bf2e67ac4b96"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_2c38e79d","line":17,"in_reply_to":"9f560f44_d6967149","updated":"2020-09-14 12:18:14.000000000","message":"I add implemets tag in the newest patch, also for https://review.opendev.org/#/c/739697/ \nplease kindly have a check","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"}],"tackerclient/client.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"cf3614afab248f178151efbc8332ecb8a277c5ee","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        kargs \u003d {}"},{"line_number":85,"context_line":"        kargs.setdefault(\u0027headers\u0027, kwargs.get(\u0027headers\u0027, {}))"},{"line_number":86,"context_line":"        kargs[\u0027headers\u0027][\u0027User-Agent\u0027] \u003d self.USER_AGENT"},{"line_number":87,"context_line":"        if \u0027body\u0027 in kwargs:"},{"line_number":88,"context_line":"            kargs[\u0027body\u0027] \u003d kwargs[\u0027body\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if self.log_credentials:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d7952a8a","line":87,"updated":"2020-09-09 17:52:31.000000000","message":"very minor point, but is this deletion needed?\nIt\u0027s better not to include unnecessary file change as possible.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        kargs \u003d {}"},{"line_number":85,"context_line":"        kargs.setdefault(\u0027headers\u0027, kwargs.get(\u0027headers\u0027, {}))"},{"line_number":86,"context_line":"        kargs[\u0027headers\u0027][\u0027User-Agent\u0027] \u003d self.USER_AGENT"},{"line_number":87,"context_line":"        if \u0027body\u0027 in kwargs:"},{"line_number":88,"context_line":"            kargs[\u0027body\u0027] \u003d kwargs[\u0027body\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if self.log_credentials:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4c5c3bf0","line":87,"in_reply_to":"9f560f44_d7952a8a","updated":"2020-09-14 12:18:14.000000000","message":"I think this change is made by pep8 check tool. I have fixed it in patch#4 .","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"}],"tackerclient/osc/v1/vnfpkgm/vnf_package.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        if not parsed_args.file:"},{"line_number":457,"context_line":"            print(body)"},{"line_number":458,"context_line":"            return"},{"line_number":459,"context_line":"        sdk_utils.save_data(body, parsed_args.file)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b693fd5b","line":458,"updated":"2020-09-09 06:32:19.000000000","message":"Not preferred. Please use `else` in the next line.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        if not parsed_args.file:"},{"line_number":457,"context_line":"            print(body)"},{"line_number":458,"context_line":"            return"},{"line_number":459,"context_line":"        sdk_utils.save_data(body, parsed_args.file)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6c5bfff5","line":458,"in_reply_to":"9f560f44_b693fd5b","updated":"2020-09-14 12:18:14.000000000","message":"I add a else line in patch #4","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"}],"tackerclient/tests/unit/osc/v1/fixture_data/sample_vnf_package_artifacts/Definitions/etsi_nfv_sol001_common_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_0"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_f6a735a7","line":1,"updated":"2020-09-09 06:32:19.000000000","message":"Please make it to be more understandable. We cannot what should do from it.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_0"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_0cffe3ab","line":1,"in_reply_to":"9f560f44_f6a735a7","updated":"2020-09-14 12:18:14.000000000","message":"I have replaced this file by official one in patch #4","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"}],"tackerclient/tests/unit/osc/v1/fixture_data/sample_vnf_package_artifacts/Definitions/etsi_nfv_sol001_vnfd_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_0"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_36b7edda","line":1,"updated":"2020-09-09 06:32:19.000000000","message":"Please make it to be more understandable. We cannot what should do from it.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_0"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_ec142fec","line":1,"in_reply_to":"9f560f44_36b7edda","updated":"2020-09-14 12:18:14.000000000","message":"I have replaced this file to a offcial one in patch #4","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"}],"tackerclient/tests/unit/osc/v1/fixture_data/sample_vnf_package_artifacts/Scripts/install.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"echo \"Hello, World!\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"9f560f44_5699c16a","line":1,"updated":"2020-09-09 06:32:19.000000000","message":"Did you change file mode? If so, please it makes no problem.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"echo \"Hello, World!\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"9f560f44_8cb2d305","line":1,"in_reply_to":"9f560f44_5699c16a","updated":"2020-09-14 12:18:14.000000000","message":"we created this new file and it seemed no problem in tox check","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"}],"tackerclient/tests/unit/osc/v1/fixture_data/sample_vnf_package_artifacts/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Hiroyuki JO"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9f560f44_b6a13d98","line":2,"updated":"2020-09-09 06:32:19.000000000","message":"You should avoid to use personal name.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Hiroyuki JO"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9f560f44_4c9d5b6b","line":2,"in_reply_to":"9f560f44_b6a13d98","updated":"2020-09-14 12:18:14.000000000","message":"I replaced with dummy user in patch #5","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"}],"tackerclient/tests/unit/osc/v1/test_vnf_package.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if exclude_fields:"},{"line_number":147,"context_line":"            columns.extend([field for field in complex_columns"},{"line_number":148,"context_line":"                            if field not in exclude_fields])"},{"line_number":149,"context_line":"        if all_fields:"},{"line_number":150,"context_line":"            columns.extend(complex_columns)"},{"line_number":151,"context_line":"            columns.extend(simple_columns)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_76ade582","line":148,"updated":"2020-09-09 06:32:19.000000000","message":"This change has no meaning, right?","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if exclude_fields:"},{"line_number":147,"context_line":"            columns.extend([field for field in complex_columns"},{"line_number":148,"context_line":"                            if field not in exclude_fields])"},{"line_number":149,"context_line":"        if all_fields:"},{"line_number":150,"context_line":"            columns.extend(complex_columns)"},{"line_number":151,"context_line":"            columns.extend(simple_columns)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0c9b6373","line":148,"in_reply_to":"9f560f44_76ade582","updated":"2020-09-14 12:18:14.000000000","message":"I think this change may casued by pep8 tool. I fixed it in patch4","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":764,"context_line":"                          self.download_vnf_package_artifacts, [], [])"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"    def _mock_request_url_for_download_artifacts("},{"line_number":767,"context_line":"        self,"},{"line_number":768,"context_line":"        artifact_path,"},{"line_number":769,"context_line":"        artifact_data):"},{"line_number":770,"context_line":"        self.header \u003d {\u0027content-type\u0027: \u0027text/plain\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f1457f45","line":767,"updated":"2020-09-09 06:32:19.000000000","message":"No need to make all args put in each line without any reason.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":764,"context_line":"                          self.download_vnf_package_artifacts, [], [])"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"    def _mock_request_url_for_download_artifacts("},{"line_number":767,"context_line":"        self,"},{"line_number":768,"context_line":"        artifact_path,"},{"line_number":769,"context_line":"        artifact_data):"},{"line_number":770,"context_line":"        self.header \u003d {\u0027content-type\u0027: \u0027text/plain\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4c86fb18","line":767,"in_reply_to":"9f560f44_f1457f45","updated":"2020-09-14 12:18:14.000000000","message":"same reason above, pep8 tool, I fixed this change in patch4","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        artifact_path,"},{"line_number":769,"context_line":"        artifact_data):"},{"line_number":770,"context_line":"        self.header \u003d {\u0027content-type\u0027: \u0027text/plain\u0027}"},{"line_number":771,"context_line":"        # get url"},{"line_number":772,"context_line":"        url \u003d os.path.join(self.url, \u0027vnfpkgm/v1/vnf_packages\u0027,"},{"line_number":773,"context_line":"                           self._vnf_package[\u0027id\u0027], \u0027artifacts\u0027, artifact_path)"},{"line_number":774,"context_line":"        # register uri"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3127f7b8","line":771,"updated":"2020-09-09 06:32:19.000000000","message":"It\u0027s almost no meaning.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        artifact_path,"},{"line_number":769,"context_line":"        artifact_data):"},{"line_number":770,"context_line":"        self.header \u003d {\u0027content-type\u0027: \u0027text/plain\u0027}"},{"line_number":771,"context_line":"        # get url"},{"line_number":772,"context_line":"        url \u003d os.path.join(self.url, \u0027vnfpkgm/v1/vnf_packages\u0027,"},{"line_number":773,"context_line":"                           self._vnf_package[\u0027id\u0027], \u0027artifacts\u0027, artifact_path)"},{"line_number":774,"context_line":"        # register uri"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ac76b73e","line":771,"in_reply_to":"9f560f44_3127f7b8","updated":"2020-09-14 12:18:14.000000000","message":"sorry for meanless comment out... I have delete this comment out in patch4","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"86bbaf3df32e8d89a0672864be94f9ac087ff586","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        # get url"},{"line_number":772,"context_line":"        url \u003d os.path.join(self.url, \u0027vnfpkgm/v1/vnf_packages\u0027,"},{"line_number":773,"context_line":"                           self._vnf_package[\u0027id\u0027], \u0027artifacts\u0027, artifact_path)"},{"line_number":774,"context_line":"        # register uri"},{"line_number":775,"context_line":"        self.requests_mock.register_uri(\u0027GET\u0027, url,"},{"line_number":776,"context_line":"                                        headers\u003dself.header,"},{"line_number":777,"context_line":"                                        text\u003dartifact_data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_711def60","line":774,"updated":"2020-09-09 06:32:19.000000000","message":"It\u0027s almost no meaning.","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"39e1200ad48089ed73114e5ede1721c8e439a017","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        # get url"},{"line_number":772,"context_line":"        url \u003d os.path.join(self.url, \u0027vnfpkgm/v1/vnf_packages\u0027,"},{"line_number":773,"context_line":"                           self._vnf_package[\u0027id\u0027], \u0027artifacts\u0027, artifact_path)"},{"line_number":774,"context_line":"        # register uri"},{"line_number":775,"context_line":"        self.requests_mock.register_uri(\u0027GET\u0027, url,"},{"line_number":776,"context_line":"                                        headers\u003dself.header,"},{"line_number":777,"context_line":"                                        text\u003dartifact_data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ec70af43","line":774,"in_reply_to":"9f560f44_711def60","updated":"2020-09-14 12:18:14.000000000","message":"sorry for meanless comment out... I have delete this comment out in patch4","commit_id":"123bb553e6a09e30029d4378c549d65aeb49f0d4"}]}
