)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a711ff15d84316f454a662968a10f9db3e6be987","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support of Scale command in openstackclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supported Scale command in Openstack Tacker Client."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I27b670c0aaa0c9b9cbce6ae44e03e5ba6234beb5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_7b74c0cf","line":10,"updated":"2020-09-10 09:33:42.000000000","message":"Please add `Implements` tag for blueprint.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d94878ed930acb5d746a7ebb0f45e240f1584c3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support of Scale command in openstackclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supported Scale command in Openstack Tacker Client."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I27b670c0aaa0c9b9cbce6ae44e03e5ba6234beb5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_4aa43ab9","line":10,"in_reply_to":"9f560f44_7b74c0cf","updated":"2020-09-11 15:02:49.000000000","message":"Done.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a711ff15d84316f454a662968a10f9db3e6be987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f560f44_ceed1ef1","line":12,"updated":"2020-09-10 09:33:42.000000000","message":"Please add `Implements` tag for your bp.","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d94878ed930acb5d746a7ebb0f45e240f1584c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f560f44_ca8faa2b","line":12,"in_reply_to":"9f560f44_ceed1ef1","updated":"2020-09-11 15:02:49.000000000","message":"Done.","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7706cfe0233ead1473805da35cd8d7b03f644978","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supported Scale command in Openstack Tacker Client."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: bp/support-etsi-nfv-specs"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I27b670c0aaa0c9b9cbce6ae44e03e5ba6234beb5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_3d3149a3","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":37},"updated":"2020-09-11 19:16:57.000000000","message":"Wrong format. Please refer to guidelines[1] or an example[2]\n[1] https://docs.opendev.org/opendev/infra-manual/latest/developers.html\n[2] https://review.opendev.org/#/c/698477/","commit_id":"25d92aef62115ec34dfcae73a0119481684f9e92"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6491cc54816a022b0f1bfa035255d6a3d8307d67","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supported Scale command in Openstack Tacker Client."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: bp/support-etsi-nfv-specs"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I27b670c0aaa0c9b9cbce6ae44e03e5ba6234beb5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_b05f333f","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":37},"in_reply_to":"9f560f44_3d3149a3","updated":"2020-09-14 03:24:28.000000000","message":"Fixed.","commit_id":"25d92aef62115ec34dfcae73a0119481684f9e92"}],"tackerclient/osc/v1/vnflcm/samples/scale_vnf_instance_param_sample.json":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"967e020e5ab217b1609d53d0e5c3a85c2e4ba69c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"type\": [\"SCALE_OUT\",\"SCALE_IN\"],"},{"line_number":3,"context_line":"    \"aspectId\" : \"sample_id\","},{"line_number":4,"context_line":"    \"numberOfSteps\" : 1,"},{"line_number":5,"context_line":"    \"additionalParam\": {\"key1\":\"value1\", \"key2\":\"value2\"}"},{"line_number":6,"context_line":"  }"}],"source_content_type":"application/json","patch_set":1,"id":"9f560f44_89e845e2","line":5,"updated":"2020-08-25 09:47:18.000000000","message":"According to the description of ETSI NFV-SOL, I think it\u0027s better to use \"additionalParams\".","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"77d9e7fefcfe7632f55b9bd552340f5b6ff07e39","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"type\": [\"SCALE_OUT\",\"SCALE_IN\"],"},{"line_number":3,"context_line":"    \"aspectId\" : \"sample_id\","},{"line_number":4,"context_line":"    \"numberOfSteps\" : 1,"},{"line_number":5,"context_line":"    \"additionalParam\": {\"key1\":\"value1\", \"key2\":\"value2\"}"},{"line_number":6,"context_line":"  }"}],"source_content_type":"application/json","patch_set":1,"id":"9f560f44_1002ec6f","line":5,"in_reply_to":"9f560f44_89e845e2","updated":"2020-09-04 03:18:36.000000000","message":"Corrected as pointed out.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a711ff15d84316f454a662968a10f9db3e6be987","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"additionalParams\": {\"key1\":\"value1\", \"key2\":\"value2\"}"},{"line_number":3,"context_line":"  }"}],"source_content_type":"application/json","patch_set":2,"id":"9f560f44_ce9b5e70","line":3,"updated":"2020-09-10 09:33:42.000000000","message":"It\u0027s better to align indenting.","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d94878ed930acb5d746a7ebb0f45e240f1584c3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"additionalParams\": {\"key1\":\"value1\", \"key2\":\"value2\"}"},{"line_number":3,"context_line":"  }"}],"source_content_type":"application/json","patch_set":2,"id":"9f560f44_4a8d5a2f","line":3,"in_reply_to":"9f560f44_ce9b5e70","updated":"2020-09-11 15:02:49.000000000","message":"Done.","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"}],"tackerclient/osc/v1/vnflcm/vnflcm.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"967e020e5ab217b1609d53d0e5c3a85c2e4ba69c","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                        \"successfully\") % vnf_instances[0])"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"class ScaleVnfLcm(command.Command):"},{"line_number":413,"context_line":"    def get_parser(self, prog_name):"},{"line_number":414,"context_line":"        \"\"\"[summary]"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_443f3486","line":412,"updated":"2020-08-25 09:47:18.000000000","message":"For help option, it\u0027s better to add the following.\n_description \u003d _(\"Scale a VNF Instance\")","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"77d9e7fefcfe7632f55b9bd552340f5b6ff07e39","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                        \"successfully\") % vnf_instances[0])"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"class ScaleVnfLcm(command.Command):"},{"line_number":413,"context_line":"    def get_parser(self, prog_name):"},{"line_number":414,"context_line":"        \"\"\"[summary]"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_50f3c49f","line":412,"in_reply_to":"9f560f44_443f3486","updated":"2020-09-04 03:18:36.000000000","message":"It is corrected as pointed out.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a711ff15d84316f454a662968a10f9db3e6be987","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"class ScaleVnfLcm(command.Command):"},{"line_number":413,"context_line":"    def get_parser(self, prog_name):"},{"line_number":414,"context_line":"        \"\"\"[summary]"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        Args:"},{"line_number":417,"context_line":"            prog_name ([string]): program name"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f652a712","line":414,"updated":"2020-09-10 09:33:42.000000000","message":"I don’ t understand this line. Is it a something memo for a later update?","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d94878ed930acb5d746a7ebb0f45e240f1584c3","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"class ScaleVnfLcm(command.Command):"},{"line_number":413,"context_line":"    def get_parser(self, prog_name):"},{"line_number":414,"context_line":"        \"\"\"[summary]"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        Args:"},{"line_number":417,"context_line":"            prog_name ([string]): program name"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0aa402a2","line":414,"in_reply_to":"9f560f44_f652a712","updated":"2020-09-11 15:02:49.000000000","message":"Deleted due to unnecessary line.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"967e020e5ab217b1609d53d0e5c3a85c2e4ba69c","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            parser [ArgumentParser]: [description]"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        parser \u003d super(ScaleVnfLcm, self).get_parser(prog_name)"},{"line_number":423,"context_line":"        parser.add_argument("},{"line_number":424,"context_line":"            \u0027vnf_instance_id\u0027,"},{"line_number":425,"context_line":"            metavar\u003d\"\u003cvnf-instance-id\u003e\","},{"line_number":426,"context_line":"            help\u003d_(\u0027VNF instance ID\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e4d76822","line":423,"updated":"2020-08-25 09:47:18.000000000","message":"To unify with other operations, it\u0027s better to define as follows.\nparser.add_argument(\n   _VNF_INSTANCE,\n   metavar\u003d\"\u003cvnf-instance\u003e\",\n   help\u003d_(\"VNF instance ID to scale\"))","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"77d9e7fefcfe7632f55b9bd552340f5b6ff07e39","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            parser [ArgumentParser]: [description]"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        parser \u003d super(ScaleVnfLcm, self).get_parser(prog_name)"},{"line_number":423,"context_line":"        parser.add_argument("},{"line_number":424,"context_line":"            \u0027vnf_instance_id\u0027,"},{"line_number":425,"context_line":"            metavar\u003d\"\u003cvnf-instance-id\u003e\","},{"line_number":426,"context_line":"            help\u003d_(\u0027VNF instance ID\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b0f22099","line":423,"in_reply_to":"9f560f44_e4d76822","updated":"2020-09-04 03:18:36.000000000","message":"It is corrected as pointed out.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6b55d6fb3f3d1571fc63fd00855dd8bd067097b0","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            \u0027vnf_instance_id\u0027,"},{"line_number":425,"context_line":"            metavar\u003d\"\u003cvnf-instance-id\u003e\","},{"line_number":426,"context_line":"            help\u003d_(\u0027VNF instance ID\u0027))"},{"line_number":427,"context_line":"        parser.add_argument("},{"line_number":428,"context_line":"            \u0027--I\u0027,"},{"line_number":429,"context_line":"            metavar\u003d\"\u003cparam-file\u003e\","},{"line_number":430,"context_line":"            help\u003d_(\"Specify scale request parameters in a json file.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e013aa5a","line":427,"updated":"2020-08-27 06:06:20.000000000","message":"Like existing terminate code, it is better to decompose it into an argument rather than a single json file because it is user-friendly and validation can be performed.\nThe coding sample is shown below, so please refer to it.\n        parser.add_argument(\n            \u0027--type\u0027,\n            metavar\u003d\"\u003ctype\u003e\",\n            choices\u003d[\u0027IN\u0027, \u0027OUT\u0027],\n            help\u003d_(\"xxx\"))\n        parser.add_argument(\n            \u0027--aspect-id\u0027,\n            metavar\u003d\"\u003caspect-id\u003e\",\n            help\u003d_(\"xxx\"))\n        parser.add_argument(\n            \u0027--number-of-steps\u0027,\n            metavar\u003d\"\u003cnumber-of-steps\u003e\",\n            type\u003dint,\n            help\u003d_(\"xxx\"))\n        parser.add_argument(\n            \u0027--additional-param-file\u0027,\n            metavar\u003d\"\u003cadditional-param-file\u003e\",\n            help\u003d_(\"xxx\"))","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"77d9e7fefcfe7632f55b9bd552340f5b6ff07e39","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            \u0027vnf_instance_id\u0027,"},{"line_number":425,"context_line":"            metavar\u003d\"\u003cvnf-instance-id\u003e\","},{"line_number":426,"context_line":"            help\u003d_(\u0027VNF instance ID\u0027))"},{"line_number":427,"context_line":"        parser.add_argument("},{"line_number":428,"context_line":"            \u0027--I\u0027,"},{"line_number":429,"context_line":"            metavar\u003d\"\u003cparam-file\u003e\","},{"line_number":430,"context_line":"            help\u003d_(\"Specify scale request parameters in a json file.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_90ed5cb9","line":427,"in_reply_to":"9f560f44_e013aa5a","updated":"2020-09-04 03:18:36.000000000","message":"It is corrected as pointed out.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"967e020e5ab217b1609d53d0e5c3a85c2e4ba69c","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            help\u003d_(\"Specify scale request parameters in a json file.\"))"},{"line_number":431,"context_line":"        return parser"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def scale_vnf_args2body(self, file_path):"},{"line_number":434,"context_line":"        \"\"\"Store request body to body(dict) from param file(json)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_24b7a0f7","line":433,"updated":"2020-08-25 09:47:18.000000000","message":"Looks like almost the same method as existing instantiate_vnf_args2body.\nIs it possible to change the method name of instantiate_vnf_args2body and use it?","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"77d9e7fefcfe7632f55b9bd552340f5b6ff07e39","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            help\u003d_(\"Specify scale request parameters in a json file.\"))"},{"line_number":431,"context_line":"        return parser"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def scale_vnf_args2body(self, file_path):"},{"line_number":434,"context_line":"        \"\"\"Store request body to body(dict) from param file(json)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f02938f2","line":433,"in_reply_to":"9f560f44_24b7a0f7","updated":"2020-09-04 03:18:36.000000000","message":"Changed instantiate_vnf_args2body to jsonfile2body and fixed it to be used where indicated.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"967e020e5ab217b1609d53d0e5c3a85c2e4ba69c","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            result \u003d client.scale_vnf_instance("},{"line_number":491,"context_line":"                parsed_args.vnf_instance_id,"},{"line_number":492,"context_line":"                self.args2body(file_path\u003dparsed_args.I))"},{"line_number":493,"context_line":"        if not result:"},{"line_number":494,"context_line":"            print((_(\u0027Scale request for VNF Instance %(id)s has been\u0027"},{"line_number":495,"context_line":"                     \u0027 accepted.\u0027) % {\u0027id\u0027: parsed_args.vnf_instance_id}))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_84966c4b","line":493,"updated":"2020-08-25 09:47:18.000000000","message":"Is the indentation correct?\nI think this process should be included in \"if parsed_args.I:\".","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"77d9e7fefcfe7632f55b9bd552340f5b6ff07e39","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            result \u003d client.scale_vnf_instance("},{"line_number":491,"context_line":"                parsed_args.vnf_instance_id,"},{"line_number":492,"context_line":"                self.args2body(file_path\u003dparsed_args.I))"},{"line_number":493,"context_line":"        if not result:"},{"line_number":494,"context_line":"            print((_(\u0027Scale request for VNF Instance %(id)s has been\u0027"},{"line_number":495,"context_line":"                     \u0027 accepted.\u0027) % {\u0027id\u0027: parsed_args.vnf_instance_id}))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d02cf402","line":493,"in_reply_to":"9f560f44_84966c4b","updated":"2020-09-04 03:18:36.000000000","message":"Corrected as pointed out.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a711ff15d84316f454a662968a10f9db3e6be987","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                ) for s in vnf_instances))"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def jsonfile2body(file_path):"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if file_path is not None and os.access(file_path, os.R_OK) is False:"},{"line_number":188,"context_line":"        msg \u003d _(\"File %s does not exist or user does not have read \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_840e6c38","line":185,"updated":"2020-09-10 09:33:42.000000000","message":"Could you tell me why you changed the name? I don\u0027t understand why it\u0027s requierd.","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d94878ed930acb5d746a7ebb0f45e240f1584c3","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                ) for s in vnf_instances))"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def jsonfile2body(file_path):"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if file_path is not None and os.access(file_path, os.R_OK) is False:"},{"line_number":188,"context_line":"        msg \u003d _(\"File %s does not exist or user does not have read \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_caf4ca89","line":185,"in_reply_to":"9f560f44_840e6c38","updated":"2020-09-11 15:02:49.000000000","message":"It is due to the fix of the following comment on patchset 1.\n--------------------\nLine 433:\nLooks like almost the same method as existing instantiate_vnf_args2body.\nIs it possible to change the method name of instantiate_vnf_args2body and use it?","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a711ff15d84316f454a662968a10f9db3e6be987","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    _description \u003d _(\"Scale a VNF Instance\")"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def get_parser(self, prog_name):"},{"line_number":416,"context_line":"        \"\"\"[summary]"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        Args:"},{"line_number":419,"context_line":"            prog_name ([string]): program name"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1bb916cb","line":416,"updated":"2020-09-10 09:33:42.000000000","message":"Could you replace it with actual description?","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d94878ed930acb5d746a7ebb0f45e240f1584c3","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    _description \u003d _(\"Scale a VNF Instance\")"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def get_parser(self, prog_name):"},{"line_number":416,"context_line":"        \"\"\"[summary]"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        Args:"},{"line_number":419,"context_line":"            prog_name ([string]): program name"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_4a2efaf9","line":416,"in_reply_to":"9f560f44_1bb916cb","updated":"2020-09-11 15:02:49.000000000","message":"Deleted due to unnecessary description.","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0f09ed3f2b2dcaba4004d4063099da889ba66098","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                print((_(\u0027Update vnf:%(id)s \u0027) %"},{"line_number":467,"context_line":"                       {\u0027id\u0027: parsed_args.vnf_instance}))"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"class ScaleVnfLcm(command.Command):"},{"line_number":470,"context_line":"    _description \u003d _(\"Scale a VNF Instance\")"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ff44dcb9","line":469,"updated":"2020-09-13 07:46:21.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"416c8c9ce99a7a642f3b51ca2a9794421002af4c"}],"tackerclient/tests/unit/osc/v1/test_vnflcm.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"967e020e5ab217b1609d53d0e5c3a85c2e4ba69c","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        self.assertEqual(expected_message, actual_message)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def test_take_action_param_file_not_exists(self):"},{"line_number":597,"context_line":"        \"\"\"[summary]"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"            Test if param file does not exist."},{"line_number":600,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4497343b","line":597,"updated":"2020-08-25 09:47:18.000000000","message":"I think this comment is unnecessary because there is no more information that can be read from the method name.\nSame for others.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"77d9e7fefcfe7632f55b9bd552340f5b6ff07e39","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        self.assertEqual(expected_message, actual_message)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def test_take_action_param_file_not_exists(self):"},{"line_number":597,"context_line":"        \"\"\"[summary]"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"            Test if param file does not exist."},{"line_number":600,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_10378c4f","line":597,"in_reply_to":"9f560f44_4497343b","updated":"2020-09-04 03:18:36.000000000","message":"Deleted the comment.","commit_id":"dbc793bc8e4b17484f07ba9714075537d2cc4f36"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01ee7e151bb84f8f006a6e2cbcb7af997db8fe01","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        arglist \u003d [vnf_instance[\u0027id\u0027],"},{"line_number":571,"context_line":"                   \u0027--aspect-id\u0027, uuidsentinel.aspect_id,"},{"line_number":572,"context_line":"                   \u0027--number-of-steps\u0027, \u00271\u0027,"},{"line_number":573,"context_line":"                   \u0027--type\u0027, \u0027SCALE_IN\u0027,"},{"line_number":574,"context_line":"                   \u0027--additional-param-file\u0027, sample_param_file]"},{"line_number":575,"context_line":"        verifylist \u003d [(\u0027vnf_instance\u0027, vnf_instance[\u0027id\u0027]),"},{"line_number":576,"context_line":"                      (\u0027aspect_id\u0027, uuidsentinel.aspect_id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_67f72cd6","line":573,"updated":"2020-09-04 10:32:35.000000000","message":"It is better to test for \u0027SCALE_OUT\u0027 as well.","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d94878ed930acb5d746a7ebb0f45e240f1584c3","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        arglist \u003d [vnf_instance[\u0027id\u0027],"},{"line_number":571,"context_line":"                   \u0027--aspect-id\u0027, uuidsentinel.aspect_id,"},{"line_number":572,"context_line":"                   \u0027--number-of-steps\u0027, \u00271\u0027,"},{"line_number":573,"context_line":"                   \u0027--type\u0027, \u0027SCALE_IN\u0027,"},{"line_number":574,"context_line":"                   \u0027--additional-param-file\u0027, sample_param_file]"},{"line_number":575,"context_line":"        verifylist \u003d [(\u0027vnf_instance\u0027, vnf_instance[\u0027id\u0027]),"},{"line_number":576,"context_line":"                      (\u0027aspect_id\u0027, uuidsentinel.aspect_id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_31707ba4","line":573,"in_reply_to":"9f560f44_67f72cd6","updated":"2020-09-11 15:02:49.000000000","message":"The test case for SCALE_OUT was added.","commit_id":"cf5be36f6f202f887f5c1d9b632e52672bc449f7"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0f09ed3f2b2dcaba4004d4063099da889ba66098","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        parsed_args \u003d self.check_parser(self.update_vnf_lcm, arglist,"},{"line_number":603,"context_line":"                                        verifylist)"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        ex \u003d self.assertRaises(exceptions.InvalidInput,"},{"line_number":606,"context_line":"                               self.update_vnf_lcm.take_action, parsed_args)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_7f31ec58","line":605,"updated":"2020-09-13 07:46:21.000000000","message":"pep8: F841 local variable \u0027ex\u0027 is assigned to but never used","commit_id":"416c8c9ce99a7a642f3b51ca2a9794421002af4c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0f09ed3f2b2dcaba4004d4063099da889ba66098","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        ex \u003d self.assertRaises(exceptions.InvalidInput,"},{"line_number":606,"context_line":"                               self.update_vnf_lcm.take_action, parsed_args)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"@ddt.ddt"},{"line_number":609,"context_line":"class TestScaleVnfLcm(TestVnfLcm):"},{"line_number":610,"context_line":"    def setUp(self):"},{"line_number":611,"context_line":"        super(TestScaleVnfLcm, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_5f34e848","line":608,"updated":"2020-09-13 07:46:21.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"416c8c9ce99a7a642f3b51ca2a9794421002af4c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0f09ed3f2b2dcaba4004d4063099da889ba66098","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                          parsed_args)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"    @ddt.data(\u0027SCALE_IN\u0027, \u0027SCALE_OUT\u0027)"},{"line_number":705,"context_line":"    def test_take_action_vnf_instance_not_found(self, scale_type):"},{"line_number":706,"context_line":"        vnf_instance \u003d vnflcm_fakes.vnf_instance_response()"},{"line_number":707,"context_line":"        sample_param_file \u003d (\"./tackerclient/osc/v1/vnflcm/samples/\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_bf3ee425","line":704,"updated":"2020-09-13 07:46:21.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"416c8c9ce99a7a642f3b51ca2a9794421002af4c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0f09ed3f2b2dcaba4004d4063099da889ba66098","unresolved":false,"context_lines":[{"line_number":702,"context_line":""},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"    @ddt.data(\u0027SCALE_IN\u0027, \u0027SCALE_OUT\u0027)"},{"line_number":705,"context_line":"    def test_take_action_vnf_instance_not_found(self, scale_type):"},{"line_number":706,"context_line":"        vnf_instance \u003d vnflcm_fakes.vnf_instance_response()"},{"line_number":707,"context_line":"        sample_param_file \u003d (\"./tackerclient/osc/v1/vnflcm/samples/\""},{"line_number":708,"context_line":"                             \"update_vnf_instance_param_sample.json\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_9f396040","line":705,"updated":"2020-09-13 07:46:21.000000000","message":"pep8: F811 redefinition of unused \u0027test_take_action_vnf_instance_not_found\u0027 from line 680","commit_id":"416c8c9ce99a7a642f3b51ca2a9794421002af4c"}]}
