)]}'
{"id":"openstack%2Fpython-tackerclient~774776","triplet_id":"openstack%2Fpython-tackerclient~master~I25e1bdc32e0b91bbe02b82f79918c02b98e5f110","project":"openstack/python-tackerclient","branch":"master","topic":"bug/1847726","hashtags":[],"change_id":"I25e1bdc32e0b91bbe02b82f79918c02b98e5f110","subject":"Fix error message for nonexistent vnf package","status":"MERGED","created":"2021-02-10 08:16:12.000000000","updated":"2021-03-05 06:57:33.000000000","submitted":"2021-03-05 06:56:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"774776-bug/1847726","meta_rev_id":"9bab445f9d79dafb62127c194d87378ce040bb35","_number":774776,"virtual_id_number":774776,"owner":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":0,"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-05 06:56:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"recommended":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"all":[{"value":1,"date":"2021-03-04 02:44:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},{"value":2,"date":"2021-03-04 16:14:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":2,"date":"2021-03-05 06:47:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":1,"date":"2021-03-05 04:31:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"all":[{"value":0,"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":1,"date":"2021-03-05 06:47:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"reviewers":{"REVIEWER":[{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-10 08:22:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-10 08:26:23.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2021-02-18 10:11:38.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"state":"REVIEWER"},{"updated":"2021-02-18 10:11:38.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2021-02-18 10:11:38.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"state":"REVIEWER"},{"updated":"2021-03-01 08:06:11.000000000","updated_by":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"reviewer":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"state":"REVIEWER"},{"updated":"2021-03-04 17:43:58.000000000","updated_by":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"reviewer":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"state":"CC"},{"updated":"2021-03-05 04:31:39.000000000","updated_by":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"reviewer":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"state":"REVIEWER"}],"messages":[{"id":"0915aaf73f72145d011b4607542772757b6fa1b3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-10 08:16:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7d9665b78707eae2b08b2ad6e160e7078ea97f39","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-10 08:22:02.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"acaea16153c4d5ce7bae6e0e4e452034b3eade77","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-10 08:22:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/961bc5f628564bcf88b0a32fdce8550c : SUCCESS in 4m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fc85ca1f712346ad877928efcdd64553 : SUCCESS in 3m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6081b70dfe164936b716f77085cbc43f : SUCCESS in 3m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9a613f7f891a40618cd2e659e250e0fb : SUCCESS in 4m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a2a1174c6c654f5ba6029c173893d000 : SUCCESS in 3m 20s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/15711fa3014d491ca78a4266f793619e : SUCCESS in 4m 03s","accounts_in_message":[],"_revision_number":1},{"id":"071a195ecdefc9f0a1b26eacfead0951bf04c2da","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-10 08:23:42.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":1},{"id":"6316856cef45465109d88b0a87f6ca1371781699","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-10 08:26:23.000000000","message":"Patch Set 1:\n\nHi, \n\nCould you please review proposed design, would like to seek an early review so that I could proceed for further modification such as unit test cases.\n\nThanks in advance 😊","accounts_in_message":[],"_revision_number":1},{"id":"ec799e498e7e8f07cbe2154367622712df8b8e0c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-18 09:57:17.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2063cacf1f24048947fc381da356106a6b85077a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 10:08:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dc03becba4d24a088439fc6b3572e14e : SUCCESS in 6m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c26477cd9b674a089e761e22eebb4d92 : SUCCESS in 4m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ee6e09e7130b4ddba0ef00eab56bab08 : SUCCESS in 4m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d44e5179335d4956a2e7f177b78c1666 : SUCCESS in 6m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6e3705a3ee544e1daaeae4456ab66373 : SUCCESS in 5m 20s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/66e19c598c7647d4bf37a4d2996747d3 : SUCCESS in 4m 50s","accounts_in_message":[],"_revision_number":2},{"id":"d6f9406a1f52e2ddf8d43800d0108a51eb554205","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-02-19 01:21:44.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2b3276141485b319473c234836bd13979dc5afd1","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-02-19 02:47:18.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nIt\u0027s better to use jsonutils instead for consistency.","accounts_in_message":[],"_revision_number":2},{"id":"14c3575b8322b77bd0a22edb57cf78a733883cf1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-19 04:15:00.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"917dea55055f2d8b34722460bdab30170825d0c0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-19 04:21:58.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3d37450bf0d545adb9443fb118d3365e : SUCCESS in 4m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4b2ec6efc1e149b5bd664688357e3546 : SUCCESS in 3m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/433ffcec7e2e492083cd2b71230f8298 : SUCCESS in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6a6784c61cbe4c519e4349de82a8c56e : SUCCESS in 4m 50s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/faccbe82d2084549b76fcf68d51966a5 : SUCCESS in 4m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2192c820dfc34fbc8c6e123dcaf065b8 : SUCCESS in 4m 33s","accounts_in_message":[],"_revision_number":3},{"id":"3cf3323c1152e50e7a11ec4a3f793d60e6e02a5e","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-19 04:23:07.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"5d14e27237496115a1e8aacc2ecfcdc293a6d540","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-02-19 05:51:44.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"d1f9fbfbda9d46770b17148b2183cceb7c0596f4","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-19 18:03:39.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":3},{"id":"2f7c791f2f0f346a4b02d4fdb91d09991fdf3cf8","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-19 18:04:32.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":3},{"id":"56833493c1487c9652a8f48e760825457223632c","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-19 18:15:21.000000000","message":"Patch Set 3: Workflow-1\n\nHi reviewers,\n\nWhile reviewing  https://review.opendev.org/c/openstack/python-tackerclient/+/776214,\nI found that author has proposed a better solution to handle ETSI error response handling.\n\nAs this bug needs to be backported in the Victoria release. \nI have suggest author to either create a separate patch for error handling or I could implement the solution in this patch and add the owner as \"co-author\" of this patch. \n\nWould be waiting for the response.\n\nThanks","accounts_in_message":[],"_revision_number":3},{"id":"efec75bc416056f43a735014d7bda46a97f7b292","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-02-22 07:22:19.000000000","message":"Patch Set 3:\n\n\u003e Patch Set 3: Workflow-1\n\u003e \n\u003e Hi reviewers,\n\u003e \n\u003e While reviewing  https://review.opendev.org/c/openstack/python-tackerclient/+/776214,\n\u003e I found that author has proposed a better solution to handle ETSI error response handling.\n\u003e \n\u003e As this bug needs to be backported in the Victoria release. \n\u003e I have suggest author to either create a separate patch for error handling or I could implement the solution in this patch and add the owner as \"co-author\" of this patch. \n\u003e \n\u003e Would be waiting for the response.\n\u003e \n\u003e Thanks\n\ngot it","accounts_in_message":[],"_revision_number":3},{"id":"959ab637b9413e954f5b38e38491f0adcfd7f6a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-03-03 02:33:32.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1cea55f11ab546fdb9759af1e3b274a35451317e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-03 02:38:30.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/145316202d5b456ba5af4903c70b92b1 : SUCCESS in 4m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d101bc0012854a539e75273a7373f946 : SUCCESS in 3m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2c79db7bba034afca7bb85a898437a20 : SUCCESS in 4m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/56642189280b4c0db27fae8782062a42 : SUCCESS in 3m 28s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a843651afc854449963d8c4c2ae012b5 : SUCCESS in 3m 40s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d59fa24f4d2d4dc59ab55bbb336da8e6 : SUCCESS in 3m 44s","accounts_in_message":[],"_revision_number":4},{"id":"bc50f0e01490f4c1ddbddd8c8f4bc0456e053d7c","author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"date":"2021-03-04 02:44:05.000000000","message":"Patch Set 4: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":4},{"id":"71ba2ce2d843634cb94ceb6658e4d9914a191aa1","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-03-04 16:14:25.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"347825316c19f3e2aef8c568942d669ea712326f","author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"date":"2021-03-04 17:43:58.000000000","message":"Patch Set 4:\n\nHello Manpreet,\nIt seems the code you got from this patch: (https://review.opendev.org/c/openstack/python-tackerclient/+/776214) has a lacking validation for \"status\". \nAs defined in SOL013 v2.6.1 6.3, \"status\" cardinality is 1, so we added a validation for such parameter. So, I think this should be applied to your code, too.\n\nhttps://review.opendev.org/c/openstack/python-tackerclient/+/776214/4/tackerclient/v1_0/client.py (from line 99)","accounts_in_message":[],"_revision_number":4},{"id":"6c9acd9f3d0f4f74f6b1e26a609b98b58856f69d","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-03-04 23:55:24.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4:\n\u003e \n\u003e Hello Manpreet,\n\u003e It seems the code you got from this patch: (https://review.opendev.org/c/openstack/python-tackerclient/+/776214) has a lacking validation for \"status\". \n\u003e As defined in SOL013 v2.6.1 6.3, \"status\" cardinality is 1, so we added a validation for such parameter. So, I think this should be applied to your code, too.\n\u003e \n\u003e https://review.opendev.org/c/openstack/python-tackerclient/+/776214/4/tackerclient/v1_0/client.py (from line 99)\n\nAldinson,\n\nThanks for the suggestion, but I think it\u0027s no need because we should raise an exception if `isinstance(etsi_error_content, dict)` is True and there is no meaning to validate at this time. If we need to validate the status, we should do before that and take some action if required. What do you think?","accounts_in_message":[],"_revision_number":4},{"id":"bd4383b953c7b7f673b34993b82161a2ae72813b","author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"date":"2021-03-05 04:28:56.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4:\n\u003e \n\u003e \u003e Patch Set 4:\n\u003e \u003e \n\u003e \u003e Hello Manpreet,\n\u003e \u003e It seems the code you got from this patch: (https://review.opendev.org/c/openstack/python-tackerclient/+/776214) has a lacking validation for \"status\". \n\u003e \u003e As defined in SOL013 v2.6.1 6.3, \"status\" cardinality is 1, so we added a validation for such parameter. So, I think this should be applied to your code, too.\n\u003e \u003e \n\u003e \u003e https://review.opendev.org/c/openstack/python-tackerclient/+/776214/4/tackerclient/v1_0/client.py (from line 99)\n\u003e \n\u003e Aldinson,\n\u003e \n\u003e Thanks for the suggestion, but I think it\u0027s no need because we should raise an exception if `isinstance(etsi_error_content, dict)` is True and there is no meaning to validate at this time. If we need to validate the status, we should do before that and take some action if required. What do you think?\n\nI basically agree with it. Thank you for your point.\nAnyway, if some issue occurs it may be handled in another patch.","accounts_in_message":[],"_revision_number":4},{"id":"47dd63c5a67df2f5baca05f72cc3408d9409b3b6","author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"date":"2021-03-05 04:31:39.000000000","message":"Patch Set 4: Code-Review+1\n\nThank you.","accounts_in_message":[],"_revision_number":4},{"id":"5a361cb9d1a773f9e0848b4d7698dceab5393791","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-03-05 05:01:47.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4:\n\u003e \n\u003e \u003e Patch Set 4:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 4:\n\u003e \u003e \u003e \n\u003e \u003e \u003e Hello Manpreet,\n\u003e \u003e \u003e It seems the code you got from this patch: (https://review.opendev.org/c/openstack/python-tackerclient/+/776214) has a lacking validation for \"status\". \n\u003e \u003e \u003e As defined in SOL013 v2.6.1 6.3, \"status\" cardinality is 1, so we added a validation for such parameter. So, I think this should be applied to your code, too.\n\u003e \u003e \u003e \n\u003e \u003e \u003e https://review.opendev.org/c/openstack/python-tackerclient/+/776214/4/tackerclient/v1_0/client.py (from line 99)\n\u003e \u003e \n\u003e \u003e Aldinson,\n\u003e \u003e \n\u003e \u003e Thanks for the suggestion, but I think it\u0027s no need because we should raise an exception if `isinstance(etsi_error_content, dict)` is True and there is no meaning to validate at this time. If we need to validate the status, we should do before that and take some action if required. What do you think?\n\u003e \n\u003e I basically agree with it. Thank you for your point.\n\u003e Anyway, if some issue occurs it may be handled in another patch.\n\nthx :)","accounts_in_message":[],"_revision_number":4},{"id":"8d05521853962a5354891766ec85f9b14d9c24c1","author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"date":"2021-03-05 06:47:31.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"0afee4ba363ad5b1fd3975d37de7640048384215","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-05 06:47:46.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"99629b7c93eefc4cad813c8e9d1915ce928c2f1e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-05 06:56:20.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b4c477767da4489e921a5de74400c689 : SUCCESS in 5m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/778b8be622bf4ada981fd342e4791375 : SUCCESS in 4m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/57e7909c777f4154b2ed084f2162e77c : SUCCESS in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1104400e1e49491aa4b9bc8018b17d4d : SUCCESS in 6m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa61b2567f9d47a5a5f9ab885d2cee2d : SUCCESS in 4m 51s","accounts_in_message":[],"_revision_number":4},{"id":"72146e8bb2a77503daa413e1a8bb6c884bcb99f7","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-05 06:56:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"9bab445f9d79dafb62127c194d87378ce040bb35","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-05 06:57:33.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/de3068a7db2d4f5cbfcc2f17d89b755e : SUCCESS in 47s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"e7a0c96920349c5a335b9eb5e5aabd38d378434a","revisions":{"37af0d67089da3b8dd2f7ccde01a8281ba9471fe":{"kind":"REWORK","_number":1,"created":"2021-02-10 08:16:12.000000000","uploader":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"ref":"refs/changes/76/774776/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tackerclient","ref":"refs/changes/76/774776/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/1"}}},"commit":{"parents":[{"commit":"bbe6d2c7e0348aa6afb7200f0ab6416016305ab4","subject":"Modify operation of scale parameters","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/bbe6d2c7e0348aa6afb7200f0ab6416016305ab4"}]}],"author":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-02-10 08:12:25.000000000","tz":330},"committer":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-02-10 08:16:05.000000000","tz":330},"subject":"[WIP]Fix error message for nonexistent vnf package","message":"[WIP]Fix error message for nonexistent vnf package\n\nIn Victoria release, the error handling of non-existing VNF package\nwas modified, please refer to [1].\nOn passing a non-existing vnf package uuid to \"vnf package upload\"\ncommand, the tacker server sends an HTTP response with \"Content-Type\"\nheader as \"application/problem+json\" and the reason for a failure\ndescribed in the JSON problem details object.\n\nIn the current design, tackerclient does not support content-type\n\"application/problem+json\".\n\nImplementation:\n* While parsing HTTP request, this patch adds new content-type\n  \"application/problem+json\".\n* De-serialize the JSON problem details object, to create an exception\n  with HTTP status code and message\n\nThis patch fixes the issue and now it will output below error message:\n\n  $ openstack vnf package upload --path sample_vnf_pkg.zip dummy-id\n  Can not find requested vnf package: dummy-id\n\nNote: This bug was earlier address in Ussuri release, please refer [2].\n\n[1] https://review.opendev.org/c/openstack/tacker/+/747678/37/tacker/api/vnfpkgm/v1/controller.py\n[2] https://review.opendev.org/c/openstack/python-tackerclient/+/688886\n\nCloses-Bug: #1847726\nChange-Id: I25e1bdc32e0b91bbe02b82f79918c02b98e5f110\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/37af0d67089da3b8dd2f7ccde01a8281ba9471fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/37af0d67089da3b8dd2f7ccde01a8281ba9471fe"}]},"branch":"refs/heads/master"},"54cd00a6ea409b88f2f9c0f030443e99027231c2":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-02-18 09:57:17.000000000","uploader":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"ref":"refs/changes/76/774776/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tackerclient","ref":"refs/changes/76/774776/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/2"}}},"commit":{"parents":[{"commit":"bbe6d2c7e0348aa6afb7200f0ab6416016305ab4","subject":"Modify operation of scale parameters","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/bbe6d2c7e0348aa6afb7200f0ab6416016305ab4"}]}],"author":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-02-10 08:12:25.000000000","tz":330},"committer":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-02-18 09:56:35.000000000","tz":330},"subject":"Fix error message for nonexistent vnf package","message":"Fix error message for nonexistent vnf package\n\nIn Victoria release, the error handling of non-existing VNF package\nwas modified, please refer to [1].\nOn passing a non-existing vnf package uuid to \"vnf package upload\"\ncommand, the tacker server sends an HTTP response with \"Content-Type\"\nheader as \"application/problem+json\" and the reason for a failure\ndescribed in the JSON problem details object.\n\nIn the current design, tackerclient does not support content-type\n\"application/problem+json\".\n\nImplementation:\n* While parsing HTTP request, this patch adds new content-type\n  \"application/problem+json\".\n* De-serialize the JSON problem details object, to create an exception\n  with HTTP status code and message\n\nThis patch fixes the issue and now it will output below error message:\n\n  $ openstack vnf package upload --path sample_vnf_pkg.zip dummy-id\n  Can not find requested vnf package: dummy-id\n\nNote: This bug was earlier address in Ussuri release, please refer [2].\n\n[1] https://review.opendev.org/c/openstack/tacker/+/747678/37/tacker/api/vnfpkgm/v1/controller.py\n[2] https://review.opendev.org/c/openstack/python-tackerclient/+/688886\n\nCloses-Bug: #1847726\nChange-Id: I25e1bdc32e0b91bbe02b82f79918c02b98e5f110\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/54cd00a6ea409b88f2f9c0f030443e99027231c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/54cd00a6ea409b88f2f9c0f030443e99027231c2"}]},"branch":"refs/heads/master"},"b446b8b942193920010240f57baa9b976e4d8d02":{"kind":"REWORK","_number":3,"created":"2021-02-19 04:15:00.000000000","uploader":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"ref":"refs/changes/76/774776/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tackerclient","ref":"refs/changes/76/774776/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/3"}}},"commit":{"parents":[{"commit":"bbe6d2c7e0348aa6afb7200f0ab6416016305ab4","subject":"Modify operation of scale parameters","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/bbe6d2c7e0348aa6afb7200f0ab6416016305ab4"}]}],"author":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-02-10 08:12:25.000000000","tz":330},"committer":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-02-19 04:12:28.000000000","tz":330},"subject":"Fix error message for nonexistent vnf package","message":"Fix error message for nonexistent vnf package\n\nIn Victoria release, the error handling of non-existing VNF package\nwas modified, please refer to [1].\nOn passing a non-existing vnf package uuid to \"vnf package upload\"\ncommand, the tacker server sends an HTTP response with \"Content-Type\"\nheader as \"application/problem+json\" and the reason for a failure\ndescribed in the JSON problem details object.\n\nIn the current design, tackerclient does not support content-type\n\"application/problem+json\".\n\nImplementation:\n* While parsing HTTP request, this patch adds new content-type\n  \"application/problem+json\".\n* De-serialize the JSON problem details object, to create an exception\n  with HTTP status code and message\n\nThis patch fixes the issue and now it will output below error message:\n\n  $ openstack vnf package upload --path sample_vnf_pkg.zip dummy-id\n  Can not find requested vnf package: dummy-id\n\nNote: This bug was earlier address in Ussuri release, please refer [2].\n\n[1] https://review.opendev.org/c/openstack/tacker/+/747678/37/tacker/api/vnfpkgm/v1/controller.py\n[2] https://review.opendev.org/c/openstack/python-tackerclient/+/688886\n\nCloses-Bug: #1847726\nChange-Id: I25e1bdc32e0b91bbe02b82f79918c02b98e5f110\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/b446b8b942193920010240f57baa9b976e4d8d02"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/b446b8b942193920010240f57baa9b976e4d8d02"}]},"branch":"refs/heads/master"},"e7a0c96920349c5a335b9eb5e5aabd38d378434a":{"kind":"REWORK","_number":4,"created":"2021-03-03 02:33:32.000000000","uploader":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"ref":"refs/changes/76/774776/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tackerclient","ref":"refs/changes/76/774776/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tackerclient refs/changes/76/774776/4"}}},"commit":{"parents":[{"commit":"76da3dbd9dc992f7efa683a3946e503b2c97c4f5","subject":"Merge \"Fix old links in installation guide\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/76da3dbd9dc992f7efa683a3946e503b2c97c4f5"}]}],"author":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-02-10 08:12:25.000000000","tz":330},"committer":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-03-03 02:33:26.000000000","tz":330},"subject":"Fix error message for nonexistent vnf package","message":"Fix error message for nonexistent vnf package\n\nIn Victoria release, the error handling of non-existing VNF package\nwas modified, please refer to [1].\nOn passing a non-existing vnf package uuid to \"vnf package upload\"\ncommand, the tacker server sends an HTTP response with \"Content-Type\"\nheader as \"application/problem+json\" and the reason for a failure\ndescribed in the JSON problem details object.\n\nThis patch extracts the ETSI error message in method\nexception_handler_v10.\n\nFixes the issue and now it will output below error message:\n\n  $ openstack vnf package upload --path sample_vnf_pkg.zip dummy-id\n  Can not find requested vnf package: dummy-id\n\nNote: This bug was earlier address in Ussuri release, please refer [2].\n\n[1] https://review.opendev.org/c/openstack/tacker/+/747678/37/tacker/api/vnfpkgm/v1/controller.py\n[2] https://review.opendev.org/c/openstack/python-tackerclient/+/688886\n\nCo-Authored-By: Wataru Juso  w-juso@nec.com\nCloses-Bug: #1847726\nChange-Id: I25e1bdc32e0b91bbe02b82f79918c02b98e5f110\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/e7a0c96920349c5a335b9eb5e5aabd38d378434a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/e7a0c96920349c5a335b9eb5e5aabd38d378434a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}