)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2ec40fc64def063e1e14b24383a4fb6f31cce631","unresolved":true,"context_lines":[{"line_number":10,"context_line":"This command can execute Fail operation."},{"line_number":11,"context_line":"The API can change operationStatus from \"FAILED_TEMP\" to \"FAILED\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: support-error-handling"},{"line_number":14,"context_line":"Spec: https://review.opendev.org/c/openstack/tacker-specs/+/759349"},{"line_number":15,"context_line":"Change-Id: I83395e159e28c7e831dfe0ecd90435b3fb18c196"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a3a186d_73d037c1","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":66},"updated":"2021-02-19 07:53:55.000000000","message":"Could you please correct the syntax for \"Implements\" tag.\nPlease refer https://review.opendev.org/c/openstack/tacker/+/774733","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"8ec2d5e81dd34579a61ed0ac3a62686dbd707a8d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"This command can execute Fail operation."},{"line_number":11,"context_line":"The API can change operationStatus from \"FAILED_TEMP\" to \"FAILED\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: support-error-handling"},{"line_number":14,"context_line":"Spec: https://review.opendev.org/c/openstack/tacker-specs/+/759349"},{"line_number":15,"context_line":"Change-Id: I83395e159e28c7e831dfe0ecd90435b3fb18c196"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ea45dfd_807fd7a9","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":66},"in_reply_to":"1a3a186d_73d037c1","updated":"2021-02-19 15:24:30.000000000","message":"Sorry, I fixed it.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"}],"tackerclient/osc/v1/vnflcm/vnflcm_op_occs.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0b152bd0cc0f9c603cee3bb98a5187bbd8b3adf1","unresolved":true,"context_lines":[{"line_number":23,"context_line":"                      \u0027isCancelPending\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_FORMATTERS \u003d {\u0027error\u0027: tacker_osc_utils.FormatComplexDataColumn,"},{"line_number":26,"context_line":"               \u0027links\u0027: tacker_osc_utils.FormatComplexDataColumn}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_columns(vnflcm_op_occ_obj):"}],"source_content_type":"text/x-python","patch_set":1,"id":"41f14a34_a3280a70","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":22},"updated":"2021-02-19 02:33:41.000000000","message":"Is \u0027_links\u0027 correct?\nI think this will not be formatted correctly.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c5eb23e9445bf2737dc750811b3c1a71b48f27d1","unresolved":true,"context_lines":[{"line_number":23,"context_line":"                      \u0027isCancelPending\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_FORMATTERS \u003d {\u0027error\u0027: tacker_osc_utils.FormatComplexDataColumn,"},{"line_number":26,"context_line":"               \u0027links\u0027: tacker_osc_utils.FormatComplexDataColumn}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_columns(vnflcm_op_occ_obj):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd1c40db_4b6b8dc3","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":22},"in_reply_to":"41f14a34_a3280a70","updated":"2021-03-04 17:44:22.000000000","message":"\u003e Is \u0027_links\u0027 correct?\n\u003e I think this will not be formatted correctly.\n\nYes, it is correct. The code is updated.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98ecc9be8fd8ec1eb8f690e9e9e48384a4a2e4d1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                      \u0027isCancelPending\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_FORMATTERS \u003d {\u0027error\u0027: tacker_osc_utils.FormatComplexDataColumn,"},{"line_number":26,"context_line":"               \u0027links\u0027: tacker_osc_utils.FormatComplexDataColumn}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_columns(vnflcm_op_occ_obj):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7bfdb2dd_f4831889","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":22},"in_reply_to":"cd1c40db_4b6b8dc3","updated":"2021-03-05 06:06:36.000000000","message":"I\u0027ve confirmed.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0b152bd0cc0f9c603cee3bb98a5187bbd8b3adf1","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_columns(vnflcm_op_occ_obj):"},{"line_number":30,"context_line":"    column_map \u003d {"},{"line_number":31,"context_line":"        \u0027id\u0027: \u0027id\u0027,"},{"line_number":32,"context_line":"        \u0027operationState\u0027: \u0027operationState\u0027,"},{"line_number":33,"context_line":"        \u0027stateEnteredTime\u0027: \u0027stateEnteredTime\u0027,"},{"line_number":34,"context_line":"        \u0027startTime\u0027: \u0027startTime\u0027,"},{"line_number":35,"context_line":"        \u0027vnfInstanceId\u0027: \u0027vnfInstanceId\u0027,"},{"line_number":36,"context_line":"        \u0027operation\u0027: \u0027operation\u0027,"},{"line_number":37,"context_line":"        \u0027isAutomaticInvocation\u0027: \u0027isAutomaticInvocation\u0027,"},{"line_number":38,"context_line":"        \u0027isCancelPending\u0027: \u0027isCancelPending\u0027,"},{"line_number":39,"context_line":"        \u0027error\u0027: \u0027error\u0027,"},{"line_number":40,"context_line":"        \u0027_links\u0027: \u0027links\u0027"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    return sdk_utils.get_osc_show_columns_for_sdk_resource(vnflcm_op_occ_obj,"},{"line_number":44,"context_line":"                                                           column_map)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2b944b9_3fe5e4ea","line":41,"range":{"start_line":30,"start_character":0,"end_line":41,"end_character":5},"updated":"2021-02-19 02:33:41.000000000","message":"Since the value of this dict is the field name that is output after executing the CLI, isn\u0027t it easier to see the following description?\n      column_map \u003d {\n         \u0027id\u0027:\u0027ID\u0027,\n         \u0027operation State\u0027:\u0027 Operation State\u0027,\n         \u0027stateEnteredTime\u0027:\u0027State Entered Time\u0027,","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c5eb23e9445bf2737dc750811b3c1a71b48f27d1","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_columns(vnflcm_op_occ_obj):"},{"line_number":30,"context_line":"    column_map \u003d {"},{"line_number":31,"context_line":"        \u0027id\u0027: \u0027id\u0027,"},{"line_number":32,"context_line":"        \u0027operationState\u0027: \u0027operationState\u0027,"},{"line_number":33,"context_line":"        \u0027stateEnteredTime\u0027: \u0027stateEnteredTime\u0027,"},{"line_number":34,"context_line":"        \u0027startTime\u0027: \u0027startTime\u0027,"},{"line_number":35,"context_line":"        \u0027vnfInstanceId\u0027: \u0027vnfInstanceId\u0027,"},{"line_number":36,"context_line":"        \u0027operation\u0027: \u0027operation\u0027,"},{"line_number":37,"context_line":"        \u0027isAutomaticInvocation\u0027: \u0027isAutomaticInvocation\u0027,"},{"line_number":38,"context_line":"        \u0027isCancelPending\u0027: \u0027isCancelPending\u0027,"},{"line_number":39,"context_line":"        \u0027error\u0027: \u0027error\u0027,"},{"line_number":40,"context_line":"        \u0027_links\u0027: \u0027links\u0027"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    return sdk_utils.get_osc_show_columns_for_sdk_resource(vnflcm_op_occ_obj,"},{"line_number":44,"context_line":"                                                           column_map)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fe7f5e0e_f195eefe","line":41,"range":{"start_line":30,"start_character":0,"end_line":41,"end_character":5},"in_reply_to":"a2b944b9_3fe5e4ea","updated":"2021-03-04 17:44:22.000000000","message":"\u003e Since the value of this dict is the field name that is output after executing the CLI, isn\u0027t it easier to see the following description?\n\u003e       column_map \u003d {\n\u003e          \u0027id\u0027:\u0027ID\u0027,\n\u003e          \u0027operation State\u0027:\u0027 Operation State\u0027,\n\u003e          \u0027stateEnteredTime\u0027:\u0027State Entered Time\u0027,\n\ncolumn_map is modified.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98ecc9be8fd8ec1eb8f690e9e9e48384a4a2e4d1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_columns(vnflcm_op_occ_obj):"},{"line_number":30,"context_line":"    column_map \u003d {"},{"line_number":31,"context_line":"        \u0027id\u0027: \u0027id\u0027,"},{"line_number":32,"context_line":"        \u0027operationState\u0027: \u0027operationState\u0027,"},{"line_number":33,"context_line":"        \u0027stateEnteredTime\u0027: \u0027stateEnteredTime\u0027,"},{"line_number":34,"context_line":"        \u0027startTime\u0027: \u0027startTime\u0027,"},{"line_number":35,"context_line":"        \u0027vnfInstanceId\u0027: \u0027vnfInstanceId\u0027,"},{"line_number":36,"context_line":"        \u0027operation\u0027: \u0027operation\u0027,"},{"line_number":37,"context_line":"        \u0027isAutomaticInvocation\u0027: \u0027isAutomaticInvocation\u0027,"},{"line_number":38,"context_line":"        \u0027isCancelPending\u0027: \u0027isCancelPending\u0027,"},{"line_number":39,"context_line":"        \u0027error\u0027: \u0027error\u0027,"},{"line_number":40,"context_line":"        \u0027_links\u0027: \u0027links\u0027"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    return sdk_utils.get_osc_show_columns_for_sdk_resource(vnflcm_op_occ_obj,"},{"line_number":44,"context_line":"                                                           column_map)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a70e3b5c_b93ec883","line":41,"range":{"start_line":30,"start_character":0,"end_line":41,"end_character":5},"in_reply_to":"fe7f5e0e_f195eefe","updated":"2021-03-05 06:06:36.000000000","message":"I\u0027ve confirmed.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"37b87a3b4dd42b25839306991c3964c76f416977","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        parser \u003d super(RollbackVnfLcmOp, self).get_parser(prog_name)"},{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            _VNF_LCM_OP_OCC_ID,"},{"line_number":60,"context_line":"            metavar\u003d\"\u003cvnf-lcm-op-occ-id\u003e\","},{"line_number":61,"context_line":"            help\u003d_(\u0027VNF lifecycle management operation occurrence ID.\u0027))"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ee191dcc_3a503d6e","line":59,"updated":"2021-02-18 10:29:53.000000000","message":"Did you make it a variable to imitate \"_VNF_INSTANCE\" in \"tackerclient/osc/v1/vnflcm/vnflcm.py\"?","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"af831da1ad364d8e0fbea97a7bba5e994a15ec6b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        parser \u003d super(RollbackVnfLcmOp, self).get_parser(prog_name)"},{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            _VNF_LCM_OP_OCC_ID,"},{"line_number":60,"context_line":"            metavar\u003d\"\u003cvnf-lcm-op-occ-id\u003e\","},{"line_number":61,"context_line":"            help\u003d_(\u0027VNF lifecycle management operation occurrence ID.\u0027))"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2e07f1d9_149aab88","line":59,"in_reply_to":"cb783814_6e324006","updated":"2021-03-04 05:05:15.000000000","message":"I\u0027ve confirmed.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"6ef134d32c2bf158313da94e1527fc527bf763a9","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        parser \u003d super(RollbackVnfLcmOp, self).get_parser(prog_name)"},{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            _VNF_LCM_OP_OCC_ID,"},{"line_number":60,"context_line":"            metavar\u003d\"\u003cvnf-lcm-op-occ-id\u003e\","},{"line_number":61,"context_line":"            help\u003d_(\u0027VNF lifecycle management operation occurrence ID.\u0027))"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cb783814_6e324006","line":59,"in_reply_to":"ee191dcc_3a503d6e","updated":"2021-03-03 13:35:39.000000000","message":"\u003e Did you make it a variable to imitate \"_VNF_INSTANCE\" in \"tackerclient/osc/v1/vnflcm/vnflcm.py\"?\n\nYes since many CLI\u0027s(rollback \u0026 fail) are using 1 argument \u0027vnf_lcm_op_occ_id\u0027","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"}],"tackerclient/tests/unit/test_cli10.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0b152bd0cc0f9c603cee3bb98a5187bbd8b3adf1","unresolved":true,"context_lines":[{"line_number":799,"context_line":"            expected_msg\u003dexpected_msg,"},{"line_number":800,"context_line":"            error_content\u003derror_content)"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    def test_exception_handler_v10_tacker_ETSI_error(self):"},{"line_number":803,"context_line":"        \"\"\"Test ETSI error response\"\"\""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        known_error_map \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"e47b9846_3c73852d","line":802,"range":{"start_line":802,"start_character":8,"end_line":802,"end_character":52},"updated":"2021-02-19 02:33:41.000000000","message":"I think it should be fixed to \"test_exception_handler_v10_tacker_etsi_error\".","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98ecc9be8fd8ec1eb8f690e9e9e48384a4a2e4d1","unresolved":false,"context_lines":[{"line_number":799,"context_line":"            expected_msg\u003dexpected_msg,"},{"line_number":800,"context_line":"            error_content\u003derror_content)"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    def test_exception_handler_v10_tacker_ETSI_error(self):"},{"line_number":803,"context_line":"        \"\"\"Test ETSI error response\"\"\""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        known_error_map \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"a0ecbdc3_b5961dc5","line":802,"range":{"start_line":802,"start_character":8,"end_line":802,"end_character":52},"in_reply_to":"b02c7c35_310e8528","updated":"2021-03-05 06:06:36.000000000","message":"I\u0027ve confirmed.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c5eb23e9445bf2737dc750811b3c1a71b48f27d1","unresolved":true,"context_lines":[{"line_number":799,"context_line":"            expected_msg\u003dexpected_msg,"},{"line_number":800,"context_line":"            error_content\u003derror_content)"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    def test_exception_handler_v10_tacker_ETSI_error(self):"},{"line_number":803,"context_line":"        \"\"\"Test ETSI error response\"\"\""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        known_error_map \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"b02c7c35_310e8528","line":802,"range":{"start_line":802,"start_character":8,"end_line":802,"end_character":52},"in_reply_to":"e47b9846_3c73852d","updated":"2021-03-04 17:44:22.000000000","message":"\u003e I think it should be fixed to \"test_exception_handler_v10_tacker_etsi_error\".\n\nmodified as suggested.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0b152bd0cc0f9c603cee3bb98a5187bbd8b3adf1","unresolved":true,"context_lines":[{"line_number":808,"context_line":"                \"title\": \"Bad Request\""},{"line_number":809,"context_line":"            }, 400),"},{"line_number":810,"context_line":"            ({"},{"line_number":811,"context_line":"                \"detail\": \"sample 3\","},{"line_number":812,"context_line":"                \"title\": \"Not Found\""},{"line_number":813,"context_line":"            }, 404),"},{"line_number":814,"context_line":"            ({"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d71fc45_364719c2","line":811,"updated":"2021-02-19 02:33:41.000000000","message":"It doesn\u0027t make much sense, but is \"Sample 2\" more appropriate?","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c5eb23e9445bf2737dc750811b3c1a71b48f27d1","unresolved":true,"context_lines":[{"line_number":808,"context_line":"                \"title\": \"Bad Request\""},{"line_number":809,"context_line":"            }, 400),"},{"line_number":810,"context_line":"            ({"},{"line_number":811,"context_line":"                \"detail\": \"sample 3\","},{"line_number":812,"context_line":"                \"title\": \"Not Found\""},{"line_number":813,"context_line":"            }, 404),"},{"line_number":814,"context_line":"            ({"}],"source_content_type":"text/x-python","patch_set":1,"id":"a38c9adc_21498c15","line":811,"in_reply_to":"1d71fc45_364719c2","updated":"2021-03-04 17:44:22.000000000","message":"\u003e It doesn\u0027t make much sense, but is \"Sample 2\" more appropriate?\n\nchanged to Sample 2","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98ecc9be8fd8ec1eb8f690e9e9e48384a4a2e4d1","unresolved":false,"context_lines":[{"line_number":808,"context_line":"                \"title\": \"Bad Request\""},{"line_number":809,"context_line":"            }, 400),"},{"line_number":810,"context_line":"            ({"},{"line_number":811,"context_line":"                \"detail\": \"sample 3\","},{"line_number":812,"context_line":"                \"title\": \"Not Found\""},{"line_number":813,"context_line":"            }, 404),"},{"line_number":814,"context_line":"            ({"}],"source_content_type":"text/x-python","patch_set":1,"id":"74332325_ea17a973","line":811,"in_reply_to":"a38c9adc_21498c15","updated":"2021-03-05 06:06:36.000000000","message":"I\u0027ve confirmed.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"}],"tackerclient/v1_0/client.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"684b0221d10fa7f0852f3f4a8c187c5bcfba50c5","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        # ETSI error response"},{"line_number":99,"context_line":"        if isinstance(etsi_error_content, dict):"},{"line_number":100,"context_line":"            if etsi_error_content.get(\u0027detail\u0027) and \\"},{"line_number":101,"context_line":"                etsi_error_content.get(\u0027title\u0027):"},{"line_number":102,"context_line":"                message \u003d etsi_error_content.get(\u0027detail\u0027)"},{"line_number":103,"context_line":"                raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":104,"context_line":"                                                       message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff48f0d1_7d00e357","line":101,"range":{"start_line":101,"start_character":16,"end_line":101,"end_character":48},"updated":"2021-02-19 02:51:36.000000000","message":"SOL013 v2.6.1 6.3 Type: By definition of ProblemDetails, \"title\" is cardinality: 0..1, so I think it is better not to check this.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98ecc9be8fd8ec1eb8f690e9e9e48384a4a2e4d1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # ETSI error response"},{"line_number":99,"context_line":"        if isinstance(etsi_error_content, dict):"},{"line_number":100,"context_line":"            if etsi_error_content.get(\u0027detail\u0027) and \\"},{"line_number":101,"context_line":"                etsi_error_content.get(\u0027title\u0027):"},{"line_number":102,"context_line":"                message \u003d etsi_error_content.get(\u0027detail\u0027)"},{"line_number":103,"context_line":"                raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":104,"context_line":"                                                       message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9e0d3b5d_51210e12","line":101,"range":{"start_line":101,"start_character":16,"end_line":101,"end_character":48},"in_reply_to":"76f5118f_276af138","updated":"2021-03-05 06:06:36.000000000","message":"I\u0027ve confirmed.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c5eb23e9445bf2737dc750811b3c1a71b48f27d1","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        # ETSI error response"},{"line_number":99,"context_line":"        if isinstance(etsi_error_content, dict):"},{"line_number":100,"context_line":"            if etsi_error_content.get(\u0027detail\u0027) and \\"},{"line_number":101,"context_line":"                etsi_error_content.get(\u0027title\u0027):"},{"line_number":102,"context_line":"                message \u003d etsi_error_content.get(\u0027detail\u0027)"},{"line_number":103,"context_line":"                raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":104,"context_line":"                                                       message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"76f5118f_276af138","line":101,"range":{"start_line":101,"start_character":16,"end_line":101,"end_character":48},"in_reply_to":"ff48f0d1_7d00e357","updated":"2021-03-04 17:44:22.000000000","message":"\u003e SOL013 v2.6.1 6.3 Type: By definition of ProblemDetails, \"title\" is cardinality: 0..1, so I think it is better not to check this.\n\nYou are correct. We removed \"title\" but we added \"status\" validation since based on SOL013 v2.6.1 6.3 \"status\" cardinality is 1.","commit_id":"bc776cfe888a60aad2ba15249c58ac4e8cf1e2f0"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"34a71c23d50a2d1524e1d0a91c7332a49c800562","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        if message:"},{"line_number":96,"context_line":"            raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":97,"context_line":"                                                   message\u003dmessage)"},{"line_number":98,"context_line":"        # ETSI error response"},{"line_number":99,"context_line":"        if isinstance(etsi_error_content, dict):"},{"line_number":100,"context_line":"            if etsi_error_content.get(\u0027detail\u0027) and \\"},{"line_number":101,"context_line":"                etsi_error_content.get(\u0027title\u0027):"},{"line_number":102,"context_line":"                message \u003d etsi_error_content.get(\u0027detail\u0027)"},{"line_number":103,"context_line":"                raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":104,"context_line":"                                                       message\u003dmessage)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    # If we end up here the exception was not a tacker error"},{"line_number":107,"context_line":"    msg \u003d \"%s-%s\" % (status_code, error_content)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f8960d23_a998177d","line":104,"range":{"start_line":98,"start_character":7,"end_line":104,"end_character":71},"updated":"2021-02-19 17:59:18.000000000","message":"This is regarding \"https://bugs.launchpad.net/python-tackerclient/+bug/1847726\".\nThis bug needs to be backported in the Victoria release as well.","commit_id":"30d1a1e34e62734684bd32a79acbee188b7ecbbe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c5eb23e9445bf2737dc750811b3c1a71b48f27d1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if message:"},{"line_number":96,"context_line":"            raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":97,"context_line":"                                                   message\u003dmessage)"},{"line_number":98,"context_line":"        # ETSI error response"},{"line_number":99,"context_line":"        if isinstance(etsi_error_content, dict):"},{"line_number":100,"context_line":"            if etsi_error_content.get(\u0027detail\u0027) and \\"},{"line_number":101,"context_line":"                etsi_error_content.get(\u0027title\u0027):"},{"line_number":102,"context_line":"                message \u003d etsi_error_content.get(\u0027detail\u0027)"},{"line_number":103,"context_line":"                raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":104,"context_line":"                                                       message\u003dmessage)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    # If we end up here the exception was not a tacker error"},{"line_number":107,"context_line":"    msg \u003d \"%s-%s\" % (status_code, error_content)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b63cd2e_06806de9","line":104,"range":{"start_line":98,"start_character":7,"end_line":104,"end_character":71},"in_reply_to":"1cc3d57f_f320f1c9","updated":"2021-03-04 17:44:22.000000000","message":"Hello Manpreet,\nIt seems the code you got from us has a lacking validation for \"status\". As defined in SOL013 v2.6.1 6.3, \"status\" cardinality is 1, so we added a validation for such parameter. So, I think this should be applied to your code, too.","commit_id":"30d1a1e34e62734684bd32a79acbee188b7ecbbe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"af831da1ad364d8e0fbea97a7bba5e994a15ec6b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if message:"},{"line_number":96,"context_line":"            raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":97,"context_line":"                                                   message\u003dmessage)"},{"line_number":98,"context_line":"        # ETSI error response"},{"line_number":99,"context_line":"        if isinstance(etsi_error_content, dict):"},{"line_number":100,"context_line":"            if etsi_error_content.get(\u0027detail\u0027) and \\"},{"line_number":101,"context_line":"                etsi_error_content.get(\u0027title\u0027):"},{"line_number":102,"context_line":"                message \u003d etsi_error_content.get(\u0027detail\u0027)"},{"line_number":103,"context_line":"                raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":104,"context_line":"                                                       message\u003dmessage)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    # If we end up here the exception was not a tacker error"},{"line_number":107,"context_line":"    msg \u003d \"%s-%s\" % (status_code, error_content)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1cc3d57f_f320f1c9","line":104,"range":{"start_line":98,"start_character":7,"end_line":104,"end_character":71},"in_reply_to":"51c6ed22_c4aa0c6e","updated":"2021-03-04 05:05:15.000000000","message":"https://review.opendev.org/c/openstack/python-tackerclient/+/774776\nI\u0027ve confirmed that the above patch reflects this fix.","commit_id":"30d1a1e34e62734684bd32a79acbee188b7ecbbe"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"06759daaeeddd930fe5dbdd12893fda4336316e5","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        if message:"},{"line_number":96,"context_line":"            raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":97,"context_line":"                                                   message\u003dmessage)"},{"line_number":98,"context_line":"        # ETSI error response"},{"line_number":99,"context_line":"        if isinstance(etsi_error_content, dict):"},{"line_number":100,"context_line":"            if etsi_error_content.get(\u0027detail\u0027) and \\"},{"line_number":101,"context_line":"                etsi_error_content.get(\u0027title\u0027):"},{"line_number":102,"context_line":"                message \u003d etsi_error_content.get(\u0027detail\u0027)"},{"line_number":103,"context_line":"                raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":104,"context_line":"                                                       message\u003dmessage)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    # If we end up here the exception was not a tacker error"},{"line_number":107,"context_line":"    msg \u003d \"%s-%s\" % (status_code, error_content)"}],"source_content_type":"text/x-python","patch_set":2,"id":"51c6ed22_c4aa0c6e","line":104,"range":{"start_line":98,"start_character":7,"end_line":104,"end_character":71},"in_reply_to":"694c5173_5205b503","updated":"2021-03-02 11:25:49.000000000","message":"Please proceed with the bug fix in victoria.","commit_id":"30d1a1e34e62734684bd32a79acbee188b7ecbbe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6f38e3f6087ed095cdf7b91c166ce5b5ade3d1a9","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        if message:"},{"line_number":96,"context_line":"            raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":97,"context_line":"                                                   message\u003dmessage)"},{"line_number":98,"context_line":"        # ETSI error response"},{"line_number":99,"context_line":"        if isinstance(etsi_error_content, dict):"},{"line_number":100,"context_line":"            if etsi_error_content.get(\u0027detail\u0027) and \\"},{"line_number":101,"context_line":"                etsi_error_content.get(\u0027title\u0027):"},{"line_number":102,"context_line":"                message \u003d etsi_error_content.get(\u0027detail\u0027)"},{"line_number":103,"context_line":"                raise exceptions.TackerClientException(status_code\u003dstatus_code,"},{"line_number":104,"context_line":"                                                       message\u003dmessage)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    # If we end up here the exception was not a tacker error"},{"line_number":107,"context_line":"    msg \u003d \"%s-%s\" % (status_code, error_content)"}],"source_content_type":"text/x-python","patch_set":2,"id":"694c5173_5205b503","line":104,"range":{"start_line":98,"start_character":7,"end_line":104,"end_character":71},"in_reply_to":"f8960d23_a998177d","updated":"2021-02-22 02:28:48.000000000","message":"I agree with Manpreet san\u0027s comments.\nI think this fix is not a fix for this \u0027Fail\u0027 patch, but a bug-fix, so I think you should avoid including it in this patch and post it as a separate bug-fix patch.","commit_id":"30d1a1e34e62734684bd32a79acbee188b7ecbbe"}]}