)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"b73816024e536eebfe10f19cf0e4271c4eed7594","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson C. Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-01 16:17:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support CLI for Getting List of VNF LCM Operation Occurences"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add ``openstack vnflcm op list`` to python-tackerclient."},{"line_number":10,"context_line":"This command can execute getting the list of VNF LCM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"98ed3414_75ab4b06","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":55},"updated":"2021-03-04 11:43:00.000000000","message":"Typo: Occurrences","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"b72cc67b488a4997e222fc0e30fbf915fcfb1ab0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson C. Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-01 16:17:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support CLI for Getting List of VNF LCM Operation Occurences"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add ``openstack vnflcm op list`` to python-tackerclient."},{"line_number":10,"context_line":"This command can execute getting the list of VNF LCM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"523fca3a_6c623fca","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":55},"in_reply_to":"5d39d5c9_dd28bb10","updated":"2021-03-09 11:23:21.000000000","message":"I\u0027ve confirmed.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson C. Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-01 16:17:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support CLI for Getting List of VNF LCM Operation Occurences"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add ``openstack vnflcm op list`` to python-tackerclient."},{"line_number":10,"context_line":"This command can execute getting the list of VNF LCM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5d39d5c9_dd28bb10","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":55},"in_reply_to":"98ed3414_75ab4b06","updated":"2021-03-08 14:27:16.000000000","message":"\u003e Typo: Occurrences\n\nTypos in Commit message is corrected.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fdb21c9fe0f51fd18ee782b3866e64056d4cb0bf","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Operation Occurences. User can specify filters for more"},{"line_number":12,"context_line":"specific results."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- Filtering for the following attributes:"},{"line_number":15,"context_line":"  operationParams, error, resourceChanges and"},{"line_number":16,"context_line":"  changedInfo is only limited to the parent"},{"line_number":17,"context_line":"  attribute. Currently, child attributes/nested"},{"line_number":18,"context_line":"  attributes are not searchable."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Implements: blueprint support-fundamental-lcm"},{"line_number":21,"context_line":"Spec: https://specs.openstack.org/openstack/tacker-specs/specs/wallaby/support-fundamental-vnf-lcm-based-on-ETSI-NFV.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d0cfa664_f0c10a5d","line":18,"range":{"start_line":14,"start_character":0,"end_line":18,"end_character":32},"updated":"2021-03-04 10:10:48.000000000","message":"Could you revise this explanation? Is it a list of supported attributes of filtering? or just a note?","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Operation Occurences. User can specify filters for more"},{"line_number":12,"context_line":"specific results."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- Filtering for the following attributes:"},{"line_number":15,"context_line":"  operationParams, error, resourceChanges and"},{"line_number":16,"context_line":"  changedInfo is only limited to the parent"},{"line_number":17,"context_line":"  attribute. Currently, child attributes/nested"},{"line_number":18,"context_line":"  attributes are not searchable."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Implements: blueprint support-fundamental-lcm"},{"line_number":21,"context_line":"Spec: https://specs.openstack.org/openstack/tacker-specs/specs/wallaby/support-fundamental-vnf-lcm-based-on-ETSI-NFV.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f781f1c3_6ed7a0e6","line":18,"range":{"start_line":14,"start_character":0,"end_line":18,"end_character":32},"in_reply_to":"d0cfa664_f0c10a5d","updated":"2021-03-08 14:27:16.000000000","message":"\u003e Could you revise this explanation? Is it a list of supported attributes of filtering? or just a note?\n\nThis is a Note, so I added \"Note:\" in commit message.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"}],"tackerclient/osc/v1/vnflcm/vnflcm_op_occs.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fdb21c9fe0f51fd18ee782b3866e64056d4cb0bf","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_VNF_LCM_OP_OCC_ID \u003d \u0027vnf_lcm_op_occ_id\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"_MIXED_CASE_FIELDS \u003d [\u0027operationState\u0027, \u0027stateEnteredTime\u0027, \u0027startTime\u0027,"},{"line_number":22,"context_line":"                      \u0027vnfInstanceId\u0027, \u0027grantId\u0027, \u0027isAutomaticInvocation\u0027,"},{"line_number":23,"context_line":"                      \u0027isCancelPending\u0027, \u0027cancelMode\u0027, \u0027operationParams\u0027,"},{"line_number":24,"context_line":"                      \u0027resourceChanges\u0027, \u0027changedInfo\u0027,"},{"line_number":25,"context_line":"                      \u0027changedExtConnectivity\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"_FORMATTERS \u003d {\u0027error\u0027: tacker_osc_utils.FormatComplexDataColumn,"},{"line_number":28,"context_line":"               \u0027links\u0027: tacker_osc_utils.FormatComplexDataColumn}"}],"source_content_type":"text/x-python","patch_set":2,"id":"d5cdaa69_2968dcad","line":25,"range":{"start_line":21,"start_character":22,"end_line":25,"end_character":46},"updated":"2021-03-04 10:10:48.000000000","message":"It is preferable to be alphabetical or reasonable order because it has many params.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_VNF_LCM_OP_OCC_ID \u003d \u0027vnf_lcm_op_occ_id\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"_MIXED_CASE_FIELDS \u003d [\u0027operationState\u0027, \u0027stateEnteredTime\u0027, \u0027startTime\u0027,"},{"line_number":22,"context_line":"                      \u0027vnfInstanceId\u0027, \u0027grantId\u0027, \u0027isAutomaticInvocation\u0027,"},{"line_number":23,"context_line":"                      \u0027isCancelPending\u0027, \u0027cancelMode\u0027, \u0027operationParams\u0027,"},{"line_number":24,"context_line":"                      \u0027resourceChanges\u0027, \u0027changedInfo\u0027,"},{"line_number":25,"context_line":"                      \u0027changedExtConnectivity\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"_FORMATTERS \u003d {\u0027error\u0027: tacker_osc_utils.FormatComplexDataColumn,"},{"line_number":28,"context_line":"               \u0027links\u0027: tacker_osc_utils.FormatComplexDataColumn}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ca1f7d9d_2ec42b3e","line":25,"range":{"start_line":21,"start_character":22,"end_line":25,"end_character":46},"in_reply_to":"d5cdaa69_2968dcad","updated":"2021-03-08 14:27:16.000000000","message":"\u003e It is preferable to be alphabetical or reasonable order because it has many params.\n\nArrangement of Parameters is in-line with SOL standard, so we will not change this.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"477e7befc7b340799315de376a1654222b581e87","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class ListVnfLcmOp(command.Lister):"},{"line_number":116,"context_line":"    _description \u003d _(\"List LCM Operation Occurances\")"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def get_parser(self, program_name):"},{"line_number":119,"context_line":"        \"\"\"Add arguments to parser."}],"source_content_type":"text/x-python","patch_set":2,"id":"d3f8e326_07b058d5","line":116,"range":{"start_line":116,"start_character":46,"end_line":116,"end_character":47},"updated":"2021-03-04 08:24:16.000000000","message":"Typo: Occurences","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class ListVnfLcmOp(command.Lister):"},{"line_number":116,"context_line":"    _description \u003d _(\"List LCM Operation Occurances\")"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def get_parser(self, program_name):"},{"line_number":119,"context_line":"        \"\"\"Add arguments to parser."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7e6ae0_3d3d904d","line":116,"range":{"start_line":116,"start_character":46,"end_line":116,"end_character":47},"in_reply_to":"a74b03b5_d12b1940","updated":"2021-03-08 14:27:16.000000000","message":"\u003e Oh, I misspelled it too. Yes, \u0027Occurrences\u0027 is correct.\n\nCorrected the misspelled word.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"b73816024e536eebfe10f19cf0e4271c4eed7594","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class ListVnfLcmOp(command.Lister):"},{"line_number":116,"context_line":"    _description \u003d _(\"List LCM Operation Occurances\")"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def get_parser(self, program_name):"},{"line_number":119,"context_line":"        \"\"\"Add arguments to parser."}],"source_content_type":"text/x-python","patch_set":2,"id":"a74b03b5_d12b1940","line":116,"range":{"start_line":116,"start_character":46,"end_line":116,"end_character":47},"in_reply_to":"b25b47dc_e3f62494","updated":"2021-03-04 11:43:00.000000000","message":"Oh, I misspelled it too. Yes, \u0027Occurrences\u0027 is correct.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"aebe813ae70ef2bad966d2b0a9f50daa1f6b6355","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class ListVnfLcmOp(command.Lister):"},{"line_number":116,"context_line":"    _description \u003d _(\"List LCM Operation Occurances\")"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def get_parser(self, program_name):"},{"line_number":119,"context_line":"        \"\"\"Add arguments to parser."}],"source_content_type":"text/x-python","patch_set":2,"id":"b25b47dc_e3f62494","line":116,"range":{"start_line":116,"start_character":46,"end_line":116,"end_character":47},"in_reply_to":"d3f8e326_07b058d5","updated":"2021-03-04 10:46:40.000000000","message":"\u0027Occurrence\u0027?","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"b72cc67b488a4997e222fc0e30fbf915fcfb1ab0","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class ListVnfLcmOp(command.Lister):"},{"line_number":116,"context_line":"    _description \u003d _(\"List LCM Operation Occurances\")"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def get_parser(self, program_name):"},{"line_number":119,"context_line":"        \"\"\"Add arguments to parser."}],"source_content_type":"text/x-python","patch_set":2,"id":"e40a4712_cf2cdc30","line":116,"range":{"start_line":116,"start_character":46,"end_line":116,"end_character":47},"in_reply_to":"fa7e6ae0_3d3d904d","updated":"2021-03-09 11:23:21.000000000","message":"I\u0027ve confirmed.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fdb21c9fe0f51fd18ee782b3866e64056d4cb0bf","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            help\u003d_(\"Complex attributes to be included into the response\"),"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        fields_exclusive_group.add_argument("},{"line_number":141,"context_line":"            \"--exclude_fields\","},{"line_number":142,"context_line":"            metavar\u003d\"\u003cexclude-fields\u003e\","},{"line_number":143,"context_line":"            help\u003d_(\"Complex attributes to be excluded from the response\"),"},{"line_number":144,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"a6de3794_29e52b29","line":141,"range":{"start_line":141,"start_character":22,"end_line":141,"end_character":23},"updated":"2021-03-04 10:10:48.000000000","message":"Why don\u0027t you use `-` instead?","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9df9b46c4928cc87a2d9bc2def54065f83809c07","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            help\u003d_(\"Complex attributes to be included into the response\"),"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        fields_exclusive_group.add_argument("},{"line_number":141,"context_line":"            \"--exclude_fields\","},{"line_number":142,"context_line":"            metavar\u003d\"\u003cexclude-fields\u003e\","},{"line_number":143,"context_line":"            help\u003d_(\"Complex attributes to be excluded from the response\"),"},{"line_number":144,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"de870e66_5a641fc4","line":141,"range":{"start_line":141,"start_character":22,"end_line":141,"end_character":23},"in_reply_to":"554e520e_f1994ecb","updated":"2021-03-09 16:36:51.000000000","message":"The reason you use underscore is only for the document, right? If so, I will confirm it in the document.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            help\u003d_(\"Complex attributes to be included into the response\"),"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        fields_exclusive_group.add_argument("},{"line_number":141,"context_line":"            \"--exclude_fields\","},{"line_number":142,"context_line":"            metavar\u003d\"\u003cexclude-fields\u003e\","},{"line_number":143,"context_line":"            help\u003d_(\"Complex attributes to be excluded from the response\"),"},{"line_number":144,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"554e520e_f1994ecb","line":141,"range":{"start_line":141,"start_character":22,"end_line":141,"end_character":23},"in_reply_to":"a6de3794_29e52b29","updated":"2021-03-08 14:27:16.000000000","message":"\u003e Why don\u0027t you use `-` instead?\n\nIn doc/source/cli/cli-etsi-vnfpkgm.rst, the token was defined with \"-exclude_fields\".","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"2ea517beaca57cc927f69c5c6d59945b16ad7db2","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            help\u003d_(\"Complex attributes to be included into the response\"),"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        fields_exclusive_group.add_argument("},{"line_number":141,"context_line":"            \"--exclude_fields\","},{"line_number":142,"context_line":"            metavar\u003d\"\u003cexclude-fields\u003e\","},{"line_number":143,"context_line":"            help\u003d_(\"Complex attributes to be excluded from the response\"),"},{"line_number":144,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"ce65be95_ab4281b4","line":141,"range":{"start_line":141,"start_character":22,"end_line":141,"end_character":23},"in_reply_to":"d5383e8f_e4a2893f","updated":"2021-03-10 13:29:48.000000000","message":"\u003e I\u0027ve understand some of options are named as such a mixed style, but no reason why to do so. I wonder that there was no consensus when it was merged. As you may know, document you referred is also just following current implementation.\n\u003e \n\u003e I think we should terminate such an inconsistency, including your patch. Is there any problem if replace underscore to \u0027-\u0027?\n\nWe understand your point. We replaced underscore to \u0027-\u0027.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7e86648d3e49b625111277fdcbd0106c2f275454","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            help\u003d_(\"Complex attributes to be included into the response\"),"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        fields_exclusive_group.add_argument("},{"line_number":141,"context_line":"            \"--exclude_fields\","},{"line_number":142,"context_line":"            metavar\u003d\"\u003cexclude-fields\u003e\","},{"line_number":143,"context_line":"            help\u003d_(\"Complex attributes to be excluded from the response\"),"},{"line_number":144,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"d5383e8f_e4a2893f","line":141,"range":{"start_line":141,"start_character":22,"end_line":141,"end_character":23},"in_reply_to":"de82e484_8a9234b8","updated":"2021-03-10 09:27:13.000000000","message":"I\u0027ve understand some of options are named as such a mixed style, but no reason why to do so. I wonder that there was no consensus when it was merged. As you may know, document you referred is also just following current implementation.\n\nI think we should terminate such an inconsistency, including your patch. Is there any problem if replace underscore to \u0027-\u0027?","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d15fd4e6e85a279afd5992a74df04dbb72f712ca","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            help\u003d_(\"Complex attributes to be included into the response\"),"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        fields_exclusive_group.add_argument("},{"line_number":141,"context_line":"            \"--exclude_fields\","},{"line_number":142,"context_line":"            metavar\u003d\"\u003cexclude-fields\u003e\","},{"line_number":143,"context_line":"            help\u003d_(\"Complex attributes to be excluded from the response\"),"},{"line_number":144,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"de82e484_8a9234b8","line":141,"range":{"start_line":141,"start_character":22,"end_line":141,"end_character":23},"in_reply_to":"de870e66_5a641fc4","updated":"2021-03-10 06:57:29.000000000","message":"\u003e The reason you use underscore is only for the document, right? If so, I will confirm it in the document.\n\nIt is not only for document. Aside from being written in doc/source/cli/cli-etsi-vnfpkgm.rst,  basically, we also followed what was already existing in the source codes. As an example, please find the source code snippet of VNF package CLI. It is using \"exclude_fields\":\n\nosc/v1/vnfpkgm/vnf_package.py:            \"--exclude_fields\",\nosc/v1/vnfpkgm/vnf_package.py:                       exclude_fields\u003dNone, exclude_default\u003dFalse):","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fdb21c9fe0f51fd18ee782b3866e64056d4cb0bf","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        return parser"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @classmethod"},{"line_number":148,"context_line":"    def get_attributes(cls):"},{"line_number":149,"context_line":"        \"\"\"Get attributes."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"50194c63_ef211ac0","line":147,"updated":"2021-03-04 10:10:48.000000000","message":"Need to be a classmethod?","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9df9b46c4928cc87a2d9bc2def54065f83809c07","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        return parser"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @classmethod"},{"line_number":148,"context_line":"    def get_attributes(cls):"},{"line_number":149,"context_line":"        \"\"\"Get attributes."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a0d7191b_5cbcf590","line":147,"in_reply_to":"30c976e3_ecae582a","updated":"2021-03-09 16:36:51.000000000","message":"What do you mean? If you use `self` instead, it does not need to be a classmethod, right? I\u0027m asking to confirm it because it\u0027s not used as classmethod from anywhere.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        return parser"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @classmethod"},{"line_number":148,"context_line":"    def get_attributes(cls):"},{"line_number":149,"context_line":"        \"\"\"Get attributes."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"30c976e3_ecae582a","line":147,"in_reply_to":"50194c63_ef211ac0","updated":"2021-03-08 14:27:16.000000000","message":"\u003e Need to be a classmethod?\n\nYes, the parameter uses \u0027cls\u0027, therefore, @classmethod is needed.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d15fd4e6e85a279afd5992a74df04dbb72f712ca","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        return parser"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @classmethod"},{"line_number":148,"context_line":"    def get_attributes(cls):"},{"line_number":149,"context_line":"        \"\"\"Get attributes."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"16ecd79a_71a7f7c8","line":147,"in_reply_to":"a0d7191b_5cbcf590","updated":"2021-03-10 06:57:29.000000000","message":"\u003e What do you mean? If you use `self` instead, it does not need to be a classmethod, right? I\u0027m asking to confirm it because it\u0027s not used as classmethod from anywhere.\n\n Removed @classmethod and changed \"def get_attributes(cls)\" to \"def get_attributes(self)\"","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fdb21c9fe0f51fd18ee782b3866e64056d4cb0bf","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @classmethod"},{"line_number":148,"context_line":"    def get_attributes(cls):"},{"line_number":149,"context_line":"        \"\"\"Get attributes."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        Returns:"},{"line_number":152,"context_line":"            attributes([attributes]):"},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        fields \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027vnfInstanceId\u0027, \u0027operation\u0027]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        attrs \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"c619d927_abedee76","line":153,"range":{"start_line":149,"start_character":0,"end_line":153,"end_character":11},"updated":"2021-03-04 10:10:48.000000000","message":"It is weird to return as a tuple of tuples without understanding the returned value is given to get_column_definitions(). You should add some explanations for the returned value and its usage.\n\nIn addition, the name of returned value is `attrs`, not `attribute` from your code.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @classmethod"},{"line_number":148,"context_line":"    def get_attributes(cls):"},{"line_number":149,"context_line":"        \"\"\"Get attributes."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        Returns:"},{"line_number":152,"context_line":"            attributes([attributes]):"},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        fields \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027vnfInstanceId\u0027, \u0027operation\u0027]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        attrs \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"05e395e0_597f8483","line":153,"range":{"start_line":149,"start_character":0,"end_line":153,"end_character":11},"in_reply_to":"c619d927_abedee76","updated":"2021-03-08 14:27:16.000000000","message":"\u003e It is weird to return as a tuple of tuples without understanding the returned value is given to get_column_definitions(). You should add some explanations for the returned value and its usage.\n\u003e \n\u003e In addition, the name of returned value is `attrs`, not `attribute` from your code.\n\nAdd some explanations for the returned value and its usage.\nRename \u0027attrs\u0027 into \u0027attribute\u0027.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fdb21c9fe0f51fd18ee782b3866e64056d4cb0bf","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        attrs \u003d []"},{"line_number":157,"context_line":"        for field in fields:"},{"line_number":158,"context_line":"            attrs.extend([(field, field,"},{"line_number":159,"context_line":"                           tacker_osc_utils.LIST_BOTH)])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return tuple(attrs)"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"25f90d03_5f126ff5","line":159,"range":{"start_line":158,"start_character":0,"end_line":159,"end_character":56},"updated":"2021-03-04 10:10:48.000000000","message":"No need to separate into two lines.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        attrs \u003d []"},{"line_number":157,"context_line":"        for field in fields:"},{"line_number":158,"context_line":"            attrs.extend([(field, field,"},{"line_number":159,"context_line":"                           tacker_osc_utils.LIST_BOTH)])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return tuple(attrs)"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"861e473e_670cd06e","line":159,"range":{"start_line":158,"start_character":0,"end_line":159,"end_character":56},"in_reply_to":"25f90d03_5f126ff5","updated":"2021-03-08 14:27:16.000000000","message":"\u003e No need to separate into two lines.\n\nMerged into 1 line.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fdb21c9fe0f51fd18ee782b3866e64056d4cb0bf","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        Args:"},{"line_number":167,"context_line":"            parsed_args ([Namespace]): arguments of CLI."},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        _params \u003d {}"},{"line_number":170,"context_line":"        exclude_fields \u003d []"},{"line_number":171,"context_line":"        extra_fields \u003d []"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"18dfdf3c_679e6fbe","line":169,"range":{"start_line":169,"start_character":8,"end_line":169,"end_character":9},"updated":"2021-03-04 10:10:48.000000000","message":"Just a question. Why it starts with `_`? It looks no need to me.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        Args:"},{"line_number":167,"context_line":"            parsed_args ([Namespace]): arguments of CLI."},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        _params \u003d {}"},{"line_number":170,"context_line":"        exclude_fields \u003d []"},{"line_number":171,"context_line":"        extra_fields \u003d []"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ef6f931d_a4cff2b6","line":169,"range":{"start_line":169,"start_character":8,"end_line":169,"end_character":9},"in_reply_to":"18dfdf3c_679e6fbe","updated":"2021-03-08 14:27:16.000000000","message":"\u003e Just a question. Why it starts with `_`? It looks no need to me.\n\nRemoved \u0027_\u0027","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fdb21c9fe0f51fd18ee782b3866e64056d4cb0bf","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            long_listing\u003dTrue)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return (headers,"},{"line_number":192,"context_line":"                (utils.get_dict_properties("},{"line_number":193,"context_line":"                    s, columns,"},{"line_number":194,"context_line":"                    mixed_case_fields\u003d_MIXED_CASE_FIELDS"},{"line_number":195,"context_line":"                ) for s in vnflcm_op_occs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"365f9745_f3281fd5","line":195,"range":{"start_line":192,"start_character":0,"end_line":195,"end_character":42},"updated":"2021-03-04 10:10:48.000000000","message":"It might be better to move this one before `return` statement because it is just a complex.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            long_listing\u003dTrue)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return (headers,"},{"line_number":192,"context_line":"                (utils.get_dict_properties("},{"line_number":193,"context_line":"                    s, columns,"},{"line_number":194,"context_line":"                    mixed_case_fields\u003d_MIXED_CASE_FIELDS"},{"line_number":195,"context_line":"                ) for s in vnflcm_op_occs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4f7c22_3a28e84f","line":195,"range":{"start_line":192,"start_character":0,"end_line":195,"end_character":42},"in_reply_to":"365f9745_f3281fd5","updated":"2021-03-08 14:27:16.000000000","message":"\u003e It might be better to move this one before `return` statement because it is just a complex.\n\nAssign \"(utils.get_dict_properties(\n s, columns,\n mixed_case_fields\u003d_MIXED_CASE_FIELDS\n ) for s in vnflcm_op_occs)\"\nto a parameter and place the parameter into the return statement","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"}],"tackerclient/tests/unit/osc/v1/test_vnflcm_op_occs.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fdb21c9fe0f51fd18ee782b3866e64056d4cb0bf","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_columns_vnflcm_op_occs(action\u003d\u0027\u0027):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027stateEnteredTime\u0027,"},{"line_number":31,"context_line":"               \u0027startTime\u0027, \u0027vnfInstanceId\u0027, \u0027grantId\u0027,"},{"line_number":32,"context_line":"               \u0027operation\u0027, \u0027isAutomaticInvocation\u0027,"},{"line_number":33,"context_line":"               \u0027operationParams\u0027, \u0027isCancelPending\u0027,"},{"line_number":34,"context_line":"               \u0027cancelMode\u0027, \u0027error\u0027, \u0027resourceChanges\u0027,"},{"line_number":35,"context_line":"               \u0027changedInfo\u0027, \u0027changedExtConnectivity\u0027, \u0027links\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if action \u003d\u003d \u0027fail\u0027:"},{"line_number":38,"context_line":"        columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027stateEnteredTime\u0027,"},{"line_number":39,"context_line":"                   \u0027startTime\u0027, \u0027vnfInstanceId\u0027, \u0027operation\u0027,"},{"line_number":40,"context_line":"                   \u0027isAutomaticInvocation\u0027, \u0027isCancelPending\u0027,"},{"line_number":41,"context_line":"                   \u0027error\u0027, \u0027links\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if action \u003d\u003d \u0027list\u0027:"},{"line_number":44,"context_line":"        columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027vnfInstanceId\u0027,"},{"line_number":45,"context_line":"                   \u0027operation\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    return columns"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"73ef89b9_a135a7ea","line":45,"range":{"start_line":30,"start_character":0,"end_line":45,"end_character":31},"updated":"2021-03-04 10:10:48.000000000","message":"nit. It\u0027s better to use \"if ... elif ... else\" for making clear the context. In addition, no need to define `columns` at first. Why don\u0027t you change it as follows?\n\n```\nif action \u003d\u003d \u0027fail\u0027:\n    return [...]\nelif action \u003d\u003d \u0027list\u0027:\n    return [...]\nelse:\n    return [...]\n```","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8e0a4d6fff1235f423225a0bcd10d0acc77fce98","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_columns_vnflcm_op_occs(action\u003d\u0027\u0027):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027stateEnteredTime\u0027,"},{"line_number":31,"context_line":"               \u0027startTime\u0027, \u0027vnfInstanceId\u0027, \u0027grantId\u0027,"},{"line_number":32,"context_line":"               \u0027operation\u0027, \u0027isAutomaticInvocation\u0027,"},{"line_number":33,"context_line":"               \u0027operationParams\u0027, \u0027isCancelPending\u0027,"},{"line_number":34,"context_line":"               \u0027cancelMode\u0027, \u0027error\u0027, \u0027resourceChanges\u0027,"},{"line_number":35,"context_line":"               \u0027changedInfo\u0027, \u0027changedExtConnectivity\u0027, \u0027links\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if action \u003d\u003d \u0027fail\u0027:"},{"line_number":38,"context_line":"        columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027stateEnteredTime\u0027,"},{"line_number":39,"context_line":"                   \u0027startTime\u0027, \u0027vnfInstanceId\u0027, \u0027operation\u0027,"},{"line_number":40,"context_line":"                   \u0027isAutomaticInvocation\u0027, \u0027isCancelPending\u0027,"},{"line_number":41,"context_line":"                   \u0027error\u0027, \u0027links\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if action \u003d\u003d \u0027list\u0027:"},{"line_number":44,"context_line":"        columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027vnfInstanceId\u0027,"},{"line_number":45,"context_line":"                   \u0027operation\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    return columns"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cb49a5ce_91eb66b1","line":45,"range":{"start_line":30,"start_character":0,"end_line":45,"end_character":31},"in_reply_to":"73ef89b9_a135a7ea","updated":"2021-03-05 07:01:48.000000000","message":"Currently, the processing is not standardized, so I think it is better to define the base \u0027columns\u0027 and then add it to the \u0027columns\u0027 according to the value of the action.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"06da304030f4b3066bfcf8b28da4032eebfcc52c","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_columns_vnflcm_op_occs(action\u003d\u0027\u0027):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027stateEnteredTime\u0027,"},{"line_number":31,"context_line":"               \u0027startTime\u0027, \u0027vnfInstanceId\u0027, \u0027grantId\u0027,"},{"line_number":32,"context_line":"               \u0027operation\u0027, \u0027isAutomaticInvocation\u0027,"},{"line_number":33,"context_line":"               \u0027operationParams\u0027, \u0027isCancelPending\u0027,"},{"line_number":34,"context_line":"               \u0027cancelMode\u0027, \u0027error\u0027, \u0027resourceChanges\u0027,"},{"line_number":35,"context_line":"               \u0027changedInfo\u0027, \u0027changedExtConnectivity\u0027, \u0027links\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if action \u003d\u003d \u0027fail\u0027:"},{"line_number":38,"context_line":"        columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027stateEnteredTime\u0027,"},{"line_number":39,"context_line":"                   \u0027startTime\u0027, \u0027vnfInstanceId\u0027, \u0027operation\u0027,"},{"line_number":40,"context_line":"                   \u0027isAutomaticInvocation\u0027, \u0027isCancelPending\u0027,"},{"line_number":41,"context_line":"                   \u0027error\u0027, \u0027links\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if action \u003d\u003d \u0027list\u0027:"},{"line_number":44,"context_line":"        columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027vnfInstanceId\u0027,"},{"line_number":45,"context_line":"                   \u0027operation\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    return columns"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"55e7a404_a759fdb4","line":45,"range":{"start_line":30,"start_character":0,"end_line":45,"end_character":31},"in_reply_to":"90b9d17b_ac7cf552","updated":"2021-03-09 08:14:25.000000000","message":"I\u0027ve confirmed your fix.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_columns_vnflcm_op_occs(action\u003d\u0027\u0027):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027stateEnteredTime\u0027,"},{"line_number":31,"context_line":"               \u0027startTime\u0027, \u0027vnfInstanceId\u0027, \u0027grantId\u0027,"},{"line_number":32,"context_line":"               \u0027operation\u0027, \u0027isAutomaticInvocation\u0027,"},{"line_number":33,"context_line":"               \u0027operationParams\u0027, \u0027isCancelPending\u0027,"},{"line_number":34,"context_line":"               \u0027cancelMode\u0027, \u0027error\u0027, \u0027resourceChanges\u0027,"},{"line_number":35,"context_line":"               \u0027changedInfo\u0027, \u0027changedExtConnectivity\u0027, \u0027links\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if action \u003d\u003d \u0027fail\u0027:"},{"line_number":38,"context_line":"        columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027stateEnteredTime\u0027,"},{"line_number":39,"context_line":"                   \u0027startTime\u0027, \u0027vnfInstanceId\u0027, \u0027operation\u0027,"},{"line_number":40,"context_line":"                   \u0027isAutomaticInvocation\u0027, \u0027isCancelPending\u0027,"},{"line_number":41,"context_line":"                   \u0027error\u0027, \u0027links\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if action \u003d\u003d \u0027list\u0027:"},{"line_number":44,"context_line":"        columns \u003d [\u0027id\u0027, \u0027operationState\u0027, \u0027vnfInstanceId\u0027,"},{"line_number":45,"context_line":"                   \u0027operation\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    return columns"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"90b9d17b_ac7cf552","line":45,"range":{"start_line":30,"start_character":0,"end_line":45,"end_character":31},"in_reply_to":"cb49a5ce_91eb66b1","updated":"2021-03-08 14:27:16.000000000","message":"\u003e Currently, the processing is not standardized, so I think it is better to define the base \u0027columns\u0027 and then add it to the \u0027columns\u0027 according to the value of the action.\n\nComment from Kitamura-san contradicts the comment from Ogawa-san at this part:\" In addition, no need to define `columns` at first. \"\nWe decided to implement based on Ogawa-san\u0027s suggestion.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"}],"tackerclient/v1_0/client.py":[{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"b73816024e536eebfe10f19cf0e4271c4eed7594","unresolved":true,"context_lines":[{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    vnf_instances_path \u003d \u0027/vnflcm/v1/vnf_instances\u0027"},{"line_number":878,"context_line":"    vnf_instance_path \u003d \u0027/vnflcm/v1/vnf_instances/%s\u0027"},{"line_number":879,"context_line":"    vnf_lcm_op_occurences_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs\u0027"},{"line_number":880,"context_line":"    vnf_lcm_op_occs_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs/%s\u0027"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    def build_action(self, action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa91305_cfff4ef0","line":879,"range":{"start_line":879,"start_character":15,"end_line":879,"end_character":25},"updated":"2021-03-04 11:43:00.000000000","message":"Typo: occurrences\n\nDoes the Typo fix affect any other code?","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8e0a4d6fff1235f423225a0bcd10d0acc77fce98","unresolved":true,"context_lines":[{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    vnf_instances_path \u003d \u0027/vnflcm/v1/vnf_instances\u0027"},{"line_number":878,"context_line":"    vnf_instance_path \u003d \u0027/vnflcm/v1/vnf_instances/%s\u0027"},{"line_number":879,"context_line":"    vnf_lcm_op_occurences_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs\u0027"},{"line_number":880,"context_line":"    vnf_lcm_op_occs_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs/%s\u0027"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    def build_action(self, action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3fbce5a_aa2bee32","line":879,"range":{"start_line":879,"start_character":15,"end_line":879,"end_character":25},"in_reply_to":"9aa91305_cfff4ef0","updated":"2021-03-05 07:01:48.000000000","message":"I think the following is better in terms of consistency.\n    vnf_lcm_op_occs_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs\u0027\n    vnf_lcm_op_occ_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs/%s","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    vnf_instances_path \u003d \u0027/vnflcm/v1/vnf_instances\u0027"},{"line_number":878,"context_line":"    vnf_instance_path \u003d \u0027/vnflcm/v1/vnf_instances/%s\u0027"},{"line_number":879,"context_line":"    vnf_lcm_op_occurences_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs\u0027"},{"line_number":880,"context_line":"    vnf_lcm_op_occs_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs/%s\u0027"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    def build_action(self, action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"f47661cf_b7f46643","line":879,"range":{"start_line":879,"start_character":15,"end_line":879,"end_character":25},"in_reply_to":"a3fbce5a_aa2bee32","updated":"2021-03-08 14:27:16.000000000","message":"\u003e I think the following is better in terms of consistency.\n\u003e     vnf_lcm_op_occs_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs\u0027\n\u003e     vnf_lcm_op_occ_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs/%s\n\n The assigned variable \u0027vnf_lcm_op_occs_path\u0027 for \u0027/vnflcm/v1/vnf_lcm_op_occs/%s\u0027 is also being used by Rollback and Fail. They are existing and are not part of the scope for our patch. If we modify this then there will be modifications in CLI-Fail and CLI-Rollback patches.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"06da304030f4b3066bfcf8b28da4032eebfcc52c","unresolved":false,"context_lines":[{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    vnf_instances_path \u003d \u0027/vnflcm/v1/vnf_instances\u0027"},{"line_number":878,"context_line":"    vnf_instance_path \u003d \u0027/vnflcm/v1/vnf_instances/%s\u0027"},{"line_number":879,"context_line":"    vnf_lcm_op_occurences_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs\u0027"},{"line_number":880,"context_line":"    vnf_lcm_op_occs_path \u003d \u0027/vnflcm/v1/vnf_lcm_op_occs/%s\u0027"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    def build_action(self, action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"15273e85_e977c903","line":879,"range":{"start_line":879,"start_character":15,"end_line":879,"end_character":25},"in_reply_to":"f47661cf_b7f46643","updated":"2021-03-09 08:14:25.000000000","message":"I\u0027ve confirmed.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"b73816024e536eebfe10f19cf0e4271c4eed7594","unresolved":true,"context_lines":[{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @APIParamsCall"},{"line_number":936,"context_line":"    def list_vnf_lcm_op_occs(self, retrieve_all\u003dTrue, **_params):"},{"line_number":937,"context_line":"        vnf_lcm_op_occs \u003d self.list(None, self.vnf_lcm_op_occurences_path,"},{"line_number":938,"context_line":"                                    retrieve_all, **_params)"},{"line_number":939,"context_line":"        return vnf_lcm_op_occs"},{"line_number":940,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"39406075_650b823f","line":937,"range":{"start_line":937,"start_character":58,"end_line":937,"end_character":68},"updated":"2021-03-04 11:43:00.000000000","message":"ditto","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d70446da1ee9420d6af9f48f3e7c2f59ffa347a5","unresolved":true,"context_lines":[{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @APIParamsCall"},{"line_number":936,"context_line":"    def list_vnf_lcm_op_occs(self, retrieve_all\u003dTrue, **_params):"},{"line_number":937,"context_line":"        vnf_lcm_op_occs \u003d self.list(None, self.vnf_lcm_op_occurences_path,"},{"line_number":938,"context_line":"                                    retrieve_all, **_params)"},{"line_number":939,"context_line":"        return vnf_lcm_op_occs"},{"line_number":940,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"952d85d3_d3e67ced","line":937,"range":{"start_line":937,"start_character":58,"end_line":937,"end_character":68},"in_reply_to":"39406075_650b823f","updated":"2021-03-08 14:27:16.000000000","message":"\u003e ditto\n\ncorrected.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"},{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"b72cc67b488a4997e222fc0e30fbf915fcfb1ab0","unresolved":false,"context_lines":[{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @APIParamsCall"},{"line_number":936,"context_line":"    def list_vnf_lcm_op_occs(self, retrieve_all\u003dTrue, **_params):"},{"line_number":937,"context_line":"        vnf_lcm_op_occs \u003d self.list(None, self.vnf_lcm_op_occurences_path,"},{"line_number":938,"context_line":"                                    retrieve_all, **_params)"},{"line_number":939,"context_line":"        return vnf_lcm_op_occs"},{"line_number":940,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3b2b946d_018eec33","line":937,"range":{"start_line":937,"start_character":58,"end_line":937,"end_character":68},"in_reply_to":"952d85d3_d3e67ced","updated":"2021-03-09 11:23:21.000000000","message":"I\u0027ve confirmed.","commit_id":"0dce444c5bda054304f36ee0f5751d36fd8ce238"}]}