)]}'
{"id":"openstack%2Fpython-tackerclient~782991","triplet_id":"openstack%2Fpython-tackerclient~master~I0d62f77cf5d1e9ec0b0a7c404abab83f97b708ba","project":"openstack/python-tackerclient","branch":"master","topic":"bug/1919350","hashtags":[],"change_id":"I0d62f77cf5d1e9ec0b0a7c404abab83f97b708ba","subject":"Fix failing UT in TestListVnfLcmOp","status":"MERGED","created":"2021-03-25 12:36:29.000000000","updated":"2021-03-31 04:28:40.000000000","submitted":"2021-03-31 04:25:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"782991-bug/1919350","meta_rev_id":"04885a9d939719825fcca5620e47c3df73f385d4","_number":782991,"virtual_id_number":782991,"owner":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-31 04:25:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"all":[{"value":2,"date":"2021-03-26 12:10:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":2,"date":"2021-03-31 04:01:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-03-30 08:12:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"all":[{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":1,"date":"2021-03-31 04:01:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"reviewers":{"REVIEWER":[{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"}],"CC":[{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-25 12:49:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-25 13:18:35.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2021-03-26 06:31:44.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"state":"REVIEWER"},{"updated":"2021-03-26 12:10:00.000000000","updated_by":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"reviewer":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"state":"REVIEWER"},{"updated":"2021-03-26 12:10:00.000000000","updated_by":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2021-03-26 12:10:00.000000000","updated_by":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"reviewer":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"state":"REVIEWER"},{"updated":"2021-03-29 08:04:47.000000000","updated_by":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"reviewer":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"state":"CC"},{"updated":"2021-03-30 08:12:02.000000000","updated_by":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"reviewer":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"state":"REVIEWER"}],"messages":[{"id":"8b9f4f857745c16548f0a2ddee7e451f556b2572","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-03-25 12:36:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5d1796db20537c68f8ad2c4d275783a94185cdfe","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-25 12:49:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/13000da644c2438892735728c701de95 : SUCCESS in 4m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a049fa994f5041f197f98d1274397cf6 : SUCCESS in 3m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ff9726c6581f4b76a437af2d1c273bd0 : SUCCESS in 4m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/32d799ce87aa4b83aba44c9423d2dfef : SUCCESS in 6m 14s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b232da05305640aa8edb9e2f42f2d87d : SUCCESS in 6m 56s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5bbf831f25a049c2bdb4be8bd97e1829 : SUCCESS in 4m 16s","accounts_in_message":[],"_revision_number":1},{"id":"48189c09aed5f3e8eab36212825ed2e2f7355ff1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-03-26 06:28:24.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2f083448f5ab38bfc3bdb5a1c56a057ebd491624","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 06:38:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b8665573139b4710a0746fc5052cc5e6 : SUCCESS in 7m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4c6c40b0b7f845ffba46575f1a6cbead : SUCCESS in 5m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f06164e84b5d48b5a91cb9b12b2fdf80 : SUCCESS in 4m 23s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4189ccdf047d4f9791abbda1e4cb1913 : SUCCESS in 5m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/26962e3b283a446694c53186a67d476d : SUCCESS in 5m 25s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d80c08c985974043bec42de855aade5a : SUCCESS in 8m 20s","accounts_in_message":[],"_revision_number":2},{"id":"1edc77453d35dab42a83d1b02c5a182693c23f4f","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-03-26 12:10:00.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0104a8ba402e500b490fa23cccedaae16c2b1284","author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"date":"2021-03-30 08:12:02.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"751100987dea607a437a2c2ca7294d3da416ff9c","author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"date":"2021-03-31 04:01:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"dd5489bdd98b7443cbcc0929acb1f4e2bbb2fb63","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 04:02:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"7eb42ec658adfd8c1eb22385d1fbd098a1e90295","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 04:25:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/aa0d54e3e3064bdba1eb90476fd9173b : SUCCESS in 5m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bb1637c6403744bea36c10cbf3372653 : SUCCESS in 4m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b96703fa2d644bb7aa61bc141ede0447 : SUCCESS in 5m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0ef03a88da884f8fa6784eaa4f86520e : SUCCESS in 4m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/70aaff322159453185d5c38309da9c3d : SUCCESS in 6m 10s","accounts_in_message":[],"_revision_number":2},{"id":"57561ef3d6afd3403f6dbfa2e6da8e5648946afe","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 04:25:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"04885a9d939719825fcca5620e47c3df73f385d4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 04:28:40.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/adc1ae394df344a393c4f4e69f413532 : SUCCESS in 2m 17s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"124be387dcae360873ca75267d9a5e66903d5c73","revisions":{"d4ce58e12efca7d6d191c912d295906aa40d4705":{"kind":"REWORK","_number":1,"created":"2021-03-25 12:36:29.000000000","uploader":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"ref":"refs/changes/91/782991/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tackerclient","ref":"refs/changes/91/782991/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/91/782991/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/91/782991/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/91/782991/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tackerclient refs/changes/91/782991/1"}}},"commit":{"parents":[{"commit":"4e6dc4c0310f02e3b71941df676674b138081890","subject":"CLI for Individual VNF LCM Operation Occurrence","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/4e6dc4c0310f02e3b71941df676674b138081890"}]}],"author":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-03-25 12:32:53.000000000","tz":330},"committer":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-03-25 12:36:21.000000000","tz":330},"subject":"[DNM] Fix unit test case in TestListVnfLcmOp","message":"[DNM] Fix unit test case in TestListVnfLcmOp\n\nIt has been observe in review IDs [1] and [2] that the unit test\n\u0027tackerclient.tests.unit.osc.v1.test_vnflcm_op_occs.\nTestListVnfLcmOp.test_take_action_with_filter\u0027\nis failing with  below error,\n   DEBUG: TypeError: Object of type \u0027FormatComplexDataColumn\u0027\n   is not JSON serializable\n\nA bug has been log for the same issue [3].\n\n[1] https://review.opendev.org/c/openstack/python-tackerclient/+/636893\n[2] https://review.opendev.org/c/openstack/python-tackerclient/+/781314\n[3] https://bugs.launchpad.net/python-tackerclient/+bug/1919350\n\nChange-Id: I0d62f77cf5d1e9ec0b0a7c404abab83f97b708ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/d4ce58e12efca7d6d191c912d295906aa40d4705"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/d4ce58e12efca7d6d191c912d295906aa40d4705"}]},"branch":"refs/heads/master"},"124be387dcae360873ca75267d9a5e66903d5c73":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-03-26 06:28:24.000000000","uploader":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"ref":"refs/changes/91/782991/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tackerclient","ref":"refs/changes/91/782991/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/91/782991/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/91/782991/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tackerclient refs/changes/91/782991/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tackerclient refs/changes/91/782991/2"}}},"commit":{"parents":[{"commit":"4e6dc4c0310f02e3b71941df676674b138081890","subject":"CLI for Individual VNF LCM Operation Occurrence","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/4e6dc4c0310f02e3b71941df676674b138081890"}]}],"author":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-03-25 12:32:53.000000000","tz":330},"committer":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2021-03-26 06:24:31.000000000","tz":330},"subject":"Fix failing UT in TestListVnfLcmOp","message":"Fix failing UT in TestListVnfLcmOp\n\nThe unit test \u0027tackerclient.tests.unit.osc.v1.test_vnflcm_op_occs.\nTestListVnfLcmOp.test_take_action_with_filter\u0027 is failing with below\nerror message,\nDEBUG: TypeError: Object of type \u0027FormatComplexDataColumn\u0027 is not\nJSON serializable\n\nBackground:\nIn class TestListVnfLcmOp definition, \"create_vnflcm_op_occs\" function\nis called and list of fake vnflcm op occs dictionary is store in\nvnflcm_op_occs_obj.\nNow this dictionary is used in two unit test cases \"test_take_action\"\nand \"test_take_action_with_filter\".\nIn order to evaluate test results, in \"test_take_action\" test case,\n\"get_vnflcm_op_occ_data\" function is called using \"vnflcm_op_occs_obj\"\nwhich appends the data in dictionary.\n\nLater this dictionary \"vnflcm_op_occs_obj\" is again used in\n\"test_take_action_with_filter\".\n\nImplementation:\nThis patch creates a separate list of fake vnflcm op occs dictionary for\nboth the test cases.\n\nThis issue has been impacting below reviews as well,\n[1] https://review.opendev.org/c/openstack/python-tackerclient/+/636893\n[2] https://review.opendev.org/c/openstack/python-tackerclient/+/781314\n\nCloses-Bug: #1919350\nChange-Id: I0d62f77cf5d1e9ec0b0a7c404abab83f97b708ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/124be387dcae360873ca75267d9a5e66903d5c73"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tackerclient/commit/124be387dcae360873ca75267d9a5e66903d5c73"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}