)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7d4dad0c24284d8b571f8e26d9819609f667c7ac","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Pooja Singla \u003cpooja.singla@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-01 12:20:26 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Help message of heal cli modified."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"b392527a_60e6a74a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":34},"updated":"2022-02-03 12:20:57.000000000","message":"Could you follow the guideline?\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\n\u003e The first line should be limited to 50 characters and should not end with a period.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"24626f47b6b0936673f1da8f61c2e3865826912f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pooja Singla \u003cpooja.singla@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-01 12:20:26 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Help message of heal cli modified."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"c93cfb1b_21dffd2d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"b392527a_60e6a74a","updated":"2022-02-07 12:43:59.000000000","message":"Done","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4efc669207bb53b6625cf162d2d623e014fd6fa9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pooja Singla \u003cpooja.singla@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-01 12:20:26 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Help message of heal cli modified."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"b4c74350_bfa07331","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"c93cfb1b_21dffd2d","updated":"2022-02-22 00:04:39.000000000","message":"I\u0027ve confirmed.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1a13d94f0d46334f56dea7b4960ad612e02f4876","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Help message of heal cli modified."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1954744"},{"line_number":12,"context_line":"Change-Id: I3b1d04df210ad07d4b9a99f300017d49e2b56f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"d6bad9a6_43aec646","line":9,"updated":"2022-02-07 06:47:51.000000000","message":"Could you please add details of the proposed design in the commit message?","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7d4dad0c24284d8b571f8e26d9819609f667c7ac","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Help message of heal cli modified."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1954744"},{"line_number":12,"context_line":"Change-Id: I3b1d04df210ad07d4b9a99f300017d49e2b56f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"d15adc04_ecfbbbcc","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":6},"updated":"2022-02-03 12:20:57.000000000","message":"nit: Why don\u0027t you change it to lowercase?","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"24626f47b6b0936673f1da8f61c2e3865826912f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Help message of heal cli modified."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1954744"},{"line_number":12,"context_line":"Change-Id: I3b1d04df210ad07d4b9a99f300017d49e2b56f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"c65c411d_63299b91","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":6},"in_reply_to":"d15adc04_ecfbbbcc","updated":"2022-02-07 12:43:59.000000000","message":"Updated commit message itself.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"24626f47b6b0936673f1da8f61c2e3865826912f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Help message of heal cli modified."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1954744"},{"line_number":12,"context_line":"Change-Id: I3b1d04df210ad07d4b9a99f300017d49e2b56f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"f67b6833_a37eae8d","line":9,"in_reply_to":"d6bad9a6_43aec646","updated":"2022-02-07 12:43:59.000000000","message":"Done","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7d4dad0c24284d8b571f8e26d9819609f667c7ac","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1954744"},{"line_number":12,"context_line":"Change-Id: I3b1d04df210ad07d4b9a99f300017d49e2b56f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"4f9be914_810f0577","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":19},"updated":"2022-02-03 12:20:57.000000000","message":"Please write in the following format.\n\n\u003e Closes-Bug: #NNNNNNN","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"24626f47b6b0936673f1da8f61c2e3865826912f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1954744"},{"line_number":12,"context_line":"Change-Id: I3b1d04df210ad07d4b9a99f300017d49e2b56f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"f9ba1165_9a1eb3ae","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":19},"in_reply_to":"4f9be914_810f0577","updated":"2022-02-07 12:43:59.000000000","message":"Done","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4efc669207bb53b6625cf162d2d623e014fd6fa9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This Patch modifies help message of heal command."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1954744"},{"line_number":12,"context_line":"Change-Id: I3b1d04df210ad07d4b9a99f300017d49e2b56f0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"100e9a72_270ed190","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":19},"in_reply_to":"f9ba1165_9a1eb3ae","updated":"2022-02-22 00:04:39.000000000","message":"I\u0027ve confirmed.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1a13d94f0d46334f56dea7b4960ad612e02f4876","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6c775be8_36f29f58","updated":"2022-02-07 06:47:51.000000000","message":"Thank you for your patch. Please find review comment.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7d4dad0c24284d8b571f8e26d9819609f667c7ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"944d0b1c_9d9ed1ad","updated":"2022-02-03 12:20:57.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"807dd297dc100dc91c0324c68351f3a2b6611b7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"069fc7d7_c8cede1c","updated":"2022-02-18 08:50:08.000000000","message":"Thanks for the quick response. I\u0027d like to ask you one more for updating docs.","commit_id":"0f193d16eb1e04656883f053b51d2c6b248fdae9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4efc669207bb53b6625cf162d2d623e014fd6fa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"ec9fa1a0_9001028b","updated":"2022-02-22 00:04:39.000000000","message":"LGTM.","commit_id":"cc73d9d0999af5240b9647e106af9aa4cd9f9eaf"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"c7aa81d31f7634bb9e98b063a7ff43fbe71fc47a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6b25bb9e_0827d456","updated":"2022-02-21 18:37:23.000000000","message":"Thanks for rework. LGTM!!","commit_id":"cc73d9d0999af5240b9647e106af9aa4cd9f9eaf"}],"tackerclient/osc/v1/vnflcm/vnflcm.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"19bde6145429cfbd511acc82e505ec7d2e24d5f6","unresolved":true,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027openstack vnflcm heal [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"},{"line_number":245,"context_line":"        parser.usage \u003d usage_message"},{"line_number":246,"context_line":"        parser.add_argument("},{"line_number":247,"context_line":"            _VNF_INSTANCE,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7be341c1_76df9f72","line":244,"range":{"start_line":241,"start_character":25,"end_line":244,"end_character":56},"updated":"2022-02-02 18:35:46.000000000","message":"Could you elaborate why you use triple single quote for the string and change the attribute `usage` because I\u0027m not sure the reason simply? Thanks.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"3b42e5765b7f2e0fe61950a107e819ea026c7096","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027openstack vnflcm heal [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"},{"line_number":245,"context_line":"        parser.usage \u003d usage_message"},{"line_number":246,"context_line":"        parser.add_argument("},{"line_number":247,"context_line":"            _VNF_INSTANCE,"}],"source_content_type":"text/x-python","patch_set":10,"id":"12573b7b_dee06109","line":244,"range":{"start_line":241,"start_character":25,"end_line":244,"end_character":56},"in_reply_to":"0fd9d7b8_0f39b9fa","updated":"2022-02-17 11:30:24.000000000","message":"Implemented comment in latest patch.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"f2a76118466547ccb17c7935b02547ea4bf949a3","unresolved":true,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027openstack vnflcm heal [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"},{"line_number":245,"context_line":"        parser.usage \u003d usage_message"},{"line_number":246,"context_line":"        parser.add_argument("},{"line_number":247,"context_line":"            _VNF_INSTANCE,"}],"source_content_type":"text/x-python","patch_set":10,"id":"b9fe38df_c91fc219","line":244,"range":{"start_line":241,"start_character":25,"end_line":244,"end_character":56},"in_reply_to":"7359637d_5e8b1999","updated":"2022-02-07 11:32:24.000000000","message":"I thought that strings without \\n were easier to read than strings with \\n.\nThere is no change in behavior from PatchSet 8.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"6c97ca8139bead58e8845568fdbfed299e4eabc7","unresolved":true,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027openstack vnflcm heal [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"},{"line_number":245,"context_line":"        parser.usage \u003d usage_message"},{"line_number":246,"context_line":"        parser.add_argument("},{"line_number":247,"context_line":"            _VNF_INSTANCE,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7359637d_5e8b1999","line":244,"range":{"start_line":241,"start_character":25,"end_line":244,"end_character":56},"in_reply_to":"7be341c1_76df9f72","updated":"2022-02-03 04:59:00.000000000","message":"Dear Ogawa San, usage message of heal cli help was coming wrong. The usage message is created by argument parser based upon the argument passed to it. In heal cli this message was coming wrong. That\u0027s why we changed the attribute usage for this particular case. \nWe used triple string because when we used double quote string then we needed to give \"\\n\" character. But as per Juso san we should avoid these characters. That\u0027s why we used here doc so that \"\\n\" character could be avoided.","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fb57bebae829415c66e63597ba96dae34ae13de8","unresolved":true,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027openstack vnflcm heal [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"},{"line_number":245,"context_line":"        parser.usage \u003d usage_message"},{"line_number":246,"context_line":"        parser.add_argument("},{"line_number":247,"context_line":"            _VNF_INSTANCE,"}],"source_content_type":"text/x-python","patch_set":10,"id":"0fd9d7b8_0f39b9fa","line":244,"range":{"start_line":241,"start_character":25,"end_line":244,"end_character":56},"in_reply_to":"b9fe38df_c91fc219","updated":"2022-02-15 18:45:09.000000000","message":"I\u0027ve understood it\u0027s a deep-seated and hard to fix issued. It\u0027s a problem of `argparse` lib we cannot put a positional arg after args of list (configured as `nargs \u003d \u0027+\u0027`) without using some trick. Unfortunately, `argparse` is wrapped with `command` lib and tacker calls `command`, so we can almost nothing for the issue.\n\nI think your fix of telling the order of args is not enough because it\u0027s not clear that `\u003cvnf-instance\u003e` should be before `--vnfc-instance` from the help. It\u0027s more preferable to separate options and positional arg with `--` like as following.\n\n```\n...\n[--vnfc-instance \u003cvnfc-instance-id\u003e [\u003cvnfc-instance-id\u003e ...]]\n-- \u003cvnf-instance\u003e\n```","commit_id":"d37fd9aefbf83818c23f2303cae6620d804310ae"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fb57bebae829415c66e63597ba96dae34ae13de8","unresolved":true,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027openstack vnflcm heal [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ffd87f57_5f8c7324","line":241,"range":{"start_line":241,"start_character":28,"end_line":241,"end_character":49},"updated":"2022-02-15 18:45:09.000000000","message":"It should be better to use `%(prog)s` instead for the convention.","commit_id":"6b6a0e1543e33247da1f1f711631b8ce2b4b415e"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"3b42e5765b7f2e0fe61950a107e819ea026c7096","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027openstack vnflcm heal [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"0efb2d4a_5d1fdf8c","line":241,"range":{"start_line":241,"start_character":28,"end_line":241,"end_character":49},"in_reply_to":"ffd87f57_5f8c7324","updated":"2022-02-17 11:30:24.000000000","message":"Thanks for your comments. I have included %(prog)s in latest patch.","commit_id":"6b6a0e1543e33247da1f1f711631b8ce2b4b415e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d551bff67842a5f334f3686ece4c838cf08d8663","unresolved":true,"context_lines":[{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027%(prog)s [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             -- \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"},{"line_number":245,"context_line":"        parser.usage \u003d usage_message"},{"line_number":246,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":17,"id":"cc2f4750_24dd3ae0","line":243,"range":{"start_line":242,"start_character":29,"end_line":243,"end_character":65},"updated":"2022-02-17 16:47:32.000000000","message":"Sorry for my comment isn\u0027t enough. Using `--` is to make it clear which arg is positional and should be given after all other optional args. So, `-- \u003cvnf-instance\u003e` should be at the last in this case.","commit_id":"9051009d04ed9fa16d26deac8f4d73bdee38cc0f"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30d9146358058e82c79a532992a5ef350f8b0337","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027%(prog)s [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             -- \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"},{"line_number":245,"context_line":"        parser.usage \u003d usage_message"},{"line_number":246,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":17,"id":"7ba00524_b3dc6e76","line":243,"range":{"start_line":242,"start_character":29,"end_line":243,"end_character":65},"in_reply_to":"9d03d94d_a2d569d2","updated":"2022-02-18 07:59:24.000000000","message":"\u003e Dear Ogawa san, In this cli positional arg \u003cvnf-instance\u003e should be given before optional args. If we give positional arg after optional then it gives error. That is why we have mentioned \u003cvnf-instance\u003e before optional args.\n\nDear Ogawa san, You are right. I have implemented comment in latest patch.","commit_id":"9051009d04ed9fa16d26deac8f4d73bdee38cc0f"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"20f215b0ef2f1ca2188267dbade02d5b65b60b68","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027%(prog)s [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             -- \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"},{"line_number":245,"context_line":"        parser.usage \u003d usage_message"},{"line_number":246,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":17,"id":"9d03d94d_a2d569d2","line":243,"range":{"start_line":242,"start_character":29,"end_line":243,"end_character":65},"in_reply_to":"b27d433a_24858ae2","updated":"2022-02-18 06:47:21.000000000","message":"The point is to separate \u003cvnf-instance\u003e with `--` and it\u0027s works on my env as bellow. `myinst` is accepted as vnf instance from the command line although it doesn\u0027t exist actually. Please ignore some warnings because of ubuntu package.\n\n```\n$ openstack vnflcm heal --vnfc-instance fde3e19f-40a7-4208-9ad9-ae41be1451a2 fde3e19f-40a7-4208-9ad9-ae41be1451a3 -- myinst\n/usr/local/lib/python3.8/dist-packages/pkg_resources/__init__.py:122: PkgResourcesDeprecationWarning: 0.1.36ubuntu1 is an invalid version and will not be supported in a future release\n  warnings.warn(\n/usr/local/lib/python3.8/dist-packages/pkg_resources/__init__.py:122: PkgResourcesDeprecationWarning: 0.23ubuntu1 is an invalid version and will not be supported in a future release\n  warnings.warn(\nCan not find requested vnf: myinst\n```","commit_id":"9051009d04ed9fa16d26deac8f4d73bdee38cc0f"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"b87a3737cc870b3d9004b1f5424ce67115fc41fd","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    def get_parser(self, prog_name):"},{"line_number":240,"context_line":"        parser \u003d super(HealVnfLcm, self).get_parser(prog_name)"},{"line_number":241,"context_line":"        usage_message \u003d (\u0027\u0027\u0027%(prog)s [-h] [--cause CAUSE]"},{"line_number":242,"context_line":"                             -- \u003cvnf-instance\u003e"},{"line_number":243,"context_line":"                             [--vnfc-instance \u003cvnfc-instance-id\u003e \u0027\u0027\u0027"},{"line_number":244,"context_line":"                         \u0027\u0027\u0027[\u003cvnfc-instance-id\u003e ...]]\u0027\u0027\u0027)"},{"line_number":245,"context_line":"        parser.usage \u003d usage_message"},{"line_number":246,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":17,"id":"b27d433a_24858ae2","line":243,"range":{"start_line":242,"start_character":29,"end_line":243,"end_character":65},"in_reply_to":"cc2f4750_24dd3ae0","updated":"2022-02-18 06:12:06.000000000","message":"Dear Ogawa san, In this cli positional arg \u003cvnf-instance\u003e should be given before optional args. If we give positional arg after optional then it gives error. That is why we have mentioned \u003cvnf-instance\u003e before optional args.","commit_id":"9051009d04ed9fa16d26deac8f4d73bdee38cc0f"}],"tackerclient/tests/unit/osc/v1/test_vnflcm.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"807dd297dc100dc91c0324c68351f3a2b6611b7e","unresolved":true,"context_lines":[{"line_number":322,"context_line":"                            \"accepted.\") % vnf_instance[\u0027id\u0027]"},{"line_number":323,"context_line":"        self.assertIn(expected_message, actual_message)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def test_heal_help_usage(self):"},{"line_number":326,"context_line":"        actual_message \u003d self.heal_vnf_lcm.get_parser("},{"line_number":327,"context_line":"            \u0027openstack vnflcm heal\u0027).format_usage().strip()"},{"line_number":328,"context_line":"        expected_message \u003d (\u0027\u0027\u0027usage: openstack vnflcm heal [-h] [--cause CAUSE]"}],"source_content_type":"text/x-python","patch_set":18,"id":"2c5b0a15_1eefc9e5","line":325,"updated":"2022-02-18 08:50:08.000000000","message":"I love testing :), but this test makes no sense because we don\u0027t need to ensure the messages are the same exactly. We should update documentation to tell users the correct usage instead. Although there are several docs showing examples of this command, I think it\u0027s enough to update the example of help message in section #7 at [1].\n\n[1] https://docs.openstack.org/tacker/latest/cli/cli-etsi-vnflcm.html","commit_id":"0f193d16eb1e04656883f053b51d2c6b248fdae9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"af6b44bc70366ecc074207447f2c598975ccf831","unresolved":true,"context_lines":[{"line_number":322,"context_line":"                            \"accepted.\") % vnf_instance[\u0027id\u0027]"},{"line_number":323,"context_line":"        self.assertIn(expected_message, actual_message)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def test_heal_help_usage(self):"},{"line_number":326,"context_line":"        actual_message \u003d self.heal_vnf_lcm.get_parser("},{"line_number":327,"context_line":"            \u0027openstack vnflcm heal\u0027).format_usage().strip()"},{"line_number":328,"context_line":"        expected_message \u003d (\u0027\u0027\u0027usage: openstack vnflcm heal [-h] [--cause CAUSE]"}],"source_content_type":"text/x-python","patch_set":18,"id":"8dfab937_f72cafa0","line":325,"in_reply_to":"2c5b0a15_1eefc9e5","updated":"2022-02-18 11:42:11.000000000","message":"Dear Ogawa san, I have removed test case. Updated https://docs.openstack.org/tacker/latest/cli/cli-etsi-vnflcm.html doc in tacker master branch in patch https://review.opendev.org/c/openstack/tacker/+/829878.","commit_id":"0f193d16eb1e04656883f053b51d2c6b248fdae9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f0162e228bd74593e4b247dabd36810eb24876e5","unresolved":true,"context_lines":[{"line_number":322,"context_line":"                            \"accepted.\") % vnf_instance[\u0027id\u0027]"},{"line_number":323,"context_line":"        self.assertIn(expected_message, actual_message)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def test_heal_help_usage(self):"},{"line_number":326,"context_line":"        actual_message \u003d self.heal_vnf_lcm.get_parser("},{"line_number":327,"context_line":"            \u0027openstack vnflcm heal\u0027).format_usage().strip()"},{"line_number":328,"context_line":"        expected_message \u003d (\u0027\u0027\u0027usage: openstack vnflcm heal [-h] [--cause CAUSE]"}],"source_content_type":"text/x-python","patch_set":18,"id":"f552690b_c16cda5a","line":325,"in_reply_to":"734a5d11_b57f1fd2","updated":"2022-02-21 17:48:29.000000000","message":"Sorry, it was my mistake and you\u0027re right. It\u0027s more helpful to have the same topic for both patches in this case, but isn\u0027t mandatory. Anyway, LGTM.","commit_id":"0f193d16eb1e04656883f053b51d2c6b248fdae9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fc7acb184c2f96fc133219f8d842cde4d4253ae1","unresolved":true,"context_lines":[{"line_number":322,"context_line":"                            \"accepted.\") % vnf_instance[\u0027id\u0027]"},{"line_number":323,"context_line":"        self.assertIn(expected_message, actual_message)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def test_heal_help_usage(self):"},{"line_number":326,"context_line":"        actual_message \u003d self.heal_vnf_lcm.get_parser("},{"line_number":327,"context_line":"            \u0027openstack vnflcm heal\u0027).format_usage().strip()"},{"line_number":328,"context_line":"        expected_message \u003d (\u0027\u0027\u0027usage: openstack vnflcm heal [-h] [--cause CAUSE]"}],"source_content_type":"text/x-python","patch_set":18,"id":"d661e84c_706ae8f7","line":325,"in_reply_to":"8dfab937_f72cafa0","updated":"2022-02-18 17:16:54.000000000","message":"Umm... Why don\u0027t you include updating doc into this patch because both are for the same topic?","commit_id":"0f193d16eb1e04656883f053b51d2c6b248fdae9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"2c382ec6b8ac79af88ca61dc43d994057441ef5b","unresolved":true,"context_lines":[{"line_number":322,"context_line":"                            \"accepted.\") % vnf_instance[\u0027id\u0027]"},{"line_number":323,"context_line":"        self.assertIn(expected_message, actual_message)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def test_heal_help_usage(self):"},{"line_number":326,"context_line":"        actual_message \u003d self.heal_vnf_lcm.get_parser("},{"line_number":327,"context_line":"            \u0027openstack vnflcm heal\u0027).format_usage().strip()"},{"line_number":328,"context_line":"        expected_message \u003d (\u0027\u0027\u0027usage: openstack vnflcm heal [-h] [--cause CAUSE]"}],"source_content_type":"text/x-python","patch_set":18,"id":"734a5d11_b57f1fd2","line":325,"in_reply_to":"d661e84c_706ae8f7","updated":"2022-02-21 11:38:50.000000000","message":"These are two different repositories. One is takerclient and another is tacker. That\u0027s why two patchset is opened which are linked with same bug id. If there is another method of linking two different repos in same link then can you please guide for how to do this.","commit_id":"0f193d16eb1e04656883f053b51d2c6b248fdae9"}]}