)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"0bee45032dd045145bcc85f6a08da13c6472feb5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add support cnf auto scale via threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold CLI to support AutoScale."},{"line_number":10,"context_line":"The Performance Management Threshold API are based on ETSI NFV-SOL"},{"line_number":11,"context_line":"003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint support-auto-lcm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"635a9df6_ca71d364","line":10,"range":{"start_line":10,"start_character":41,"end_line":10,"end_character":44},"updated":"2023-02-15 04:54:14.000000000","message":"nits: are -\u003e is","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9f2b7e5157b880419d063f68041d474df4eb296b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support cnf auto scale via threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold CLI to support AutoScale."},{"line_number":10,"context_line":"The Performance Management Threshold API are based on ETSI NFV-SOL"},{"line_number":11,"context_line":"003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint support-auto-lcm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f24f27ce_04bbc581","line":10,"range":{"start_line":10,"start_character":41,"end_line":10,"end_character":44},"in_reply_to":"0a4ef0c4_c4708ec0","updated":"2023-02-16 01:10:57.000000000","message":"Done","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3c814427035f8a2c2a3b7adcdd342a6ba34004c8","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add support cnf auto scale via threshold interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold CLI to support AutoScale."},{"line_number":10,"context_line":"The Performance Management Threshold API are based on ETSI NFV-SOL"},{"line_number":11,"context_line":"003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint support-auto-lcm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0a4ef0c4_c4708ec0","line":10,"range":{"start_line":10,"start_character":41,"end_line":10,"end_character":44},"in_reply_to":"635a9df6_ca71d364","updated":"2023-02-15 05:36:42.000000000","message":"I fixed it in patchset 4.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"0bee45032dd045145bcc85f6a08da13c6472feb5","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold CLI to support AutoScale."},{"line_number":10,"context_line":"The Performance Management Threshold API are based on ETSI NFV-SOL"},{"line_number":11,"context_line":"003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint support-auto-lcm"},{"line_number":14,"context_line":"Change-Id: Idd313d6abe47dfa41fc86ddc614d00f99f3fc3b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b7ffd1d8_ff3b973d","line":11,"updated":"2023-02-15 04:54:14.000000000","message":"The VNF PM Threshold is also defined in ETSI NFV-SOL002.\n`002 v3.3.1 and ETSI NFV-SOL 003 v3.3.1, which is Version \"2.0.0\" API of Tacker.`","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9f2b7e5157b880419d063f68041d474df4eb296b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold CLI to support AutoScale."},{"line_number":10,"context_line":"The Performance Management Threshold API are based on ETSI NFV-SOL"},{"line_number":11,"context_line":"003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint support-auto-lcm"},{"line_number":14,"context_line":"Change-Id: Idd313d6abe47dfa41fc86ddc614d00f99f3fc3b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9094f5c9_5ac9dbc5","line":11,"in_reply_to":"b52bbaaf_2a2a70fd","updated":"2023-02-16 01:10:57.000000000","message":"Done","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3c814427035f8a2c2a3b7adcdd342a6ba34004c8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the Performance Management Threshold CLI to support AutoScale."},{"line_number":10,"context_line":"The Performance Management Threshold API are based on ETSI NFV-SOL"},{"line_number":11,"context_line":"003 v3.3.1, which are Version \"2.0.0\" API of Tacker."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint support-auto-lcm"},{"line_number":14,"context_line":"Change-Id: Idd313d6abe47dfa41fc86ddc614d00f99f3fc3b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b52bbaaf_2a2a70fd","line":11,"in_reply_to":"b7ffd1d8_ff3b973d","updated":"2023-02-15 05:36:42.000000000","message":"I fixed it in patchset 4.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"0bee45032dd045145bcc85f6a08da13c6472feb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c00c2eb_bd428d21","updated":"2023-02-15 04:54:14.000000000","message":"Thank you for the patch. Please kindly check my comments.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7dc73ac879a84d0b83d74c293cb9219027b00e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5c89155_2704b6e3","updated":"2023-02-10 04:33:30.000000000","message":"recheck - py310 failure\n\nthe following test is failed, but the test work fine in my local environment\n\n* tackerclient.tests.unit.osc.v1.test_vnflcm.TestListVnfLcm.test_take_action_with_pagination","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"81e75b5f2c07479197ac7219cce7d87f53c349b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"861a013e_83293eeb","updated":"2023-02-10 03:16:36.000000000","message":"recheck - py38 failure\n\nthe following test is failed, but the test work fine in my local environment\n\n* tackerclient.tests.unit.osc.v1.test_vnflcm.TestListVnfLcm.test_take_action_with_pagination","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"4ae9c90409b36d82d57fde64d01b1a44cde921b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"33a9a9c2_6fb806fb","updated":"2023-02-15 05:16:36.000000000","message":"Thank you for re-work!\nI added comment, so please kindly check it.","commit_id":"898d760d638bcc0d6b8bd5ebb7f771c0090ae867"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"e1ce31314a82ce63d327c6971f6d9e57ba17664f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19c12faa_63b0c1b4","updated":"2023-02-16 01:30:08.000000000","message":"LGTM","commit_id":"6afb95be5eec51a03522457000307ceabfe3ecbe"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25a32c73611c28f29ae6c7a2c1a24ec22ec27912","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f36363eb_8b8358fd","updated":"2023-02-16 01:26:11.000000000","message":"Thank you for re-work!","commit_id":"6afb95be5eec51a03522457000307ceabfe3ecbe"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9f2b7e5157b880419d063f68041d474df4eb296b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"670a7753_8823855c","updated":"2023-02-16 01:10:57.000000000","message":"Thanks for your re-work!","commit_id":"6afb95be5eec51a03522457000307ceabfe3ecbe"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2920225ba30543c297182b70fa3b4c848d44812b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"216c9912_876cdba6","updated":"2023-02-16 00:58:03.000000000","message":"recheck, the following test is failed, but the test work fine in my local environment\n* tackerclient.tests.unit.osc.v1.test_vnflcm.TestListVnfLcm.test_take_action_with_pagination","commit_id":"6afb95be5eec51a03522457000307ceabfe3ecbe"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9d1c7c220e1a9d366be89d116ffec7d44b13af95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f6f71261_7c740859","updated":"2023-02-16 00:36:15.000000000","message":"recheck, the following test is failed, but the test work fine in my local environment\n* tackerclient.tests.unit.osc.v1.test_vnflcm.TestListVnfLcm.test_take_action_with_pagination","commit_id":"6afb95be5eec51a03522457000307ceabfe3ecbe"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e3d43facd00510289151a14f6af8dac12d1a3361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c5924d8_91c37221","updated":"2023-02-15 09:43:41.000000000","message":"recheck, the following test is failed, but the test work fine in my local environment\n* tackerclient.tests.unit.osc.v1.test_vnflcm_subsc.TestListLccnSubscription.test_take_action_with_pagination","commit_id":"6afb95be5eec51a03522457000307ceabfe3ecbe"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"f71035bc47354548a416c0455f6938494493864d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4fb18e6b_9efb4c85","updated":"2023-02-16 04:10:38.000000000","message":"LGTM","commit_id":"8b45c8082b297ffb0aafc6575440747c1382158d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5e2fe61bcd1f2ae589cabccb7ff6d3879db2fb68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b4844b27_f180fdf8","updated":"2023-02-16 02:10:10.000000000","message":"Thanks for your patch, LGTM.","commit_id":"8b45c8082b297ffb0aafc6575440747c1382158d"}],"tackerclient/osc/v2/vnfpm/samples/create_vnf_pm_threshold_param_sample.json":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"0bee45032dd045145bcc85f6a08da13c6472feb5","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    \"authentication\": {"},{"line_number":17,"context_line":"        \"authType\": ["},{"line_number":18,"context_line":"            \"BASIC\","},{"line_number":19,"context_line":"            \"OAUTH2_CLIENT_CREDENTIALS\""},{"line_number":20,"context_line":"        ],"},{"line_number":21,"context_line":"        \"paramsBasic\": {"},{"line_number":22,"context_line":"            \"userName\": \"nfvo\","}],"source_content_type":"application/json","patch_set":2,"id":"7ae2795c_fee08d12","line":19,"updated":"2023-02-15 04:54:14.000000000","message":"Do you plan to add \"OAUTH2_CLIENT_CERT\" and \"paramsOauth2ClientCert\" attributes in the samples?\nIn Tacker Antelope release, we will support \"OAUTH2_CLIENT_CERT\" for mutual TLS functions[1], so it is better to add new params if the patch will be merged.\n\n[1] https://review.opendev.org/c/openstack/tacker/+/861323","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9f2b7e5157b880419d063f68041d474df4eb296b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \"authentication\": {"},{"line_number":17,"context_line":"        \"authType\": ["},{"line_number":18,"context_line":"            \"BASIC\","},{"line_number":19,"context_line":"            \"OAUTH2_CLIENT_CREDENTIALS\""},{"line_number":20,"context_line":"        ],"},{"line_number":21,"context_line":"        \"paramsBasic\": {"},{"line_number":22,"context_line":"            \"userName\": \"nfvo\","}],"source_content_type":"application/json","patch_set":2,"id":"1b5d6ee8_204f132e","line":19,"in_reply_to":"61d19bf1_0b64b26f","updated":"2023-02-16 01:10:57.000000000","message":"Thanks for your contribution! Done","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3c814427035f8a2c2a3b7adcdd342a6ba34004c8","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    \"authentication\": {"},{"line_number":17,"context_line":"        \"authType\": ["},{"line_number":18,"context_line":"            \"BASIC\","},{"line_number":19,"context_line":"            \"OAUTH2_CLIENT_CREDENTIALS\""},{"line_number":20,"context_line":"        ],"},{"line_number":21,"context_line":"        \"paramsBasic\": {"},{"line_number":22,"context_line":"            \"userName\": \"nfvo\","}],"source_content_type":"application/json","patch_set":2,"id":"61d19bf1_0b64b26f","line":19,"in_reply_to":"7ae2795c_fee08d12","updated":"2023-02-15 05:36:42.000000000","message":"I appended the case of `OAUTH2_CLIENT_CERT`.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"}],"tackerclient/osc/v2/vnfpm/vnfpm_threshold.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5f61eb7257e22e95d2ccf6335e06bb6d0154fcee","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        vnf_pm_threshold, column_map)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def jsonfile2body(file_path):"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    if file_path is None:"},{"line_number":80,"context_line":"        msg \u003d _(\"File %s does not exist\")"},{"line_number":81,"context_line":"        reason \u003d msg % file_path"},{"line_number":82,"context_line":"        raise exceptions.InvalidInput(reason\u003dreason)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    if os.access(file_path, os.R_OK) is False:"},{"line_number":85,"context_line":"        msg \u003d _(\"User does not have read privileges to it\")"},{"line_number":86,"context_line":"        raise exceptions.InvalidInput(reason\u003dmsg)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    try:"},{"line_number":89,"context_line":"        with open(file_path) as f:"},{"line_number":90,"context_line":"            body \u003d json.load(f)"},{"line_number":91,"context_line":"    except (IOError, ValueError) as ex:"},{"line_number":92,"context_line":"        msg \u003d _(\"Failed to load parameter file. Error: %s\")"},{"line_number":93,"context_line":"        reason \u003d msg % ex"},{"line_number":94,"context_line":"        raise exceptions.InvalidInput(reason\u003dreason)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if not body:"},{"line_number":97,"context_line":"        reason \u003d _(\u0027The parameter file is empty\u0027)"},{"line_number":98,"context_line":"        raise exceptions.EmptyInput(reason\u003dreason)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    return body"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class CreateVnfPmThreshold(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":2,"id":"87f3bbf0_378c6e60","line":100,"range":{"start_line":77,"start_character":0,"end_line":100,"end_character":15},"updated":"2023-02-14 01:30:41.000000000","message":"Why don\u0027t you make it as a common function because there are several similar ones with the same name under `osc` dir?","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        vnf_pm_threshold, column_map)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def jsonfile2body(file_path):"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    if file_path is None:"},{"line_number":80,"context_line":"        msg \u003d _(\"File %s does not exist\")"},{"line_number":81,"context_line":"        reason \u003d msg % file_path"},{"line_number":82,"context_line":"        raise exceptions.InvalidInput(reason\u003dreason)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    if os.access(file_path, os.R_OK) is False:"},{"line_number":85,"context_line":"        msg \u003d _(\"User does not have read privileges to it\")"},{"line_number":86,"context_line":"        raise exceptions.InvalidInput(reason\u003dmsg)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    try:"},{"line_number":89,"context_line":"        with open(file_path) as f:"},{"line_number":90,"context_line":"            body \u003d json.load(f)"},{"line_number":91,"context_line":"    except (IOError, ValueError) as ex:"},{"line_number":92,"context_line":"        msg \u003d _(\"Failed to load parameter file. Error: %s\")"},{"line_number":93,"context_line":"        reason \u003d msg % ex"},{"line_number":94,"context_line":"        raise exceptions.InvalidInput(reason\u003dreason)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if not body:"},{"line_number":97,"context_line":"        reason \u003d _(\u0027The parameter file is empty\u0027)"},{"line_number":98,"context_line":"        raise exceptions.EmptyInput(reason\u003dreason)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    return body"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class CreateVnfPmThreshold(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":2,"id":"d036a1ee_aa95042e","line":100,"range":{"start_line":77,"start_character":0,"end_line":100,"end_character":15},"in_reply_to":"87f3bbf0_378c6e60","updated":"2023-02-15 05:03:13.000000000","message":"I moved it into `tackleclient/osc/utils.py`.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"890ecee745b142eb9549f6a77aa131cfce47e2a7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        vnf_pm_threshold, column_map)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def jsonfile2body(file_path):"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    if file_path is None:"},{"line_number":80,"context_line":"        msg \u003d _(\"File %s does not exist\")"},{"line_number":81,"context_line":"        reason \u003d msg % file_path"},{"line_number":82,"context_line":"        raise exceptions.InvalidInput(reason\u003dreason)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    if os.access(file_path, os.R_OK) is False:"},{"line_number":85,"context_line":"        msg \u003d _(\"User does not have read privileges to it\")"},{"line_number":86,"context_line":"        raise exceptions.InvalidInput(reason\u003dmsg)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    try:"},{"line_number":89,"context_line":"        with open(file_path) as f:"},{"line_number":90,"context_line":"            body \u003d json.load(f)"},{"line_number":91,"context_line":"    except (IOError, ValueError) as ex:"},{"line_number":92,"context_line":"        msg \u003d _(\"Failed to load parameter file. Error: %s\")"},{"line_number":93,"context_line":"        reason \u003d msg % ex"},{"line_number":94,"context_line":"        raise exceptions.InvalidInput(reason\u003dreason)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if not body:"},{"line_number":97,"context_line":"        reason \u003d _(\u0027The parameter file is empty\u0027)"},{"line_number":98,"context_line":"        raise exceptions.EmptyInput(reason\u003dreason)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    return body"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class CreateVnfPmThreshold(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5abb18a9_3959fa57","line":100,"range":{"start_line":77,"start_character":0,"end_line":100,"end_character":15},"in_reply_to":"d036a1ee_aa95042e","updated":"2023-02-15 19:01:04.000000000","message":"Ack","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"8fa8b53849c3494743a68bda1350b59b4137810c","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    _description \u003d _(\"Create a new VNF PM threshold\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_parser(self, prog_name):"},{"line_number":107,"context_line":"        parser \u003d super(CreateVnfPmThreshold, self).get_parser(prog_name)"},{"line_number":108,"context_line":"        parser.add_argument("},{"line_number":109,"context_line":"            \u0027request_file\u0027,"},{"line_number":110,"context_line":"            metavar\u003d\"\u003cparam-file\u003e\","}],"source_content_type":"text/x-python","patch_set":2,"id":"959bbd26_c7219957","line":107,"updated":"2023-02-14 08:33:07.000000000","message":"\"ListVnfPmThreshold\" and \"UpdateVnfPmThreshold\" are outputting debug logs.\n(`LOG.debug(\u0027get_parser(%s)\u0027, prog_name)`)\nIs there any reason not to output logs?","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25a32c73611c28f29ae6c7a2c1a24ec22ec27912","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    _description \u003d _(\"Create a new VNF PM threshold\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_parser(self, prog_name):"},{"line_number":107,"context_line":"        parser \u003d super(CreateVnfPmThreshold, self).get_parser(prog_name)"},{"line_number":108,"context_line":"        parser.add_argument("},{"line_number":109,"context_line":"            \u0027request_file\u0027,"},{"line_number":110,"context_line":"            metavar\u003d\"\u003cparam-file\u003e\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3aafa3c9_59372dce","line":107,"in_reply_to":"411b5c63_b9b63660","updated":"2023-02-16 01:26:11.000000000","message":"Done","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    _description \u003d _(\"Create a new VNF PM threshold\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_parser(self, prog_name):"},{"line_number":107,"context_line":"        parser \u003d super(CreateVnfPmThreshold, self).get_parser(prog_name)"},{"line_number":108,"context_line":"        parser.add_argument("},{"line_number":109,"context_line":"            \u0027request_file\u0027,"},{"line_number":110,"context_line":"            metavar\u003d\"\u003cparam-file\u003e\","}],"source_content_type":"text/x-python","patch_set":2,"id":"411b5c63_b9b63660","line":107,"in_reply_to":"959bbd26_c7219957","updated":"2023-02-15 05:03:13.000000000","message":"I fixed it in patchset 3.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5f61eb7257e22e95d2ccf6335e06bb6d0154fcee","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        if total \u003e 1:"},{"line_number":243,"context_line":"            print(_(\u0027All specified VNF PM thresholds are deleted \u0027"},{"line_number":244,"context_line":"                    \u0027successfully\u0027))"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            print(_(\"VNF PM threshold \u0027%s\u0027 deleted \""},{"line_number":247,"context_line":"                    \"successfully\") % vnf_pm_threshold_ids[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"d03b61fc_31ff4d65","line":245,"updated":"2023-02-14 01:30:41.000000000","message":"nit: it\u0027s useless.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3c814427035f8a2c2a3b7adcdd342a6ba34004c8","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        if total \u003e 1:"},{"line_number":243,"context_line":"            print(_(\u0027All specified VNF PM thresholds are deleted \u0027"},{"line_number":244,"context_line":"                    \u0027successfully\u0027))"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            print(_(\"VNF PM threshold \u0027%s\u0027 deleted \""},{"line_number":247,"context_line":"                    \"successfully\") % vnf_pm_threshold_ids[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"f0918c06_bd071b0c","line":245,"in_reply_to":"236bd7a8_5a3c037a","updated":"2023-02-15 05:36:42.000000000","message":"I understood it as deleting the else and replacing it with return.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        if total \u003e 1:"},{"line_number":243,"context_line":"            print(_(\u0027All specified VNF PM thresholds are deleted \u0027"},{"line_number":244,"context_line":"                    \u0027successfully\u0027))"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            print(_(\"VNF PM threshold \u0027%s\u0027 deleted \""},{"line_number":247,"context_line":"                    \"successfully\") % vnf_pm_threshold_ids[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"236bd7a8_5a3c037a","line":245,"in_reply_to":"d03b61fc_31ff4d65","updated":"2023-02-15 05:03:13.000000000","message":"I removed this `else`.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"0bee45032dd045145bcc85f6a08da13c6472feb5","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        if total \u003e 1:"},{"line_number":243,"context_line":"            print(_(\u0027All specified VNF PM thresholds are deleted \u0027"},{"line_number":244,"context_line":"                    \u0027successfully\u0027))"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            print(_(\"VNF PM threshold \u0027%s\u0027 deleted \""},{"line_number":247,"context_line":"                    \"successfully\") % vnf_pm_threshold_ids[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f6dbdcf_18687653","line":245,"in_reply_to":"d03b61fc_31ff4d65","updated":"2023-02-15 04:54:14.000000000","message":"IMO, it is needed. What do you think?\nerror case -\u003e multiple case -\u003e single case (else)","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"890ecee745b142eb9549f6a77aa131cfce47e2a7","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        if total \u003e 1:"},{"line_number":243,"context_line":"            print(_(\u0027All specified VNF PM thresholds are deleted \u0027"},{"line_number":244,"context_line":"                    \u0027successfully\u0027))"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            print(_(\"VNF PM threshold \u0027%s\u0027 deleted \""},{"line_number":247,"context_line":"                    \"successfully\") % vnf_pm_threshold_ids[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"c001037b_21477569","line":245,"in_reply_to":"f0918c06_bd071b0c","updated":"2023-02-15 19:01:04.000000000","message":"Ack","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"4ae9c90409b36d82d57fde64d01b1a44cde921b0","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    _description \u003d _(\"Display VNF PM threshold details\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def get_parser(self, prog_name):"},{"line_number":128,"context_line":"        parser \u003d super(ShowVnfPmThreshold, self).get_parser(prog_name)"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            _VNF_PM_THRESHOLD_ID,"},{"line_number":131,"context_line":"            metavar\u003d\"\u003cvnf-pm-threshold-id\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"2e3bb201_a7ff55fd","line":128,"updated":"2023-02-15 05:16:36.000000000","message":"\"ListVnfPmThreshold\" and \"UpdateVnfPmThreshold\" are outputting debug logs.\n( `LOG.debug(\u0027get_parser(%s)\u0027, prog_name)` )\nIs there any reason not to output logs?","commit_id":"898d760d638bcc0d6b8bd5ebb7f771c0090ae867"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3c814427035f8a2c2a3b7adcdd342a6ba34004c8","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    _description \u003d _(\"Display VNF PM threshold details\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def get_parser(self, prog_name):"},{"line_number":128,"context_line":"        parser \u003d super(ShowVnfPmThreshold, self).get_parser(prog_name)"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            _VNF_PM_THRESHOLD_ID,"},{"line_number":131,"context_line":"            metavar\u003d\"\u003cvnf-pm-threshold-id\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"cb6a4d6a_ff612881","line":128,"in_reply_to":"2e3bb201_a7ff55fd","updated":"2023-02-15 05:36:42.000000000","message":"I fixed it in patchset 4.","commit_id":"898d760d638bcc0d6b8bd5ebb7f771c0090ae867"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25a32c73611c28f29ae6c7a2c1a24ec22ec27912","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    _description \u003d _(\"Display VNF PM threshold details\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def get_parser(self, prog_name):"},{"line_number":128,"context_line":"        parser \u003d super(ShowVnfPmThreshold, self).get_parser(prog_name)"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            _VNF_PM_THRESHOLD_ID,"},{"line_number":131,"context_line":"            metavar\u003d\"\u003cvnf-pm-threshold-id\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7d1a3f2c_ac4a1ebb","line":128,"in_reply_to":"cb6a4d6a_ff612881","updated":"2023-02-16 01:26:11.000000000","message":"Done","commit_id":"898d760d638bcc0d6b8bd5ebb7f771c0090ae867"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"4ae9c90409b36d82d57fde64d01b1a44cde921b0","unresolved":true,"context_lines":[{"line_number":177,"context_line":"    _description \u003d _(\"Delete VNF PM threshold\")"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def get_parser(self, prog_name):"},{"line_number":180,"context_line":"        parser \u003d super(DeleteVnfPmThreshold, self).get_parser(prog_name)"},{"line_number":181,"context_line":"        parser.add_argument("},{"line_number":182,"context_line":"            _VNF_PM_THRESHOLD_ID,"},{"line_number":183,"context_line":"            metavar\u003d\"\u003cvnf-pm-threshold-id\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"4dd55be0_2547aee3","line":180,"updated":"2023-02-15 05:16:36.000000000","message":"ditto.","commit_id":"898d760d638bcc0d6b8bd5ebb7f771c0090ae867"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3c814427035f8a2c2a3b7adcdd342a6ba34004c8","unresolved":true,"context_lines":[{"line_number":177,"context_line":"    _description \u003d _(\"Delete VNF PM threshold\")"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def get_parser(self, prog_name):"},{"line_number":180,"context_line":"        parser \u003d super(DeleteVnfPmThreshold, self).get_parser(prog_name)"},{"line_number":181,"context_line":"        parser.add_argument("},{"line_number":182,"context_line":"            _VNF_PM_THRESHOLD_ID,"},{"line_number":183,"context_line":"            metavar\u003d\"\u003cvnf-pm-threshold-id\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9b8c0ac5_10371593","line":180,"in_reply_to":"4dd55be0_2547aee3","updated":"2023-02-15 05:36:42.000000000","message":"I fixed it in patchset 4.","commit_id":"898d760d638bcc0d6b8bd5ebb7f771c0090ae867"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25a32c73611c28f29ae6c7a2c1a24ec22ec27912","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    _description \u003d _(\"Delete VNF PM threshold\")"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def get_parser(self, prog_name):"},{"line_number":180,"context_line":"        parser \u003d super(DeleteVnfPmThreshold, self).get_parser(prog_name)"},{"line_number":181,"context_line":"        parser.add_argument("},{"line_number":182,"context_line":"            _VNF_PM_THRESHOLD_ID,"},{"line_number":183,"context_line":"            metavar\u003d\"\u003cvnf-pm-threshold-id\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"93e7af37_858deb1d","line":180,"in_reply_to":"9b8c0ac5_10371593","updated":"2023-02-16 01:26:11.000000000","message":"Done","commit_id":"898d760d638bcc0d6b8bd5ebb7f771c0090ae867"}],"tackerclient/tests/unit/osc/v2/test_vnfpm_threshold.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5f61eb7257e22e95d2ccf6335e06bb6d0154fcee","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        parsed_args \u003d self.check_parser(self.create_vnf_pm_threshold, arg_list,"},{"line_number":80,"context_line":"                                        verify_list)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        json \u003d vnfpm_threshold_fakes.vnf_pm_threshold_response()"},{"line_number":83,"context_line":"        self.requests_mock.register_uri("},{"line_number":84,"context_line":"            \u0027POST\u0027, os.path.join(self.url, \u0027vnfpm/v2/thresholds\u0027),"},{"line_number":85,"context_line":"            json\u003djson, headers\u003dself.header)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3c83b3e2_ea2e3ddf","line":82,"updated":"2023-02-14 01:30:41.000000000","message":"Please don\u0027t use such a var name confusing like as a name of standard lib.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        parsed_args \u003d self.check_parser(self.create_vnf_pm_threshold, arg_list,"},{"line_number":80,"context_line":"                                        verify_list)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        json \u003d vnfpm_threshold_fakes.vnf_pm_threshold_response()"},{"line_number":83,"context_line":"        self.requests_mock.register_uri("},{"line_number":84,"context_line":"            \u0027POST\u0027, os.path.join(self.url, \u0027vnfpm/v2/thresholds\u0027),"},{"line_number":85,"context_line":"            json\u003djson, headers\u003dself.header)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f9d01e1d_1bfaf5a5","line":82,"in_reply_to":"3c83b3e2_ea2e3ddf","updated":"2023-02-15 05:03:13.000000000","message":"I changed `json` to `response_json`.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"890ecee745b142eb9549f6a77aa131cfce47e2a7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        parsed_args \u003d self.check_parser(self.create_vnf_pm_threshold, arg_list,"},{"line_number":80,"context_line":"                                        verify_list)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        json \u003d vnfpm_threshold_fakes.vnf_pm_threshold_response()"},{"line_number":83,"context_line":"        self.requests_mock.register_uri("},{"line_number":84,"context_line":"            \u0027POST\u0027, os.path.join(self.url, \u0027vnfpm/v2/thresholds\u0027),"},{"line_number":85,"context_line":"            json\u003djson, headers\u003dself.header)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2cb6839c_c69ac9f9","line":82,"in_reply_to":"f9d01e1d_1bfaf5a5","updated":"2023-02-15 19:01:04.000000000","message":"Ack","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5f61eb7257e22e95d2ccf6335e06bb6d0154fcee","unresolved":true,"context_lines":[{"line_number":199,"context_line":"            self.app, self.app_args, cmd_name\u003d\u0027vnfpm threshold show\u0027)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_take_action(self):"},{"line_number":202,"context_line":"        \"\"\"Test of take_action()\"\"\""},{"line_number":203,"context_line":"        vnfpm_threshold_obj \u003d vnfpm_threshold_fakes.vnf_pm_threshold_response()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        arg_list \u003d [vnfpm_threshold_obj[\u0027id\u0027]]"}],"source_content_type":"text/x-python","patch_set":2,"id":"4e374805_3d83d431","line":202,"updated":"2023-02-14 01:30:41.000000000","message":"Let me confirm why you add docstrings for methods only in some classes, not all? It looks no need to do that for me.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"890ecee745b142eb9549f6a77aa131cfce47e2a7","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            self.app, self.app_args, cmd_name\u003d\u0027vnfpm threshold show\u0027)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_take_action(self):"},{"line_number":202,"context_line":"        \"\"\"Test of take_action()\"\"\""},{"line_number":203,"context_line":"        vnfpm_threshold_obj \u003d vnfpm_threshold_fakes.vnf_pm_threshold_response()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        arg_list \u003d [vnfpm_threshold_obj[\u0027id\u0027]]"}],"source_content_type":"text/x-python","patch_set":2,"id":"556bf303_dd26f2d2","line":202,"in_reply_to":"1127fb37_9c0ad67c","updated":"2023-02-15 19:01:04.000000000","message":"Ack","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":199,"context_line":"            self.app, self.app_args, cmd_name\u003d\u0027vnfpm threshold show\u0027)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_take_action(self):"},{"line_number":202,"context_line":"        \"\"\"Test of take_action()\"\"\""},{"line_number":203,"context_line":"        vnfpm_threshold_obj \u003d vnfpm_threshold_fakes.vnf_pm_threshold_response()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        arg_list \u003d [vnfpm_threshold_obj[\u0027id\u0027]]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1127fb37_9c0ad67c","line":202,"in_reply_to":"4e374805_3d83d431","updated":"2023-02-15 05:03:13.000000000","message":"I removed redundant docstrings.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5f61eb7257e22e95d2ccf6335e06bb6d0154fcee","unresolved":true,"context_lines":[{"line_number":370,"context_line":"        verify_list \u003d [(\u0027vnf_pm_threshold_id\u0027, arg_list)]"},{"line_number":371,"context_line":"        parsed_args \u003d self.check_parser(self.delete_vnf_pm_threshold, arg_list,"},{"line_number":372,"context_line":"                                        verify_list)"},{"line_number":373,"context_line":"        for i in range(0, 3):"},{"line_number":374,"context_line":"            self._mock_request_url_for_delete(i)"},{"line_number":375,"context_line":"        sys.stdout \u003d buffer \u003d StringIO()"},{"line_number":376,"context_line":"        result \u003d self.delete_vnf_pm_threshold.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d3ae5a8e_a45bfde7","line":373,"range":{"start_line":373,"start_character":26,"end_line":373,"end_character":27},"updated":"2023-02-14 01:30:41.000000000","message":"It\u0027s better to not use fixed value for such a value, but len of list defines IDs instead for conventions.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":370,"context_line":"        verify_list \u003d [(\u0027vnf_pm_threshold_id\u0027, arg_list)]"},{"line_number":371,"context_line":"        parsed_args \u003d self.check_parser(self.delete_vnf_pm_threshold, arg_list,"},{"line_number":372,"context_line":"                                        verify_list)"},{"line_number":373,"context_line":"        for i in range(0, 3):"},{"line_number":374,"context_line":"            self._mock_request_url_for_delete(i)"},{"line_number":375,"context_line":"        sys.stdout \u003d buffer \u003d StringIO()"},{"line_number":376,"context_line":"        result \u003d self.delete_vnf_pm_threshold.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e3f76245_4dbca847","line":373,"range":{"start_line":373,"start_character":26,"end_line":373,"end_character":27},"in_reply_to":"d3ae5a8e_a45bfde7","updated":"2023-02-15 05:03:13.000000000","message":"I used len of list instead of fixed value.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"890ecee745b142eb9549f6a77aa131cfce47e2a7","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        verify_list \u003d [(\u0027vnf_pm_threshold_id\u0027, arg_list)]"},{"line_number":371,"context_line":"        parsed_args \u003d self.check_parser(self.delete_vnf_pm_threshold, arg_list,"},{"line_number":372,"context_line":"                                        verify_list)"},{"line_number":373,"context_line":"        for i in range(0, 3):"},{"line_number":374,"context_line":"            self._mock_request_url_for_delete(i)"},{"line_number":375,"context_line":"        sys.stdout \u003d buffer \u003d StringIO()"},{"line_number":376,"context_line":"        result \u003d self.delete_vnf_pm_threshold.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"70dbcd50_5188a940","line":373,"range":{"start_line":373,"start_character":26,"end_line":373,"end_character":27},"in_reply_to":"e3f76245_4dbca847","updated":"2023-02-15 19:01:04.000000000","message":"Ack","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5f61eb7257e22e95d2ccf6335e06bb6d0154fcee","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                                      self.delete_vnf_pm_threshold.take_action,"},{"line_number":401,"context_line":"                                      parsed_args)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.assertEqual(\u0027Failed to delete 1 of 3 VNF PM thresholds.\u0027,"},{"line_number":404,"context_line":"                         exception.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b33187e_6de6040c","line":403,"range":{"start_line":403,"start_character":48,"end_line":403,"end_character":49},"updated":"2023-02-14 01:30:41.000000000","message":"ditto","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                                      self.delete_vnf_pm_threshold.take_action,"},{"line_number":401,"context_line":"                                      parsed_args)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.assertEqual(\u0027Failed to delete 1 of 3 VNF PM thresholds.\u0027,"},{"line_number":404,"context_line":"                         exception.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a6ac3714_198a6250","line":403,"range":{"start_line":403,"start_character":48,"end_line":403,"end_character":49},"in_reply_to":"5b33187e_6de6040c","updated":"2023-02-15 05:03:13.000000000","message":"I used len of list instead of fixed value.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"890ecee745b142eb9549f6a77aa131cfce47e2a7","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                                      self.delete_vnf_pm_threshold.take_action,"},{"line_number":401,"context_line":"                                      parsed_args)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.assertEqual(\u0027Failed to delete 1 of 3 VNF PM thresholds.\u0027,"},{"line_number":404,"context_line":"                         exception.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"00cb2d0b_0441a933","line":403,"range":{"start_line":403,"start_character":48,"end_line":403,"end_character":49},"in_reply_to":"a6ac3714_198a6250","updated":"2023-02-15 19:01:04.000000000","message":"Ack","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"}],"tackerclient/tests/unit/osc/v2/vnfpm_threshold_fakes.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5f61eb7257e22e95d2ccf6335e06bb6d0154fcee","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    :param Dictionary attrs:"},{"line_number":41,"context_line":"        A dictionary with all attributes"},{"line_number":42,"context_line":"    :return:"},{"line_number":43,"context_line":"        A pm threshold dict"},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    if action \u003d\u003d \u0027update\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"298011c0_3e9ed8ba","line":42,"updated":"2023-02-14 01:30:41.000000000","message":"No need to add a description for arg `action` before?","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    :param Dictionary attrs:"},{"line_number":41,"context_line":"        A dictionary with all attributes"},{"line_number":42,"context_line":"    :return:"},{"line_number":43,"context_line":"        A pm threshold dict"},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    if action \u003d\u003d \u0027update\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c725beb_79a2490f","line":42,"in_reply_to":"298011c0_3e9ed8ba","updated":"2023-02-15 05:03:13.000000000","message":"I appended description for `action`.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"890ecee745b142eb9549f6a77aa131cfce47e2a7","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    :param Dictionary attrs:"},{"line_number":41,"context_line":"        A dictionary with all attributes"},{"line_number":42,"context_line":"    :return:"},{"line_number":43,"context_line":"        A pm threshold dict"},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    if action \u003d\u003d \u0027update\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f6721952_ef8365d6","line":42,"in_reply_to":"9c725beb_79a2490f","updated":"2023-02-15 19:01:04.000000000","message":"Ack","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5f61eb7257e22e95d2ccf6335e06bb6d0154fcee","unresolved":true,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def get_vnfpm_threshold_data(vnf_pm_threshold, columns\u003dNone):"},{"line_number":103,"context_line":"    \"\"\"Get the vnfpm threshold."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    :return:"},{"line_number":106,"context_line":"        A tuple object sorted based on the name of the columns."},{"line_number":107,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1e80c964_2f3614e0","line":104,"updated":"2023-02-14 01:30:41.000000000","message":"Why don\u0027t you add descs for args with `param` here?","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def get_vnfpm_threshold_data(vnf_pm_threshold, columns\u003dNone):"},{"line_number":103,"context_line":"    \"\"\"Get the vnfpm threshold."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    :return:"},{"line_number":106,"context_line":"        A tuple object sorted based on the name of the columns."},{"line_number":107,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"49cad6ab_f294bcca","line":104,"in_reply_to":"1e80c964_2f3614e0","updated":"2023-02-15 05:03:13.000000000","message":"I appended descs for args with `param`.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"890ecee745b142eb9549f6a77aa131cfce47e2a7","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def get_vnfpm_threshold_data(vnf_pm_threshold, columns\u003dNone):"},{"line_number":103,"context_line":"    \"\"\"Get the vnfpm threshold."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    :return:"},{"line_number":106,"context_line":"        A tuple object sorted based on the name of the columns."},{"line_number":107,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"0bf9226d_018221ca","line":104,"in_reply_to":"49cad6ab_f294bcca","updated":"2023-02-15 19:01:04.000000000","message":"Ack","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"}],"tackerclient/v1_0/client.py":[{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"f17bed42e5ebc5468bc97a7625e4d7e4dcfd74bf","unresolved":true,"context_lines":[{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"    @APIParamsCall"},{"line_number":1154,"context_line":"    def list_vnf_pm_thresholds(self, retrieve_all\u003dTrue, **_params):"},{"line_number":1155,"context_line":"        vnf_pm_thresholds \u003d self.list("},{"line_number":1156,"context_line":"            \"vnf_pm_thresholds\", self.vnf_pm_thresholds_path, retrieve_all,"},{"line_number":1157,"context_line":"            headers\u003dself.headers, **_params)"},{"line_number":1158,"context_line":"        return vnf_pm_thresholds"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"    @APIParamsCall"},{"line_number":1161,"context_line":"    def show_vnf_pm_threshold(self, vnf_pm_threshold_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"0c9204ed_ea121cc1","line":1158,"range":{"start_line":1155,"start_character":0,"end_line":1158,"end_character":32},"updated":"2023-02-14 08:27:38.000000000","message":"It\u0027s just a little bit redundant, below is better for me. What do you think?\n\n```\nreturn self.list(\n    \"vnf_pm_thresholds\", self.vnf_pm_thresholds_path, retrieve_all,\n    headers\u003dself.headers, **_params)\n```","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7e4e2b8cb05c55ada6ef249fa7b25e8c2a0b9ad4","unresolved":true,"context_lines":[{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"    @APIParamsCall"},{"line_number":1154,"context_line":"    def list_vnf_pm_thresholds(self, retrieve_all\u003dTrue, **_params):"},{"line_number":1155,"context_line":"        vnf_pm_thresholds \u003d self.list("},{"line_number":1156,"context_line":"            \"vnf_pm_thresholds\", self.vnf_pm_thresholds_path, retrieve_all,"},{"line_number":1157,"context_line":"            headers\u003dself.headers, **_params)"},{"line_number":1158,"context_line":"        return vnf_pm_thresholds"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"    @APIParamsCall"},{"line_number":1161,"context_line":"    def show_vnf_pm_threshold(self, vnf_pm_threshold_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c8a2aac5_64a76d44","line":1158,"range":{"start_line":1155,"start_character":0,"end_line":1158,"end_character":32},"in_reply_to":"0c9204ed_ea121cc1","updated":"2023-02-15 05:03:13.000000000","message":"I fixed it in patchset 3.","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"4ae9c90409b36d82d57fde64d01b1a44cde921b0","unresolved":false,"context_lines":[{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"    @APIParamsCall"},{"line_number":1154,"context_line":"    def list_vnf_pm_thresholds(self, retrieve_all\u003dTrue, **_params):"},{"line_number":1155,"context_line":"        vnf_pm_thresholds \u003d self.list("},{"line_number":1156,"context_line":"            \"vnf_pm_thresholds\", self.vnf_pm_thresholds_path, retrieve_all,"},{"line_number":1157,"context_line":"            headers\u003dself.headers, **_params)"},{"line_number":1158,"context_line":"        return vnf_pm_thresholds"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"    @APIParamsCall"},{"line_number":1161,"context_line":"    def show_vnf_pm_threshold(self, vnf_pm_threshold_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"167c8805_cd5a9224","line":1158,"range":{"start_line":1155,"start_character":0,"end_line":1158,"end_character":32},"in_reply_to":"c8a2aac5_64a76d44","updated":"2023-02-15 05:16:36.000000000","message":"Done","commit_id":"0919ff5afe270d2b26f664eb9298c5eae186f881"}]}