)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f8256a840273377e6e299fa484f47a39edb4638b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"supported, but if the vim type is OpenStack, it is not supported."},{"line_number":13,"context_line":"This patch fixes that."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: https://blueprints.launchpad.net/tacker/+spec/enhance-api-policy"},{"line_number":16,"context_line":"Change-Id: I37a3e21afced0aae6e0fd3c0cbb28ab16f2b7df8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1949dfd7_16275f25","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":76},"updated":"2023-02-09 07:21:47.000000000","message":"Please change this line to\n```\nImplements: blueprint enhance-api-policy\n```","commit_id":"27e75680cef3c9c7c62130b4f6749678b408117a"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"e77d2a8a06ff15ed62b6412c1e41d17dfa6555d2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"supported, but if the vim type is OpenStack, it is not supported."},{"line_number":13,"context_line":"This patch fixes that."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: https://blueprints.launchpad.net/tacker/+spec/enhance-api-policy"},{"line_number":16,"context_line":"Change-Id: I37a3e21afced0aae6e0fd3c0cbb28ab16f2b7df8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"075f4b9d_ef61aab2","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":76},"in_reply_to":"1949dfd7_16275f25","updated":"2023-02-09 08:01:42.000000000","message":"Done","commit_id":"27e75680cef3c9c7c62130b4f6749678b408117a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"deb056ddf1cb19d03609b293a6b55a06d00e4ef2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-02-09 07:26:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support extra for OpenStack type when register vim"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When register vim, regardless of whether the vim type is"},{"line_number":10,"context_line":"OpenStack or kubernetes, the tacker api supports extra. However,"},{"line_number":11,"context_line":"in the tackerclient, if the vim type is kubernetes, extra is"},{"line_number":12,"context_line":"supported, but if the vim type is OpenStack, it is not supported."},{"line_number":13,"context_line":"This patch fixes that."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint enhance-api-policy"},{"line_number":16,"context_line":"Change-Id: I37a3e21afced0aae6e0fd3c0cbb28ab16f2b7df8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4d33cd92_fd1d010b","line":13,"range":{"start_line":8,"start_character":0,"end_line":13,"end_character":22},"updated":"2023-02-10 14:38:19.000000000","message":"I think it\u0027s better to change it simply like below.\n```\nThis patch changes to allow setting the `extra` parameter in the VIM\nconfiguration for openstack vim type.\n```\nWhat do you think?","commit_id":"6b92ecbe2d7876884fdc4fbd6e3eee19e71a9e33"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"bf024b4c36bbed60acd2883db7011b9418ab952c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-02-09 07:26:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support extra for OpenStack type when register vim"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When register vim, regardless of whether the vim type is"},{"line_number":10,"context_line":"OpenStack or kubernetes, the tacker api supports extra. However,"},{"line_number":11,"context_line":"in the tackerclient, if the vim type is kubernetes, extra is"},{"line_number":12,"context_line":"supported, but if the vim type is OpenStack, it is not supported."},{"line_number":13,"context_line":"This patch fixes that."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint enhance-api-policy"},{"line_number":16,"context_line":"Change-Id: I37a3e21afced0aae6e0fd3c0cbb28ab16f2b7df8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ddf85d4_3df2926f","line":13,"range":{"start_line":8,"start_character":0,"end_line":13,"end_character":22},"in_reply_to":"4d33cd92_fd1d010b","updated":"2023-02-13 01:42:03.000000000","message":"Thanks for your comment.\nAgree, I changed it at patchset 4.","commit_id":"6b92ecbe2d7876884fdc4fbd6e3eee19e71a9e33"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2cbe60f173b5e21a10a79ce6e7e89af295e2d386","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     kexuesheng \u003ckexuesheng@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-13 10:36:06 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support extra for OpenStack type when register vim"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes to allow setting the `extra` parameter in the VIM"},{"line_number":10,"context_line":"configuration for openstack vim type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e39f4e98_b53aea7f","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":13},"updated":"2023-02-14 02:47:30.000000000","message":"nit: The term \u0027extra\u0027 is so general and can be wondered \"extra what?\". So, \u0027extra param\u0027 is better for me.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"5d95b101cfdd7068e0b5ddc486c73e60f2cf5e2e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     kexuesheng \u003ckexuesheng@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-13 10:36:06 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support extra for OpenStack type when register vim"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes to allow setting the `extra` parameter in the VIM"},{"line_number":10,"context_line":"configuration for openstack vim type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"57cd3140_e47f0555","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":13},"in_reply_to":"ce8ec2af_348e6049","updated":"2023-02-16 01:43:11.000000000","message":"It seems OK. I will fix it in PS5.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"7b874a6037fafdece8145fd22d335edba1410e87","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     kexuesheng \u003ckexuesheng@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-13 10:36:06 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support extra for OpenStack type when register vim"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes to allow setting the `extra` parameter in the VIM"},{"line_number":10,"context_line":"configuration for openstack vim type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"eb383ea8_e9f7c249","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":13},"in_reply_to":"e39f4e98_b53aea7f","updated":"2023-02-15 08:25:28.000000000","message":"I think `extra param` is better, too. But, the title will longer than 50 characters. Which word to drop, \u0027param\u0027 seems to have the least importance in comparison, so I dropped it.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2d6f00a793fbf6de8503c8ac37d5eba062869c24","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     kexuesheng \u003ckexuesheng@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-13 10:36:06 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support extra for OpenStack type when register vim"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes to allow setting the `extra` parameter in the VIM"},{"line_number":10,"context_line":"configuration for openstack vim type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ce8ec2af_348e6049","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":13},"in_reply_to":"eb383ea8_e9f7c249","updated":"2023-02-15 18:58:58.000000000","message":"Why don\u0027t you simply drop \"Support\" instead?","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2cbe60f173b5e21a10a79ce6e7e89af295e2d386","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes to allow setting the `extra` parameter in the VIM"},{"line_number":10,"context_line":"configuration for openstack vim type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint enhance-api-policy"},{"line_number":13,"context_line":"Change-Id: I37a3e21afced0aae6e0fd3c0cbb28ab16f2b7df8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"02fbc188_d9f46781","line":11,"updated":"2023-02-14 02:47:30.000000000","message":"Just a confirmation. No need to update docs?","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"7b874a6037fafdece8145fd22d335edba1410e87","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes to allow setting the `extra` parameter in the VIM"},{"line_number":10,"context_line":"configuration for openstack vim type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint enhance-api-policy"},{"line_number":13,"context_line":"Change-Id: I37a3e21afced0aae6e0fd3c0cbb28ab16f2b7df8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a8e5aa7_5d4ca09b","line":11,"in_reply_to":"02fbc188_d9f46781","updated":"2023-02-15 08:25:28.000000000","message":"In the doc of python-tackerclient, I found something related:\nhttps://docs.openstack.org/python-tackerclient/latest/cli/vim_commands.html#vim-register\n\n```\n--config-file \u003cCONFIG_FILE\u003e\n    YAML file with VIM configuration parameters\n```\nDoc does not describe in detail to introduce VIM configuration parameters. So I don\u0027t think there is any need to update the doc to introduce extra param.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2d6f00a793fbf6de8503c8ac37d5eba062869c24","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes to allow setting the `extra` parameter in the VIM"},{"line_number":10,"context_line":"configuration for openstack vim type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint enhance-api-policy"},{"line_number":13,"context_line":"Change-Id: I37a3e21afced0aae6e0fd3c0cbb28ab16f2b7df8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"414dec01_f59625fe","line":11,"in_reply_to":"3a8e5aa7_5d4ca09b","updated":"2023-02-15 18:58:58.000000000","message":"Ack","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f8256a840273377e6e299fa484f47a39edb4638b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8ccd9298_a81bde00","updated":"2023-02-09 07:21:47.000000000","message":"Thanks for your patch, please kindly find my comment.","commit_id":"27e75680cef3c9c7c62130b4f6749678b408117a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"deb056ddf1cb19d03609b293a6b55a06d00e4ef2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"23483a3b_f05a73d7","updated":"2023-02-10 14:38:19.000000000","message":"Thanks for your update, sorry for additional comment, please kindly confirm it.","commit_id":"6b92ecbe2d7876884fdc4fbd6e3eee19e71a9e33"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"977563f95cd24ac10d84b98299b47cb8130e4b3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f2e413fe_01f617a9","updated":"2023-02-14 07:16:59.000000000","message":"Thank you for the patch.\n\nPlease kindly find my comment.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"cf75ee98216bd8f1e1940af5a6907cdbefe1adc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ea616a1e_8ebb0932","updated":"2023-02-14 06:47:10.000000000","message":"Thank you for the patch. Please kindly check my proposal.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"5d95b101cfdd7068e0b5ddc486c73e60f2cf5e2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c676aeac_ba0bb582","updated":"2023-02-16 01:43:11.000000000","message":"Thank you for the review.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"7b874a6037fafdece8145fd22d335edba1410e87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e3334257_f6fb1c0a","updated":"2023-02-15 08:25:28.000000000","message":"Thank you for the review.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5a38ba6bc675d0c9be38a83347126ed3dfc405f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0279801_0cec880f","updated":"2023-02-13 23:23:43.000000000","message":"Thanks for your rework, LGTM.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"9bb7d42c00cdc2d2df0bc931b04a93b9db158220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"021e4995_77448b91","updated":"2023-02-16 08:21:57.000000000","message":"recheck, the following test is failed, but the test work fine in my local environment\ntackerclient.tests.unit.osc.v1.test_vnflcm_subsc.TestListLccnSubscription.test_take_action_with_pagination","commit_id":"e398f422a8a90ece0b105553356ee55be02e6105"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"6c2e9bab98c7ea5621632b1a29b1a57f210fa9ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"238bda9a_9d7f370d","updated":"2023-02-16 03:11:14.000000000","message":"recheck, the following test is failed, but the test work fine in my local environment\ntackerclient.tests.unit.osc.v1.test_vnflcm_subsc.TestListLccnSubscription.test_take_action_with_pagination","commit_id":"e398f422a8a90ece0b105553356ee55be02e6105"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"9381ddb724ebc36d4649a7c01fc35bece3a34496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eb12b65d_d813b9f5","updated":"2023-02-16 02:54:58.000000000","message":"recheck, the following test is failed, but the test work fine in my local environment\ntackerclient.tests.unit.osc.v1.test_vnflcm_subsc.TestListLccnSubscription.test_take_action_with_pagination","commit_id":"e398f422a8a90ece0b105553356ee55be02e6105"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"613ee74a97bbee01519629cb998dd05ba58610a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa20bcd5_65fe760c","updated":"2023-02-16 04:41:30.000000000","message":"recheck, the following test is failed, but the test work fine in my local environment\ntackerclient.tests.unit.osc.v1.test_vnflcm_subsc.TestListLccnSubscription.test_take_action_with_pagination","commit_id":"e398f422a8a90ece0b105553356ee55be02e6105"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"974524dcea775b56bec7e181214001aa028792f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa403b76_6c4004fd","updated":"2023-02-16 07:52:56.000000000","message":"recheck, the following test is failed, but the test work fine in my local environment\ntackerclient.tests.unit.osc.v1.test_vnflcm_subsc.TestListLccnSubscription.test_take_action_with_pagination","commit_id":"e398f422a8a90ece0b105553356ee55be02e6105"}],"tackerclient/tacker/v1_0/nfvo/vim_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2cbe60f173b5e21a10a79ce6e7e89af295e2d386","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        ssl_ca_cert \u003d config_param.pop(\u0027ssl_ca_cert\u0027, \u0027\u0027)"},{"line_number":97,"context_line":"        if ssl_ca_cert:"},{"line_number":98,"context_line":"            vim[\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027] \u003d ssl_ca_cert"},{"line_number":99,"context_line":"    extra \u003d config_param.pop(\u0027extra\u0027, {})"},{"line_number":100,"context_line":"    if extra:"},{"line_number":101,"context_line":"        vim[\u0027extra\u0027] \u003d extra"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def validate_auth_url(url):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a2f89177_ff86a500","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":28},"updated":"2023-02-14 02:47:30.000000000","message":"Is there any reason to use pop() and assign `{}` at once if `config_param` doesn\u0027t have \u0027extra\u0027? Is not enough like as below?\n\n```\nif \u0027extra\u0027 in config_param.keys():\n    vim[\u0027extra\u0027] \u003d config_param[\u0027extra\u0027]\n```","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2d6f00a793fbf6de8503c8ac37d5eba062869c24","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        ssl_ca_cert \u003d config_param.pop(\u0027ssl_ca_cert\u0027, \u0027\u0027)"},{"line_number":97,"context_line":"        if ssl_ca_cert:"},{"line_number":98,"context_line":"            vim[\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027] \u003d ssl_ca_cert"},{"line_number":99,"context_line":"    extra \u003d config_param.pop(\u0027extra\u0027, {})"},{"line_number":100,"context_line":"    if extra:"},{"line_number":101,"context_line":"        vim[\u0027extra\u0027] \u003d extra"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def validate_auth_url(url):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ada0eabd_e2593c9e","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":28},"in_reply_to":"41fab1dd_0dfdef4f","updated":"2023-02-15 18:58:58.000000000","message":"Umm, using pop() doesn\u0027t have any means because `config_param` is not referred from anywhere again after returned from the function in all places calling it, so it\u0027s the same as without pop() actually. Only `vim` is the interested variable after that. However, I agree with your alternative for now.\n\nI\u0027d suggest one more, add a TODO for reminding that pop() is required in the function actually.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"7b874a6037fafdece8145fd22d335edba1410e87","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        ssl_ca_cert \u003d config_param.pop(\u0027ssl_ca_cert\u0027, \u0027\u0027)"},{"line_number":97,"context_line":"        if ssl_ca_cert:"},{"line_number":98,"context_line":"            vim[\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027] \u003d ssl_ca_cert"},{"line_number":99,"context_line":"    extra \u003d config_param.pop(\u0027extra\u0027, {})"},{"line_number":100,"context_line":"    if extra:"},{"line_number":101,"context_line":"        vim[\u0027extra\u0027] \u003d extra"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def validate_auth_url(url):"}],"source_content_type":"text/x-python","patch_set":4,"id":"41fab1dd_0dfdef4f","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":28},"in_reply_to":"9209edf7_ac5454e1","updated":"2023-02-15 08:25:28.000000000","message":"I think what you both said makes sense, how about modifying it like below?\n```\nif \u0027extra\u0027 in config_param:\n    vim[\u0027extra\u0027] \u003d config_param.pop(\u0027extra\u0027)\n```","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"cf75ee98216bd8f1e1940af5a6907cdbefe1adc7","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        ssl_ca_cert \u003d config_param.pop(\u0027ssl_ca_cert\u0027, \u0027\u0027)"},{"line_number":97,"context_line":"        if ssl_ca_cert:"},{"line_number":98,"context_line":"            vim[\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027] \u003d ssl_ca_cert"},{"line_number":99,"context_line":"    extra \u003d config_param.pop(\u0027extra\u0027, {})"},{"line_number":100,"context_line":"    if extra:"},{"line_number":101,"context_line":"        vim[\u0027extra\u0027] \u003d extra"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def validate_auth_url(url):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9209edf7_ac5454e1","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":28},"in_reply_to":"a2f89177_ff86a500","updated":"2023-02-14 06:47:10.000000000","message":"Thanks for the suggestion, PTL. I agree that your examples look simply. \nHowever I think that we use pop() because current vim register functions use it..\nTherefore, how about we follow the same policy as the others and will refactor.\nWhat do you think?","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"5d95b101cfdd7068e0b5ddc486c73e60f2cf5e2e","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        ssl_ca_cert \u003d config_param.pop(\u0027ssl_ca_cert\u0027, \u0027\u0027)"},{"line_number":97,"context_line":"        if ssl_ca_cert:"},{"line_number":98,"context_line":"            vim[\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027] \u003d ssl_ca_cert"},{"line_number":99,"context_line":"    extra \u003d config_param.pop(\u0027extra\u0027, {})"},{"line_number":100,"context_line":"    if extra:"},{"line_number":101,"context_line":"        vim[\u0027extra\u0027] \u003d extra"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def validate_auth_url(url):"}],"source_content_type":"text/x-python","patch_set":4,"id":"34ced370_7aa3f4a5","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":28},"in_reply_to":"ada0eabd_e2593c9e","updated":"2023-02-16 01:43:11.000000000","message":"\"pop() is required in the function actually.\" Doesn\u0027t seem to match your intention, is it correct?\n\nIn addition, I guess, the programmer who wrote this code used pop() to mean moving data from one dictionary to another dictionary, in this case, moving data from config_param to vim. pop() is often used in functions like a2b(), here is args2body_vim().","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"}],"tackerclient/tests/unit/vm/test_vim_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2cbe60f173b5e21a10a79ce6e7e89af295e2d386","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027}}"},{"line_number":55,"context_line":"        vim \u003d {}"},{"line_number":56,"context_line":"        auth_cred \u003d config_param.copy()"},{"line_number":57,"context_line":"        auth_cred.pop(\u0027project_name\u0027)"},{"line_number":58,"context_line":"        auth_cred.pop(\u0027project_domain_name\u0027)"},{"line_number":59,"context_line":"        auth_cred.pop(\u0027type\u0027)"},{"line_number":60,"context_line":"        auth_cred.pop(\u0027extra\u0027)"},{"line_number":61,"context_line":"        expected_vim \u003d {\u0027auth_cred\u0027: auth_cred,"},{"line_number":62,"context_line":"                        \u0027vim_project\u0027:"},{"line_number":63,"context_line":"                            {\u0027name\u0027: sentinel.prj_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff6f0252_07d7c532","line":60,"range":{"start_line":57,"start_character":8,"end_line":60,"end_character":30},"updated":"2023-02-14 02:47:30.000000000","message":"It\u0027s just a little bit redundant, below is better for me. What do you think?\n```\nfor i in [\u0027project_name\u0027, \u0027project_domain_name\u0027, \u0027type\u0027, \u0027extra\u0027]:\n    auth_cred.pop(i)\n```","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2d6f00a793fbf6de8503c8ac37d5eba062869c24","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027}}"},{"line_number":55,"context_line":"        vim \u003d {}"},{"line_number":56,"context_line":"        auth_cred \u003d config_param.copy()"},{"line_number":57,"context_line":"        auth_cred.pop(\u0027project_name\u0027)"},{"line_number":58,"context_line":"        auth_cred.pop(\u0027project_domain_name\u0027)"},{"line_number":59,"context_line":"        auth_cred.pop(\u0027type\u0027)"},{"line_number":60,"context_line":"        auth_cred.pop(\u0027extra\u0027)"},{"line_number":61,"context_line":"        expected_vim \u003d {\u0027auth_cred\u0027: auth_cred,"},{"line_number":62,"context_line":"                        \u0027vim_project\u0027:"},{"line_number":63,"context_line":"                            {\u0027name\u0027: sentinel.prj_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"cbc8a530_2732f5b2","line":60,"range":{"start_line":57,"start_character":8,"end_line":60,"end_character":30},"in_reply_to":"1166ffe0_e4b9a576","updated":"2023-02-15 18:58:58.000000000","message":"Ack","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"5d95b101cfdd7068e0b5ddc486c73e60f2cf5e2e","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027}}"},{"line_number":55,"context_line":"        vim \u003d {}"},{"line_number":56,"context_line":"        auth_cred \u003d config_param.copy()"},{"line_number":57,"context_line":"        auth_cred.pop(\u0027project_name\u0027)"},{"line_number":58,"context_line":"        auth_cred.pop(\u0027project_domain_name\u0027)"},{"line_number":59,"context_line":"        auth_cred.pop(\u0027type\u0027)"},{"line_number":60,"context_line":"        auth_cred.pop(\u0027extra\u0027)"},{"line_number":61,"context_line":"        expected_vim \u003d {\u0027auth_cred\u0027: auth_cred,"},{"line_number":62,"context_line":"                        \u0027vim_project\u0027:"},{"line_number":63,"context_line":"                            {\u0027name\u0027: sentinel.prj_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"531c17ea_4cb53e67","line":60,"range":{"start_line":57,"start_character":8,"end_line":60,"end_character":30},"in_reply_to":"1166ffe0_e4b9a576","updated":"2023-02-16 01:43:11.000000000","message":"Agree.","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"464a55fd5d9c61e3d14aade95f118a78932918f6","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027}}"},{"line_number":55,"context_line":"        vim \u003d {}"},{"line_number":56,"context_line":"        auth_cred \u003d config_param.copy()"},{"line_number":57,"context_line":"        auth_cred.pop(\u0027project_name\u0027)"},{"line_number":58,"context_line":"        auth_cred.pop(\u0027project_domain_name\u0027)"},{"line_number":59,"context_line":"        auth_cred.pop(\u0027type\u0027)"},{"line_number":60,"context_line":"        auth_cred.pop(\u0027extra\u0027)"},{"line_number":61,"context_line":"        expected_vim \u003d {\u0027auth_cred\u0027: auth_cred,"},{"line_number":62,"context_line":"                        \u0027vim_project\u0027:"},{"line_number":63,"context_line":"                            {\u0027name\u0027: sentinel.prj_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1166ffe0_e4b9a576","line":60,"range":{"start_line":57,"start_character":8,"end_line":60,"end_character":30},"in_reply_to":"15948a44_d4f16e68","updated":"2023-02-15 08:54:02.000000000","message":"In general, +1.\n\nnits, but you can write:\n\n```\n        config_param \u003d {\u0027project_name\u0027: sentinel.prj_name,\n                        \u0027project_domain_name\u0027: sentinel.prj_domain_name1,\n                        \u0027type\u0027: \u0027openstack\u0027,\n                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027},\n                        **auth_cred}\n```","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33464,"name":"kexuesheng","email":"kexuesheng@fujitsu.com","username":"kexsh"},"change_message_id":"7b874a6037fafdece8145fd22d335edba1410e87","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027}}"},{"line_number":55,"context_line":"        vim \u003d {}"},{"line_number":56,"context_line":"        auth_cred \u003d config_param.copy()"},{"line_number":57,"context_line":"        auth_cred.pop(\u0027project_name\u0027)"},{"line_number":58,"context_line":"        auth_cred.pop(\u0027project_domain_name\u0027)"},{"line_number":59,"context_line":"        auth_cred.pop(\u0027type\u0027)"},{"line_number":60,"context_line":"        auth_cred.pop(\u0027extra\u0027)"},{"line_number":61,"context_line":"        expected_vim \u003d {\u0027auth_cred\u0027: auth_cred,"},{"line_number":62,"context_line":"                        \u0027vim_project\u0027:"},{"line_number":63,"context_line":"                            {\u0027name\u0027: sentinel.prj_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"15948a44_d4f16e68","line":60,"range":{"start_line":57,"start_character":8,"end_line":60,"end_character":30},"in_reply_to":"56e7d8df_2bbcc498","updated":"2023-02-15 08:25:28.000000000","message":"I agree with both of you, how about modifying it like below?\n```\n    def test_args2body_vim_extra(self):\n        auth_cred \u003d {\u0027username\u0027: sentinel.usrname1,\n                     \u0027password\u0027: sentinel.password1,\n                     \u0027user_domain_name\u0027: sentinel.user_domain.name,\n                     \u0027cert_verify\u0027: \u0027True\u0027}\n        config_param \u003d {\u0027project_name\u0027: sentinel.prj_name,\n                        \u0027project_domain_name\u0027: sentinel.prj_domain_name1,\n                        \u0027type\u0027: \u0027openstack\u0027,\n                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027}}\n        config_param.update(auth_cred)\n        vim \u003d {}\n\n        expected_vim \u003d {\u0027auth_cred\u0027: auth_cred,\n                        \u0027vim_project\u0027:\n                            {\u0027name\u0027: sentinel.prj_name,\n                             \u0027project_domain_name\u0027: sentinel.prj_domain_name1},\n                        \u0027type\u0027: \u0027openstack\u0027,\n                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027}}\n        \n        vim_utils.args2body_vim(config_param.copy(), vim)\n        self.assertEqual(expected_vim, vim)\n```","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"977563f95cd24ac10d84b98299b47cb8130e4b3b","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027}}"},{"line_number":55,"context_line":"        vim \u003d {}"},{"line_number":56,"context_line":"        auth_cred \u003d config_param.copy()"},{"line_number":57,"context_line":"        auth_cred.pop(\u0027project_name\u0027)"},{"line_number":58,"context_line":"        auth_cred.pop(\u0027project_domain_name\u0027)"},{"line_number":59,"context_line":"        auth_cred.pop(\u0027type\u0027)"},{"line_number":60,"context_line":"        auth_cred.pop(\u0027extra\u0027)"},{"line_number":61,"context_line":"        expected_vim \u003d {\u0027auth_cred\u0027: auth_cred,"},{"line_number":62,"context_line":"                        \u0027vim_project\u0027:"},{"line_number":63,"context_line":"                            {\u0027name\u0027: sentinel.prj_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"56e7d8df_2bbcc498","line":60,"range":{"start_line":57,"start_character":8,"end_line":60,"end_character":30},"in_reply_to":"ff6f0252_07d7c532","updated":"2023-02-14 07:16:59.000000000","message":"I agree with Ogawa-san\u0027s opinion. It\u0027s redundant. I would like to suggest to define auth_cred and config_param separately. IMO, a good test shows what is the input value clearly, vice versa.\n\n```\n        config_param \u003d {\u0027project_name\u0027: sentinel.prj_name,\n                        \u0027username\u0027: sentinel.usrname1,\n                        \u0027password\u0027: sentinel.password1,\n                        \u0027project_domain_name\u0027: sentinel.prj_domain_name1,\n                        \u0027user_domain_name\u0027: sentinel.user_domain.name,\n                        \u0027cert_verify\u0027: \u0027True\u0027,\n                        \u0027type\u0027: \u0027openstack\u0027,\n                        \u0027extra\u0027: {\u0027area\u0027: \u0027area_A@region_A\u0027}}\n                        \n        auth_cred \u003d {\u0027username\u0027: sentinel.usrname1,\n                     \u0027password\u0027: sentinel.password1,\n                     \u0027user_domain_name\u0027: sentinel.user_domain.name,\n                     \u0027cert_verify\u0027: \u0027True\u0027}        \n```","commit_id":"fa0e86837cb79dc823a6ef3d58f73ff556d6cd10"}]}