)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9e45b14a4586bc0312b6bab5afc4d8be20f3019a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5707d1de_761e9641","updated":"2023-02-16 08:08:28.000000000","message":"Thank you for the patch. \nLGTM","commit_id":"4d75e5cd342602081b0afca539186a34f558b116"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"3fad09a8f713640ffa17bad2252f3787254aa6e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db406a60_c5e35185","updated":"2023-02-16 08:11:26.000000000","message":"Thank you for the patch. LGTM!","commit_id":"4d75e5cd342602081b0afca539186a34f558b116"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0f40174a2ba36b6b1e90adb0319a4e317d31a973","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d11e649f_d7193cf7","updated":"2023-02-16 08:40:56.000000000","message":"Thanks for your patch!\n\nIf you know, please tell me that one thing,\nThe following other error occur in tox testing.\n\n```\ntackerclient.tests.unit.osc.v1.test_vnflcm.TestListVnfLcm.test_take_action_with_pagination\n------------------------------------------------------------------------------------------\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/tackerclient/client.py\", line 98, in _cs_request\n    resp, body \u003d self.request(*args, **kargs)\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/tackerclient/client.py\", line 139, in request\n    resp \u003d requests.request(\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/.tox/py38/lib/python3.8/site-packages/requests/api.py\", line 59, in request\n    return session.request(method\u003dmethod, url\u003durl, **kwargs)\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/.tox/py38/lib/python3.8/site-packages/requests/sessions.py\", line 587, in request\n    resp \u003d self.send(prep, **send_kwargs)\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/.tox/py38/lib/python3.8/site-packages/requests_mock/mocker.py\", line 185, in _fake_send\n    return _original_send(session, request, **kwargs)\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/.tox/py38/lib/python3.8/site-packages/requests/sessions.py\", line 701, in send\n    r \u003d adapter.send(request, **kwargs)\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/.tox/py38/lib/python3.8/site-packages/requests_mock/adapter.py\", line 248, in send\n    resp \u003d matcher(request)\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/.tox/py38/lib/python3.8/site-packages/requests_mock/adapter.py\", line 228, in __call__\n    return response_matcher.get_response(request)\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/.tox/py38/lib/python3.8/site-packages/requests_mock/response.py\", line 270, in get_response\n    return create_response(request,\n\n      File \"/home/zuul/src/opendev.org/openstack/python-tackerclient/.tox/py38/lib/python3.8/site-packages/requests_mock/response.py\", line 182, in create_response\n    text \u003d jsonutils.dumps(json, cls\u003dencoder)\n\n      File \"/usr/lib/python3.8/json/__init__.py\", line 234, in dumps\n    return cls(\n\n      File \"/usr/lib/python3.8/json/encoder.py\", line 199, in encode\n    chunks \u003d self.iterencode(o, _one_shot\u003dTrue)\n\n      File \"/usr/lib/python3.8/json/encoder.py\", line 257, in iterencode\n    return _iterencode(o, 0)\n\n      File \"/usr/lib/python3.8/json/encoder.py\", line 179, in default\n    raise TypeError(f\u0027Object of type {o.__class__.__name__} \u0027\n\n    TypeError: Object of type FormatComplexDataColumn is not JSON serializable\n```\n\nThe tests in the TestListVnfLcm use the one data (`vnf_instances`) like as the cause code for this patch.\n\nhttps://opendev.org/openstack/python-tackerclient/src/branch/master/tackerclient/tests/unit/osc/v1/test_vnflcm.py#L160\n\nIn that case, could you add a fix to this patch, or post it with other patches?\nThank you.","commit_id":"4d75e5cd342602081b0afca539186a34f558b116"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ac3f998bba5f739d59197ca589c62aa5476583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"61355dfd_f59de81a","in_reply_to":"aa0b6710_aedd1d7b","updated":"2023-02-17 04:30:33.000000000","message":"Thanks for your quick work! I\u0027ve confirmed.","commit_id":"4d75e5cd342602081b0afca539186a34f558b116"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2b5f2bb063c60a9b67615430370085bac2b6b591","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa0b6710_aedd1d7b","in_reply_to":"d11e649f_d7193cf7","updated":"2023-02-16 09:25:37.000000000","message":"Thank you for the information.\nI modified the UT for the VNF list as well.\nPlease confirm.","commit_id":"4d75e5cd342602081b0afca539186a34f558b116"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1e2dff7756cbaa6daf3ec2b97875de24d7c7f95b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dcdda44e_48ee8b1b","updated":"2023-02-16 11:10:04.000000000","message":"I don\u0027t agree to just create a new instances in all the functions because the actual cause of the problem is `get_subscription_data()` in which the arg `subscription` is changed unexpectedly. I think creating new instances in functions doesn\u0027t any harm, but useless if `get_subscription_data()` is fixed to not change the given arg. It can be useful only to avoid the `subscription` in somewhere accidentally in a future update.\n\nTo summarize, I think we should fix `get_subscription_data()` anyway. What do you think?","commit_id":"60e8aa155cffe1bfd5d3369ce2955135b32705c4"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"0145056e0782bc948dd243660535cb58812e024d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8de95938_226e80fa","updated":"2023-02-16 10:37:27.000000000","message":"Thank you for fixing tackerclient UT. LGTM 😊","commit_id":"60e8aa155cffe1bfd5d3369ce2955135b32705c4"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d1a45ae5eea6d503438ea13ad8333aa8d3d26956","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5e31c84b_23b7bc1e","in_reply_to":"7db87a1b_2968331f","updated":"2023-02-17 00:45:45.000000000","message":"Thank you for your opinion.\nI changed the subscription and vnf_instance to not modify it directly.\nPlease confirm.\n\nWith this fix, test data can now be used in common for each test.\nBut I think each test should be independent.\nConsidering the future, I would like to create test data for each test.","commit_id":"60e8aa155cffe1bfd5d3369ce2955135b32705c4"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9ba64f96a18463f7bec80f9a3831e1ee2b8f216e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7db87a1b_2968331f","in_reply_to":"dcdda44e_48ee8b1b","updated":"2023-02-16 11:14:10.000000000","message":"The arg is changed here.\nhttps://opendev.org/openstack/python-tackerclient/src/branch/master/tackerclient/tests/unit/osc/v1/vnflcm_subsc_fakes.py#L166","commit_id":"60e8aa155cffe1bfd5d3369ce2955135b32705c4"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"92a969e5250d64db24d9a4a47e1bf9f5241045e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"78ac5f62_d91b3484","updated":"2023-02-17 04:23:22.000000000","message":"LGTM, thanks.","commit_id":"a41323dc1df66ebd86e96e65137f3c7e2363b7f4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85ac3f998bba5f739d59197ca589c62aa5476583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"375ea268_4e9a90b3","updated":"2023-02-17 04:30:33.000000000","message":"LGTM.","commit_id":"a41323dc1df66ebd86e96e65137f3c7e2363b7f4"}]}