)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b7233cbfade0168122af13f8dea01e8e1f9d4176","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Obsolete Legacy APIs excluding VIM feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch obsoletes CLI for Legacy APIs excluding VIM feature."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9be376a660c6f7c34c0abe7e327dec7a91d49ee2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"8d79f12f_f147dd9a","line":10,"updated":"2023-12-07 10:19:48.000000000","message":"It is better to add the following.\n- Implements: blueprint deprecate-legacy-apis\n\nAnd it is better to set the following in Topic.\n- bp/deprecate-legacy-apis","commit_id":"3ad2ea6268e7bdf282a2a8024479558af22d733d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8bb9677da058f37cd4c77c95e5c817e5b9e4cdaf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Obsolete Legacy APIs excluding VIM feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch obsoletes CLI for Legacy APIs excluding VIM feature."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9be376a660c6f7c34c0abe7e327dec7a91d49ee2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d103e45c_032c5a5f","line":10,"in_reply_to":"6b02a61d_6812a01e","updated":"2023-12-10 23:45:59.000000000","message":"Done","commit_id":"3ad2ea6268e7bdf282a2a8024479558af22d733d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5816226f15386b5c12e9bc8e1c4a438d35f7a1e3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Obsolete Legacy APIs excluding VIM feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch obsoletes CLI for Legacy APIs excluding VIM feature."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9be376a660c6f7c34c0abe7e327dec7a91d49ee2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6b02a61d_6812a01e","line":10,"in_reply_to":"8d79f12f_f147dd9a","updated":"2023-12-08 04:11:24.000000000","message":"I added Implements tag and set Topic in PS6.","commit_id":"3ad2ea6268e7bdf282a2a8024479558af22d733d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b7233cbfade0168122af13f8dea01e8e1f9d4176","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d8e57f3c_b351f331","updated":"2023-12-07 10:19:48.000000000","message":"Are the following Exceptions necessary?\n- tackerclient/common/exceptions.py\n   - InvalidIpForNetworkClient\n   - MacAddressInUseClient\n   - AmbiguousEndpoints","commit_id":"3ad2ea6268e7bdf282a2a8024479558af22d733d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8bb9677da058f37cd4c77c95e5c817e5b9e4cdaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b1a634a1_05dd1004","in_reply_to":"a0e678b3_abd2eca9","updated":"2023-12-10 23:45:59.000000000","message":"Done","commit_id":"3ad2ea6268e7bdf282a2a8024479558af22d733d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5816226f15386b5c12e9bc8e1c4a438d35f7a1e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a0e678b3_abd2eca9","in_reply_to":"d8e57f3c_b351f331","updated":"2023-12-08 04:11:24.000000000","message":"I think those Exceptions are not necessary. Also I removed unnecessary other exceptions.","commit_id":"3ad2ea6268e7bdf282a2a8024479558af22d733d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4d939b16b4ef7c9716305c0b8d779a8b26fd6b8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1fb1c0e2_f5414429","updated":"2023-12-08 08:04:19.000000000","message":"Just a tiny question.","commit_id":"e1cd39fa41b823138dfd3cbca4063f2f475ddc34"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"16faa983721a3a41bb12ffbdd604cd8ef681cd8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"620dbabe_2f63fce0","updated":"2023-12-12 02:01:56.000000000","message":"LGTM","commit_id":"e1cd39fa41b823138dfd3cbca4063f2f475ddc34"}],"tackerclient/common/serializer.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4d939b16b4ef7c9716305c0b8d779a8b26fd6b8c","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        return jsonutils.dumps(data, default\u003dsanitizer)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class XMLDictSerializer(DictSerializer):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def __init__(self, metadata\u003dNone, xmlns\u003dNone):"},{"line_number":64,"context_line":"        \"\"\"XMLDictSerializer constructor."}],"source_content_type":"text/x-python","patch_set":6,"id":"b0dbc576_1303d264","side":"PARENT","line":61,"updated":"2023-12-08 08:04:19.000000000","message":"Why this and after classes related to parse xml are removed? It doesn\u0027t seem a dedicated class for legacy features. Is there no need to keep the method in tacker anymore?","commit_id":"1c608378b1d162cf18fb564a75f9f37422370714"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ae655ca85092a3dbe35b3af33a906419d8f71a4d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        return jsonutils.dumps(data, default\u003dsanitizer)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class XMLDictSerializer(DictSerializer):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def __init__(self, metadata\u003dNone, xmlns\u003dNone):"},{"line_number":64,"context_line":"        \"\"\"XMLDictSerializer constructor."}],"source_content_type":"text/x-python","patch_set":6,"id":"dc488629_ec2c1835","side":"PARENT","line":61,"in_reply_to":"b0dbc576_1303d264","updated":"2023-12-08 08:39:15.000000000","message":"Thanks for your question.\nThe SOL v1/v2 API and Vim functionality did not need the XML format files to be input, so I thought XML was unnecessary.\nAlso, as for whether it was used by other Legacy APIs, the documentation doesn\u0027t show that xml is used, so at least it seems unnecessary for Tacker now.\n\nI also feel that what was used in python-neutronclient that python-tackerclient referenced is still there. FYI, the XML support was dropped and remove codes long ago in neutronclient [1].\n\nShould I not delete it?\n\n[1] https://opendev.org/openstack/python-neutronclient/commit/54a4aea969fe06422f64005652ce23ac7b616d98","commit_id":"1c608378b1d162cf18fb564a75f9f37422370714"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"65a4faebf546b1292f4f69669b34f298445b2c4d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        return jsonutils.dumps(data, default\u003dsanitizer)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class XMLDictSerializer(DictSerializer):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def __init__(self, metadata\u003dNone, xmlns\u003dNone):"},{"line_number":64,"context_line":"        \"\"\"XMLDictSerializer constructor."}],"source_content_type":"text/x-python","patch_set":6,"id":"e3fa88f3_e62c357e","side":"PARENT","line":61,"in_reply_to":"dc488629_ec2c1835","updated":"2023-12-12 02:00:09.000000000","message":"OK, agree. thanks!","commit_id":"1c608378b1d162cf18fb564a75f9f37422370714"}]}