)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e03cecdabdcb365377f3f169c045f1a364fc4ba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"58aa57d9_cb3a34ae","updated":"2024-12-10 06:16:29.000000000","message":"LGTM, thanks for your patch.\nAlso, I saw that it was reflected in the documentation by the following tacker patch. I\u0027ll review it later.","commit_id":"0a8dced06eb3b416d89b64c78f4f945dea1f002f"},{"author":{"_account_id":31668},"change_message_id":"b4a552faa8db23fbb84e4828cb03297f65fcb3b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d50159a8_103fa0eb","updated":"2024-12-09 05:16:10.000000000","message":"Thank you for the review.","commit_id":"0a8dced06eb3b416d89b64c78f4f945dea1f002f"},{"author":{"_account_id":36938,"name":"Kyaw Myo Thant","display_name":"Kyaw Myo Thant","email":"kyawmyothant@ntt-at.co.jp","username":"AT-Kyawmyothant"},"change_message_id":"949d919a3283f3ec093c5868818816889326d9ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4799e0df_7cc9e877","updated":"2024-12-09 08:24:55.000000000","message":"Thanks for the fix. LGTM","commit_id":"0a8dced06eb3b416d89b64c78f4f945dea1f002f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"89d2de13542a95b19c35b1775edb655c306e2906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"82659a84_81bc4904","in_reply_to":"58aa57d9_cb3a34ae","updated":"2024-12-10 07:13:05.000000000","message":"Sorry, there was an omission in a comment.\n\nThe relevant change patch for tacker\u0027s documentation is:\nhttps://review.opendev.org/c/openstack/tacker/+/937090","commit_id":"0a8dced06eb3b416d89b64c78f4f945dea1f002f"}],"tackerclient/osc/v1/vnflcm/vnflcm.py":[{"author":{"_account_id":36938,"name":"Kyaw Myo Thant","display_name":"Kyaw Myo Thant","email":"kyawmyothant@ntt-at.co.jp","username":"AT-Kyawmyothant"},"change_message_id":"befc9a4fc73f036511158ef15219cc0ee6db1963","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        if vnflcm_obj[\u0027instantiationState\u0027] \u003d\u003d \u0027INSTANTIATED\u0027:"},{"line_number":74,"context_line":"            column_map.update("},{"line_number":75,"context_line":"                {\u0027instantiatedVnfInfo\u0027: \u0027Instantiated Vnf Info\u0027}"},{"line_number":76,"context_line":"            )"},{"line_number":77,"context_line":"        column_map.update("},{"line_number":78,"context_line":"            {\u0027vimConnectionInfo\u0027: \u0027VIM Connection Info\u0027,"},{"line_number":79,"context_line":"             \u0027_links\u0027: \u0027Links\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b9d8fd4_bc7266fe","line":76,"updated":"2024-12-09 03:08:35.000000000","message":"Thanks for the fixing improving the display of vnfPkgId. \nI suggest the following code because I think it will be better if vnfPkgId is displayed as \"VNF Package ID\" like other column. \n```suggestion\n            )\n        if \u0027vnfPkgId\u0027 in vnflcm_obj:\n            column_map.update(\n                {\u0027vnfPkgId\u0027: \u0027VNF Package ID\u0027}\n            )\n```","commit_id":"bac698372b1bbfd87614294411c3514612e6b3f5"},{"author":{"_account_id":36938,"name":"Kyaw Myo Thant","display_name":"Kyaw Myo Thant","email":"kyawmyothant@ntt-at.co.jp","username":"AT-Kyawmyothant"},"change_message_id":"949d919a3283f3ec093c5868818816889326d9ec","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if vnflcm_obj[\u0027instantiationState\u0027] \u003d\u003d \u0027INSTANTIATED\u0027:"},{"line_number":74,"context_line":"            column_map.update("},{"line_number":75,"context_line":"                {\u0027instantiatedVnfInfo\u0027: \u0027Instantiated Vnf Info\u0027}"},{"line_number":76,"context_line":"            )"},{"line_number":77,"context_line":"        column_map.update("},{"line_number":78,"context_line":"            {\u0027vimConnectionInfo\u0027: \u0027VIM Connection Info\u0027,"},{"line_number":79,"context_line":"             \u0027_links\u0027: \u0027Links\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"8462ecf2_90d46359","line":76,"in_reply_to":"7b9a1446_884cbc56","updated":"2024-12-09 08:24:55.000000000","message":"Done","commit_id":"bac698372b1bbfd87614294411c3514612e6b3f5"},{"author":{"_account_id":31668},"change_message_id":"b4a552faa8db23fbb84e4828cb03297f65fcb3b9","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        if vnflcm_obj[\u0027instantiationState\u0027] \u003d\u003d \u0027INSTANTIATED\u0027:"},{"line_number":74,"context_line":"            column_map.update("},{"line_number":75,"context_line":"                {\u0027instantiatedVnfInfo\u0027: \u0027Instantiated Vnf Info\u0027}"},{"line_number":76,"context_line":"            )"},{"line_number":77,"context_line":"        column_map.update("},{"line_number":78,"context_line":"            {\u0027vimConnectionInfo\u0027: \u0027VIM Connection Info\u0027,"},{"line_number":79,"context_line":"             \u0027_links\u0027: \u0027Links\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b9a1446_884cbc56","line":76,"in_reply_to":"7b9d8fd4_bc7266fe","updated":"2024-12-09 05:16:10.000000000","message":"Thank you for your suggestion.\nI think it would be ideal to comply with SOL and not use vnfPkgId in the v1 API, or to separate Clients for v1 and v2, so I added a Note and applied your suggestion.","commit_id":"bac698372b1bbfd87614294411c3514612e6b3f5"}],"tackerclient/tests/unit/osc/v1/test_vnflcm.py":[{"author":{"_account_id":36938,"name":"Kyaw Myo Thant","display_name":"Kyaw Myo Thant","email":"kyawmyothant@ntt-at.co.jp","username":"AT-Kyawmyothant"},"change_message_id":"befc9a4fc73f036511158ef15219cc0ee6db1963","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    columns \u003d [\u0027ID\u0027, \u0027Instantiation State\u0027, \u0027VNF Instance Description\u0027,"},{"line_number":51,"context_line":"               \u0027VNF Instance Name\u0027, \u0027VNF Product Name\u0027, \u0027VNF Provider\u0027,"},{"line_number":52,"context_line":"               \u0027VNF Software Version\u0027, \u0027VNFD ID\u0027, \u0027VNFD Version\u0027, \u0027Links\u0027,"},{"line_number":53,"context_line":"               \u0027VNF Configurable Properties\u0027, \u0027vnfPkgId\u0027]"},{"line_number":54,"context_line":"    if action \u003d\u003d \u0027show\u0027:"},{"line_number":55,"context_line":"        columns.extend([\u0027Instantiated Vnf Info\u0027, \u0027VIM Connection Info\u0027])"},{"line_number":56,"context_line":"    if action \u003d\u003d \u0027list\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"c5dbc444_c0b9cb07","line":53,"updated":"2024-12-09 03:08:35.000000000","message":"If the change that I suggested in the previous comment is accepted, I think column name here is also needed to be changed for unit test.","commit_id":"bac698372b1bbfd87614294411c3514612e6b3f5"},{"author":{"_account_id":36938,"name":"Kyaw Myo Thant","display_name":"Kyaw Myo Thant","email":"kyawmyothant@ntt-at.co.jp","username":"AT-Kyawmyothant"},"change_message_id":"949d919a3283f3ec093c5868818816889326d9ec","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    columns \u003d [\u0027ID\u0027, \u0027Instantiation State\u0027, \u0027VNF Instance Description\u0027,"},{"line_number":51,"context_line":"               \u0027VNF Instance Name\u0027, \u0027VNF Product Name\u0027, \u0027VNF Provider\u0027,"},{"line_number":52,"context_line":"               \u0027VNF Software Version\u0027, \u0027VNFD ID\u0027, \u0027VNFD Version\u0027, \u0027Links\u0027,"},{"line_number":53,"context_line":"               \u0027VNF Configurable Properties\u0027, \u0027vnfPkgId\u0027]"},{"line_number":54,"context_line":"    if action \u003d\u003d \u0027show\u0027:"},{"line_number":55,"context_line":"        columns.extend([\u0027Instantiated Vnf Info\u0027, \u0027VIM Connection Info\u0027])"},{"line_number":56,"context_line":"    if action \u003d\u003d \u0027list\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"c0eb9ce7_b0a39c0c","line":53,"in_reply_to":"0c3e9e2d_32217a69","updated":"2024-12-09 08:24:55.000000000","message":"Done","commit_id":"bac698372b1bbfd87614294411c3514612e6b3f5"},{"author":{"_account_id":31668},"change_message_id":"b4a552faa8db23fbb84e4828cb03297f65fcb3b9","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    columns \u003d [\u0027ID\u0027, \u0027Instantiation State\u0027, \u0027VNF Instance Description\u0027,"},{"line_number":51,"context_line":"               \u0027VNF Instance Name\u0027, \u0027VNF Product Name\u0027, \u0027VNF Provider\u0027,"},{"line_number":52,"context_line":"               \u0027VNF Software Version\u0027, \u0027VNFD ID\u0027, \u0027VNFD Version\u0027, \u0027Links\u0027,"},{"line_number":53,"context_line":"               \u0027VNF Configurable Properties\u0027, \u0027vnfPkgId\u0027]"},{"line_number":54,"context_line":"    if action \u003d\u003d \u0027show\u0027:"},{"line_number":55,"context_line":"        columns.extend([\u0027Instantiated Vnf Info\u0027, \u0027VIM Connection Info\u0027])"},{"line_number":56,"context_line":"    if action \u003d\u003d \u0027list\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c3e9e2d_32217a69","line":53,"in_reply_to":"c5dbc444_c0b9cb07","updated":"2024-12-09 05:16:10.000000000","message":"I fixed it.","commit_id":"bac698372b1bbfd87614294411c3514612e6b3f5"}]}