)]}'
{"tripleoclient/tests/v1/overcloud_deploy/fakes.py":[{"author":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"change_message_id":"74c7cd31ea5c574cc724f855579f3b596a415649","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def create_to_dict_mock(**kwargs):"},{"line_number":21,"context_line":"    mock_ \u003d mock.Mock()"},{"line_number":22,"context_line":"    mock_.configure_mock(**kwargs)"},{"line_number":23,"context_line":"    mock_.to_dict.return_value \u003d kwargs"},{"line_number":24,"context_line":"    return mock_"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_3aaf8f2b","line":21,"updated":"2015-09-23 11:16:23.000000000","message":"Nit: I am not sure if variable name ending with underscore looks nice.","commit_id":"3d7ea1ede509019579b14855996bc6a98d535018"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a6a75e79d7b707e5b51f9a2e0cf218cb1a8ee8d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def create_to_dict_mock(**kwargs):"},{"line_number":21,"context_line":"    mock_ \u003d mock.Mock()"},{"line_number":22,"context_line":"    mock_.configure_mock(**kwargs)"},{"line_number":23,"context_line":"    mock_.to_dict.return_value \u003d kwargs"},{"line_number":24,"context_line":"    return mock_"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_41229353","line":21,"in_reply_to":"ba15a1d1_3aaf8f2b","updated":"2016-08-31 10:52:26.000000000","message":"Done","commit_id":"3d7ea1ede509019579b14855996bc6a98d535018"}],"tripleoclient/tests/v1/overcloud_deploy/test_overcloud_deploy.py":[{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"325c18d770a0aab427e2f89a2bf5e733475faa02","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                \u0027_deploy_tripleo_heat_templates\u0027, autospec\u003dTrue)"},{"line_number":423,"context_line":"    @mock.patch(\u0027tripleoclient.v1.overcloud_deploy.DeployOvercloud.\u0027"},{"line_number":424,"context_line":"                \u0027_pre_heat_deploy\u0027, autospec\u003dTrue)"},{"line_number":425,"context_line":"    def test_invalid_deploy_call(self, mock_pre_deploy, mock_deploy_tht):"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        arglist \u003d [\u0027--plan\u0027, \u0027undercloud\u0027, \u0027--templates\u0027]"},{"line_number":428,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_394a0b27","line":425,"updated":"2015-09-17 14:29:45.000000000","message":"If removing the --plan arg, this test is no longer necessary","commit_id":"866af58d9dd172a2fa3be125a9538cbc959c3bd1"}],"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"325c18d770a0aab427e2f89a2bf5e733475faa02","unresolved":false,"context_lines":[{"line_number":902,"context_line":"        )"},{"line_number":903,"context_line":"        main_group \u003d parser.add_mutually_exclusive_group(required\u003dTrue)"},{"line_number":904,"context_line":"        main_group.add_argument("},{"line_number":905,"context_line":"            \u0027--plan\u0027,"},{"line_number":906,"context_line":"            help\u003d_(\"The Name or UUID of the Tuskar plan to deploy.\")"},{"line_number":907,"context_line":"        )"},{"line_number":908,"context_line":"        main_group.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_39dc4b72","line":905,"updated":"2015-09-17 14:29:45.000000000","message":"Removing this?","commit_id":"866af58d9dd172a2fa3be125a9538cbc959c3bd1"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"ee1b83b827c4d04fcaf1745ca58cc574489b5fa5","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        main_group \u003d parser.add_mutually_exclusive_group(required\u003dTrue)"},{"line_number":918,"context_line":"        main_group.add_argument("},{"line_number":919,"context_line":"            \u0027--templates\u0027, nargs\u003d\u0027?\u0027, const\u003dTRIPLEO_HEAT_TEMPLATES,"},{"line_number":920,"context_line":"            help\u003d_(\"The directory containing the Heat templates to deploy\"))"},{"line_number":921,"context_line":"        parser.add_argument(\u0027--stack\u0027,"},{"line_number":922,"context_line":"                            help\u003d_(\"Stack name to create or update\"),"},{"line_number":923,"context_line":"                            default\u003d\u0027overcloud\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_52ccb1ba","line":920,"updated":"2015-09-23 09:04:13.000000000","message":"Is the --plan option was removed, then the mutually exclusive group is no longer necessary.\n\nYou could now add the --templates argument directly to the parser (and not to the main_group) and set required\u003dTrue in there.","commit_id":"a32a6ef75a4b702ec3a07f3a447db813f500bb20"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6f7e27cfb5a6b3d3491c0f3fc2731c91de78274e","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        main_group \u003d parser.add_mutually_exclusive_group(required\u003dTrue)"},{"line_number":918,"context_line":"        main_group.add_argument("},{"line_number":919,"context_line":"            \u0027--templates\u0027, nargs\u003d\u0027?\u0027, const\u003dTRIPLEO_HEAT_TEMPLATES,"},{"line_number":920,"context_line":"            help\u003d_(\"The directory containing the Heat templates to deploy\"))"},{"line_number":921,"context_line":"        parser.add_argument(\u0027--stack\u0027,"},{"line_number":922,"context_line":"                            help\u003d_(\"Stack name to create or update\"),"},{"line_number":923,"context_line":"                            default\u003d\u0027overcloud\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_48ade499","line":920,"in_reply_to":"ba15a1d1_52ccb1ba","updated":"2015-09-23 09:55:18.000000000","message":"Good point. I need to look and see how to make it a required argument to make sure we don\u0027t change the behaviour. I\u0027ll update it with this change shortly.","commit_id":"a32a6ef75a4b702ec3a07f3a447db813f500bb20"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"59a1a017f4f2aca2346156a00c717c7d39dfa97e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            parameters[\u0027SwiftPassword\u0027] \u003d passwords[\u0027OVERCLOUD_SWIFT_PASSWORD\u0027]"},{"line_number":135,"context_line":"            parameters[\u0027SnmpdReadonlyUserPassword\u0027] \u003d ("},{"line_number":136,"context_line":"                undercloud_ceilometer_snmpd_password)"},{"line_number":137,"context_line":"        else:"},{"line_number":138,"context_line":"            parameters[\u0027Controller-1::AdminPassword\u0027] \u003d passwords["},{"line_number":139,"context_line":"                \u0027OVERCLOUD_ADMIN_PASSWORD\u0027]"},{"line_number":140,"context_line":"            parameters[\u0027Controller-1::AdminToken\u0027] \u003d passwords["}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_6f6f83fc","side":"PARENT","line":137,"updated":"2015-09-23 13:12:03.000000000","message":"This whole section needs to go away.","commit_id":"0309bea1acc816cdfa04253e55efb1fde237c27d"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a6a75e79d7b707e5b51f9a2e0cf218cb1a8ee8d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            parameters[\u0027SwiftPassword\u0027] \u003d passwords[\u0027OVERCLOUD_SWIFT_PASSWORD\u0027]"},{"line_number":135,"context_line":"            parameters[\u0027SnmpdReadonlyUserPassword\u0027] \u003d ("},{"line_number":136,"context_line":"                undercloud_ceilometer_snmpd_password)"},{"line_number":137,"context_line":"        else:"},{"line_number":138,"context_line":"            parameters[\u0027Controller-1::AdminPassword\u0027] \u003d passwords["},{"line_number":139,"context_line":"                \u0027OVERCLOUD_ADMIN_PASSWORD\u0027]"},{"line_number":140,"context_line":"            parameters[\u0027Controller-1::AdminToken\u0027] \u003d passwords["}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_81daeb49","side":"PARENT","line":137,"in_reply_to":"ba15a1d1_6f6f83fc","updated":"2016-08-31 10:52:26.000000000","message":"Done","commit_id":"0309bea1acc816cdfa04253e55efb1fde237c27d"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"59a1a017f4f2aca2346156a00c717c7d39dfa97e","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                        \u0027NeutronEnableTunnelling\u0027: neutron_enable_tunneling,"},{"line_number":239,"context_line":"                    })"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            param_args \u003d ("},{"line_number":243,"context_line":"                (\u0027Controller-1::NeutronPublicInterface\u0027,"},{"line_number":244,"context_line":"                    \u0027neutron_public_interface\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_2f766bd7","side":"PARENT","line":241,"updated":"2015-09-23 13:12:03.000000000","message":"As does this.","commit_id":"0309bea1acc816cdfa04253e55efb1fde237c27d"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a6a75e79d7b707e5b51f9a2e0cf218cb1a8ee8d","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                        \u0027NeutronEnableTunnelling\u0027: neutron_enable_tunneling,"},{"line_number":239,"context_line":"                    })"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            param_args \u003d ("},{"line_number":243,"context_line":"                (\u0027Controller-1::NeutronPublicInterface\u0027,"},{"line_number":244,"context_line":"                    \u0027neutron_public_interface\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_61e6b716","side":"PARENT","line":241,"in_reply_to":"ba15a1d1_2f766bd7","updated":"2016-08-31 10:52:26.000000000","message":"Done","commit_id":"0309bea1acc816cdfa04253e55efb1fde237c27d"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"59a1a017f4f2aca2346156a00c717c7d39dfa97e","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                    \u0027NeutronL3HA\u0027: True,"},{"line_number":329,"context_line":"                    \u0027NeutronAllowL3AgentFailover\u0027: False,"},{"line_number":330,"context_line":"                })"},{"line_number":331,"context_line":"            else:"},{"line_number":332,"context_line":"                parameters.update({"},{"line_number":333,"context_line":"                    \u0027Controller-1::NeutronL3HA\u0027: True,"},{"line_number":334,"context_line":"                    \u0027Controller-1::NeutronAllowL3AgentFailover\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_4f415f62","side":"PARENT","line":331,"updated":"2015-09-23 13:12:03.000000000","message":"Can get rid of this.","commit_id":"0309bea1acc816cdfa04253e55efb1fde237c27d"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a6a75e79d7b707e5b51f9a2e0cf218cb1a8ee8d","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                    \u0027NeutronL3HA\u0027: True,"},{"line_number":329,"context_line":"                    \u0027NeutronAllowL3AgentFailover\u0027: False,"},{"line_number":330,"context_line":"                })"},{"line_number":331,"context_line":"            else:"},{"line_number":332,"context_line":"                parameters.update({"},{"line_number":333,"context_line":"                    \u0027Controller-1::NeutronL3HA\u0027: True,"},{"line_number":334,"context_line":"                    \u0027Controller-1::NeutronAllowL3AgentFailover\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_41e933e5","side":"PARENT","line":331,"in_reply_to":"ba15a1d1_4f415f62","updated":"2016-08-31 10:52:26.000000000","message":"Done","commit_id":"0309bea1acc816cdfa04253e55efb1fde237c27d"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"59a1a017f4f2aca2346156a00c717c7d39dfa97e","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                    \u0027NeutronAllowL3AgentFailover\u0027: False,"},{"line_number":343,"context_line":"                })"},{"line_number":344,"context_line":"            else:"},{"line_number":345,"context_line":"                parameters.update({"},{"line_number":346,"context_line":"                    \u0027Controller-1::NeutronL3HA\u0027: False,"},{"line_number":347,"context_line":"                    \u0027Controller-1::NeutronAllowL3AgentFailover\u0027: False,"},{"line_number":348,"context_line":"                    \u0027Compute-1::NeutronL3HA\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_6f3d43dc","side":"PARENT","line":345,"updated":"2015-09-23 13:12:03.000000000","message":"Here.","commit_id":"0309bea1acc816cdfa04253e55efb1fde237c27d"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a6a75e79d7b707e5b51f9a2e0cf218cb1a8ee8d","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                    \u0027NeutronAllowL3AgentFailover\u0027: False,"},{"line_number":343,"context_line":"                })"},{"line_number":344,"context_line":"            else:"},{"line_number":345,"context_line":"                parameters.update({"},{"line_number":346,"context_line":"                    \u0027Controller-1::NeutronL3HA\u0027: False,"},{"line_number":347,"context_line":"                    \u0027Controller-1::NeutronAllowL3AgentFailover\u0027: False,"},{"line_number":348,"context_line":"                    \u0027Compute-1::NeutronL3HA\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_01efbbe9","side":"PARENT","line":345,"in_reply_to":"ba15a1d1_6f3d43dc","updated":"2016-08-31 10:52:26.000000000","message":"Done","commit_id":"0309bea1acc816cdfa04253e55efb1fde237c27d"}],"tripleoclient/v1/overcloud_update.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"ee1b83b827c4d04fcaf1745ca58cc574489b5fa5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        main_group.add_argument("},{"line_number":39,"context_line":"            \u0027--templates\u0027, nargs\u003d\u0027?\u0027, const\u003dTRIPLEO_HEAT_TEMPLATES,"},{"line_number":40,"context_line":"            help\u003d\"The directory containing the Heat templates to deploy\""},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":"        parser.add_argument(\u0027-i\u0027, \u0027--interactive\u0027, dest\u003d\u0027interactive\u0027,"},{"line_number":43,"context_line":"                            action\u003d\u0027store_true\u0027)"},{"line_number":44,"context_line":"        parser.add_argument(\u0027-a\u0027, \u0027--abort\u0027, dest\u003d\u0027abort_update\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_124ab926","line":41,"updated":"2015-09-23 09:04:13.000000000","message":"same comment as I put in overcloud_deploy","commit_id":"a32a6ef75a4b702ec3a07f3a447db813f500bb20"}]}