)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"31d175269ef9007937add6388bce7672acee830b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch adds the \"openstack overcloud postconfig\" command, intending"},{"line_number":14,"context_line":"to make it available to resolve that case. This moves the"},{"line_number":15,"context_line":"postconfiguration into `utils.py` which is suboptimal, and in a"},{"line_number":16,"context_line":"follow-up patch I plan on breaking utils.py into multiple files/modules"},{"line_number":17,"context_line":"so it has more focused functionality."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_c094c0e9","line":15,"updated":"2015-09-21 16:58:42.000000000","message":"The utils.py part isn\u0027t accurate anymore.  Should probably remove/replace that.","commit_id":"c619f927ad1847a4b2dbf4278e5ffe2deb1a3fff"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"4cef6fb6423be69201227b1acaa744f6a23efee5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch adds the \"openstack overcloud postconfig\" command, intending"},{"line_number":14,"context_line":"to make it available to resolve that case. This moves the"},{"line_number":15,"context_line":"postconfiguration into `utils.py` which is suboptimal, and in a"},{"line_number":16,"context_line":"follow-up patch I plan on breaking utils.py into multiple files/modules"},{"line_number":17,"context_line":"so it has more focused functionality."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_10461f4f","line":15,"in_reply_to":"ba15a1d1_c094c0e9","updated":"2015-09-23 15:15:57.000000000","message":"Ah, you\u0027re right, it isn\u0027t. Fixed.","commit_id":"c619f927ad1847a4b2dbf4278e5ffe2deb1a3fff"}],"tripleoclient/utils.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a939220416c1a6c6e49cc4e05ebfe879962d060e","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        return True"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"def deploy_postconfig(stack):"},{"line_number":527,"context_line":"    overcloud_endpoint \u003d get_overcloud_endpoint(stack)"},{"line_number":528,"context_line":"    overcloud_ip \u003d six.moves.urllib.parse.urlparse("},{"line_number":529,"context_line":"        overcloud_endpoint).hostname"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_d9915648","line":526,"updated":"2015-09-18 18:06:48.000000000","message":"It seems perfectly reasonable to me to put this in overcloud_post_deploy and just call it from overcloud_deploy too.  Is there a reason I\u0027m not aware of to not do that?","commit_id":"8dc09dc150f607a27b3d668a4983cb97ba3e3651"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"7d33e749326e1620912e4708962622bda794180a","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        return True"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"def deploy_postconfig(stack):"},{"line_number":527,"context_line":"    overcloud_endpoint \u003d get_overcloud_endpoint(stack)"},{"line_number":528,"context_line":"    overcloud_ip \u003d six.moves.urllib.parse.urlparse("},{"line_number":529,"context_line":"        overcloud_endpoint).hostname"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_19f10e95","line":526,"in_reply_to":"ba15a1d1_d9915648","updated":"2015-09-18 18:07:37.000000000","message":"That would be a better place for it -- excellent point.","commit_id":"8dc09dc150f607a27b3d668a4983cb97ba3e3651"}],"tripleoclient/v1/overcloud_post_deploy.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"31d175269ef9007937add6388bce7672acee830b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            return True"},{"line_number":141,"context_line":"        except exceptions.DeploymentError as err:"},{"line_number":142,"context_line":"            print(\"Postconfig failed: \", err, file\u003dsys.stderr)"},{"line_number":143,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_00f2b89a","line":143,"updated":"2015-09-21 16:58:42.000000000","message":"I\u0027m thinking this should just re-raise the exception so it can be handled by the calling code the same way any other exception would be.  Swallowing it like this won\u0027t give us things like the stack trace, even if --debug is turned on.","commit_id":"c619f927ad1847a4b2dbf4278e5ffe2deb1a3fff"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"4cef6fb6423be69201227b1acaa744f6a23efee5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            return True"},{"line_number":141,"context_line":"        except exceptions.DeploymentError as err:"},{"line_number":142,"context_line":"            print(\"Postconfig failed: \", err, file\u003dsys.stderr)"},{"line_number":143,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_90222fa2","line":143,"in_reply_to":"ba15a1d1_00f2b89a","updated":"2015-09-23 15:15:57.000000000","message":"Good point, fixed","commit_id":"c619f927ad1847a4b2dbf4278e5ffe2deb1a3fff"}]}