)]}'
{"tripleoclient/tests/v1/overcloud_deploy/test_overcloud_deploy.py":[{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"f6e301bf404f27b64c99d32fc0d5992382c5d92d","unresolved":false,"context_lines":[{"line_number":835,"context_line":"                          mock_create_ocrc,"},{"line_number":836,"context_line":"                          mock_create_tempest_deployer_input,"},{"line_number":837,"context_line":"                          mock_check_nodes_count):"},{"line_number":838,"context_line":"        answers \u003d (\"templates: {templates}\\n\""},{"line_number":839,"context_line":"                   \"environments:\\n\""},{"line_number":840,"context_line":"                   \"  - {environment}\\n\")"},{"line_number":841,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_93baad09","line":838,"updated":"2016-01-07 20:08:17.000000000","message":"Instead of this, can we use the actual YAML (or JSON, since it\u0027s a YAML subset) serializer to create the valid answers.yaml file? It\u0027s not a huge deal, but it would let us test with \u003e1 environment file.","commit_id":"c088ee36a25fcb0f7be1e4698d4c5eb75750eac9"},{"author":{"_account_id":11997,"name":"Lennart Regebro","email":"lregebro@redhat.com","username":"lregebro"},"change_message_id":"830008d9dc05b0b3eedf1a695b636501d81ddc61","unresolved":false,"context_lines":[{"line_number":835,"context_line":"                          mock_create_ocrc,"},{"line_number":836,"context_line":"                          mock_create_tempest_deployer_input,"},{"line_number":837,"context_line":"                          mock_check_nodes_count):"},{"line_number":838,"context_line":"        answers \u003d (\"templates: {templates}\\n\""},{"line_number":839,"context_line":"                   \"environments:\\n\""},{"line_number":840,"context_line":"                   \"  - {environment}\\n\")"},{"line_number":841,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_6d7832c5","line":838,"in_reply_to":"fa69d971_93baad09","updated":"2016-01-13 11:54:47.000000000","message":"Done","commit_id":"c088ee36a25fcb0f7be1e4698d4c5eb75750eac9"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"f6e301bf404f27b64c99d32fc0d5992382c5d92d","unresolved":false,"context_lines":[{"line_number":853,"context_line":""},{"line_number":854,"context_line":"            arglist \u003d [\u0027--answers-file\u0027, answerfile.name,"},{"line_number":855,"context_line":"                       \u0027--environment-file\u0027, \u0027/tmp/environment.yaml\u0027,"},{"line_number":856,"context_line":"                       \u0027--block-storage-scale\u0027, \u00273\u0027]"},{"line_number":857,"context_line":"            verifylist \u003d ["},{"line_number":858,"context_line":"                (\u0027answers_file\u0027, answerfile.name),"},{"line_number":859,"context_line":"                (\u0027environment_files\u0027, [\u0027/tmp/environment.yaml\u0027]),"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_333661b5","line":856,"updated":"2016-01-07 20:08:17.000000000","message":"Is there a reason to only have the environments and template dir in this file, or could the scale/flavor parameters be added as well?","commit_id":"c088ee36a25fcb0f7be1e4698d4c5eb75750eac9"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3c8c4337bb4f0d73217d151c4b4882ff12d258b8","unresolved":false,"context_lines":[{"line_number":853,"context_line":""},{"line_number":854,"context_line":"            arglist \u003d [\u0027--answers-file\u0027, answerfile.name,"},{"line_number":855,"context_line":"                       \u0027--environment-file\u0027, \u0027/tmp/environment.yaml\u0027,"},{"line_number":856,"context_line":"                       \u0027--block-storage-scale\u0027, \u00273\u0027]"},{"line_number":857,"context_line":"            verifylist \u003d ["},{"line_number":858,"context_line":"                (\u0027answers_file\u0027, answerfile.name),"},{"line_number":859,"context_line":"                (\u0027environment_files\u0027, [\u0027/tmp/environment.yaml\u0027]),"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_2b9b1dcb","line":856,"in_reply_to":"fa69d971_333661b5","updated":"2016-08-31 10:52:40.000000000","message":"We want to remove all the CLI args in favour of using envs. They were a mistake. Hopefully the answer file will help direct users to using environments more as this file will make things much more convenient.","commit_id":"c088ee36a25fcb0f7be1e4698d4c5eb75750eac9"}],"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"66eb5c17f9dd66cb525434b1b8a8ab3c79f82259","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                args.templates \u003d answers[\u0027templates\u0027]"},{"line_number":108,"context_line":"            if \u0027environments\u0027 in answers:"},{"line_number":109,"context_line":"                if args.environment_files is not None:"},{"line_number":110,"context_line":"                    answers[\u0027environments\u0027].extend(args.environment_files)"},{"line_number":111,"context_line":"                args.environment_files \u003d answers[\u0027environments\u0027]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        param_args \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_77d6d4c4","line":110,"updated":"2015-12-10 15:29:25.000000000","message":"Shouldn\u0027t cli args override the answers file? With environment files, order matters, as last one wins. Here, if you extend (rather than prepend) you are putting answers file environment files at a higher precedence than cli environment files.","commit_id":"d862a270bdf4c86e580bc9d081dbedbecc247b10"},{"author":{"_account_id":11997,"name":"Lennart Regebro","email":"lregebro@redhat.com","username":"lregebro"},"change_message_id":"ad9dab17355a969d84665d404434ba0618902902","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                args.templates \u003d answers[\u0027templates\u0027]"},{"line_number":108,"context_line":"            if \u0027environments\u0027 in answers:"},{"line_number":109,"context_line":"                if args.environment_files is not None:"},{"line_number":110,"context_line":"                    answers[\u0027environments\u0027].extend(args.environment_files)"},{"line_number":111,"context_line":"                args.environment_files \u003d answers[\u0027environments\u0027]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        param_args \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_3d4c1f9d","line":110,"in_reply_to":"7a740942_77d6d4c4","updated":"2015-12-14 14:41:56.000000000","message":"Ah, I actually didn\u0027t consider that you\u0027d might have an answer file *and* specify an environment as parameters, because why would you? But of course, people will do this. I\u0027ll fix it.","commit_id":"d862a270bdf4c86e580bc9d081dbedbecc247b10"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"66eb5c17f9dd66cb525434b1b8a8ab3c79f82259","unresolved":false,"context_lines":[{"line_number":453,"context_line":"    def _validate_args(self, parsed_args):"},{"line_number":454,"context_line":"        if parsed_args.templates is None and parsed_args.answers_file is None:"},{"line_number":455,"context_line":"            raise oscexc.CommandError("},{"line_number":456,"context_line":"                \"You must specify either --templates use an --answers-file\")"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        network_type \u003d parsed_args.neutron_network_type"},{"line_number":459,"context_line":"        tunnel_types \u003d parsed_args.neutron_tunnel_types"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_f7f08468","line":456,"updated":"2015-12-10 15:29:25.000000000","message":"*or","commit_id":"d862a270bdf4c86e580bc9d081dbedbecc247b10"}],"tripleoclient/v1/overcloud_update.py":[{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"66eb5c17f9dd66cb525434b1b8a8ab3c79f82259","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def take_action(self, parsed_args):"},{"line_number":62,"context_line":"        if parsed_args.templates is None and parsed_args.answers_file is None:"},{"line_number":63,"context_line":"            raise oscexc.CommandError("},{"line_number":64,"context_line":"                \"You must specify either --templates use an --answers-file\")"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if parsed_args.answers_file is not None:"},{"line_number":67,"context_line":"            with open(parsed_args.answers_file, \u0027r\u0027) as answers_file:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_979ee005","line":64,"updated":"2015-12-10 15:29:25.000000000","message":"*or","commit_id":"d862a270bdf4c86e580bc9d081dbedbecc247b10"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"66eb5c17f9dd66cb525434b1b8a8ab3c79f82259","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    parsed_args.templates \u003d answers[\u0027templates\u0027]"},{"line_number":72,"context_line":"                if \u0027environments\u0027 in answers:"},{"line_number":73,"context_line":"                    if parsed_args.environment_files is not None:"},{"line_number":74,"context_line":"                        answers.environments.extend("},{"line_number":75,"context_line":"                            parsed_args.environment_files)"},{"line_number":76,"context_line":"                    parsed_args.environment_files \u003d answers[\u0027environments\u0027]"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_d79468e9","line":74,"updated":"2015-12-10 15:29:25.000000000","message":"See previous comment.","commit_id":"d862a270bdf4c86e580bc9d081dbedbecc247b10"}]}