)]}'
{"tripleoclient/v1/undercloud.py":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c3660a4c0b66ebbbb8ea761928bf3c1edc0dc154","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027update\u0027, \u0027-y\u0027])"},{"line_number":51,"context_line":"        subprocess.check_call(\"instack-install-undercloud\")"},{"line_number":52,"context_line":"        # restart nova-api https://bugzilla.redhat.com/show_bug.cgi?id\u003d1315467"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027systemctl\u0027, \u0027restart\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_f981c34e","side":"PARENT","line":50,"updated":"2016-08-03 13:05:45.000000000","message":"why did you remove this line?\n\nthis is the only way to get instack-undercloud updated *before* we call instack-install-undercloud.\n\nPerhaps just change the line to update instack-undercloud?","commit_id":"66cd751c462b4f2d703fd444836313e09b49168f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"447f2425d9ababc790730ad7afb06802aa3679e6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027systemctl\u0027, \u0027stop\u0027, \u0027openstack-*\u0027])"},{"line_number":51,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027systemctl\u0027, \u0027stop\u0027, \u0027neutron-*\u0027])"},{"line_number":52,"context_line":"        subprocess.check_call(\"instack-install-undercloud\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_b0580058","line":51,"updated":"2016-08-03 12:30:52.000000000","message":"might as well add haproxy here. Not sure if keepalived is necessary also.","commit_id":"2168babfca3c0e428eb58615f8e439e798cd6fac"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5954575e259a682d1963fc475fb8a32b0e470e5b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027systemctl\u0027, \u0027stop\u0027, \u0027openstack-*\u0027])"},{"line_number":51,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027systemctl\u0027, \u0027stop\u0027, \u0027neutron-*\u0027])"},{"line_number":52,"context_line":"        subprocess.check_call(\"instack-install-undercloud\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_d34f7e68","line":51,"in_reply_to":"bacf61ea_b0580058","updated":"2016-08-03 12:33:42.000000000","message":"I didn\u0027t have to do it to make it work. It\u0027s already managed by Puppet during update.","commit_id":"2168babfca3c0e428eb58615f8e439e798cd6fac"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"3533cfb810c2f46b3f265a4ecca0fc8aad9811d0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027systemctl\u0027, \u0027stop\u0027, \u0027openstack-*\u0027])"},{"line_number":51,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027systemctl\u0027, \u0027stop\u0027, \u0027neutron-*\u0027])"},{"line_number":52,"context_line":"        subprocess.check_call(\"instack-install-undercloud\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_d3849e5e","line":51,"in_reply_to":"bacf61ea_d34f7e68","updated":"2016-08-03 12:35:01.000000000","message":"No biggie, just in case. But sure, I guess it can work without that.","commit_id":"2168babfca3c0e428eb58615f8e439e798cd6fac"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c3660a4c0b66ebbbb8ea761928bf3c1edc0dc154","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027systemctl\u0027, \u0027stop\u0027, \u0027openstack-*\u0027])"},{"line_number":51,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027systemctl\u0027, \u0027stop\u0027, \u0027neutron-*\u0027])"},{"line_number":52,"context_line":"        subprocess.check_call(\"instack-install-undercloud\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_f97383b2","line":51,"in_reply_to":"bacf61ea_d3849e5e","updated":"2016-08-03 13:05:45.000000000","message":"i think this logic to stop services needs to be part of instack-undercloud. that way we don\u0027t have installation/upgrade logic split across python-tripleoclient and instack-undercloud","commit_id":"2168babfca3c0e428eb58615f8e439e798cd6fac"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"9cbc9d0afd325f0008dbede3cb8de07c36344a0d","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_0220949a","line":50,"updated":"2016-08-03 16:31:15.000000000","message":"I\u0027m still curious why we can\u0027t yum update here.  Wouldn\u0027t a \"yum update -y instack-undercloud openstack-puppet-*\" take care of updating the packages and their dependencies?","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b9f8e28ac9ddca99b1936f5630056d78a7f7af90","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_78d0b21f","line":50,"in_reply_to":"9ad45d7e_57869cdb","updated":"2016-08-11 09:42:50.000000000","message":"Hmm i\u0027m not aware of the full context yet, but if there\u0027s some packaging mishap that prevents us from updating OPM correctly (e.g. if we were going *down* with version from semver point of view for some reason), then i\u0027d probably rather add a version specific admonition with workaround to the docs than write the workaround as code. (Especially since this is undercloud, so any manual steps need to be performed just on single server.)","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b8d86bc102ba95a0b088636d218ca4760860368c","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_984486b7","line":50,"in_reply_to":"9ad45d7e_78d0b21f","updated":"2016-08-11 09:48:19.000000000","message":"Or if we write it as code, we might make it a few additional lines preceding the normal update, that only deal with OPM and are marked as a workaround, and can be simply removed later without having to rewrite the normal update.","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"5bbbac20c2c0b5b941771d58511532e293b222e1","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_621510e4","line":50,"in_reply_to":"bacf61ea_0220949a","updated":"2016-08-03 16:33:56.000000000","message":"i\u0027m not a fan of the reinstall and don\u0027t understand why it\u0027s needed.\n\ni\u0027m not interested in how this only slows down CI by ONE minute. it\u0027s not forward progress.","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c7c823fdc5e149a11ac45de2f6edc7c4f4be76ab","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_854e4ebf","line":50,"in_reply_to":"bacf61ea_621510e4","updated":"2016-08-03 16:53:12.000000000","message":"also i\u0027d think you\u0027d need to remove all of puppet-* here as well since that is not covered by what you\u0027re trying to do with openstack-puppet-*.","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b0acc81edd7e467ce79f933cd5b84586ad4da8a7","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_57869cdb","line":50,"in_reply_to":"bacf61ea_854e4ebf","updated":"2016-08-10 09:48:21.000000000","message":"wrt the remove/re-install , at least for the openstack-puppet-modules, there is some discussion at https://review.openstack.org/#/c/332889/2 - I didn\u0027t get a chance to get back to that work so am not sure if it has since been resolved (i.e. can you now just yum update and get the right opm)","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"9cbc9d0afd325f0008dbede3cb8de07c36344a0d","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":54,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":55,"context_line":"            \u0027python-tripleoclient\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_7c59365b","line":52,"range":{"start_line":52,"start_character":13,"end_line":52,"end_character":33},"updated":"2016-08-03 16:31:15.000000000","message":"I would suggest we leave tripleoclient out and let the full update in instack-undercloud take care of it.  Updating it from the client call isn\u0027t going to take effect anyway, and uninstalling it while it\u0027s running seems sketchy.  At best it has no effect, and if the reinstall fails for some reason (mirror issue, etc.) you may be left with no client to retry.","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"75ddf772a84fc073284cee6ee3c00db938f2a48c","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":54,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":55,"context_line":"            \u0027python-tripleoclient\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_764f8cbd","line":52,"range":{"start_line":52,"start_character":13,"end_line":52,"end_character":33},"in_reply_to":"9ad45d7e_a98ff9ca","updated":"2016-08-09 15:57:31.000000000","message":"Ultimately the idea is that any future changes go into instack-undercloud, which can be sanely upgraded here.  Obviously for Mitaka-Newton that\u0027s a problem, but hopefully it\u0027s a one-time problem.  We could also backport this since I\u0027m pretty sure our current upgrade procedure doesn\u0027t work so it\u0027s a valid bug backport, but that does still require people to yum update tripleoclient first so it may make sense just to do what you suggest for now.","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"991a86f04eb07d4b2da22a8def2646fcc5cf25b3","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":54,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":55,"context_line":"            \u0027python-tripleoclient\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_a98ff9ca","line":52,"range":{"start_line":52,"start_character":13,"end_line":52,"end_character":33},"in_reply_to":"bacf61ea_7c59365b","updated":"2016-08-09 11:56:36.000000000","message":"+1 on leaving out tripleoclient due to the change not taking effect when needed.\n\nI\u0027d be -1 on letting just instack-undercloud update it though, we\u0027ll probably need it updated before running `openstack undercloud upgrade` to fetch potential changes to this command (e.g. whoever installed Mitaka will not have *this* patch present in tripleoclient when upgrading undercloud to Newton). We should probably document something like this to make the workflow safe:\n\n    yum -y update python-tripleoclient\n    openstack undercloud upgrade","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b0acc81edd7e467ce79f933cd5b84586ad4da8a7","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027remove\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":51,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":52,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":54,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":55,"context_line":"            \u0027python-tripleoclient\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_57385c3d","line":52,"range":{"start_line":52,"start_character":13,"end_line":52,"end_character":33},"in_reply_to":"bacf61ea_7c59365b","updated":"2016-08-10 09:48:21.000000000","message":"trouble is at least for mitaka, removing openstack-puppet-modules removed instack-undercloud and the tripleoclient too  - like at https://review.openstack.org/#/c/332889/2/tripleoclient/v1/undercloud.py","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"72aa3970c48fcde80735273647c7f98f39bf48c7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027instack*\u0027,"},{"line_number":54,"context_line":"            \u0027openstack-tripleo*\u0027, \u0027os-*\u0027, \u0027openstack-puppet-*\u0027,"},{"line_number":55,"context_line":"            \u0027python-tripleoclient\u0027])"},{"line_number":56,"context_line":"        subprocess.check_call(\"instack-install-undercloud\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_44b584ec","line":56,"updated":"2016-08-09 12:03:06.000000000","message":"Also if https://review.openstack.org/#/c/350657 lands soon, we could add `--upgrade` here.","commit_id":"86577c3906a1a85f5292e62a5343d256a4249038"}]}