)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"681bd10231b8782e22bdf821f29f575b7f766b7e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"mistral workflow"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If7527e36c1e5d2214dc155392a2e3750b38ec365"},{"line_number":19,"context_line":"Closes-Bug: lp#1640933"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_93a085a1","line":19,"updated":"2016-11-16 11:14:19.000000000","message":"Should be: Closes-Bug: #1640933","commit_id":"a20446aaacd8fe2e2c447593d21d28dda6cc246d"}],"tripleoclient/v1/overcloud_node.py":[{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"9a8ec1c27094e99203fa361e51ac3bc0d9b3c3df","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if not stack:"},{"line_number":73,"context_line":"            print(\"stack {} not found\".format(parsed_args.stack))"},{"line_number":74,"context_line":"            return 1"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        print(\"deleting nodes {0} from stack {1}\".format(parsed_args.nodes,"},{"line_number":77,"context_line":"                                                         stack.stack_name))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_a2def73c","line":74,"updated":"2016-11-16 16:28:22.000000000","message":"I would prefer that you throw an exception here.","commit_id":"441a1db897a98531311b05cb9c0d157c3409ee04"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"dcf1083c01874bc89e95371a36db552a90b9a690","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if not stack:"},{"line_number":73,"context_line":"            print(\"stack {} not found\".format(parsed_args.stack))"},{"line_number":74,"context_line":"            return 1"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        print(\"deleting nodes {0} from stack {1}\".format(parsed_args.nodes,"},{"line_number":77,"context_line":"                                                         stack.stack_name))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_c2ebf3ae","line":74,"in_reply_to":"7a77a97e_a2def73c","updated":"2016-11-16 16:30:13.000000000","message":"I should be more explicit why... I\u0027m not sure this has the effect that you are intending. In order to have OSC actually return something other than 0, you have to throw an exception, not a return value from take_action.","commit_id":"441a1db897a98531311b05cb9c0d157c3409ee04"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"eb3d012ae2974b428d35ed727cdff3b52a26e699","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        clients \u003d self.app.client_manager"},{"line_number":69,"context_line":"        orchestration_client \u003d clients.orchestration"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        stack \u003d oooutils.get_stack(orchestration_client, parsed_args.stack)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if not stack:"},{"line_number":74,"context_line":"            raise InvalidConfiguration(\"stack {} not found\".format("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_ce1ff2b5","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":34},"updated":"2016-11-21 16:30:44.000000000","message":"The docstring for get_stack suggests that it does the opposite of what we\u0027re trying to do here - it says it maps a name to an id.  This is incorrect if you read the code, but it\u0027s confusing.  What it\u0027s actually doing is taking a stack id and returning the stack object.  It\u0027s not clear to me that it even works with a name.  heatclient\u0027s stacks.get method says it takes a stack id and says nothing about also accepting a name.  If it doesn\u0027t actually take a name, then this new call will fail any time a user passes a name instead of an id.\n\nI assume this has been tested for the \"user passes an id\" case it\u0027s trying to fix, but has it also been tested for the \"user passes a name\" case?  According to what I\u0027m seeing in the code it won\u0027t work for the latter (but again, the docstrings seem to be inconsistent, so I\u0027m not sure).\n\nHeatclient docs I\u0027m looking at: http://docs.openstack.org/developer/python-heatclient/ref/v1/stacks.html\n\nget_stack call I\u0027m looking at: https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/utils.py#L463","commit_id":"a3012ca424747ae815ed0b72184fa465765ccb9a"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"9d3157f32c7953ae6376fa637f5b6870294c767a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        clients \u003d self.app.client_manager"},{"line_number":69,"context_line":"        orchestration_client \u003d clients.orchestration"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        stack \u003d oooutils.get_stack(orchestration_client, parsed_args.stack)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if not stack:"},{"line_number":74,"context_line":"            raise InvalidConfiguration(\"stack {} not found\".format("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_831ddd68","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":34},"in_reply_to":"7a77a97e_ce1ff2b5","updated":"2016-11-23 08:34:14.000000000","message":"Ben,\nI did some tests and both work shown here: http://paste.openstack.org/show/590169/\n\nI think the issue is that the docstring is correct but a bit confusing\n\nThe Heat API docs in this case define it as: stack_identity: The UUID or the name of a stack. here http://git.openstack.org/cgit/openstack/heat/tree/api-ref/source/v1/parameters.yaml#n69\n\nso stack_id can be either a uuid or a name. They are both forms of ID","commit_id":"a3012ca424747ae815ed0b72184fa465765ccb9a"}]}