)]}'
{"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"55555f2675e68b1eb99c0564fd64b3092d9ba0eb","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                    errors)"},{"line_number":1098,"context_line":"                if parsed_args.validation_warnings_fatal or \\"},{"line_number":1099,"context_line":"                        parsed_args.validation_errors_fatal:"},{"line_number":1100,"context_line":"                    raise exceptions.InvalidConfiguration()"},{"line_number":1101,"context_line":"            if warnings \u003e 0:"},{"line_number":1102,"context_line":"                self.log.error("},{"line_number":1103,"context_line":"                    \"Configuration has %d warnings, fix them before \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_3df5d5ca","line":1100,"updated":"2017-03-20 07:43:45.000000000","message":"Does it make sense to pass the error string or a similar message as exception message?","commit_id":"28051613c9c1c5231140981fca76fa704af55d5d"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"ecf28652e7e2ce5600284e4d0c51f187cddebb49","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                    errors)"},{"line_number":1098,"context_line":"                if parsed_args.validation_warnings_fatal or \\"},{"line_number":1099,"context_line":"                        parsed_args.validation_errors_fatal:"},{"line_number":1100,"context_line":"                    raise exceptions.InvalidConfiguration()"},{"line_number":1101,"context_line":"            if warnings \u003e 0:"},{"line_number":1102,"context_line":"                self.log.error("},{"line_number":1103,"context_line":"                    \"Configuration has %d warnings, fix them before \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_313dfebb","line":1100,"in_reply_to":"1a1ced50_3df5d5ca","updated":"2017-03-20 10:03:43.000000000","message":"Because it\u0027s already logged above, it would cause it to be displayed twice on the CLI.","commit_id":"28051613c9c1c5231140981fca76fa704af55d5d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8b11055bf7c27cf3e73eea448fdc066a13a41103","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"                    \"proceeding.\","},{"line_number":1105,"context_line":"                    warnings)"},{"line_number":1106,"context_line":"                if parsed_args.validation_warnings_fatal:"},{"line_number":1107,"context_line":"                    raise exceptions.InvalidConfiguration()"},{"line_number":1108,"context_line":"            else:"},{"line_number":1109,"context_line":"                self.log.info(\"SUCCESS: No warnings or errors in deploy \""},{"line_number":1110,"context_line":"                              \"configuration, proceeding.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_2c69bcbd","line":1107,"range":{"start_line":1107,"start_character":26,"end_line":1107,"end_character":57},"updated":"2017-03-24 00:26:58.000000000","message":"(nit) are warning necessarily invalid? might be better to raise a different exception for warnings so that the caller could catch it and ignore if they wanted to","commit_id":"28051613c9c1c5231140981fca76fa704af55d5d"}]}