)]}'
{"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"7f43b717b32c77ae6d93ac107d161b3bfb2c204e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    \u0027rhel_reg_sat_url\u0027: args.reg_sat_url,"},{"line_number":125,"context_line":"                    \u0027rhel_reg_activation_key\u0027: args.reg_activation_key}"},{"line_number":126,"context_line":"        parameter_defaults \u003d {\"parameter_defaults\": user_env}"},{"line_number":127,"context_line":"        env_path, swift_path \u003d self._write_user_environment("},{"line_number":128,"context_line":"            parameter_defaults,"},{"line_number":129,"context_line":"            \u0027tripleoclient-registration-parameters.yaml\u0027,"},{"line_number":130,"context_line":"            tht_root,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_49ce912d","line":127,"updated":"2017-05-23 07:26:52.000000000","message":"I wondering if all of the \"utility\" function in the (huge) overcloud_deploy.py class would be better in a common/utils.py file, where every other overcloud_* could get access. (ie : write_user_environment \u0026 so)\nIts just a thought here.. but..","commit_id":"7285076e420e43d1ff1cd2548bf59a2103272519"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"9d4c74dc08e8d84d0fd2dae60a3b0b73ef6f8eb1","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    \u0027rhel_reg_sat_url\u0027: args.reg_sat_url,"},{"line_number":125,"context_line":"                    \u0027rhel_reg_activation_key\u0027: args.reg_activation_key}"},{"line_number":126,"context_line":"        parameter_defaults \u003d {\"parameter_defaults\": user_env}"},{"line_number":127,"context_line":"        env_path, swift_path \u003d self._write_user_environment("},{"line_number":128,"context_line":"            parameter_defaults,"},{"line_number":129,"context_line":"            \u0027tripleoclient-registration-parameters.yaml\u0027,"},{"line_number":130,"context_line":"            tht_root,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_f225e60b","line":127,"in_reply_to":"ff0f0b1f_49ce912d","updated":"2017-08-17 13:21:31.000000000","message":"Yeah I did think the same, but perhaps we can do the changes to move to server side merging, then refactor to enable easier reuse?  I\u0027d prefer to avoid doing both in the same patch as it\u0027ll just be harder to rebase (and revert if it goes wrong..)","commit_id":"7285076e420e43d1ff1cd2548bf59a2103272519"}]}