)]}'
{"tripleoclient/workflows/plan_management.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"93514e96abc3b143983784ef0a39c1b8911d71b1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                    constants.OVERCLOUD_ROLES_FILE,"},{"line_number":44,"context_line":"                                    rf)"},{"line_number":45,"context_line":"    # Optional override of the plan-environment.yaml file"},{"line_number":46,"context_line":"    if plan_env_file:"},{"line_number":47,"context_line":"        with open(plan_env_file) as pf:"},{"line_number":48,"context_line":"            swift_client.put_object(container_name,"},{"line_number":49,"context_line":"                                    constants.PLAN_ENVIRONMENT_FILE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_f69ff962","line":46,"updated":"2017-05-26 18:13:40.000000000","message":"It\u0027s clear how this uploads a file if a (valid) file name is specified. Have we thought about whether it\u0027s necessary to allow the user to change their mind about overriding the plan environment? That would require reverting this action, maybe like this:\n\nif plan_env_file:\n  ...\nelse:\n   swift_client.delete_object(container_name,\n                              constants.OVERCLOUD_ROLES_FILE)\n\nWas this sort of thing considered when support for the roles_file was added?","commit_id":"a2ab230b73c5a92ab0c994de9ed55a98a0305c36"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"204a4436ba5941e1ec488d228f1fefdf02f130c9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                    constants.OVERCLOUD_ROLES_FILE,"},{"line_number":44,"context_line":"                                    rf)"},{"line_number":45,"context_line":"    # Optional override of the plan-environment.yaml file"},{"line_number":46,"context_line":"    if plan_env_file:"},{"line_number":47,"context_line":"        with open(plan_env_file) as pf:"},{"line_number":48,"context_line":"            swift_client.put_object(container_name,"},{"line_number":49,"context_line":"                                    constants.PLAN_ENVIRONMENT_FILE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_4c2cf246","line":46,"in_reply_to":"ff0f0b1f_f69ff962","updated":"2017-05-29 06:23:39.000000000","message":"The tarball will always upload the default plan-environment.yaml file which is part of the tht. If the user had overridden, the overridden plan-env file will be uploaded. This will happen in all the stack deploy and update commands. So if user wishes to remove it, then can remove it during the stack update.","commit_id":"a2ab230b73c5a92ab0c994de9ed55a98a0305c36"}]}
