)]}'
{"tripleoclient/v1/undercloud_config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"90124991b9fb27ee285c74d71791ac00677cf8c1","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                deprecated_reason\u003d(\u0027Please switch to hardware types and \u0027"},{"line_number":318,"context_line":"                                   \u0027the enabled_hardware_types option.\u0027)),"},{"line_number":319,"context_line":"    cfg.ListOpt(\u0027enabled_hardware_types\u0027,"},{"line_number":320,"context_line":"                default\u003d[\u0027ipmi\u0027, \u0027redfish\u0027, \u0027ilo\u0027, \u0027idrac\u0027, \u0027xclarity\u0027],"},{"line_number":321,"context_line":"                help\u003d(\u0027List of enabled bare metal hardware types (next \u0027"},{"line_number":322,"context_line":"                      \u0027generation drivers).\u0027)),"},{"line_number":323,"context_line":"    cfg.StrOpt(\u0027docker_registry_mirror\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_98bac36b","line":320,"range":{"start_line":320,"start_character":58,"end_line":320,"end_character":71},"updated":"2018-04-23 12:41:48.000000000","message":"this change is probably incorrect, I\u0027d prefer we don\u0027t get more default drivers","commit_id":"b828f41d81ee04bd7846353fe98758072619fc25"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"90124991b9fb27ee285c74d71791ac00677cf8c1","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    # use one variable for them."},{"line_number":414,"context_line":"    mgmt_interfaces \u003d {\u0027fake\u0027, \u0027ipmitool\u0027}"},{"line_number":415,"context_line":"    # TODO(dtantsur): can we somehow avoid hardcoding hardware types here?"},{"line_number":416,"context_line":"    for hw_type in (\u0027redfish\u0027, \u0027idrac\u0027, \u0027ilo\u0027, \u0027irmc\u0027, \u0027staging-ovirt\u0027,"},{"line_number":417,"context_line":"                    \u0027xclarity\u0027):"},{"line_number":418,"context_line":"        if hw_type in enabled_hardware_types:"},{"line_number":419,"context_line":"            mgmt_interfaces.add(hw_type)"},{"line_number":420,"context_line":"    for (hw_type, iface) in [(\u0027cisco-ucs-managed\u0027, \u0027ucsm\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_38b3779a","line":417,"range":{"start_line":416,"start_character":0,"end_line":417,"end_character":32},"updated":"2018-04-23 12:41:48.000000000","message":"and this change is required for the driver to be usable","commit_id":"b828f41d81ee04bd7846353fe98758072619fc25"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"90124991b9fb27ee285c74d71791ac00677cf8c1","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    # Three hardware types use non-default boot interfaces."},{"line_number":426,"context_line":"    boot_interfaces \u003d {\u0027pxe\u0027}"},{"line_number":427,"context_line":"    for hw_type in (\u0027ilo\u0027, \u0027irmc\u0027, \u0027xclarity\u0027):"},{"line_number":428,"context_line":"        if hw_type in enabled_hardware_types:"},{"line_number":429,"context_line":"            boot_interfaces.add(\u0027%s-pxe\u0027 % hw_type)"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_f8a89f20","line":427,"range":{"start_line":427,"start_character":33,"end_line":427,"end_character":46},"updated":"2018-04-23 12:41:48.000000000","message":"this is incorrect, there is no xclarify-pxe boot interface","commit_id":"b828f41d81ee04bd7846353fe98758072619fc25"}]}