)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"dc6b556adefc4ab8c441c411e7942761e85f375e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  openstack overcloud ffwd-upgrade prepare"},{"line_number":11,"context_line":"and"},{"line_number":12,"context_line":"  openstack overcloud ffwd-upgrade run"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TODO the converge remains. It wont be a stack update,"},{"line_number":15,"context_line":"just unset the config-download in the plan"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_30ecf18d","line":13,"updated":"2018-03-30 14:32:58.000000000","message":"I am working with the sequence described in https://bugzilla.redhat.com/show_bug.cgi?id\u003d1561178. The idea, with this patch, is the operator would do:\n\n1 openstack overcloud ffwd-upgrade prepare --container-registry-file containers.yaml ... any -e needed \n\n# this will do the stack update for the ansible playbooks.\n# then:\n\n2 openstack overcloud ffwd-upgrade run \n# will run the fast_forward_upgrade_playbook.yaml against the entire overcloud (noneed for limit hosts here?)\n\n3 openstack overcloud upgrade run --roles Controller\n# ... repeat for --roles or --nodes as needed. this runs the\n# upgrade_steps_playbook.yaml and the deploy_steps_playbook.yaml and the post_upgrade_steps_playbook.yaml. NOTE: this uses the existing \"overcloud *upgrade* run\" command.\n\n4 openstack overcloud ffwd-upgrade converge \n# or \u0027complete\u0027 or whatever. no stack update, just unset the config-download /noop from the stored plan to fix future stack updates.","commit_id":"0dca18bd0688ac8aa5652a1a92b3d476aab315ce"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5baf9f4e47ee8ef77a582da5b8b1f34042c135e1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"just unset the config-download in the plan"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related:"},{"line_number":18,"context_line":"  tripleo-common Ib9647b899fb9d49203c4d35c1abfe9c36e0babbe"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ie7823e121a4fa57feb1c56bd4d58f3183e41b8d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_908ffdcb","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":9},"updated":"2018-03-30 14:37:16.000000000","message":"this is more like Depends-On: \nsince otherwise the workflow will fail (we are passing a new parameter to it here https://review.openstack.org/#/c/557937/1/tripleoclient/v1/overcloud_ffwd_upgrade.py@77 )","commit_id":"0dca18bd0688ac8aa5652a1a92b3d476aab315ce"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ebdf2b982b352b642f23d3a930e91b9719eb6b95","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mandreou \u003cmarios@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-11 16:39:54 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - ffwd-upgrade cli adds ffwd-upgrade [prepare|run|converge]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Working with the sequence described in [0] with this patch and"},{"line_number":10,"context_line":"the tripleo-common review in dependency below the operator can do:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bf659307_f9d665f2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2018-04-12 10:27:13.000000000","message":"remove... i think we agreed we will go for v1 of this by friday. I just tidied up the tripleo-common side.","commit_id":"74b891e0347b86a5d9dd54b5d9beb51eedb81265"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b19b80a64e5102ef277eb6ea4b86c37aff4c15c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mandreou \u003cmarios@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-11 16:39:54 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - ffwd-upgrade cli adds ffwd-upgrade [prepare|run|converge]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Working with the sequence described in [0] with this patch and"},{"line_number":10,"context_line":"the tripleo-common review in dependency below the operator can do:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bf659307_1c6787b9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"in_reply_to":"bf659307_f9d665f2","updated":"2018-04-12 10:49:53.000000000","message":"Done","commit_id":"74b891e0347b86a5d9dd54b5d9beb51eedb81265"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ebdf2b982b352b642f23d3a930e91b9719eb6b95","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    2 openstack overcloud ffwd-upgrade run ... $params"},{"line_number":16,"context_line":"    # ^^^ added here. run fast_forward_upgrade_playbook.yaml"},{"line_number":17,"context_line":"    # against the overcloud (noneed for --limit-hosts??)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    3 openstack overcloud upgrade run --roles Controller"},{"line_number":20,"context_line":"    # ^^^ exists... runs the upgrade_steps_playbook.yaml and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bf659307_39fa9d74","line":17,"range":{"start_line":17,"start_character":53,"end_line":17,"end_character":55},"updated":"2018-04-12 10:27:13.000000000","message":"reword/remove ??","commit_id":"74b891e0347b86a5d9dd54b5d9beb51eedb81265"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b19b80a64e5102ef277eb6ea4b86c37aff4c15c4","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    2 openstack overcloud ffwd-upgrade run ... $params"},{"line_number":16,"context_line":"    # ^^^ added here. run fast_forward_upgrade_playbook.yaml"},{"line_number":17,"context_line":"    # against the overcloud (noneed for --limit-hosts??)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    3 openstack overcloud upgrade run --roles Controller"},{"line_number":20,"context_line":"    # ^^^ exists... runs the upgrade_steps_playbook.yaml and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bf659307_bc053bc4","line":17,"range":{"start_line":17,"start_character":53,"end_line":17,"end_character":55},"in_reply_to":"bf659307_39fa9d74","updated":"2018-04-12 10:49:53.000000000","message":"Done","commit_id":"74b891e0347b86a5d9dd54b5d9beb51eedb81265"}],"tripleoclient/tests/v1/overcloud_ffwd_upgrade/test_overcloud_ffwd_upgrade.py":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"84a2ef0733c7303edb092455d4ef461e97100cea","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            self.cmd, argslist, verifylist))"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# WIP: this needs fixing"},{"line_number":160,"context_line":"class TestFFWDUpgradeConverge(fakes.TestFFWDUpgradeConverge):"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_52ad4a99","line":159,"updated":"2018-04-09 11:24:04.000000000","message":"Highlight","commit_id":"fd036e656a4a86413bb80609d311b6e8a8e132ec"}],"tripleoclient/v1/overcloud_ffwd_upgrade.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5baf9f4e47ee8ef77a582da5b8b1f34042c135e1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        package_update.update(clients, container\u003dstack_name,"},{"line_number":75,"context_line":"                              container_registry\u003dregistry,"},{"line_number":76,"context_line":"                              ceph_ansible_playbook\u003dceph_ansible_playbook,"},{"line_number":77,"context_line":"                              config_download\u003dTrue)"},{"line_number":78,"context_line":"        package_update.get_config(clients, container\u003dstack_name)"},{"line_number":79,"context_line":"        print(\"FFWD Upgrade Prepare on stack {0} complete.\".format("},{"line_number":80,"context_line":"              parsed_args.stack))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_b08c81d7","line":77,"range":{"start_line":77,"start_character":30,"end_line":77,"end_character":45},"updated":"2018-03-30 14:37:16.000000000","message":"this is the new parameter we are passing to tripleo-common (see commit message), it makes it that we use the right environment for setting the \u0027noop\u0027. in ffu we need the config download env.","commit_id":"0dca18bd0688ac8aa5652a1a92b3d476aab315ce"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"81b1e1e82c2062c97f70ea8c95f77f6c720ead2c","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class FFWDUpgradeRun(command.Command):"},{"line_number":84,"context_line":"    \"\"\"Run fast forward upgrade ansible playbooks on Overcloud nodes\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    log \u003d logging.getLogger(__name__ + \".FFWDUpgradeRun\")"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_d871f0a9","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":71},"updated":"2018-04-03 11:20:30.000000000","message":"add more here, it shows up in helptext (undercloud) [stack@undercloud-71516 python-tripleoclient]$ openstack overcloud ffwd-upgrade run --help\nusage: openstack overcloud ffwd-upgrade run [-h]\n                                            [--static-inventory STATIC_INVENTORY]\n\nRun fast forward upgrade ansible playbooks on Overcloud nodes\n\noptional arguments:\n  -h, --help            show this help message and exit\n  --static-inventory STATIC_INVENTORY\n                        Path to an existing ansible inventory to use. If not\n                        specified, one will be generated in ~/tripleo-ansible-\n                        inventory.yaml\n\nThis command is provided by the python-tripleoclient plugin.","commit_id":"251aad13e72ef9e388f39e1605a06c087cfa8fdf"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bbc452d42972e6ad26d38821ac945ea8c93b308c","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class FFWDUpgradeRun(command.Command):"},{"line_number":84,"context_line":"    \"\"\"Run fast forward upgrade ansible playbooks on Overcloud nodes\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    log \u003d logging.getLogger(__name__ + \".FFWDUpgradeRun\")"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_38582c54","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":71},"in_reply_to":"bf659307_d871f0a9","updated":"2018-04-03 12:10:08.000000000","message":"Done","commit_id":"251aad13e72ef9e388f39e1605a06c087cfa8fdf"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7f062a7ec7e6935955460c6b5bed2129a1ee6d5c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                   \u0027use. If not specified, one will be \u0027"},{"line_number":99,"context_line":"                                   \u0027generated in \u0027"},{"line_number":100,"context_line":"                                   \u0027~/tripleo-ansible-inventory.yaml\u0027)"},{"line_number":101,"context_line":"                            )"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def take_action(self, parsed_args):"},{"line_number":104,"context_line":"        self.log.debug(\"take_action(%s)\" % parsed_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_b8075c18","line":101,"updated":"2018-04-03 11:15:48.000000000","message":"and you might want to return the parser probably ;)","commit_id":"251aad13e72ef9e388f39e1605a06c087cfa8fdf"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bbc452d42972e6ad26d38821ac945ea8c93b308c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                   \u0027use. If not specified, one will be \u0027"},{"line_number":99,"context_line":"                                   \u0027generated in \u0027"},{"line_number":100,"context_line":"                                   \u0027~/tripleo-ansible-inventory.yaml\u0027)"},{"line_number":101,"context_line":"                            )"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def take_action(self, parsed_args):"},{"line_number":104,"context_line":"        self.log.debug(\"take_action(%s)\" % parsed_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_9874d8d0","line":101,"in_reply_to":"bf659307_b8075c18","updated":"2018-04-03 12:10:08.000000000","message":"Done","commit_id":"251aad13e72ef9e388f39e1605a06c087cfa8fdf"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"defd8ead8218b378900fb5a767f7803fe9d52436","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument(\u0027--stack\u0027,"},{"line_number":136,"context_line":"                            action\u003d\"store\","},{"line_number":137,"context_line":"                            default\u003d\u0027overcloud\u0027,"},{"line_number":138,"context_line":"                            help\u003d_(\u0027Name of the Heat stack\u0027)"},{"line_number":139,"context_line":"                            )"},{"line_number":140,"context_line":"        return parser"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_789a24b9","line":138,"updated":"2018-04-03 11:23:55.000000000","message":"This defaults to \u0027overcloud\u0027 and you should use this parameter to override that value if your overcloud deployment heat stack is named differently.","commit_id":"251aad13e72ef9e388f39e1605a06c087cfa8fdf"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bbc452d42972e6ad26d38821ac945ea8c93b308c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument(\u0027--stack\u0027,"},{"line_number":136,"context_line":"                            action\u003d\"store\","},{"line_number":137,"context_line":"                            default\u003d\u0027overcloud\u0027,"},{"line_number":138,"context_line":"                            help\u003d_(\u0027Name of the Heat stack\u0027)"},{"line_number":139,"context_line":"                            )"},{"line_number":140,"context_line":"        return parser"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_3806ec21","line":138,"in_reply_to":"bf659307_789a24b9","updated":"2018-04-03 12:10:08.000000000","message":"Done","commit_id":"251aad13e72ef9e388f39e1605a06c087cfa8fdf"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"390a4c56dddb1a5999324a92ab2e07dd43e42d3a","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def get_parser(self, prog_name):"},{"line_number":94,"context_line":"        parser \u003d super(FFWDUpgradeRun, self).get_parser(prog_name)"},{"line_number":95,"context_line":"        # TODO(marios) not adding nodes or roles for now, easy to do, but"},{"line_number":96,"context_line":"        # pending discussion around whether we will have FFU with --limit-hosts"},{"line_number":97,"context_line":"        # I think for canary deployment we need it but #firstpass"},{"line_number":98,"context_line":"        parser.add_argument(\u0027--static-inventory\u0027,"},{"line_number":99,"context_line":"                            dest\u003d\u0027static_inventory\u0027,"},{"line_number":100,"context_line":"                            action\u003d\"store\","}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_264afc7f","line":97,"range":{"start_line":95,"start_character":0,"end_line":97,"end_character":64},"updated":"2018-04-06 15:19:55.000000000","message":"remove this is fine we don\u0027t want --limit-hosts for ffwd-upgrade run","commit_id":"59d22150e6433359ee6b095cf83fbfe72a60623d"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"84a2ef0733c7303edb092455d4ef461e97100cea","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                   parsed_args.stack)"},{"line_number":153,"context_line":"        stack_name \u003d stack.stack_name"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        parsed_args.update_plan_only \u003d True"},{"line_number":156,"context_line":"        # Add the converge environment into the args to unset noop etc"},{"line_number":157,"context_line":"        templates_dir \u003d (parsed_args.templates or"},{"line_number":158,"context_line":"                         constants.TRIPLEO_HEAT_TEMPLATES)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_72a08ea6","line":155,"updated":"2018-04-09 11:24:04.000000000","message":"Do we want parsed_args.config_download \u003d True as well?","commit_id":"fd036e656a4a86413bb80609d311b6e8a8e132ec"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"0bb86e9b1f88ea85652ecd026e762668c6a30b2c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    log \u003d logging.getLogger(__name__ + \".FFWDUpgradePrepare\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # enable preservation of all important files (plan env, user env,"},{"line_number":37,"context_line":"    # roles/network data, user files) so that we don\u0027t have to pass"},{"line_number":38,"context_line":"    # all env files on update command"},{"line_number":39,"context_line":"    _keep_env_on_update \u003d True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_parser(self, prog_name):"},{"line_number":42,"context_line":"        parser \u003d super(FFWDUpgradePrepare, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_4c37ed4e","line":39,"range":{"start_line":36,"start_character":0,"end_line":39,"end_character":30},"updated":"2018-04-09 15:02:17.000000000","message":"Forgot to drop this... Let\u0027s pick it up on next PS, i don\u0027t want to torture zuul anymore.","commit_id":"7da8e2bc02567a66262c38bb5aea472ea4ec443d"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"9a5f7534743c59a4e4a00af9e634a4efb6b2dc72","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    log \u003d logging.getLogger(__name__ + \".FFWDUpgradePrepare\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # enable preservation of all important files (plan env, user env,"},{"line_number":37,"context_line":"    # roles/network data, user files) so that we don\u0027t have to pass"},{"line_number":38,"context_line":"    # all env files on update command"},{"line_number":39,"context_line":"    _keep_env_on_update \u003d True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_parser(self, prog_name):"},{"line_number":42,"context_line":"        parser \u003d super(FFWDUpgradePrepare, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_ec260117","line":39,"range":{"start_line":36,"start_character":0,"end_line":39,"end_character":30},"in_reply_to":"bf659307_4c37ed4e","updated":"2018-04-09 15:03:26.000000000","message":"Actually lbezdick probably needs it to test... updating.","commit_id":"7da8e2bc02567a66262c38bb5aea472ea4ec443d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7a298ea21e2613e2ac8727ef52a3379b7fce827e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        package_update.update(clients, container\u003dstack_name,"},{"line_number":80,"context_line":"                              container_registry\u003dregistry,"},{"line_number":81,"context_line":"                              ceph_ansible_playbook\u003dceph_ansible_playbook,"},{"line_number":82,"context_line":"                              config_download\u003dTrue)"},{"line_number":83,"context_line":"        package_update.get_config(clients, container\u003dstack_name)"},{"line_number":84,"context_line":"        print(\"FFWD Upgrade Prepare on stack {0} complete.\".format("},{"line_number":85,"context_line":"              parsed_args.stack))"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_b5cb49a3","line":82,"range":{"start_line":82,"start_character":32,"end_line":82,"end_character":50},"updated":"2018-04-10 16:28:14.000000000","message":"remove this is gone from the latest version of the dependency @ https://review.openstack.org/#/c/557936/","commit_id":"07a7a062026bcffa536694a7591446a4bcf05d05"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f3a182c5fc5f3565e1f5db15eaaf0679c934cba6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        super(FFWDUpgradeConverge, self).take_action(parsed_args)"},{"line_number":171,"context_line":"        # Run converge steps"},{"line_number":172,"context_line":"        package_update.ffwd_converge_nodes("},{"line_number":173,"context_line":"            clients, container\u003dstack_name, config_download\u003dTrue,"},{"line_number":174,"context_line":"            queue_name\u003dconstants.FFWD_UPGRADE_QUEUE)"},{"line_number":175,"context_line":"        print(\"FFWD Upgrade Converge on stack {0} complete.\".format("},{"line_number":176,"context_line":"              parsed_args.stack))"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_d48286c8","line":173,"range":{"start_line":173,"start_character":43,"end_line":173,"end_character":63},"updated":"2018-04-10 13:21:29.000000000","message":"we will remove this one too. It is being used tripleo-common side to set the no-op for ffu (which is config-download and so different to what is used for major upgrade currently). i.e. i will remove https://review.openstack.org/#/c/557936/5/workbooks/package_update.yaml@20","commit_id":"07a7a062026bcffa536694a7591446a4bcf05d05"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"86fbdc0105769ff6364ce6f1484ddd6a14f6d538","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        super(FFWDUpgradeConverge, self).take_action(parsed_args)"},{"line_number":171,"context_line":"        # Run converge steps"},{"line_number":172,"context_line":"        package_update.ffwd_converge_nodes("},{"line_number":173,"context_line":"            clients, container\u003dstack_name, config_download\u003dTrue,"},{"line_number":174,"context_line":"            queue_name\u003dconstants.FFWD_UPGRADE_QUEUE)"},{"line_number":175,"context_line":"        print(\"FFWD Upgrade Converge on stack {0} complete.\".format("},{"line_number":176,"context_line":"              parsed_args.stack))"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_8e413d3c","line":173,"range":{"start_line":173,"start_character":43,"end_line":173,"end_character":63},"in_reply_to":"bf659307_754a9127","updated":"2018-04-11 13:17:50.000000000","message":"updating this now and fixing the borked py27 tests too (well fighting with them currently anyway :))","commit_id":"07a7a062026bcffa536694a7591446a4bcf05d05"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7a298ea21e2613e2ac8727ef52a3379b7fce827e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        super(FFWDUpgradeConverge, self).take_action(parsed_args)"},{"line_number":171,"context_line":"        # Run converge steps"},{"line_number":172,"context_line":"        package_update.ffwd_converge_nodes("},{"line_number":173,"context_line":"            clients, container\u003dstack_name, config_download\u003dTrue,"},{"line_number":174,"context_line":"            queue_name\u003dconstants.FFWD_UPGRADE_QUEUE)"},{"line_number":175,"context_line":"        print(\"FFWD Upgrade Converge on stack {0} complete.\".format("},{"line_number":176,"context_line":"              parsed_args.stack))"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_754a9127","line":173,"range":{"start_line":173,"start_character":43,"end_line":173,"end_character":63},"in_reply_to":"bf659307_d48286c8","updated":"2018-04-10 16:28:14.000000000","message":"so we should remove this its gone tripleo-common side - though I kept the converge workflow (even though it is no longer really necessary, wdyt?0","commit_id":"07a7a062026bcffa536694a7591446a4bcf05d05"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3e1d942bdc1b1e5d1dcc909c8a08c0335518d420","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def get_parser(self, prog_name):"},{"line_number":98,"context_line":"        parser \u003d super(FFWDUpgradeRun, self).get_parser(prog_name)"},{"line_number":99,"context_line":"        # TODO(marios) not adding nodes or roles for now, easy to do, but"},{"line_number":100,"context_line":"        # pending discussion around whether we will have FFU with --limit-hosts"},{"line_number":101,"context_line":"        # I think for canary deployment we need it but #firstpass"},{"line_number":102,"context_line":"        parser.add_argument(\u0027--static-inventory\u0027,"},{"line_number":103,"context_line":"                            dest\u003d\u0027static_inventory\u0027,"},{"line_number":104,"context_line":"                            action\u003d\"store\","}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_1928f994","line":101,"range":{"start_line":99,"start_character":11,"end_line":101,"end_character":65},"updated":"2018-04-12 10:38:09.000000000","message":"remove comment","commit_id":"74b891e0347b86a5d9dd54b5d9beb51eedb81265"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b19b80a64e5102ef277eb6ea4b86c37aff4c15c4","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def get_parser(self, prog_name):"},{"line_number":98,"context_line":"        parser \u003d super(FFWDUpgradeRun, self).get_parser(prog_name)"},{"line_number":99,"context_line":"        # TODO(marios) not adding nodes or roles for now, easy to do, but"},{"line_number":100,"context_line":"        # pending discussion around whether we will have FFU with --limit-hosts"},{"line_number":101,"context_line":"        # I think for canary deployment we need it but #firstpass"},{"line_number":102,"context_line":"        parser.add_argument(\u0027--static-inventory\u0027,"},{"line_number":103,"context_line":"                            dest\u003d\u0027static_inventory\u0027,"},{"line_number":104,"context_line":"                            action\u003d\"store\","}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_7cc803a7","line":101,"range":{"start_line":99,"start_character":11,"end_line":101,"end_character":65},"in_reply_to":"bf659307_1928f994","updated":"2018-04-12 10:49:53.000000000","message":"Done","commit_id":"74b891e0347b86a5d9dd54b5d9beb51eedb81265"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3e1d942bdc1b1e5d1dcc909c8a08c0335518d420","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # Run ansible:"},{"line_number":124,"context_line":"        inventory \u003d oooutils.get_tripleo_ansible_inventory("},{"line_number":125,"context_line":"            parsed_args.static_inventory)"},{"line_number":126,"context_line":"        # TODO(marios): enable limit hosts?"},{"line_number":127,"context_line":"        limit_hosts \u003d \u0027\u0027"},{"line_number":128,"context_line":"        oooutils.run_update_ansible_action("},{"line_number":129,"context_line":"            self.log, clients, limit_hosts, inventory,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_590bd128","line":126,"range":{"start_line":126,"start_character":10,"end_line":126,"end_character":43},"updated":"2018-04-12 10:38:09.000000000","message":"remove comment","commit_id":"74b891e0347b86a5d9dd54b5d9beb51eedb81265"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b19b80a64e5102ef277eb6ea4b86c37aff4c15c4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # Run ansible:"},{"line_number":124,"context_line":"        inventory \u003d oooutils.get_tripleo_ansible_inventory("},{"line_number":125,"context_line":"            parsed_args.static_inventory)"},{"line_number":126,"context_line":"        # TODO(marios): enable limit hosts?"},{"line_number":127,"context_line":"        limit_hosts \u003d \u0027\u0027"},{"line_number":128,"context_line":"        oooutils.run_update_ansible_action("},{"line_number":129,"context_line":"            self.log, clients, limit_hosts, inventory,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_3c4b6b2b","line":126,"range":{"start_line":126,"start_character":10,"end_line":126,"end_character":43},"in_reply_to":"bf659307_590bd128","updated":"2018-04-12 10:49:53.000000000","message":"Done","commit_id":"74b891e0347b86a5d9dd54b5d9beb51eedb81265"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"213669452a9d53d2ebd67c8c0bf8caef236fb2d7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                         constants.TRIPLEO_HEAT_TEMPLATES)"},{"line_number":72,"context_line":"        if not parsed_args.environment_files:"},{"line_number":73,"context_line":"            parsed_args.environment_files \u003d []"},{"line_number":74,"context_line":"        oooutils.prepend_environment("},{"line_number":75,"context_line":"            parsed_args.environment_files, templates_dir,"},{"line_number":76,"context_line":"            constants.FFWD_UPGRADE_PREPARE_ENV)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        super(FFWDUpgradePrepare, self).take_action(parsed_args)"},{"line_number":79,"context_line":"        package_update.update(clients, container\u003dstack_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_3c4eee96","line":76,"range":{"start_line":74,"start_character":9,"end_line":76,"end_character":21},"updated":"2018-04-13 07:56:21.000000000","message":"i think it shouldn\u0027t be necessary but lets update this to be assigned the returned value like https://review.openstack.org/#/c/558866/9/tripleoclient/v1/overcloud_upgrade.py@86 and https://review.openstack.org/#/c/558536/9/tripleoclient/v1/overcloud_update.py@197","commit_id":"2781e551a24dd8cfbbf7ab7f50749cbcd4be95ad"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5f73de60ac525faf84753bde168e221b6ec7f96b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                         constants.TRIPLEO_HEAT_TEMPLATES)"},{"line_number":72,"context_line":"        if not parsed_args.environment_files:"},{"line_number":73,"context_line":"            parsed_args.environment_files \u003d []"},{"line_number":74,"context_line":"        oooutils.prepend_environment("},{"line_number":75,"context_line":"            parsed_args.environment_files, templates_dir,"},{"line_number":76,"context_line":"            constants.FFWD_UPGRADE_PREPARE_ENV)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        super(FFWDUpgradePrepare, self).take_action(parsed_args)"},{"line_number":79,"context_line":"        package_update.update(clients, container\u003dstack_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_169c2268","line":76,"range":{"start_line":74,"start_character":9,"end_line":76,"end_character":21},"in_reply_to":"bf659307_3c4eee96","updated":"2018-04-13 11:00:47.000000000","message":"Done v13 https://review.openstack.org/#/c/557937/12..13/tripleoclient/v1/overcloud_ffwd_upgrade.py","commit_id":"2781e551a24dd8cfbbf7ab7f50749cbcd4be95ad"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"213669452a9d53d2ebd67c8c0bf8caef236fb2d7","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                         constants.TRIPLEO_HEAT_TEMPLATES)"},{"line_number":160,"context_line":"        if not parsed_args.environment_files:"},{"line_number":161,"context_line":"            parsed_args.environment_files \u003d []"},{"line_number":162,"context_line":"        oooutils.prepend_environment("},{"line_number":163,"context_line":"            parsed_args.environment_files, templates_dir,"},{"line_number":164,"context_line":"            constants.UPGRADE_CONVERGE_ENV)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        super(FFWDUpgradeConverge, self).take_action(parsed_args)"},{"line_number":167,"context_line":"        # Run converge steps"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_fc43966a","line":164,"range":{"start_line":162,"start_character":13,"end_line":164,"end_character":23},"updated":"2018-04-13 07:56:21.000000000","message":"and here too","commit_id":"2781e551a24dd8cfbbf7ab7f50749cbcd4be95ad"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5f73de60ac525faf84753bde168e221b6ec7f96b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                         constants.TRIPLEO_HEAT_TEMPLATES)"},{"line_number":160,"context_line":"        if not parsed_args.environment_files:"},{"line_number":161,"context_line":"            parsed_args.environment_files \u003d []"},{"line_number":162,"context_line":"        oooutils.prepend_environment("},{"line_number":163,"context_line":"            parsed_args.environment_files, templates_dir,"},{"line_number":164,"context_line":"            constants.UPGRADE_CONVERGE_ENV)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        super(FFWDUpgradeConverge, self).take_action(parsed_args)"},{"line_number":167,"context_line":"        # Run converge steps"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_b684560c","line":164,"range":{"start_line":162,"start_character":13,"end_line":164,"end_character":23},"in_reply_to":"bf659307_fc43966a","updated":"2018-04-13 11:00:47.000000000","message":"Done v13 https://review.openstack.org/#/c/557937/12..13/tripleoclient/v1/overcloud_ffwd_upgrade.py","commit_id":"2781e551a24dd8cfbbf7ab7f50749cbcd4be95ad"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"026b929ab940279407d74ef0fdd515a732335ba6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            parsed_args.environment_files \u003d []"},{"line_number":162,"context_line":"        parsed_args.environment_files \u003d oooutils.prepend_environment("},{"line_number":163,"context_line":"            parsed_args.environment_files, templates_dir,"},{"line_number":164,"context_line":"            constants.UPGRADE_CONVERGE_ENV)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        super(FFWDUpgradeConverge, self).take_action(parsed_args)"},{"line_number":167,"context_line":"        # Run converge steps"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_a8d7b9ed","line":164,"range":{"start_line":164,"start_character":42,"end_line":164,"end_character":43},"updated":"2018-04-17 12:37:02.000000000","message":"FFWD env","commit_id":"51e62432b2d686cac11a372d6ed667fa93fe8ca1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5baba2598704b293e6ccf7ab9cf6dcb681b56938","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            parsed_args.environment_files \u003d []"},{"line_number":162,"context_line":"        parsed_args.environment_files \u003d oooutils.prepend_environment("},{"line_number":163,"context_line":"            parsed_args.environment_files, templates_dir,"},{"line_number":164,"context_line":"            constants.UPGRADE_CONVERGE_ENV)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        super(FFWDUpgradeConverge, self).take_action(parsed_args)"},{"line_number":167,"context_line":"        # Run converge steps"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_689a0115","line":164,"range":{"start_line":164,"start_character":42,"end_line":164,"end_character":43},"in_reply_to":"9f6a8fd7_a8d7b9ed","updated":"2018-04-17 12:41:44.000000000","message":"thanks nice catch (in fact that was there before the rebase we just missed it)","commit_id":"51e62432b2d686cac11a372d6ed667fa93fe8ca1"}],"tripleoclient/workflows/package_update.py":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"d2309d4ba84a255104727fc6347f1892bf8d7478","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":143,"context_line":"    tripleoclients \u003d clients.tripleoclient"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    with tripleoclients.messaging_websocket() as ws:"},{"line_number":146,"context_line":"        execution \u003d base.start_workflow("},{"line_number":147,"context_line":"            workflow_client,"},{"line_number":148,"context_line":"            \u0027tripleo.package_update.v1.ffwd_upgrade_converge_plan\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_525db844","line":145,"range":{"start_line":145,"start_character":43,"end_line":145,"end_character":45},"updated":"2018-04-03 15:21:41.000000000","message":"I think you\u0027ll need to pass in the queue name here to make it work. I had to do it in update converge:\n\nhttps://review.openstack.org/#/c/558536/2/tripleoclient/workflows/package_update.py\n\nAlthough i\u0027m thinking we should just drop all that and simply use the \"tripleo\" queue when a calmer time comes around.","commit_id":"5f97e1a457f4f2edc58345fa1699c8189ea86d44"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"39c7d9da1df9b2a37db6eaeb97e0201d2d95746a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":143,"context_line":"    tripleoclients \u003d clients.tripleoclient"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    with tripleoclients.messaging_websocket() as ws:"},{"line_number":146,"context_line":"        execution \u003d base.start_workflow("},{"line_number":147,"context_line":"            workflow_client,"},{"line_number":148,"context_line":"            \u0027tripleo.package_update.v1.ffwd_upgrade_converge_plan\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_d21f8869","line":145,"range":{"start_line":145,"start_character":43,"end_line":145,"end_character":45},"in_reply_to":"bf659307_525db844","updated":"2018-04-03 15:23:08.000000000","message":"(BTW i didn\u0027t do a full review here yet, just came here to comment as i hit that ^^ in the update code.)","commit_id":"5f97e1a457f4f2edc58345fa1699c8189ea86d44"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8504a85beea303945cb98eb75c99629d90a859ac","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":143,"context_line":"    tripleoclients \u003d clients.tripleoclient"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    with tripleoclients.messaging_websocket() as ws:"},{"line_number":146,"context_line":"        execution \u003d base.start_workflow("},{"line_number":147,"context_line":"            workflow_client,"},{"line_number":148,"context_line":"            \u0027tripleo.package_update.v1.ffwd_upgrade_converge_plan\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_f50076ad","line":145,"range":{"start_line":145,"start_character":43,"end_line":145,"end_character":45},"in_reply_to":"bf659307_75f1c600","updated":"2018-04-03 15:37:53.000000000","message":"Done","commit_id":"5f97e1a457f4f2edc58345fa1699c8189ea86d44"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b6b7f412a0460d0d37f65a292a215877c3776d29","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":143,"context_line":"    tripleoclients \u003d clients.tripleoclient"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    with tripleoclients.messaging_websocket() as ws:"},{"line_number":146,"context_line":"        execution \u003d base.start_workflow("},{"line_number":147,"context_line":"            workflow_client,"},{"line_number":148,"context_line":"            \u0027tripleo.package_update.v1.ffwd_upgrade_converge_plan\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_75f1c600","line":145,"range":{"start_line":145,"start_character":43,"end_line":145,"end_character":45},"in_reply_to":"bf659307_d21f8869","updated":"2018-04-03 15:30:20.000000000","message":"ack thanks","commit_id":"5f97e1a457f4f2edc58345fa1699c8189ea86d44"}]}