)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a0c3026656ee3ac1836b1e2cdf988d18d645fff1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add warning + required confirm for ffwd-upgrade cli --yes to skip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds for all invocations of the ffwd-upgrade prepare, run and"},{"line_number":10,"context_line":"converge a warning to the operator that ffwd-upgrade is still"},{"line_number":11,"context_line":"under development and to be used with caution. The operator"},{"line_number":12,"context_line":"must type \u0027yes\u0027 in order to proceed, or set the new --yes"},{"line_number":13,"context_line":"parameter added here."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_d450b5d7","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":53},"updated":"2018-05-03 10:52:05.000000000","message":"cli ?","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"67c54768e4ad3e2ccf5e8ee92d1f541591e4c6b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add warning + required confirm for ffwd-upgrade cli --yes to skip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds for all invocations of the ffwd-upgrade prepare, run and"},{"line_number":10,"context_line":"converge a warning to the operator that ffwd-upgrade is still"},{"line_number":11,"context_line":"under development and to be used with caution. The operator"},{"line_number":12,"context_line":"must type \u0027yes\u0027 in order to proceed, or set the new --yes"},{"line_number":13,"context_line":"parameter added here."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_14cdcd5c","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":53},"in_reply_to":"5f7c97a3_d450b5d7","updated":"2018-05-03 11:09:12.000000000","message":"well not really. i am more referring to the workflow/process in general","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"}],"tripleoclient/constants.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"976bb1a355f90f32c0562c5945f7d04daf0f0ef1","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# The default ffwd upgrade ansible playbooks generated from heat stack output"},{"line_number":48,"context_line":"FFWD_UPGRADE_PLAYBOOK \u003d \"fast_forward_upgrade_playbook.yaml\""},{"line_number":49,"context_line":"FFWD_UPGRADE_MESSAGE \u003d (\"Warning! The TripleO Fast Forward Upgrade workflow \""},{"line_number":50,"context_line":"                        \"is currently considered as dev-test and at most \""},{"line_number":51,"context_line":"                        \"still in beta release. In particular invocation \""},{"line_number":52,"context_line":"                        \"should be limited to dev/test environments.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_c05eb411","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":20},"updated":"2018-04-26 12:30:42.000000000","message":"didn\u0027t end up needed/using this going to remove thanks","commit_id":"6b8bd96e23254f4a76eaec147ff98cf11a10287b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f3262c10f906704f04d3298f40fe7ca7c45fbb19","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# The default ffwd upgrade ansible playbooks generated from heat stack output"},{"line_number":48,"context_line":"FFWD_UPGRADE_PLAYBOOK \u003d \"fast_forward_upgrade_playbook.yaml\""},{"line_number":49,"context_line":"FFWD_UPGRADE_MESSAGE \u003d (\"Warning! The TripleO Fast Forward Upgrade workflow \""},{"line_number":50,"context_line":"                        \"is currently considered as dev-test and at most \""},{"line_number":51,"context_line":"                        \"still in beta release. In particular invocation \""},{"line_number":52,"context_line":"                        \"should be limited to dev/test environments.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_937539cf","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":20},"in_reply_to":"9f6a8fd7_22197d87","updated":"2018-04-30 14:40:25.000000000","message":"Done","commit_id":"6b8bd96e23254f4a76eaec147ff98cf11a10287b"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"76d43619b54e91f2389d5b9144e2258298f800c0","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# The default ffwd upgrade ansible playbooks generated from heat stack output"},{"line_number":48,"context_line":"FFWD_UPGRADE_PLAYBOOK \u003d \"fast_forward_upgrade_playbook.yaml\""},{"line_number":49,"context_line":"FFWD_UPGRADE_MESSAGE \u003d (\"Warning! The TripleO Fast Forward Upgrade workflow \""},{"line_number":50,"context_line":"                        \"is currently considered as dev-test and at most \""},{"line_number":51,"context_line":"                        \"still in beta release. In particular invocation \""},{"line_number":52,"context_line":"                        \"should be limited to dev/test environments.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_22197d87","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":20},"in_reply_to":"9f6a8fd7_c05eb411","updated":"2018-04-30 12:01:11.000000000","message":"time to remove it?","commit_id":"6b8bd96e23254f4a76eaec147ff98cf11a10287b"}],"tripleoclient/utils.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"72b8258bbd8c7646e0552d9519712da987376cd3","unresolved":false,"context_lines":[{"line_number":966,"context_line":"def ffwd_upgrade_operator_confirm(parsed_args_yes, log):"},{"line_number":967,"context_line":"    print(\"Warning! The TripleO Fast Forward Upgrade workflow \""},{"line_number":968,"context_line":"          \"is currently considered as dev/test and at most \""},{"line_number":969,"context_line":"          \"still in alpha release. In particular invocation \""},{"line_number":970,"context_line":"          \"should be limited to development/test environments.\")"},{"line_number":971,"context_line":"    if parsed_args_yes:"},{"line_number":972,"context_line":"        log.debug(\"Fast forward upgrade --yes continuing\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_3189cd25","line":969,"range":{"start_line":969,"start_character":13,"end_line":969,"end_character":32},"updated":"2018-04-30 09:05:38.000000000","message":"lets rework this as per mbracho suggestion","commit_id":"6b8bd96e23254f4a76eaec147ff98cf11a10287b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f3262c10f906704f04d3298f40fe7ca7c45fbb19","unresolved":false,"context_lines":[{"line_number":966,"context_line":"def ffwd_upgrade_operator_confirm(parsed_args_yes, log):"},{"line_number":967,"context_line":"    print(\"Warning! The TripleO Fast Forward Upgrade workflow \""},{"line_number":968,"context_line":"          \"is currently considered as dev/test and at most \""},{"line_number":969,"context_line":"          \"still in alpha release. In particular invocation \""},{"line_number":970,"context_line":"          \"should be limited to development/test environments.\")"},{"line_number":971,"context_line":"    if parsed_args_yes:"},{"line_number":972,"context_line":"        log.debug(\"Fast forward upgrade --yes continuing\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_b372bde2","line":969,"range":{"start_line":969,"start_character":13,"end_line":969,"end_character":32},"in_reply_to":"9f6a8fd7_3189cd25","updated":"2018-04-30 14:40:25.000000000","message":"Done","commit_id":"6b8bd96e23254f4a76eaec147ff98cf11a10287b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a0c3026656ee3ac1836b1e2cdf988d18d645fff1","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        print(\"Continuing fast forward upgrade\")"},{"line_number":1084,"context_line":"        return"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        response \u003d raw_input(\"Proceed with the fast forward upgrade? \""},{"line_number":1087,"context_line":"                             \"Type \\\u0027yes\\\u0027 to continue and anything else to \""},{"line_number":1088,"context_line":"                             \"cancel. Consider using the --yes parameter if \""},{"line_number":1089,"context_line":"                             \"you wish to skip this warning in future. \")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_94d6bd4f","line":1086,"range":{"start_line":1086,"start_character":19,"end_line":1086,"end_character":28},"updated":"2018-05-03 10:52:05.000000000","message":"Do we care that it\u0027s not python3 compatible (was renamed \"input\" just because they can :))","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3e7733a867c5c4a0f398f39bf92b7d8679673f42","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        print(\"Continuing fast forward upgrade\")"},{"line_number":1084,"context_line":"        return"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        response \u003d raw_input(\"Proceed with the fast forward upgrade? \""},{"line_number":1087,"context_line":"                             \"Type \\\u0027yes\\\u0027 to continue and anything else to \""},{"line_number":1088,"context_line":"                             \"cancel. Consider using the --yes parameter if \""},{"line_number":1089,"context_line":"                             \"you wish to skip this warning in future. \")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_329fb951","line":1086,"range":{"start_line":1086,"start_character":19,"end_line":1086,"end_character":28},"in_reply_to":"5f7c97a3_1294fd43","updated":"2018-05-03 13:03:18.000000000","message":"never mind previous, i will update it per your suggestion thanks","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2a8bba771ef7827a782b778cf7c5922b52c1dc1c","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        print(\"Continuing fast forward upgrade\")"},{"line_number":1084,"context_line":"        return"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        response \u003d raw_input(\"Proceed with the fast forward upgrade? \""},{"line_number":1087,"context_line":"                             \"Type \\\u0027yes\\\u0027 to continue and anything else to \""},{"line_number":1088,"context_line":"                             \"cancel. Consider using the --yes parameter if \""},{"line_number":1089,"context_line":"                             \"you wish to skip this warning in future. \")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_b46c199d","line":1086,"range":{"start_line":1086,"start_character":19,"end_line":1086,"end_character":28},"in_reply_to":"5f7c97a3_94d6bd4f","updated":"2018-05-03 11:05:49.000000000","message":"ack thanks i can update this.\n\n(https://docs.python.org/3/whatsnew/3.0.html#builtins)\n\nhm... maybe not why is this happening with 2.7:\n\n\u003e\u003e\u003e input(\"Foo foo\")\nFoo foofdsa\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"\u003cstring\u003e\", line 1, in \u003cmodule\u003e\nNameError: name \u0027fdsa\u0027 is not defined\n\u003e\u003e\u003e res\u003dinput(\"Foo \u0027foo\u0027\")\nFoo \u0027foo\u0027foo\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"\u003cstring\u003e\", line 1, in \u003cmodule\u003e\nNameError: name \u0027foo\u0027 is not defined\n\n\nthere is a clue in the https://docs.python.org/3/whatsnew/3.0.html#builtins \"To get the old behavior of input(), use eval(input()). \" which explains the above i think...","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"2049c9746ee0a45b37ea4d79eef36b38942b00a9","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        print(\"Continuing fast forward upgrade\")"},{"line_number":1084,"context_line":"        return"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        response \u003d raw_input(\"Proceed with the fast forward upgrade? \""},{"line_number":1087,"context_line":"                             \"Type \\\u0027yes\\\u0027 to continue and anything else to \""},{"line_number":1088,"context_line":"                             \"cancel. Consider using the --yes parameter if \""},{"line_number":1089,"context_line":"                             \"you wish to skip this warning in future. \")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f2ece1f4","line":1086,"range":{"start_line":1086,"start_character":19,"end_line":1086,"end_character":28},"in_reply_to":"5f7c97a3_94e1ddd3","updated":"2018-05-03 12:56:13.000000000","message":"This\n\n   # Fix Python 2.x.\n   try: input \u003d raw_input\n   except NameError: pass\n   response \u003d input(\"blaaaahhh\")\n\nwill work for 2 and 3.","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9a0fd82f5803602f7f154ed4a86c0d2973107d5e","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        print(\"Continuing fast forward upgrade\")"},{"line_number":1084,"context_line":"        return"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        response \u003d raw_input(\"Proceed with the fast forward upgrade? \""},{"line_number":1087,"context_line":"                             \"Type \\\u0027yes\\\u0027 to continue and anything else to \""},{"line_number":1088,"context_line":"                             \"cancel. Consider using the --yes parameter if \""},{"line_number":1089,"context_line":"                             \"you wish to skip this warning in future. \")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_94e1ddd3","line":1086,"range":{"start_line":1086,"start_character":19,"end_line":1086,"end_character":28},"in_reply_to":"5f7c97a3_b46c199d","updated":"2018-05-03 11:07:43.000000000","message":"https://docs.python.org/2.7/library/functions.html#input \n\"Equivalent to eval(raw_input(prompt)).\"","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"befcec3eae9fc8a588fe308c5b2547d16c467af2","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        print(\"Continuing fast forward upgrade\")"},{"line_number":1084,"context_line":"        return"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        response \u003d raw_input(\"Proceed with the fast forward upgrade? \""},{"line_number":1087,"context_line":"                             \"Type \\\u0027yes\\\u0027 to continue and anything else to \""},{"line_number":1088,"context_line":"                             \"cancel. Consider using the --yes parameter if \""},{"line_number":1089,"context_line":"                             \"you wish to skip this warning in future. \")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1294fd43","line":1086,"range":{"start_line":1086,"start_character":19,"end_line":1086,"end_character":28},"in_reply_to":"5f7c97a3_f2ece1f4","updated":"2018-05-03 12:58:08.000000000","message":"do you mind if we post that as a follow up unless there is a reason to do this here.","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a0c3026656ee3ac1836b1e2cdf988d18d645fff1","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"        return"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        response \u003d raw_input(\"Proceed with the fast forward upgrade? \""},{"line_number":1087,"context_line":"                             \"Type \\\u0027yes\\\u0027 to continue and anything else to \""},{"line_number":1088,"context_line":"                             \"cancel. Consider using the --yes parameter if \""},{"line_number":1089,"context_line":"                             \"you wish to skip this warning in future. \")"},{"line_number":1090,"context_line":"        if response !\u003d \u0027yes\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f4c4d194","line":1087,"range":{"start_line":1087,"start_character":34,"end_line":1087,"end_character":36},"updated":"2018-05-03 10:52:05.000000000","message":"The backslash seems to not be necessary unless I\u0027m missing something.","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"2049c9746ee0a45b37ea4d79eef36b38942b00a9","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"        return"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        response \u003d raw_input(\"Proceed with the fast forward upgrade? \""},{"line_number":1087,"context_line":"                             \"Type \\\u0027yes\\\u0027 to continue and anything else to \""},{"line_number":1088,"context_line":"                             \"cancel. Consider using the --yes parameter if \""},{"line_number":1089,"context_line":"                             \"you wish to skip this warning in future. \")"},{"line_number":1090,"context_line":"        if response !\u003d \u0027yes\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_52b595ed","line":1087,"range":{"start_line":1087,"start_character":34,"end_line":1087,"end_character":36},"in_reply_to":"5f7c97a3_94323da7","updated":"2018-05-03 12:56:13.000000000","message":"With the above hack (the try/except), you can safely remove the \\\u0027","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2a8bba771ef7827a782b778cf7c5922b52c1dc1c","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"        return"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        response \u003d raw_input(\"Proceed with the fast forward upgrade? \""},{"line_number":1087,"context_line":"                             \"Type \\\u0027yes\\\u0027 to continue and anything else to \""},{"line_number":1088,"context_line":"                             \"cancel. Consider using the --yes parameter if \""},{"line_number":1089,"context_line":"                             \"you wish to skip this warning in future. \")"},{"line_number":1090,"context_line":"        if response !\u003d \u0027yes\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_94323da7","line":1087,"range":{"start_line":1087,"start_character":34,"end_line":1087,"end_character":36},"in_reply_to":"5f7c97a3_f4c4d194","updated":"2018-05-03 11:05:49.000000000","message":"i thought we needed to escape it but it seems to work the same either way thanks will update ...\n\nUPDATE: it seems for python 2.7 at least it does matter, it works ok with raw_input but not with input: \n\n\u003e\u003e\u003e raw_input(\"Foo \\\u0027foo\\\u0027\")\nFoo \u0027foo\u0027foo\n\u0027foo\u0027\n\u003e\u003e\u003e input(\"Foo \\\u0027foo\\\u0027\")\nFoo \u0027foo\u0027foo\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"\u003cstring\u003e\", line 1, in \u003cmodule\u003e\nNameError: name \u0027foo\u0027 is not defined\n\u003e\u003e\u003e","commit_id":"dced8a887c0ceae696b684f4d7be861a7f0cc940"}]}