)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2bbcbefddadccf4d68a0d4ad3eef5c32baf4d24f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[0]: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1561255"},{"line_number":18,"context_line":"Related-Bug: 1758161"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I77fdc9deab97c785725f09b8529c512950753f86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_f3135965","line":19,"updated":"2018-05-07 13:15:25.000000000","message":"Depends-On: https://review.openstack.org/566576","commit_id":"6f165674d343212ff3d344d47f4d2102a7cd073a"}],"tripleoclient/constants.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3d25ffd08faefb71cc57e855cdeaf45ba6687468","unresolved":false,"context_lines":[{"line_number":63,"context_line":"FFWD_UPGRADE_PREPARE_ENV \u003d \"environments/lifecycle/ffwd-upgrade-prepare.yaml\""},{"line_number":64,"context_line":"FFWD_UPGRADE_CONVERGE_ENV \u003d \"environments/lifecycle/ffwd-upgrade-converge.yaml\""},{"line_number":65,"context_line":"FFWD_UPGRADE_PREPARE_SCRIPT \u003d (\"#!/bin/bash \\n\""},{"line_number":66,"context_line":"                               \"rm /usr/libexec/os-apply-config/templates/etc/\""},{"line_number":67,"context_line":"                               \"os-net-config/config.json || true \\n\""},{"line_number":68,"context_line":"                               \"touch /root/marioswashere \\n\")"},{"line_number":69,"context_line":"CEPH_UPGRADE_PREPARE_ENV \u003d \"environments/lifecycle/ceph-upgrade-prepare.yaml\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9cbc7706","line":66,"range":{"start_line":66,"start_character":34,"end_line":66,"end_character":37},"updated":"2018-05-07 10:37:24.000000000","message":"make it -f","commit_id":"6f165674d343212ff3d344d47f4d2102a7cd073a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"14e7893e72666b9fcbf426d0e7320b3f9b844364","unresolved":false,"context_lines":[{"line_number":62,"context_line":"UPGRADE_CONVERGE_ENV \u003d \"environments/lifecycle/upgrade-converge.yaml\""},{"line_number":63,"context_line":"FFWD_UPGRADE_PREPARE_ENV \u003d \"environments/lifecycle/ffwd-upgrade-prepare.yaml\""},{"line_number":64,"context_line":"FFWD_UPGRADE_CONVERGE_ENV \u003d \"environments/lifecycle/ffwd-upgrade-converge.yaml\""},{"line_number":65,"context_line":"FFWD_UPGRADE_PREPARE_SCRIPT \u003d (\"#!/bin/bash \\n\""},{"line_number":66,"context_line":"                               \"rm -f /usr/libexec/os-apply-config/templates/\""},{"line_number":67,"context_line":"                               \"etc/os-net-config/config.json || true \\n\")"},{"line_number":68,"context_line":"CEPH_UPGRADE_PREPARE_ENV \u003d \"environments/lifecycle/ceph-upgrade-prepare.yaml\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_f89ee4b6","line":65,"updated":"2018-05-18 11:17:40.000000000","message":"I am not a fan of hardcoding this here; if the change is not urgent, can we make this point to a file and read its contents?","commit_id":"08360e466730598e9ca5f270798cb3a510a5c9ee"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"581fd6a0c51eb297526419d498c9eaccb101fa7e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                               \"etc/os-net-config/config.json || true \\n\")"},{"line_number":68,"context_line":"CEPH_UPGRADE_PREPARE_ENV \u003d \"environments/lifecycle/ceph-upgrade-prepare.yaml\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"ENABLE_SSH_ADMIN_TIMEOUT \u003d 300"},{"line_number":71,"context_line":"ENABLE_SSH_ADMIN_STATUS_INTERVAL \u003d 5"},{"line_number":72,"context_line":"ENABLE_SSH_ADMIN_SSH_PORT_TIMEOUT \u003d 300"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_25c43540","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":33},"updated":"2018-05-18 10:38:49.000000000","message":"if you are looking at https://review.openstack.org/#/c/566336/6..7/tripleoclient/constants.py this stuff is from rebase see https://review.openstack.org/#/c/566336/7/tripleoclient/constants.py","commit_id":"08360e466730598e9ca5f270798cb3a510a5c9ee"}],"tripleoclient/v1/overcloud_ffwd_upgrade.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"89273c776a56b6df76a66f9519f4833df9e7cf68","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # ffwd-upgrade \"init\" run command on overcloud nodes"},{"line_number":72,"context_line":"        print(\"mariosdebug: ABOUT TO INVOKE\")"},{"line_number":73,"context_line":"        package_update.run_on_nodes("},{"line_number":74,"context_line":"            clients, server_name\u003dstack_name,"},{"line_number":75,"context_line":"            config_name\u003d\u0027ffwd-upgrade-prepare\u0027,"},{"line_number":76,"context_line":"            config\u003dconstants.FFWD_UPGRADE_PREPARE_SCRIPT, group\u003d\u0027script\u0027,"},{"line_number":77,"context_line":"            queue_name\u003d\u0027tripleo\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3028e784","line":74,"range":{"start_line":74,"start_character":21,"end_line":74,"end_character":43},"updated":"2018-05-07 11:26:09.000000000","message":"this one we do need to add parameter for. it is matching with  \u0027nova list\u0027 here https://github.com/openstack/tripleo-common/blob/eb43cf0c2993cb20342ba04563866371ddec3773/workbooks/deployment.yaml#L74-L78\n\nso we need to allow some override incase nodes are called \"controller1,dbase1\" etc i.e. no \u0027overcloud\u0027 prefix.\n\ni think it has to be comma separated like --nova-name-common \"control,compute,\" or just --nova-name-common \"myovercloud-\" if that is a common prefix for all nova nodes (myovercloud-controller-1, myovercloud-compute-0 etc)","commit_id":"6f165674d343212ff3d344d47f4d2102a7cd073a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8d7928f303e7367ff62604fc6065e962d6450d73","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # ffwd-upgrade \"init\" run command on overcloud nodes"},{"line_number":72,"context_line":"        print(\"mariosdebug: ABOUT TO INVOKE\")"},{"line_number":73,"context_line":"        package_update.run_on_nodes("},{"line_number":74,"context_line":"            clients, server_name\u003dstack_name,"},{"line_number":75,"context_line":"            config_name\u003d\u0027ffwd-upgrade-prepare\u0027,"},{"line_number":76,"context_line":"            config\u003dconstants.FFWD_UPGRADE_PREPARE_SCRIPT, group\u003d\u0027script\u0027,"},{"line_number":77,"context_line":"            queue_name\u003d\u0027tripleo\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b0cf177e","line":74,"range":{"start_line":74,"start_character":21,"end_line":74,"end_character":43},"in_reply_to":"5f7c97a3_3028e784","updated":"2018-05-07 11:50:01.000000000","message":"no i am doing something else tripleo-common side so the operator doesn\u0027t need to know about this at all","commit_id":"6f165674d343212ff3d344d47f4d2102a7cd073a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"98bf9a57ed296ede0eb8b09081fae5b67d122cba","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # ffwd-upgrade \"init\" run command on overcloud nodes"},{"line_number":72,"context_line":"        print(\"mariosdebug: ABOUT TO INVOKE\")"},{"line_number":73,"context_line":"        package_update.run_on_nodes("},{"line_number":74,"context_line":"            clients, server_name\u003dstack_name,"},{"line_number":75,"context_line":"            config_name\u003d\u0027ffwd-upgrade-prepare\u0027,"},{"line_number":76,"context_line":"            config\u003dconstants.FFWD_UPGRADE_PREPARE_SCRIPT, group\u003d\u0027script\u0027,"},{"line_number":77,"context_line":"            queue_name\u003d\u0027tripleo\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_93046519","line":74,"range":{"start_line":74,"start_character":21,"end_line":74,"end_character":43},"in_reply_to":"5f7c97a3_b0cf177e","updated":"2018-05-07 13:16:00.000000000","message":"https://review.openstack.org/566576 we can set this to \u0027all\u0027","commit_id":"6f165674d343212ff3d344d47f4d2102a7cd073a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"89273c776a56b6df76a66f9519f4833df9e7cf68","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        package_update.run_on_nodes("},{"line_number":74,"context_line":"            clients, server_name\u003dstack_name,"},{"line_number":75,"context_line":"            config_name\u003d\u0027ffwd-upgrade-prepare\u0027,"},{"line_number":76,"context_line":"            config\u003dconstants.FFWD_UPGRADE_PREPARE_SCRIPT, group\u003d\u0027script\u0027,"},{"line_number":77,"context_line":"            queue_name\u003d\u0027tripleo\u0027)"},{"line_number":78,"context_line":"        print(\"mariosdebug: COMPLETED \")"},{"line_number":79,"context_line":"        import sys"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bc24d3c7","line":76,"range":{"start_line":76,"start_character":11,"end_line":76,"end_character":56},"updated":"2018-05-07 11:26:09.000000000","message":"i am updating this today and testing a little more on my pike environment. I was wondering if we want to make this configurable.\n\nI think we do not want this to be a general purpose \u0027run some configuration on your overcloud\u0027 (we already have \u0027openstack overcloud execute\u0027 for that see https://bugzilla.redhat.com/show_bug.cgi?id\u003d1561255#c5 for example)","commit_id":"6f165674d343212ff3d344d47f4d2102a7cd073a"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"0db4b6ec85d20d24198d24af41b1de9bae855310","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # ffwd-upgrade \"init\" run command on overcloud nodes"},{"line_number":72,"context_line":"        package_update.run_on_nodes("},{"line_number":73,"context_line":"            clients, server_name\u003d\u0027all\u0027,"},{"line_number":74,"context_line":"            config_name\u003d\u0027ffwd-upgrade-prepare\u0027,"},{"line_number":75,"context_line":"            config\u003dconstants.FFWD_UPGRADE_PREPARE_SCRIPT, group\u003d\u0027script\u0027,"},{"line_number":76,"context_line":"            queue_name\u003d\u0027tripleo\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_72e2ac31","line":73,"range":{"start_line":73,"start_character":21,"end_line":73,"end_character":38},"updated":"2018-05-09 15:26:41.000000000","message":"Can we try to scope this a little more? \u0027all\u0027 will break if there\u0027s more than 1 overcloud being managed, or if not all nova servers are in the overcloud.","commit_id":"f783f5e1d65eebd430ef56d8e2dae26537a2afa0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"05303a9feb5382e8b2ce5c60fe2e06a94155367f","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # ffwd-upgrade \"init\" run command on overcloud nodes"},{"line_number":72,"context_line":"        package_update.run_on_nodes("},{"line_number":73,"context_line":"            clients, server_name\u003d\u0027all\u0027,"},{"line_number":74,"context_line":"            config_name\u003d\u0027ffwd-upgrade-prepare\u0027,"},{"line_number":75,"context_line":"            config\u003dconstants.FFWD_UPGRADE_PREPARE_SCRIPT, group\u003d\u0027script\u0027,"},{"line_number":76,"context_line":"            queue_name\u003d\u0027tripleo\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_99119b60","line":73,"range":{"start_line":73,"start_character":21,"end_line":73,"end_character":38},"in_reply_to":"5f7c97a3_72e2ac31","updated":"2018-05-10 09:12:47.000000000","message":"right, as discussed in https://review.openstack.org/#/c/566576/1/workbooks/deployment.yaml on the tripleo-common side, that is true but not for OSP10 afaik which is where we need this.\n\nhow would you propose we scope it though, do you mean instaed of calling it \u0027all\u0027 call it \u0027all_nova\u0027 ? but really then it is about making the mistral side do more than just query nova list, which is valid but not immediately useful for the current FFU 10-13","commit_id":"f783f5e1d65eebd430ef56d8e2dae26537a2afa0"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f502e83a327b24a2403988019e97f818e5a7012d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            clients, server_name\u003d\u0027all\u0027,"},{"line_number":74,"context_line":"            config_name\u003d\u0027ffwd-upgrade-prepare\u0027,"},{"line_number":75,"context_line":"            config\u003dconstants.FFWD_UPGRADE_PREPARE_SCRIPT, group\u003d\u0027script\u0027,"},{"line_number":76,"context_line":"            queue_name\u003d\u0027tripleo\u0027)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        registry \u003d oooutils.load_container_registry("},{"line_number":79,"context_line":"            self.log, parsed_args.container_registry_file)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1229f888","line":76,"updated":"2018-05-09 15:21:08.000000000","message":"Is this queue suposed to be tripleo for a reason? or could it be constants.FFWD_UPGRADE_QUEUE?","commit_id":"f783f5e1d65eebd430ef56d8e2dae26537a2afa0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"05303a9feb5382e8b2ce5c60fe2e06a94155367f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            clients, server_name\u003d\u0027all\u0027,"},{"line_number":74,"context_line":"            config_name\u003d\u0027ffwd-upgrade-prepare\u0027,"},{"line_number":75,"context_line":"            config\u003dconstants.FFWD_UPGRADE_PREPARE_SCRIPT, group\u003d\u0027script\u0027,"},{"line_number":76,"context_line":"            queue_name\u003d\u0027tripleo\u0027)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        registry \u003d oooutils.load_container_registry("},{"line_number":79,"context_line":"            self.log, parsed_args.container_registry_file)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b916d754","line":76,"in_reply_to":"5f7c97a3_1229f888","updated":"2018-05-10 09:12:47.000000000","message":"right i can update this thanks","commit_id":"f783f5e1d65eebd430ef56d8e2dae26537a2afa0"}],"tripleoclient/workflows/package_update.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b449bb2de0aea5af6fdcc1b9a51a0beb389730aa","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            workflow_client,"},{"line_number":182,"context_line":"            \u0027tripleo.deployment.v1.deploy_on_servers\u0027,"},{"line_number":183,"context_line":"            workflow_input\u003dworkflow_input"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":"        for payload in base.wait_for_messages(workflow_client, ws, execution):"},{"line_number":186,"context_line":"            if payload[\u0027status\u0027] \u003d\u003d \"SUCCESS\":"},{"line_number":187,"context_line":"                print(\u0027Success\u0027)"},{"line_number":188,"context_line":"                break"},{"line_number":189,"context_line":"            elif payload[\u0027status\u0027] \u003d\u003d \"FAILED\":"},{"line_number":190,"context_line":"                raise RuntimeError(\u0027run on nodes failed: {}\u0027.format(payload))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5cc33fee","line":190,"range":{"start_line":184,"start_character":4,"end_line":190,"end_character":77},"updated":"2018-05-07 11:10:18.000000000","message":"update incoming","commit_id":"6f165674d343212ff3d344d47f4d2102a7cd073a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"59a726a5cdc3ed38000141620e2d61be7c723dfc","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":176,"context_line":"    tripleoclients \u003d clients.tripleoclient"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    with tripleoclients.messaging_websocket() as ws:"},{"line_number":179,"context_line":"        execution \u003d base.start_workflow("},{"line_number":180,"context_line":"            workflow_client,"},{"line_number":181,"context_line":"            \u0027tripleo.deployment.v1.deploy_on_servers\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_eed4284a","line":178,"range":{"start_line":178,"start_character":43,"end_line":178,"end_character":46},"updated":"2018-05-15 12:09:51.000000000","message":"there is a nit here I am not using the right queue... since it was updated to use the correct ffu queue in v3 https://review.openstack.org/#/c/566336/2..3/tripleoclient/v1/overcloud_ffwd_upgrade.py@76\n\nthis is very likely related to what mcornea was seeing, though he also has other issues on his environment (db connection problems). \n\nwith this fixed it works ok in my env (full disclaimer... iadded an \u0027sys.exit(0)\u0027 just after the run_on_nodes:\n\n(undercloud) [stack@521-m--undercloud ~]$ openstack overcloud ffwd-upgrade prepare\nWarning! The TripleO Fast Forward Upgrade workflow is currently considered under development. In particular invocations of the ffwd-upgrade cli should be initially limited to development/test environments. Once and if you decide to use ffwd-upgrade in production, ensure you are adequately prepared with valid backup of your current deployment state.\nProceed with the fast forward upgrade? Type \u0027yes\u0027 to continue and anything else to cancel. Consider using the --yes parameter if you wish to skip this warning in future. yes\nStarted Mistral Workflow tripleo.deployment.v1.deploy_on_servers. Execution ID: 5026ed54-47f2-4792-8cd6-508ef2e0d3d0\nWaiting for messages on queue \u0027ffwdupgrade\u0027 with no timeout.\nSuccess","commit_id":"9f5d374804b6022ad58d4458bf2ffbd8a91ee978"}]}