)]}'
{"tripleoclient/tests/v1/overcloud_ffwd_upgrade/test_overcloud_ffwd_upgrade.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c95caf483c4025af397caeb97bcf3a530df4aa04","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def test_ffwd_upgrade_playbook("},{"line_number":150,"context_line":"            self, mock_open, mock_execute, mock_expanduser, upgrade_ansible):"},{"line_number":151,"context_line":"        mock_expanduser.return_value \u003d \u0027/home/fake/\u0027"},{"line_number":152,"context_line":"        argslist \u003d [\u0027--ssh-user\u0027,\u0027heat-admin\u0027,\u0027--yes\u0027]"},{"line_number":153,"context_line":"        verifylist \u003d [(\u0027ssh_user\u0027, \u0027heat-admin\u0027),(\u0027yes\u0027, True), ]"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, argslist, verifylist)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_45f6e4fb","line":152,"range":{"start_line":152,"start_character":34,"end_line":152,"end_character":44},"updated":"2018-05-08 15:37:42.000000000","message":"lets add another that isn\u0027t the default too\n\nalso pep8 missing whitespace","commit_id":"5fe7fdcffa6315fb9c174939e38e6420868fcc97"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c95caf483c4025af397caeb97bcf3a530df4aa04","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            self, mock_open, mock_execute, mock_expanduser, upgrade_ansible):"},{"line_number":151,"context_line":"        mock_expanduser.return_value \u003d \u0027/home/fake/\u0027"},{"line_number":152,"context_line":"        argslist \u003d [\u0027--ssh-user\u0027,\u0027heat-admin\u0027,\u0027--yes\u0027]"},{"line_number":153,"context_line":"        verifylist \u003d [(\u0027ssh_user\u0027, \u0027heat-admin\u0027),(\u0027yes\u0027, True), ]"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, argslist, verifylist)"},{"line_number":156,"context_line":"        with mock.patch(\u0027os.path.exists\u0027) as mock_exists:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e5f850c5","line":153,"range":{"start_line":153,"start_character":48,"end_line":153,"end_character":50},"updated":"2018-05-08 15:37:42.000000000","message":"kpep8","commit_id":"5fe7fdcffa6315fb9c174939e38e6420868fcc97"}],"tripleoclient/v1/overcloud_ffwd_upgrade.py":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ad5f5de75557176db422754a99d31996776878e8","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        oooutils.ffwd_upgrade_operator_confirm(parsed_args.yes, self.log)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        clients \u003d self.app.client_manager"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # Run ansible:"},{"line_number":152,"context_line":"        inventory \u003d oooutils.get_tripleo_ansible_inventory("},{"line_number":153,"context_line":"            inventory_file\u003dparsed_args.static_inventory,"},{"line_number":154,"context_line":"            ssh_user\u003dparsed_args.ssh_user, stack\u003dparsed_args.stack)"},{"line_number":155,"context_line":"        # Don\u0027t expost limit_hosts. We need this on the whole overcloud."},{"line_number":156,"context_line":"        limit_hosts \u003d \u0027\u0027"},{"line_number":157,"context_line":"        oooutils.run_update_ansible_action("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_8ff9604e","line":154,"range":{"start_line":150,"start_character":0,"end_line":154,"end_character":67},"updated":"2018-05-09 14:36:22.000000000","message":"This is effectively a no-op edit, just shuffling variable naming, no?","commit_id":"9c9a197f29728e3ab1115813e6c3d9036a194bfe"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"d2079a40748ac5a88e3863cd74f398d62bfc1cd5","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        oooutils.ffwd_upgrade_operator_confirm(parsed_args.yes, self.log)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        clients \u003d self.app.client_manager"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # Run ansible:"},{"line_number":152,"context_line":"        inventory \u003d oooutils.get_tripleo_ansible_inventory("},{"line_number":153,"context_line":"            inventory_file\u003dparsed_args.static_inventory,"},{"line_number":154,"context_line":"            ssh_user\u003dparsed_args.ssh_user, stack\u003dparsed_args.stack)"},{"line_number":155,"context_line":"        # Don\u0027t expost limit_hosts. We need this on the whole overcloud."},{"line_number":156,"context_line":"        limit_hosts \u003d \u0027\u0027"},{"line_number":157,"context_line":"        oooutils.run_update_ansible_action("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_af777cd4","line":154,"range":{"start_line":150,"start_character":0,"end_line":154,"end_character":67},"in_reply_to":"5f7c97a3_8ff9604e","updated":"2018-05-09 14:39:27.000000000","message":"We can still land this as a refactor if you want, but we should at least sync the commit message with what this does. (And this doesn\u0027t need to be backported i think.)","commit_id":"9c9a197f29728e3ab1115813e6c3d9036a194bfe"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"426d1fcd5cadca1a9da99be586e256a0bad58922","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        oooutils.ffwd_upgrade_operator_confirm(parsed_args.yes, self.log)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        clients \u003d self.app.client_manager"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # Run ansible:"},{"line_number":152,"context_line":"        inventory \u003d oooutils.get_tripleo_ansible_inventory("},{"line_number":153,"context_line":"            inventory_file\u003dparsed_args.static_inventory,"},{"line_number":154,"context_line":"            ssh_user\u003dparsed_args.ssh_user, stack\u003dparsed_args.stack)"},{"line_number":155,"context_line":"        # Don\u0027t expost limit_hosts. We need this on the whole overcloud."},{"line_number":156,"context_line":"        limit_hosts \u003d \u0027\u0027"},{"line_number":157,"context_line":"        oooutils.run_update_ansible_action("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_8f139f5c","line":154,"range":{"start_line":150,"start_character":0,"end_line":154,"end_character":67},"in_reply_to":"5f7c97a3_af777cd4","updated":"2018-05-09 14:43:57.000000000","message":"Yeah, but it was actually my mistake I shouldn\u0027t have pushed the fix over this one.\nIll change the commit message, still, can we backport this to stable/queens for having the unit tests correctly?","commit_id":"9c9a197f29728e3ab1115813e6c3d9036a194bfe"}]}