)]}'
{"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"c3f7b6231cbf726a02e816d7a529dab3357456df","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        return \"%s/%s\" % (stack_name, stack_id)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def _download_ansible_playbooks(self, client, stack_name,"},{"line_number":496,"context_line":"                                    tripleo_role_name\u003d\u0027Undercloud\u0027):"},{"line_number":497,"context_line":"        stack_config \u003d config.Config(client)"},{"line_number":498,"context_line":"        self._create_working_dirs()"},{"line_number":499,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_4516e457","line":496,"range":{"start_line":496,"start_character":55,"end_line":496,"end_character":65},"updated":"2018-05-22 07:15:07.000000000","message":"The default value provided for _process_hieradata_overrides function is \"Standalone\" and the default value of the parameter is also \"Standalone\". Having the default as \"Undercloud\" creates confusion on why is it so? Event though the value is passed for all these functions, having same default value is correct in all functions. WDYT?","commit_id":"c015df8a3f37792503ccb63d936fb3080a5c18b4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7778b6d40318c5dff5d6e34b2344e5ff041757f3","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        return \"%s/%s\" % (stack_name, stack_id)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def _download_ansible_playbooks(self, client, stack_name,"},{"line_number":496,"context_line":"                                    tripleo_role_name\u003d\u0027Undercloud\u0027):"},{"line_number":497,"context_line":"        stack_config \u003d config.Config(client)"},{"line_number":498,"context_line":"        self._create_working_dirs()"},{"line_number":499,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ea281898","line":496,"range":{"start_line":496,"start_character":55,"end_line":496,"end_character":65},"in_reply_to":"5f7c97a3_4516e457","updated":"2018-05-22 13:19:05.000000000","message":"Because we\u0027ve hard coded undercloud as the stack name (yet to be configurable). So this is techincally the default for the containerized undercloud at the moment. Until we properly support the standalone method, I\u0027m trying to make smaller iterative patches to make sure we don\u0027t break the undercloud install.  I\u0027ll update this one I guess, it doesn\u0027t really matter at the moment because we provide the tripleo_role_name everywhere","commit_id":"c015df8a3f37792503ccb63d936fb3080a5c18b4"}]}