)]}'
{"releasenotes/notes/use_heat-d0ff532588200051.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ae7e2b54eaf1bb9abeb333282837c06d1365720c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    upgrade`` command (same as before)."},{"line_number":11,"context_line":"deprecations:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    The \u0027--use-heat\u0027 parameter is now deprecated and will be removed in Stein."},{"line_number":14,"context_line":"other:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    A new parameter was added for Rocky, \u0027--use-instack\u0027 so deployers can"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_b099416e","line":13,"updated":"2018-06-19 06:05:13.000000000","message":"IIRC it was introduced for Rocky and had been yet ever release, so no need to deprecate it","commit_id":"d379a90cb6c89f8375f337e39100db9cfe31b906"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"daef56db8c70347813604906238fcb034afa35b5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    upgrade`` command (same as before)."},{"line_number":11,"context_line":"deprecations:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    The \u0027--use-heat\u0027 parameter is now deprecated and will be removed in Stein."},{"line_number":14,"context_line":"other:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    A new parameter was added for Rocky, \u0027--use-instack\u0027 so deployers can"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_911a067a","line":13,"in_reply_to":"5f7c97a3_b099416e","updated":"2018-06-19 09:10:53.000000000","message":"https://github.com/openstack/python-tripleoclient/blob/stable/queens/tripleoclient/v1/undercloud.py\n\nIt is in queens too.","commit_id":"d379a90cb6c89f8375f337e39100db9cfe31b906"}],"tripleoclient/tests/v1/undercloud/test_undercloud.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"65354d103933d6a8c653c0ce1cad5d4f3df881e2","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    def test_undercloud_install_with_heat_(self, mock_subprocess,"},{"line_number":343,"context_line":"                                           mock_cwd, mock_wr,"},{"line_number":344,"context_line":"                                           mock_os):"},{"line_number":345,"context_line":"        arglist \u003d [\u0027--use-heat\u0027, \u0027--no-validations\u0027]"},{"line_number":346,"context_line":"        verifylist \u003d []"},{"line_number":347,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_70c40942","line":345,"range":{"start_line":345,"start_character":20,"end_line":345,"end_character":30},"updated":"2018-06-19 06:07:28.000000000","message":"ditto, we can let it go, it had yet been released","commit_id":"d379a90cb6c89f8375f337e39100db9cfe31b906"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9c844e4d4e7611cfd0b9619fe193e38c0c027ddb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.cmd \u003d undercloud.InstallUndercloud(self.app, app_args)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @mock.patch(\u0027subprocess.check_call\u0027, autospec\u003dTrue)"},{"line_number":51,"context_line":"    def test_undercloud_install_default(self, mock_subprocess):"},{"line_number":52,"context_line":"        arglist \u003d []"},{"line_number":53,"context_line":"        verifylist \u003d []"},{"line_number":54,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_3b6f9fc5","side":"PARENT","line":51,"updated":"2018-07-10 22:03:25.000000000","message":"We likely should update this test to check that it matches test_undercloud_install_heat_customized (without the customization)","commit_id":"5db4ef9a0d9e6dc912c4f762247805634191709b"}],"tripleoclient/v1/undercloud.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9551d164d3756e7ebf7e39a8f5f5f35f6dcdb01","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            help\u003d_(\"Perform undercloud deploy using instack-undercloud.\""},{"line_number":56,"context_line":"                   \"This argument will only be supported in Rocky as we \""},{"line_number":57,"context_line":"                   \" moved to the containerized undercloud.\"),"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027--no-validations\u0027,"},{"line_number":61,"context_line":"            dest\u003d\u0027no_validations\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_a082eac5","line":58,"updated":"2018-06-23 11:15:37.000000000","message":"nit: you can add these arguments to a mutually exclusive group to avoid users specifying both","commit_id":"3aaf5b7fa861c5de4ab545b07ff78d996a95fe20"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e512f1faab60143b0b4fe257408fabdf25ec35f6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            help\u003d_(\"Perform undercloud deploy using instack-undercloud.\""},{"line_number":56,"context_line":"                   \"This argument will only be supported in Rocky as we \""},{"line_number":57,"context_line":"                   \" moved to the containerized undercloud.\"),"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027--no-validations\u0027,"},{"line_number":61,"context_line":"            dest\u003d\u0027no_validations\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_bf2deefd","line":58,"in_reply_to":"5f7c97a3_a082eac5","updated":"2018-06-26 23:13:01.000000000","message":"Done","commit_id":"3aaf5b7fa861c5de4ab545b07ff78d996a95fe20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9551d164d3756e7ebf7e39a8f5f5f35f6dcdb01","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        if parsed_args.use_instack:"},{"line_number":118,"context_line":"            self.log.warning(_(\u0027Non-containerized undercloud deployment is \u0027"},{"line_number":119,"context_line":"                               \u0027deprecated in Rocky cycle. Upgrades using \u0027"},{"line_number":120,"context_line":"                               \u0027instack-undercloud are not supported.\u0027))"},{"line_number":121,"context_line":"            subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027update\u0027, \u0027-y\u0027,"},{"line_number":122,"context_line":"                                  \u0027instack-undercloud\u0027])"},{"line_number":123,"context_line":"            subprocess.check_call(\"instack-pre-upgrade-undercloud\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_406bd61d","line":120,"updated":"2018-06-23 11:15:37.000000000","message":"should we even try them?","commit_id":"3aaf5b7fa861c5de4ab545b07ff78d996a95fe20"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e512f1faab60143b0b4fe257408fabdf25ec35f6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        if parsed_args.use_instack:"},{"line_number":118,"context_line":"            self.log.warning(_(\u0027Non-containerized undercloud deployment is \u0027"},{"line_number":119,"context_line":"                               \u0027deprecated in Rocky cycle. Upgrades using \u0027"},{"line_number":120,"context_line":"                               \u0027instack-undercloud are not supported.\u0027))"},{"line_number":121,"context_line":"            subprocess.check_call([\u0027sudo\u0027, \u0027yum\u0027, \u0027update\u0027, \u0027-y\u0027,"},{"line_number":122,"context_line":"                                  \u0027instack-undercloud\u0027])"},{"line_number":123,"context_line":"            subprocess.check_call(\"instack-pre-upgrade-undercloud\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_5f305a55","line":120,"in_reply_to":"5f7c97a3_406bd61d","updated":"2018-06-26 23:13:01.000000000","message":"we shouldn\u0027t completely break it, it\u0027s likely to still work.","commit_id":"3aaf5b7fa861c5de4ab545b07ff78d996a95fe20"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9c844e4d4e7611cfd0b9619fe193e38c0c027ddb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        utils.ensure_run_as_normal_user()"},{"line_number":91,"context_line":"        if parsed_args.use_heat is not None:"},{"line_number":92,"context_line":"            self.log.warning(\u0027--use-heat is deprecated in Rocky\u0027)"},{"line_number":93,"context_line":"        # NOTE(EvilienM): For backwards compatibility until CI has been"},{"line_number":94,"context_line":"        # switched we need to still run instack-undercloud when --use-heat"},{"line_number":95,"context_line":"        # is not provided. This will be removed in a follow up patch"},{"line_number":96,"context_line":"        # once CI has been converted to pass in --use-heat\u003dFalse"},{"line_number":97,"context_line":"        if parsed_args.use_heat is not None and \\"},{"line_number":98,"context_line":"                parsed_args.use_heat.lower() \u003d\u003d \"false\":"},{"line_number":99,"context_line":"            self.log.warning(_(\u0027Non-containerized undercloud deployment is \u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_9b16f34a","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":64},"updated":"2018-07-10 22:03:25.000000000","message":"You can drop the comment in this patch","commit_id":"77443da0b25494429ca1f9cee5f995612029002d"}]}