)]}'
{"releasenotes/notes/overcloud-node-bios-c9ae89e35a96c7b1.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e782f7417ce3d02de6b2548827a0f4489ffb9549","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        openstack overcloud node bios configure --configuration \u003c..\u003e [--all-manageable|uuid1,uuid2,..]"},{"line_number":7,"context_line":"        openstack overcloud node bios reset [--all-manageable|uuid1,uuid2,..]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    The first command configures given BIOS settings on given nodes or all manageable nodes;"},{"line_number":10,"context_line":"    the second command reset BIOS settings to factory default on given nodes or all manageable nodes."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_0f71d0a8","line":10,"range":{"start_line":9,"start_character":4,"end_line":10,"end_character":101},"updated":"2018-06-20 08:28:39.000000000","message":"nit: linebreaks to stay below 80 chars per line.","commit_id":"550fcb1560fe8b2e505d547a61de58adffde11ad"},{"author":{"_account_id":21151,"name":"zenghui.shi","email":"zshi@redhat.com","username":"zshi"},"change_message_id":"a21035c5bc146685974453bc6c95e3816250b431","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        openstack overcloud node bios configure --configuration \u003c..\u003e [--all-manageable|uuid1,uuid2,..]"},{"line_number":7,"context_line":"        openstack overcloud node bios reset [--all-manageable|uuid1,uuid2,..]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    The first command configures given BIOS settings on given nodes or all manageable nodes;"},{"line_number":10,"context_line":"    the second command reset BIOS settings to factory default on given nodes or all manageable nodes."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_6ba7eaa9","line":10,"range":{"start_line":9,"start_character":4,"end_line":10,"end_character":101},"in_reply_to":"5f7c97a3_0f71d0a8","updated":"2018-06-22 03:39:56.000000000","message":"Done","commit_id":"550fcb1560fe8b2e505d547a61de58adffde11ad"}],"setup.cfg":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e6745769aa456c87cadb15c70a5f2aa9d0da0e52","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    overcloud_profiles_match \u003d tripleoclient.v1.overcloud_profiles:MatchProfiles"},{"line_number":79,"context_line":"    overcloud_profiles_list \u003d tripleoclient.v1.overcloud_profiles:ListProfiles"},{"line_number":80,"context_line":"    overcloud_raid_create \u003d tripleoclient.v1.overcloud_raid:CreateRAID"},{"line_number":81,"context_line":"    overcloud_bios_configure \u003d tripleoclient.v1.overcloud_bios:ConfigureBIOS"},{"line_number":82,"context_line":"    overcloud_bios_reset \u003d tripleoclient.v1.overcloud_bios:ResetBIOS"},{"line_number":83,"context_line":"    overcloud_role_show\u003d tripleoclient.v1.overcloud_roles:RoleShow"},{"line_number":84,"context_line":"    overcloud_role_list \u003d tripleoclient.v1.overcloud_roles:RoleList"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"5f7c97a3_7f14d19f","line":81,"updated":"2018-06-19 10:17:31.000000000","message":"should be overcloud_node_bios_configure and overcloud_node_bios_reset","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"},{"author":{"_account_id":21151,"name":"zenghui.shi","email":"zshi@redhat.com","username":"zshi"},"change_message_id":"acebb34b259497961a43baa046de4b4b9f3b6e87","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    overcloud_profiles_match \u003d tripleoclient.v1.overcloud_profiles:MatchProfiles"},{"line_number":79,"context_line":"    overcloud_profiles_list \u003d tripleoclient.v1.overcloud_profiles:ListProfiles"},{"line_number":80,"context_line":"    overcloud_raid_create \u003d tripleoclient.v1.overcloud_raid:CreateRAID"},{"line_number":81,"context_line":"    overcloud_bios_configure \u003d tripleoclient.v1.overcloud_bios:ConfigureBIOS"},{"line_number":82,"context_line":"    overcloud_bios_reset \u003d tripleoclient.v1.overcloud_bios:ResetBIOS"},{"line_number":83,"context_line":"    overcloud_role_show\u003d tripleoclient.v1.overcloud_roles:RoleShow"},{"line_number":84,"context_line":"    overcloud_role_list \u003d tripleoclient.v1.overcloud_roles:RoleList"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"5f7c97a3_7b64d321","line":81,"in_reply_to":"5f7c97a3_7f14d19f","updated":"2018-06-20 03:43:51.000000000","message":"Done","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"}],"tripleoclient/v1/overcloud_bios.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e6745769aa456c87cadb15c70a5f2aa9d0da0e52","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super(ConfigureBIOS, self).get_parser(prog_name)"},{"line_number":33,"context_line":"        parser.add_argument(\u0027--node\u0027, action\u003d\u0027append\u0027, required\u003dTrue,"},{"line_number":34,"context_line":"                            help\u003d_(\u0027Nodes to Configure BIOS on (expected \u0027"},{"line_number":35,"context_line":"                                   \u0027to be in manageable state). Can be \u0027"},{"line_number":36,"context_line":"                                   \u0027specified multiple times.\u0027))"},{"line_number":37,"context_line":"        parser.add_argument(\u0027configuration\u0027,"},{"line_number":38,"context_line":"                            help\u003d_(\u0027BIOS configuration (YAML/JSON string or \u0027"},{"line_number":39,"context_line":"                                   \u0027file name).\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3f35f945","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":64},"updated":"2018-06-19 10:17:31.000000000","message":"Please change the interface to be the same as for CleanNode and some other: https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/overcloud_node.py#L133-L142. I.e.\n\n overcloud node bios configure --configuration \u003c..\u003e \u003cnode1\u003e \u003cnode2\u003e ...","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"},{"author":{"_account_id":21151,"name":"zenghui.shi","email":"zshi@redhat.com","username":"zshi"},"change_message_id":"acebb34b259497961a43baa046de4b4b9f3b6e87","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super(ConfigureBIOS, self).get_parser(prog_name)"},{"line_number":33,"context_line":"        parser.add_argument(\u0027--node\u0027, action\u003d\u0027append\u0027, required\u003dTrue,"},{"line_number":34,"context_line":"                            help\u003d_(\u0027Nodes to Configure BIOS on (expected \u0027"},{"line_number":35,"context_line":"                                   \u0027to be in manageable state). Can be \u0027"},{"line_number":36,"context_line":"                                   \u0027specified multiple times.\u0027))"},{"line_number":37,"context_line":"        parser.add_argument(\u0027configuration\u0027,"},{"line_number":38,"context_line":"                            help\u003d_(\u0027BIOS configuration (YAML/JSON string or \u0027"},{"line_number":39,"context_line":"                                   \u0027file name).\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7bf1336a","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":64},"in_reply_to":"5f7c97a3_3f35f945","updated":"2018-06-20 03:43:51.000000000","message":"Done","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e6745769aa456c87cadb15c70a5f2aa9d0da0e52","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def get_parser(self, prog_name):"},{"line_number":85,"context_line":"        parser \u003d super(ResetBIOS, self).get_parser(prog_name)"},{"line_number":86,"context_line":"        parser.add_argument(\u0027--node\u0027, action\u003d\u0027append\u0027, required\u003dTrue,"},{"line_number":87,"context_line":"                            help\u003d_(\u0027Nodes to Reset BIOS on (expected \u0027"},{"line_number":88,"context_line":"                                   \u0027to be in manageable state). Can be \u0027"},{"line_number":89,"context_line":"                                   \u0027specified multiple times.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ff36a14f","line":86,"range":{"start_line":86,"start_character":29,"end_line":86,"end_character":35},"updated":"2018-06-19 10:17:31.000000000","message":"ditto","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"},{"author":{"_account_id":21151,"name":"zenghui.shi","email":"zshi@redhat.com","username":"zshi"},"change_message_id":"acebb34b259497961a43baa046de4b4b9f3b6e87","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def get_parser(self, prog_name):"},{"line_number":85,"context_line":"        parser \u003d super(ResetBIOS, self).get_parser(prog_name)"},{"line_number":86,"context_line":"        parser.add_argument(\u0027--node\u0027, action\u003d\u0027append\u0027, required\u003dTrue,"},{"line_number":87,"context_line":"                            help\u003d_(\u0027Nodes to Reset BIOS on (expected \u0027"},{"line_number":88,"context_line":"                                   \u0027to be in manageable state). Can be \u0027"},{"line_number":89,"context_line":"                                   \u0027specified multiple times.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1be83f7a","line":86,"range":{"start_line":86,"start_character":29,"end_line":86,"end_character":35},"in_reply_to":"5f7c97a3_ff36a14f","updated":"2018-06-20 03:43:51.000000000","message":"Done","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8f0d7ee0d803799b944db9791fee586fc91dd70b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                  \"\u0027manageable\u0027 state\"))"},{"line_number":44,"context_line":"        parser.add_argument(\u0027--configuration\u0027, metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":45,"context_line":"                            dest\u003d\u0027configuration\u0027,"},{"line_number":46,"context_line":"                            help\u003d_(\u0027BIOS configuration (YAML/JSON string or \u0027"},{"line_number":47,"context_line":"                                   \u0027file name).\u0027))"},{"line_number":48,"context_line":"        return parser"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_7b71d343","line":46,"updated":"2018-08-14 11:03:03.000000000","message":"Any valid JSON is also valid YAML. We use this property in a few places, I think.","commit_id":"938f146df4e44368a1373c8c2868d158cc81c655"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"7284f8eede2798289725d25baea685a727d16413","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                  \"\u0027manageable\u0027 state\"))"},{"line_number":44,"context_line":"        parser.add_argument(\u0027--configuration\u0027, metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":45,"context_line":"                            dest\u003d\u0027configuration\u0027,"},{"line_number":46,"context_line":"                            help\u003d_(\u0027BIOS configuration (YAML/JSON string or \u0027"},{"line_number":47,"context_line":"                                   \u0027file name).\u0027))"},{"line_number":48,"context_line":"        return parser"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7fa48c4c","line":46,"updated":"2018-07-17 17:49:26.000000000","message":"is this supposed to support JSON? I don\u0027t see how the code handles JSON.","commit_id":"938f146df4e44368a1373c8c2868d158cc81c655"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"745f9cc67c59063d17cfeea7f9b92b79f83c78bd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                  \"\u0027manageable\u0027 state\"))"},{"line_number":44,"context_line":"        parser.add_argument(\u0027--configuration\u0027, metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":45,"context_line":"                            dest\u003d\u0027configuration\u0027,"},{"line_number":46,"context_line":"                            help\u003d_(\u0027BIOS configuration (YAML/JSON string or \u0027"},{"line_number":47,"context_line":"                                   \u0027file name).\u0027))"},{"line_number":48,"context_line":"        return parser"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_e299c21e","line":46,"in_reply_to":"3f79a3b5_7b71d343","updated":"2019-02-27 10:49:52.000000000","message":"I agree with Dmitry, we even have places where we drop json into files with .yaml extensions relying on JSON also being valid YAML.","commit_id":"938f146df4e44368a1373c8c2868d158cc81c655"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"57dd418c6a850657681e395483a249dd1aacd34c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                  \"\u0027manageable\u0027 state\"))"},{"line_number":44,"context_line":"        parser.add_argument(\u0027--configuration\u0027, metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":45,"context_line":"                            dest\u003d\u0027configuration\u0027,"},{"line_number":46,"context_line":"                            help\u003d_(\u0027BIOS configuration (YAML/JSON string or \u0027"},{"line_number":47,"context_line":"                                   \u0027file name).\u0027))"},{"line_number":48,"context_line":"        return parser"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b5aaf1ce","line":46,"in_reply_to":"9fdfeff1_e299c21e","updated":"2019-02-28 12:29:43.000000000","message":"ok, makes sense then.","commit_id":"938f146df4e44368a1373c8c2868d158cc81c655"}],"tripleoclient/workflows/baremetal.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e6745769aa456c87cadb15c70a5f2aa9d0da0e52","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        )"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        for payload in base.wait_for_messages(workflow_client, ws, execution):"},{"line_number":416,"context_line":"            if \u0027message\u0027 in payload:"},{"line_number":417,"context_line":"                print(payload[\u0027message\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    if payload[\u0027status\u0027] \u003d\u003d \u0027SUCCESS\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bf1909d2","line":416,"updated":"2018-06-19 10:17:31.000000000","message":"please check that the message is not empty, e.g. as in https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/workflows/baremetal.py#L359","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"},{"author":{"_account_id":21151,"name":"zenghui.shi","email":"zshi@redhat.com","username":"zshi"},"change_message_id":"acebb34b259497961a43baa046de4b4b9f3b6e87","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        )"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        for payload in base.wait_for_messages(workflow_client, ws, execution):"},{"line_number":416,"context_line":"            if \u0027message\u0027 in payload:"},{"line_number":417,"context_line":"                print(payload[\u0027message\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    if payload[\u0027status\u0027] \u003d\u003d \u0027SUCCESS\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7b9613f2","line":416,"in_reply_to":"5f7c97a3_bf1909d2","updated":"2018-06-20 03:43:51.000000000","message":"Done","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e6745769aa456c87cadb15c70a5f2aa9d0da0e52","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        )"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        for payload in base.wait_for_messages(workflow_client, ws, execution):"},{"line_number":445,"context_line":"            if \u0027message\u0027 in payload:"},{"line_number":446,"context_line":"                print(payload[\u0027message\u0027])"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    if payload[\u0027status\u0027] \u003d\u003d \u0027SUCCESS\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5f76b50e","line":445,"updated":"2018-06-19 10:17:31.000000000","message":"ditto","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"},{"author":{"_account_id":21151,"name":"zenghui.shi","email":"zshi@redhat.com","username":"zshi"},"change_message_id":"acebb34b259497961a43baa046de4b4b9f3b6e87","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        )"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        for payload in base.wait_for_messages(workflow_client, ws, execution):"},{"line_number":445,"context_line":"            if \u0027message\u0027 in payload:"},{"line_number":446,"context_line":"                print(payload[\u0027message\u0027])"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    if payload[\u0027status\u0027] \u003d\u003d \u0027SUCCESS\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5b931701","line":445,"in_reply_to":"5f7c97a3_5f76b50e","updated":"2018-06-20 03:43:51.000000000","message":"Done","commit_id":"045cdd80d8a021634042b663d51ccfd057e10365"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"53522e956116c8b6a597e641ec0593b01fe27559","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":404,"context_line":"    ooo_client \u003d clients.tripleoclient"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    print(\u0027Applying BIOS settings for given nodes, this may take time\u0027)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    with ooo_client.messaging_websocket() as ws:"},{"line_number":409,"context_line":"        execution \u003d base.start_workflow("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_fe320c5e","line":406,"range":{"start_line":406,"start_character":38,"end_line":406,"end_character":43},"updated":"2018-06-20 06:44:53.000000000","message":"nit, you can specify the node uuids there","commit_id":"550fcb1560fe8b2e505d547a61de58adffde11ad"},{"author":{"_account_id":21151,"name":"zenghui.shi","email":"zshi@redhat.com","username":"zshi"},"change_message_id":"a9793d5f79bdbd202a6659abd2adbf01ef96b707","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":404,"context_line":"    ooo_client \u003d clients.tripleoclient"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    print(\u0027Applying BIOS settings for given nodes, this may take time\u0027)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    with ooo_client.messaging_websocket() as ws:"},{"line_number":409,"context_line":"        execution \u003d base.start_workflow("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_342985f1","line":406,"range":{"start_line":406,"start_character":38,"end_line":406,"end_character":43},"in_reply_to":"5f7c97a3_fe320c5e","updated":"2018-06-20 08:02:52.000000000","message":"yes, it could be, I noticed other methods don\u0027t print the actual node uuids, and there is a debug log for parsed_args which includes the node_uuids at the beginning of ConfigureBIOS/ResetBIOS.take_action() function.","commit_id":"550fcb1560fe8b2e505d547a61de58adffde11ad"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"53522e956116c8b6a597e641ec0593b01fe27559","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":434,"context_line":"    ooo_client \u003d clients.tripleoclient"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    print(\u0027Applying BIOS settings for given nodes, this may take time\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    with ooo_client.messaging_websocket() as ws:"},{"line_number":439,"context_line":"        execution \u003d base.start_workflow("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1e36e852","line":436,"range":{"start_line":436,"start_character":38,"end_line":436,"end_character":43},"updated":"2018-06-20 06:44:53.000000000","message":"nit, you can specify \"for all manageable nodes\" there","commit_id":"550fcb1560fe8b2e505d547a61de58adffde11ad"},{"author":{"_account_id":21151,"name":"zenghui.shi","email":"zshi@redhat.com","username":"zshi"},"change_message_id":"a9793d5f79bdbd202a6659abd2adbf01ef96b707","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":434,"context_line":"    ooo_client \u003d clients.tripleoclient"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    print(\u0027Applying BIOS settings for given nodes, this may take time\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    with ooo_client.messaging_websocket() as ws:"},{"line_number":439,"context_line":"        execution \u003d base.start_workflow("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_344bc55f","line":436,"range":{"start_line":436,"start_character":38,"end_line":436,"end_character":43},"in_reply_to":"5f7c97a3_1e36e852","updated":"2018-06-20 08:02:52.000000000","message":"yep, this should be all manageable nodes.","commit_id":"550fcb1560fe8b2e505d547a61de58adffde11ad"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"53522e956116c8b6a597e641ec0593b01fe27559","unresolved":false,"context_lines":[{"line_number":462,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":463,"context_line":"    ooo_client \u003d clients.tripleoclient"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    print(\u0027Reset BIOS settings on manageable nodes, this may take time\u0027)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    with ooo_client.messaging_websocket() as ws:"},{"line_number":468,"context_line":"        execution \u003d base.start_workflow("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5e15409a","line":465,"range":{"start_line":465,"start_character":34,"end_line":465,"end_character":44},"updated":"2018-06-20 06:44:53.000000000","message":"this is on manageable? should not be on specific nodes?","commit_id":"550fcb1560fe8b2e505d547a61de58adffde11ad"},{"author":{"_account_id":21151,"name":"zenghui.shi","email":"zshi@redhat.com","username":"zshi"},"change_message_id":"a9793d5f79bdbd202a6659abd2adbf01ef96b707","unresolved":false,"context_lines":[{"line_number":462,"context_line":"    workflow_client \u003d clients.workflow_engine"},{"line_number":463,"context_line":"    ooo_client \u003d clients.tripleoclient"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    print(\u0027Reset BIOS settings on manageable nodes, this may take time\u0027)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    with ooo_client.messaging_websocket() as ws:"},{"line_number":468,"context_line":"        execution \u003d base.start_workflow("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d434d1e1","line":465,"range":{"start_line":465,"start_character":34,"end_line":465,"end_character":44},"in_reply_to":"5f7c97a3_5e15409a","updated":"2018-06-20 08:02:52.000000000","message":"You\u0027re right, this should be specific nodes or given nodes.","commit_id":"550fcb1560fe8b2e505d547a61de58adffde11ad"}]}