)]}'
{"tripleoclient/tests/v1/undercloud/test_undercloud.py":[{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"521dede9fe3376e956d4dbe9495d9c144081700c","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def test_undercloud_install_with_heat_and_debug(self, mock_subprocess,"},{"line_number":282,"context_line":"                                                    mock_wr,"},{"line_number":283,"context_line":"                                                    mock_os, mock_open):"},{"line_number":284,"context_line":"        self.conf.config(undercloud_log_file\u003d\u0027/foo/bar\u0027)"},{"line_number":285,"context_line":"        arglist \u003d [\u0027--use-heat\u0027, \u0027--no-validations\u0027]"},{"line_number":286,"context_line":"        verifylist \u003d []"},{"line_number":287,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f30ea2e2","line":284,"updated":"2018-06-21 14:09:25.000000000","message":"Is this a reasonable name, even as a test junk name?","commit_id":"b9d551f38c8a0d09b0378e9a332d117ec69ef835"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7149db6084c45f871ebe9cff8d4d16a0f4260b62","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def test_undercloud_install_with_heat_and_debug(self, mock_subprocess,"},{"line_number":282,"context_line":"                                                    mock_wr,"},{"line_number":283,"context_line":"                                                    mock_os, mock_open):"},{"line_number":284,"context_line":"        self.conf.config(undercloud_log_file\u003d\u0027/foo/bar\u0027)"},{"line_number":285,"context_line":"        arglist \u003d [\u0027--use-heat\u0027, \u0027--no-validations\u0027]"},{"line_number":286,"context_line":"        verifylist \u003d []"},{"line_number":287,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_529e5e06","line":284,"in_reply_to":"5f7c97a3_f30ea2e2","updated":"2018-06-22 10:13:57.000000000","message":"I think it\u0027s fine :) Would you prefer is as /foo/bar.log? :)","commit_id":"b9d551f38c8a0d09b0378e9a332d117ec69ef835"},{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"6493c5b4f19f7a3c7f85570b5e231b557a658ce6","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def test_undercloud_install_with_heat_and_debug(self, mock_subprocess,"},{"line_number":282,"context_line":"                                                    mock_wr,"},{"line_number":283,"context_line":"                                                    mock_os, mock_open):"},{"line_number":284,"context_line":"        self.conf.config(undercloud_log_file\u003d\u0027/foo/bar\u0027)"},{"line_number":285,"context_line":"        arglist \u003d [\u0027--use-heat\u0027, \u0027--no-validations\u0027]"},{"line_number":286,"context_line":"        verifylist \u003d []"},{"line_number":287,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_03117653","line":284,"in_reply_to":"5f7c97a3_f30ea2e2","updated":"2018-06-22 12:39:39.000000000","message":"hehe - I guess it doesn\u0027t matter too much, but it feels a little hokey to me. :-)","commit_id":"b9d551f38c8a0d09b0378e9a332d117ec69ef835"}],"tripleoclient/utils.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"b69f21ef4e4ff1bdcb7328f69b08872802c75cb7","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"        # NOTE(bogdando): we are making an exception to the oslo_log\u0027ish"},{"line_number":1179,"context_line":"        # default WARN level to have INFO logs as well. Some modules"},{"line_number":1180,"context_line":"        # produce INFO msgs we want to see and keep by default, like"},{"line_number":1181,"context_line":"        # pre-flight valiation notes."},{"line_number":1182,"context_line":"        log.setLevel(logging.INFO)"},{"line_number":1183,"context_line":"        fhandler.setLevel(logging.INFO)"},{"line_number":1184,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1b5503c3","line":1181,"updated":"2018-06-27 15:24:24.000000000","message":"Why? My preference is WARN I think.","commit_id":"5531e8bbbc57310ab855aec66ff9aecde5cc9ac0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"968800e83341175304fd1cc98ec099a13f12e9e4","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"        # NOTE(bogdando): we are making an exception to the oslo_log\u0027ish"},{"line_number":1179,"context_line":"        # default WARN level to have INFO logs as well. Some modules"},{"line_number":1180,"context_line":"        # produce INFO msgs we want to see and keep by default, like"},{"line_number":1181,"context_line":"        # pre-flight valiation notes."},{"line_number":1182,"context_line":"        log.setLevel(logging.INFO)"},{"line_number":1183,"context_line":"        fhandler.setLevel(logging.INFO)"},{"line_number":1184,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1b366304","line":1181,"in_reply_to":"5f7c97a3_1b5503c3","updated":"2018-06-27 15:43:53.000000000","message":"I\u0027d rather have us set info. There\u0027s a lot of things that are INFO and not WARN. I\u0027ve always hated the default for openstack client is WARN because from a complex UI response, WARN is usually a bad thing. It makes sense for other actions, but not our deployment actions where we want to display progress, etc","commit_id":"5531e8bbbc57310ab855aec66ff9aecde5cc9ac0"}],"tripleoclient/v1/undercloud_config.py":[{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"521dede9fe3376e956d4dbe9495d9c144081700c","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    if verbose_level \u003e 1:"},{"line_number":559,"context_line":"        deploy_args.append(\u0027--debug\u0027)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    LOG_FILE \u003d os.path.join(os.getcwd() + \u0027/install-undercloud.log\u0027)"},{"line_number":562,"context_line":"    deploy_args.append(\u0027--log-file\u003d\u0027 + LOG_FILE)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    cmd \u003d [\"sudo\", \"openstack\", \"tripleo\", \"deploy\", \"--standalone\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_93208e4b","side":"PARENT","line":561,"updated":"2018-06-21 14:09:25.000000000","message":"Apart from just different, is there a reason to move away from this?","commit_id":"3726c7750f650de83546dd0bfa8f1c7a38d6dc8f"},{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"6493c5b4f19f7a3c7f85570b5e231b557a658ce6","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    if verbose_level \u003e 1:"},{"line_number":559,"context_line":"        deploy_args.append(\u0027--debug\u0027)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    LOG_FILE \u003d os.path.join(os.getcwd() + \u0027/install-undercloud.log\u0027)"},{"line_number":562,"context_line":"    deploy_args.append(\u0027--log-file\u003d\u0027 + LOG_FILE)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    cmd \u003d [\"sudo\", \"openstack\", \"tripleo\", \"deploy\", \"--standalone\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_63086a26","side":"PARENT","line":561,"in_reply_to":"5f7c97a3_52e97e7c","updated":"2018-06-22 12:39:39.000000000","message":"Ack - thanks.","commit_id":"3726c7750f650de83546dd0bfa8f1c7a38d6dc8f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7149db6084c45f871ebe9cff8d4d16a0f4260b62","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    if verbose_level \u003e 1:"},{"line_number":559,"context_line":"        deploy_args.append(\u0027--debug\u0027)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    LOG_FILE \u003d os.path.join(os.getcwd() + \u0027/install-undercloud.log\u0027)"},{"line_number":562,"context_line":"    deploy_args.append(\u0027--log-file\u003d\u0027 + LOG_FILE)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    cmd \u003d [\"sudo\", \"openstack\", \"tripleo\", \"deploy\", \"--standalone\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_52e97e7c","side":"PARENT","line":561,"in_reply_to":"5f7c97a3_93208e4b","updated":"2018-06-22 10:13:57.000000000","message":"It has been moved into constants, and it\u0027s become hard to unit test it after that, as I can\u0027t mock constants\u0027 os.getcwd() ... It needs to be in constants as we shared the logging config for a several module in that patch.","commit_id":"3726c7750f650de83546dd0bfa8f1c7a38d6dc8f"}]}