)]}'
{"tripleoclient/tests/v1/overcloud_deploy/test_overcloud_deploy.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f21c24f737896005aae248bd39ce2930a4b8b94a","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        mock_create_tempest_deployer.assert_called_with()"},{"line_number":521,"context_line":"        mock_validate_args.assert_called_once_with(parsed_args)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        plane_management_fixture.mock_tarball.create_tarball.\\"},{"line_number":524,"context_line":"            assert_called_with("},{"line_number":525,"context_line":"                \u0027/tmp/tht/tripleo-heat-templates\u0027, mock.ANY)"},{"line_number":526,"context_line":"        plane_management_fixture.mock_tarball.\\"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff570b3c_32f24807","line":523,"updated":"2020-05-19 14:02:48.000000000","message":"pep8: F821 undefined name \u0027plane_management_fixture\u0027","commit_id":"b3176ff15ff9dd06f6ddc6ba4a1586f3336b5a34"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f21c24f737896005aae248bd39ce2930a4b8b94a","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        plane_management_fixture.mock_tarball.create_tarball.\\"},{"line_number":524,"context_line":"            assert_called_with("},{"line_number":525,"context_line":"                \u0027/tmp/tht/tripleo-heat-templates\u0027, mock.ANY)"},{"line_number":526,"context_line":"        plane_management_fixture.mock_tarball.\\"},{"line_number":527,"context_line":"            tarball_extract_to_swift_container.assert_called_with("},{"line_number":528,"context_line":"                clients.tripleoclient.object_store, mock.ANY, \u0027overcloud\u0027)"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ff570b3c_12f584ed","line":526,"updated":"2020-05-19 14:02:48.000000000","message":"pep8: F821 undefined name \u0027plane_management_fixture\u0027","commit_id":"b3176ff15ff9dd06f6ddc6ba4a1586f3336b5a34"}],"tripleoclient/tests/v1/test_overcloud_plan.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f21c24f737896005aae248bd39ce2930a4b8b94a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                 mock_upload_templates):"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Setup"},{"line_number":118,"context_line":"        arglist \u003d [\u0027overcast\u0027]"},{"line_number":119,"context_line":"        verifylist \u003d ["},{"line_number":120,"context_line":"            (\u0027name\u0027, \u0027overcast\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff570b3c_d2ee6c20","line":117,"updated":"2020-05-19 14:02:48.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"b3176ff15ff9dd06f6ddc6ba4a1586f3336b5a34"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"84d2afee5806ec34e70c5388dc686b13dd384199","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                 mock_upload_templates):"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Setup"},{"line_number":118,"context_line":"        arglist \u003d [\u0027overcast\u0027]"},{"line_number":119,"context_line":"        verifylist \u003d ["},{"line_number":120,"context_line":"            (\u0027name\u0027, \u0027overcast\u0027),"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_4fb331ea","line":117,"updated":"2020-09-18 13:42:22.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"6a98d1143bf0ee6947786c60d151f0c158552b4b"}],"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"e5047a209d219ed64b6c91179ee72b86587439d9","unresolved":false,"context_lines":[{"line_number":339,"context_line":"                with open(file_path, \u0027w\u0027) as f:"},{"line_number":340,"context_line":"                    f.write(self.object_client.get_object(plan_name, pf)[1])"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        tarfile \u003d os.path.join(tht_dir, \u0027tripleo-heat-templates.tar.gz\u0027)"},{"line_number":343,"context_line":"        if os.path.isfile(tarfile):"},{"line_number":344,"context_line":"            cmd \u003d [\u0027/bin/tar\u0027, \u0027--skip-old-files\u0027, \u0027-x\u0027,"},{"line_number":345,"context_line":"                   \u0027-C\u0027, tht_dir, \u0027-f\u0027, file_path]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_db177053","line":342,"updated":"2018-08-03 14:37:54.000000000","message":"why not using TEMPLATES_TARBALL_NAME constant?","commit_id":"ef52ada1e9c30c7a82e00db387bf3704bb7d7400"},{"author":{"_account_id":2011,"name":"Ian Main","email":"imain@redhat.com","username":"imain"},"change_message_id":"550c4d56dddd2adfcb492135674f2af1969768bf","unresolved":false,"context_lines":[{"line_number":339,"context_line":"                with open(file_path, \u0027w\u0027) as f:"},{"line_number":340,"context_line":"                    f.write(self.object_client.get_object(plan_name, pf)[1])"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        tarfile \u003d os.path.join(tht_dir, \u0027tripleo-heat-templates.tar.gz\u0027)"},{"line_number":343,"context_line":"        if os.path.isfile(tarfile):"},{"line_number":344,"context_line":"            cmd \u003d [\u0027/bin/tar\u0027, \u0027--skip-old-files\u0027, \u0027-x\u0027,"},{"line_number":345,"context_line":"                   \u0027-C\u0027, tht_dir, \u0027-f\u0027, file_path]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_8713825c","line":342,"in_reply_to":"5f7c97a3_db177053","updated":"2018-08-09 19:02:47.000000000","message":"Done","commit_id":"ef52ada1e9c30c7a82e00db387bf3704bb7d7400"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"12a05f450f0e29b4922d590f916987a47836d924","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        tarfile \u003d os.path.join(tht_dir, \u0027tripleo-heat-templates.tar.gz\u0027)"},{"line_number":343,"context_line":"        if os.path.isfile(tarfile):"},{"line_number":344,"context_line":"            cmd \u003d [\u0027/bin/tar\u0027, \u0027--skip-old-files\u0027, \u0027-x\u0027,"},{"line_number":345,"context_line":"                   \u0027-C\u0027, tht_dir, \u0027-f\u0027, file_path]"},{"line_number":346,"context_line":"            self.log.debug(\u0027Running tar command: %s\u0027 % (\u0027 \u0027.join(cmd)))"},{"line_number":347,"context_line":"            utils.run_command_and_log(self.log, cmd)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0350f55c","line":345,"range":{"start_line":345,"start_character":40,"end_line":345,"end_character":49},"updated":"2018-08-08 08:53:56.000000000","message":"This should be tarfile.","commit_id":"ef52ada1e9c30c7a82e00db387bf3704bb7d7400"},{"author":{"_account_id":2011,"name":"Ian Main","email":"imain@redhat.com","username":"imain"},"change_message_id":"550c4d56dddd2adfcb492135674f2af1969768bf","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        tarfile \u003d os.path.join(tht_dir, \u0027tripleo-heat-templates.tar.gz\u0027)"},{"line_number":343,"context_line":"        if os.path.isfile(tarfile):"},{"line_number":344,"context_line":"            cmd \u003d [\u0027/bin/tar\u0027, \u0027--skip-old-files\u0027, \u0027-x\u0027,"},{"line_number":345,"context_line":"                   \u0027-C\u0027, tht_dir, \u0027-f\u0027, file_path]"},{"line_number":346,"context_line":"            self.log.debug(\u0027Running tar command: %s\u0027 % (\u0027 \u0027.join(cmd)))"},{"line_number":347,"context_line":"            utils.run_command_and_log(self.log, cmd)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_471d6a64","line":345,"range":{"start_line":345,"start_character":40,"end_line":345,"end_character":49},"in_reply_to":"3f79a3b5_0350f55c","updated":"2018-08-09 19:02:47.000000000","message":"Done","commit_id":"ef52ada1e9c30c7a82e00db387bf3704bb7d7400"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9ab1c7c9da89a43debab8fa057281f7af40277b5","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            cmd \u003d [\u0027/bin/tar\u0027, \u0027--skip-old-files\u0027, \u0027-x\u0027,"},{"line_number":345,"context_line":"                   \u0027-C\u0027, tht_dir, \u0027-f\u0027, file_path]"},{"line_number":346,"context_line":"            self.log.debug(\u0027Running tar command: %s\u0027 % (\u0027 \u0027.join(cmd)))"},{"line_number":347,"context_line":"            utils.run_command_and_log(self.log, cmd)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _deploy_tripleo_heat_templates_tmpdir(self, stack, parsed_args):"},{"line_number":350,"context_line":"        # copy tht_root to temporary directory because we need to"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_5ae4fe0a","line":347,"updated":"2018-08-01 04:18:38.000000000","message":"The python tarfile module should probably be used instead of shelling out here:\n\nhttps://docs.python.org/2/library/tarfile.html","commit_id":"ef52ada1e9c30c7a82e00db387bf3704bb7d7400"},{"author":{"_account_id":2011,"name":"Ian Main","email":"imain@redhat.com","username":"imain"},"change_message_id":"550c4d56dddd2adfcb492135674f2af1969768bf","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            cmd \u003d [\u0027/bin/tar\u0027, \u0027--skip-old-files\u0027, \u0027-x\u0027,"},{"line_number":345,"context_line":"                   \u0027-C\u0027, tht_dir, \u0027-f\u0027, file_path]"},{"line_number":346,"context_line":"            self.log.debug(\u0027Running tar command: %s\u0027 % (\u0027 \u0027.join(cmd)))"},{"line_number":347,"context_line":"            utils.run_command_and_log(self.log, cmd)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _deploy_tripleo_heat_templates_tmpdir(self, stack, parsed_args):"},{"line_number":350,"context_line":"        # copy tht_root to temporary directory because we need to"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0729b288","line":347,"in_reply_to":"5f7c97a3_5ae4fe0a","updated":"2018-08-09 19:02:47.000000000","message":"Done","commit_id":"ef52ada1e9c30c7a82e00db387bf3704bb7d7400"}],"tripleoclient/workflows/plan_management.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8f10f1f9b585f9f6f33d096192647cec4055b891","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Optional override of the roles_data.yaml file"},{"line_number":45,"context_line":"    if not roles_file:"},{"line_number":46,"context_line":"        roles_file \u003d os.path.join(tht_root, constants.OVERCLOUD_ROLES_FILE)"},{"line_number":47,"context_line":"    _upload_file(swift_client, container_name, constants.OVERCLOUD_ROLES_FILE,"},{"line_number":48,"context_line":"                 roles_file)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f96c9d09","line":46,"updated":"2018-08-07 14:46:59.000000000","message":"could you please use that utility instead http://git.openstack.org/cgit/openstack/python-tripleoclient/tree/tripleoclient/utils.py#n1228 ?","commit_id":"ef52ada1e9c30c7a82e00db387bf3704bb7d7400"},{"author":{"_account_id":2011,"name":"Ian Main","email":"imain@redhat.com","username":"imain"},"change_message_id":"550c4d56dddd2adfcb492135674f2af1969768bf","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Optional override of the roles_data.yaml file"},{"line_number":45,"context_line":"    if not roles_file:"},{"line_number":46,"context_line":"        roles_file \u003d os.path.join(tht_root, constants.OVERCLOUD_ROLES_FILE)"},{"line_number":47,"context_line":"    _upload_file(swift_client, container_name, constants.OVERCLOUD_ROLES_FILE,"},{"line_number":48,"context_line":"                 roles_file)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_011be280","line":46,"in_reply_to":"3f79a3b5_f96c9d09","updated":"2018-08-09 19:02:47.000000000","message":"Done","commit_id":"ef52ada1e9c30c7a82e00db387bf3704bb7d7400"}]}