)]}'
{"tripleoclient/v1/undercloud_config.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"52f40c391805e163fb5e944ff659a8357aabea79","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    if CONF.get(\u0027undercloud_ntp_servers\u0027, None):"},{"line_number":297,"context_line":"        env_data[\u0027NtpServer\u0027] \u003d CONF[\u0027undercloud_ntp_servers\u0027][0]"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if CONF.get(\u0027enable_validations\u0027, True) and not no_validations:"},{"line_number":300,"context_line":"        env_data[\u0027EnableValidations\u0027] \u003d CONF[\u0027enable_validations\u0027]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    if CONF.get(\u0027overcloud_domain_name\u0027, None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_eb9bec60","line":299,"range":{"start_line":299,"start_character":38,"end_line":299,"end_character":42},"updated":"2018-07-18 09:51:46.000000000","message":"This seems reasonable, but now this is inconsistent with the standalone default in tripleoclient/config/standalone.py and also the t-h-t default in extraconfig/post_deploy/undercloud_post.yaml\n\nI wonder if we should set all of those to True, or just modify the docs?","commit_id":"51901520957f8440f777e669bc4522fce219a8d3"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"2d708b965f69a5ae99a8437bb0c9521e01432d2b","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    if CONF.get(\u0027enable_validations\u0027, True):"},{"line_number":410,"context_line":"        env_data[\u0027UndercloudConfigFilePath\u0027] \u003d constants.UNDERCLOUD_CONF_PATH"},{"line_number":411,"context_line":"        if not no_validations:"},{"line_number":412,"context_line":"            env_data[\u0027EnableValidations\u0027] \u003d CONF[\u0027enable_validations\u0027]"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    if CONF.get(\u0027overcloud_domain_name\u0027, None):"},{"line_number":415,"context_line":"        env_data[\u0027NeutronDnsDomain\u0027] \u003d CONF[\u0027overcloud_domain_name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_b849428f","line":412,"updated":"2019-04-01 13:53:37.000000000","message":"I just checked and the EnableValidations parameter is actually removed from t-h-t. See: I338e139fa770ebb7bdcc1c0afb79eec062fada8b\n\nAs such do we even need this code block anymore or can it simply be removed. See also the code below at line 690...","commit_id":"286514ef2c6ccabbe97bfcb2c4cf71da381c9f24"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"0fb84edf80eabf40a8d10f3775972149fa62654d","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    if CONF.get(\u0027enable_validations\u0027, True):"},{"line_number":410,"context_line":"        env_data[\u0027UndercloudConfigFilePath\u0027] \u003d constants.UNDERCLOUD_CONF_PATH"},{"line_number":411,"context_line":"        if not no_validations:"},{"line_number":412,"context_line":"            env_data[\u0027EnableValidations\u0027] \u003d CONF[\u0027enable_validations\u0027]"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    if CONF.get(\u0027overcloud_domain_name\u0027, None):"},{"line_number":415,"context_line":"        env_data[\u0027NeutronDnsDomain\u0027] \u003d CONF[\u0027overcloud_domain_name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_139ceb68","line":412,"in_reply_to":"5fc1f717_b849428f","updated":"2019-04-02 05:23:07.000000000","message":"hmmm good catch. Will wait for the Validation Folks to have another look at that patch. Might as well drop that block, indeed.\n\nAnd check whether block at l690 is still valid as well, since it uses the same config key...","commit_id":"286514ef2c6ccabbe97bfcb2c4cf71da381c9f24"}]}