)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"4f6d76610726b7a71debba9e925689cdc9e32fcd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"and just downloaded on the file system for the deployment."},{"line_number":23,"context_line":"(it removed all the code for the \"missing_files\" and the j2"},{"line_number":24,"context_line":"templating on FS)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I6c4e0d7f1cec5fbac0a7869c998f17593b3e416d"},{"line_number":27,"context_line":"Depends-On: I91ca29507997e4eed3863f2682fd4f605814fe4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3f79a3b5_34b490d1","line":25,"updated":"2018-08-28 13:26:58.000000000","message":"I think this is such a huge change (i don\u0027t mean just lines of code, but the whole concepts around how we approach deployment plan) that it would warrant a spec where we describe/discuss the solution from high-level conceptual view. We\u0027ve already tried to do this twice for updates/upgrades, and we failed twice, so i think our 3rd attempt should be properly thought through on high/conceptual level before we start merging code.\n\nFor example -- if we always persist the env files, what should user do when they want to remove some of them etc. I know the commit message says there will be life cycle solved in another patch but so far it\u0027s not easy to imagine that.","commit_id":"25ce01dca04da8282ed57e11a098e526d7b84193"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"509540cfc707144b5c55c07f81240995a94186dd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"and just downloaded on the file system for the deployment."},{"line_number":23,"context_line":"(it removed all the code for the \"missing_files\" and the j2"},{"line_number":24,"context_line":"templating on FS)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I6c4e0d7f1cec5fbac0a7869c998f17593b3e416d"},{"line_number":27,"context_line":"Depends-On: I91ca29507997e4eed3863f2682fd4f605814fe4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3f79a3b5_741688aa","line":25,"in_reply_to":"3f79a3b5_34b490d1","updated":"2018-08-28 13:30:16.000000000","message":"I mean it\u0027s not easy to imagine right now how the final solution would look.\n\nI don\u0027t see having specs as a strict requirement in general, but in this case it might be easier to discuss on high level first, to make sure that we go in a direction that reviewers (thinking also DF squad) will agree with and we don\u0027t have to rework the proposed code.","commit_id":"25ce01dca04da8282ed57e11a098e526d7b84193"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"23bb1103dcaa2727c215a6f04b0a588c86565704","unresolved":false,"context_lines":[{"line_number":22,"context_line":"and just downloaded on the file system for the deployment."},{"line_number":23,"context_line":"(it removed all the code for the \"missing_files\" and the j2"},{"line_number":24,"context_line":"templating on FS)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I6c4e0d7f1cec5fbac0a7869c998f17593b3e416d"},{"line_number":27,"context_line":"Depends-On: I91ca29507997e4eed3863f2682fd4f605814fe4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3f79a3b5_b74e6236","line":25,"in_reply_to":"3f79a3b5_741688aa","updated":"2018-08-28 13:46:30.000000000","message":"Thank you Jiri for your review and yes, I agree, this is a big change.\nI will propose a spec for that and I will try to describe with much details as possible what is the current situation and what I have in mind (and why it would be better).\n\nIn general, we failed twice as you said probably because we didn\u0027t really want to change the whole behavior of the plan management for the deployment.\n\nWhen I looked at the code and all the calls from the api, I saw that we were doing a lot of \"workaround\" and \"useless\" calls to swift or heat to construct the plan.\n\n* So this was my first goal: limited the calls and simplified the code for the plan. (There is still a lot to refactor to get something simple as much as possible).\n\n* My second goal was to keep the environment files, or at least the arguments passed via the cli, just for information and why for being re-used for the update/upgrade.\n\n* A third goal was for the life cycle management: store into swift all the information of the current deployment (env files, parameters \u0026 so), and even, give the opportunity to update (upload) a specific files, playbooks or whatever.\n\nThis first patch clarified a bit the plan management (1st goal), add the env files and params (2nd goal), but there is still some work to do. Probably to refactor this new code itself. I first wanted to see what I could potentially break with it and see if this solution and refactoring was something \"doable\" or \"not at all\".\nSo I got successful deployments (classic, config download) and upgrades with it.\n\nSo I\u0027m going to propose a spec with the review attached... And thank you again for your (precious) feedback..","commit_id":"25ce01dca04da8282ed57e11a098e526d7b84193"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ffdc7fe8125762e1aa138e22826bfe0cb47bc184","unresolved":false,"context_lines":[{"line_number":22,"context_line":"and just downloaded on the file system for the deployment."},{"line_number":23,"context_line":"(it removed all the code for the \"missing_files\" and the j2"},{"line_number":24,"context_line":"templating on FS)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I6c4e0d7f1cec5fbac0a7869c998f17593b3e416d"},{"line_number":27,"context_line":"Depends-On: I91ca29507997e4eed3863f2682fd4f605814fe4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3f79a3b5_1743966e","line":25,"in_reply_to":"3f79a3b5_b74e6236","updated":"2018-08-28 13:58:10.000000000","message":"Thanks, the above makes sense and i agree the persistence is a valuable feature to have and also it\u0027s valuable to simplify the plan management approach (with user_env and plan_env which kinda collide). Thanks a lot for looking into this :)","commit_id":"25ce01dca04da8282ed57e11a098e526d7b84193"}],"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"62a3f04cc441f38c77978543d298c7a41c8907b7","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                # python3 if opened as Text I/O"},{"line_number":276,"context_line":"                with open(file_path, \u0027wb\u0027) as f:"},{"line_number":277,"context_line":"                    f.write(self.object_client.get_object(plan_name, pf)[1])"},{"line_number":278,"context_line":"        return tht_tmp"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _deploy_tripleo_heat_templates_tmpdir(self, stack, parsed_args):"},{"line_number":281,"context_line":"        # Create tht_tmp directory"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_d4469f7b","line":278,"updated":"2018-08-27 14:30:58.000000000","message":"Why returning the same tht_tmp which was passed as argument? if the variable didn\u0027t change at all..","commit_id":"25ce01dca04da8282ed57e11a098e526d7b84193"}]}