)]}'
{"id":"openstack%2Fpython-tripleoclient~584367","triplet_id":"openstack%2Fpython-tripleoclient~master~I90e9718324b2f5e8420b89e8c00b5e366b82e96b","project":"openstack/python-tripleoclient","branch":"master","hashtags":[],"change_id":"I90e9718324b2f5e8420b89e8c00b5e366b82e96b","subject":"Don\u0027t assume ansible_dir in finally clause","status":"MERGED","created":"2018-07-20 13:19:07.000000000","updated":"2018-07-24 04:49:26.000000000","submitted":"2018-07-24 04:49:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"584367-1532407766953-553ded53","meta_rev_id":"3eac663c0c7bd10cb0668ff806b76a4a02a798b8","_number":584367,"virtual_id_number":584367,"owner":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},{"value":2,"date":"2018-07-24 04:49:26.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-07-20 15:54:07.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2018-07-21 00:23:01.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2018-07-20 18:32:49.000000000","_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2018-07-21 00:23:07.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-20 15:54:07.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-07-20 18:32:49.000000000","updated_by":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"reviewer":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"state":"REVIEWER"},{"updated":"2018-07-21 00:23:07.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2018-07-24 04:49:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ab3e2125abd3717671ef96da038719f736843ecf","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2018-07-20 13:19:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"00c589c4ea2e757aedfa6ae3713190b93f80ba89","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2018-07-20 15:54:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-master http://logs.rdoproject.org/67/584367/1/openstack-check/legacy-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-master/c8643f5/ : SUCCESS in 2h 28m 08s\n- legacy-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035-master http://logs.rdoproject.org/67/584367/1/openstack-check/legacy-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035-master/5a6e03d/ : SUCCESS in 2h 28m 06s","accounts_in_message":[],"_revision_number":1},{"id":"0fe58ff92ef5d7d7c9d7aa8cc11f600bd5fe129e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-20 16:50:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/67/584367/1/check/openstack-tox-pep8/9f37207/ : SUCCESS in 4m 16s\n- openstack-tox-py27 http://logs.openstack.org/67/584367/1/check/openstack-tox-py27/c7f5e7a/ : SUCCESS in 6m 41s\n- openstack-tox-py35 http://logs.openstack.org/67/584367/1/check/openstack-tox-py35/d3d16ca/ : SUCCESS in 4m 43s\n- openstackclient-check-plugins http://logs.openstack.org/67/584367/1/check/openstackclient-check-plugins/b351884/ : SUCCESS in 10m 10s (non-voting)\n- build-openstack-sphinx-docs http://logs.openstack.org/67/584367/1/check/build-openstack-sphinx-docs/163bc11/html/ : SUCCESS in 6m 45s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/67/584367/1/check/tripleo-ci-centos-7-undercloud-oooq/de1bc60/ : SUCCESS in 1h 08m 28s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/67/584367/1/check/tripleo-ci-centos-7-undercloud-upgrades/15a2f50/ : SUCCESS in 1h 22m 10s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/67/584367/1/check/tripleo-ci-centos-7-undercloud-containers/e10ba63/ : SUCCESS in 1h 27m 33s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/67/584367/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/ab6dec7/ : SUCCESS in 1h 51m 46s\n- tripleo-ci-centos-7-3nodes-multinode http://logs.openstack.org/67/584367/1/check/tripleo-ci-centos-7-3nodes-multinode/4700cf2/ : SUCCESS in 2h 42m 32s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/67/584367/1/check/tripleo-ci-centos-7-containers-multinode/8137ffc/ : SUCCESS in 2h 08m 20s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/67/584367/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/572434e/ : SUCCESS in 2h 33m 54s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/67/584367/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/aa76077/ : SUCCESS in 2h 07m 08s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/67/584367/1/check/tripleo-ci-centos-7-standalone/09c1606/ : SUCCESS in 55m 28s (non-voting)\n- tripleo-buildimage-overcloud-full-centos-7 http://logs.openstack.org/67/584367/1/check/tripleo-buildimage-overcloud-full-centos-7/2db14ba/ : SUCCESS in 24m 52s\n- openstack-tox-lower-constraints http://logs.openstack.org/67/584367/1/check/openstack-tox-lower-constraints/19a87aa/ : SUCCESS in 6m 59s","accounts_in_message":[],"_revision_number":1},{"id":"7d28f538102709b829bfa0382f96dc7e0f213155","author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"date":"2018-07-20 18:32:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"55e75bc823537b21e7dd22dd6b9c032ba77eb413","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-07-21 00:23:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"bb5ede85e21c354dda81077c9d41e9466c2a7a37","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-07-21 00:23:07.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8a7f1d0bde8abb44fe822a1bdf03baf47d865b59","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-23 20:21:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"042ad6a70e7e67a015fa0987b1869996d447d33e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-24 04:49:26.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3eac663c0c7bd10cb0668ff806b76a4a02a798b8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-24 04:49:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/67/584367/1/gate/openstack-tox-pep8/9ff86cb/ : SUCCESS in 5m 04s\n- openstack-tox-py27 http://logs.openstack.org/67/584367/1/gate/openstack-tox-py27/395b067/ : SUCCESS in 5m 18s\n- openstack-tox-py35 http://logs.openstack.org/67/584367/1/gate/openstack-tox-py35/55b2974/ : SUCCESS in 5m 40s\n- build-openstack-sphinx-docs http://logs.openstack.org/67/584367/1/gate/build-openstack-sphinx-docs/d35d32e/html/ : SUCCESS in 5m 11s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/67/584367/1/gate/tripleo-ci-centos-7-undercloud-oooq/7538960/ : SUCCESS in 1h 18m 58s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/67/584367/1/gate/tripleo-ci-centos-7-undercloud-containers/60c99a1/ : SUCCESS in 1h 55m 23s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/67/584367/1/gate/tripleo-ci-centos-7-containerized-undercloud-upgrades/1745099/ : SUCCESS in 49m 27s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/67/584367/1/gate/tripleo-ci-centos-7-containers-multinode/638728b/ : SUCCESS in 2h 48m 37s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/67/584367/1/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/265b894/ : SUCCESS in 2h 01m 06s\n- tripleo-buildimage-overcloud-full-centos-7 http://logs.openstack.org/67/584367/1/gate/tripleo-buildimage-overcloud-full-centos-7/ca695a2/ : SUCCESS in 27m 16s\n- openstack-tox-lower-constraints http://logs.openstack.org/67/584367/1/gate/openstack-tox-lower-constraints/c164a52/ : SUCCESS in 6m 18s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d077cb33d881c67009e6234c927c6f2be7cb3710","revisions":{"d077cb33d881c67009e6234c927c6f2be7cb3710":{"kind":"REWORK","_number":1,"created":"2018-07-20 13:19:07.000000000","uploader":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"ref":"refs/changes/67/584367/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/67/584367/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/584367/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/584367/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/584367/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/584367/1"}}},"commit":{"parents":[{"commit":"26d0ed218e9bb6ffa7293ec1eed7895bafc01420","subject":"Add --force-stack-create","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/26d0ed218e9bb6ffa7293ec1eed7895bafc01420"}]}],"author":{"name":"James Slagle","email":"jslagle@redhat.com","date":"2018-07-20 13:17:06.000000000","tz":-240},"committer":{"name":"James Slagle","email":"jslagle@redhat.com","date":"2018-07-20 13:17:06.000000000","tz":-240},"subject":"Don\u0027t assume ansible_dir in finally clause","message":"Don\u0027t assume ansible_dir in finally clause\n\nAs an exception can occur before ansible_dir is ever defined, we\nshouldn\u0027t assume it exists in the main finally clause, otherwise an\nUndefined exception could be thrown.\n\nInstead, save ansbie_dir as a class variable and default it to None,\nthat way we can first check if it\u0027s been set before trying to use it in\nfinally.\n\nChange-Id: I90e9718324b2f5e8420b89e8c00b5e366b82e96b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/d077cb33d881c67009e6234c927c6f2be7cb3710"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/d077cb33d881c67009e6234c927c6f2be7cb3710"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}