)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7722cf71dd9af4a9525016e0491ecf20b82d32c5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"backup was not performed. This patch handles the case"},{"line_number":12,"context_line":"when a negative or wrong answer is provided,"},{"line_number":13,"context_line":"displaying an informative log that the upgrade didn\u0027t"},{"line_number":14,"context_line":"take place."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I80ae52e8a732b2827e8179ce024f92ed52a29394"},{"line_number":17,"context_line":"Closes-Bug: #1783722"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_988ad517","line":14,"updated":"2018-07-30 08:25:34.000000000","message":"Instead of log.info \u0026 return, we now raise a new UndercloudUpgradeNotConfirmed exception added here, with context appropriate error message.","commit_id":"df80f6f91110f20b14cf27c65e247a874d6f285c"}],"tripleoclient/tests/v1/tripleo/test_tripleo_upgrade.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7722cf71dd9af4a9525016e0491ecf20b82d32c5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                        verifylist)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":71,"context_line":"        parsed_args.standalone \u003d True"},{"line_number":72,"context_line":"        parsed_args.upgrade \u003d True"},{"line_number":73,"context_line":"        mock_deploy.assert_called_with(self.cmd, parsed_args)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_982e5540","line":71,"updated":"2018-07-30 08:25:34.000000000","message":"so in fact it was broken here but tests passed?","commit_id":"df80f6f91110f20b14cf27c65e247a874d6f285c"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"dbeb9062ddfaf5eaca070359439140e5f39e0c33","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                        verifylist)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":71,"context_line":"        parsed_args.standalone \u003d True"},{"line_number":72,"context_line":"        parsed_args.upgrade \u003d True"},{"line_number":73,"context_line":"        mock_deploy.assert_called_with(self.cmd, parsed_args)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_5614ed9e","line":71,"in_reply_to":"5f7c97a3_982e5540","updated":"2018-08-01 12:26:14.000000000","message":"Exactly, I spent a lot of time understanding why this was not cought and still don\u0027t understand it.. :-S","commit_id":"df80f6f91110f20b14cf27c65e247a874d6f285c"}],"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7722cf71dd9af4a9525016e0491ecf20b82d32c5","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"        self.log.debug(\"take_action(%s)\" % parsed_args)"},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":"        try:"},{"line_number":1188,"context_line":"            if parsed_args.upgrade and ("},{"line_number":1189,"context_line":"                    not parsed_args.yes and sys.stdin.isatty()):"},{"line_number":1190,"context_line":"                prompt_response \u003d six.moves.input("},{"line_number":1191,"context_line":"                    (\u0027It is strongly recommended to perform a backup \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_98a175ab","line":1188,"updated":"2018-07-30 08:25:34.000000000","message":"imo it would be tidier to move all of this into a stand-alone function here but that is independent of this change","commit_id":"df80f6f91110f20b14cf27c65e247a874d6f285c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7722cf71dd9af4a9525016e0491ecf20b82d32c5","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"                     \u0027upgrade [y/N]?\u0027)"},{"line_number":1194,"context_line":"                ).lower()"},{"line_number":1195,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1196,"context_line":"                    msg \u003d _(\u0027User did not confirm upgrade so \u0027"},{"line_number":1197,"context_line":"                            \u0027taking no action.\u0027)"},{"line_number":1198,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(msg)"},{"line_number":1199,"context_line":"        except KeyboardInterrupt:  # ctrl-c"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b8bc71b6","line":1196,"range":{"start_line":1196,"start_character":29,"end_line":1196,"end_character":61},"updated":"2018-07-30 08:25:34.000000000","message":"can we add something like \"consider using the --yes parameter if you prefer to skip this warning in future\"\n\nperhaps even move part of this error string into a parameter so you can re-use it instead of duplicating like\n\n\"%s ctrl-c\" % basemsg \n\"%s ctrl-d\" % basemsg \netc\nwhere basemsg is like \"User did not confirm upgrade so exiting. Consider using the --yes parameter if you prefer to skip this warning in future\"","commit_id":"df80f6f91110f20b14cf27c65e247a874d6f285c"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"dbeb9062ddfaf5eaca070359439140e5f39e0c33","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"                     \u0027upgrade [y/N]?\u0027)"},{"line_number":1194,"context_line":"                ).lower()"},{"line_number":1195,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1196,"context_line":"                    msg \u003d _(\u0027User did not confirm upgrade so \u0027"},{"line_number":1197,"context_line":"                            \u0027taking no action.\u0027)"},{"line_number":1198,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(msg)"},{"line_number":1199,"context_line":"        except KeyboardInterrupt:  # ctrl-c"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_579a905f","line":1196,"range":{"start_line":1196,"start_character":29,"end_line":1196,"end_character":61},"in_reply_to":"5f7c97a3_b8bc71b6","updated":"2018-08-01 12:26:14.000000000","message":"Good idea, I like it.","commit_id":"df80f6f91110f20b14cf27c65e247a874d6f285c"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"33e4dc800a6cc0633d0ff69aea2712a41ea24125","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1198,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(unconf_msg)"},{"line_number":1199,"context_line":"        except KeyboardInterrupt:  # ctrl-c"},{"line_number":1200,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1201,"context_line":"                                                            unconf_msg)"},{"line_number":1202,"context_line":"        except EOFError:  # ctrl-d"},{"line_number":1203,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-d) %s\" %"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_da2d6545","line":1200,"updated":"2018-08-01 12:54:49.000000000","message":"It is strongly recommended to perform a backup before the upgrade. Are you sure you want to upgrade [y/N]?^C(ctrl-c) User did not confirm upgrade, so exiting. Consider using the --yes parameter if you prefer to skip this warning in the future\nTraceback (most recent call last):\n  File \"/usr/bin/openstack\", line 10, in \u003cmodule\u003e\n    sys.exit(main())\n  File \"/usr/lib/python2.7/site-packages/openstackclient/shell.py\", line 210, in main\n    return OpenStackShell().run(argv)\n  File \"/usr/lib/python2.7/site-packages/osc_lib/shell.py\", line 135, in run\n    ret_val \u003d super(OpenStackShell, self).run(argv)\n  File \"/usr/lib/python2.7/site-packages/cliff/app.py\", line 281, in run\n    result \u003d self.run_subcommand(remainder)\n  File \"/usr/lib/python2.7/site-packages/osc_lib/shell.py\", line 175, in run_subcommand\n    ret_value \u003d super(OpenStackShell, self).run_subcommand(argv)\n  File \"/usr/lib/python2.7/site-packages/cliff/app.py\", line 402, in run_subcommand\n    result \u003d cmd.run(parsed_args)\n  File \"/usr/lib/python2.7/site-packages/tripleoclient/command.py\", line 25, in run\n    super(Command, self).run(parsed_args)\n  File \"/usr/lib/python2.7/site-packages/osc_lib/command/command.py\", line 41, in run\n    return super(Command, self).run(parsed_args)\n  File \"/usr/lib/python2.7/site-packages/cliff/command.py\", line 184, in run\n    return_code \u003d self.take_action(parsed_args) or 0\n  File \"/usr/lib/python2.7/site-packages/tripleoclient/v1/undercloud.py\", line 203, in take_action\n    subprocess.check_call(cmd)\n  File \"/usr/lib64/python2.7/subprocess.py\", line 537, in check_call\n    retcode \u003d call(*popenargs, **kwargs)\n  File \"/usr/lib64/python2.7/subprocess.py\", line 524, in call\n    return Popen(*popenargs, **kwargs).wait()\n  File \"/usr/lib64/python2.7/subprocess.py\", line 1376, in wait\n    pid, sts \u003d _eintr_retry_call(os.waitpid, self.pid, 0)\n  File \"/usr/lib64/python2.7/subprocess.py\", line 478, in _eintr_retry_call\n    return func(*args)\nKeyboardInterrupt","commit_id":"a791752369d48fc6d823609ebfbc35e221b356ac"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"33e4dc800a6cc0633d0ff69aea2712a41ea24125","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1201,"context_line":"                                                            unconf_msg)"},{"line_number":1202,"context_line":"        except EOFError:  # ctrl-d"},{"line_number":1203,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-d) %s\" %"},{"line_number":1204,"context_line":"                                                            unconf_msg)"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"        if parsed_args.standalone:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1a0f5dd4","line":1203,"updated":"2018-08-01 12:54:49.000000000","message":"It is strongly recommended to perform a backup before the upgrade. Are you sure you want to upgrade [y/N]?(ctrl-d) User did not confirm upgrade, so exiting. Consider using the --yes parameter if you prefer to skip this warning in the future\n\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n\nAn error has occured while deploying the Undercloud.\n\nSee the previous output for details about what went wrong.\n\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!","commit_id":"a791752369d48fc6d823609ebfbc35e221b356ac"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"a78bf074bf5b4d9033876cd9c8692c4a3af085bc","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"                ).lower()"},{"line_number":1166,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1167,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(unconf_msg)"},{"line_number":1168,"context_line":"        except KeyboardInterrupt:  # ctrl-c"},{"line_number":1169,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1170,"context_line":"                                                            unconf_msg)"},{"line_number":1171,"context_line":"        except EOFError:  # ctrl-d"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_7a68ccf1","line":1168,"updated":"2018-08-01 16:11:33.000000000","message":"You don\u0027t need to double exceptions.\n\nexcept KeyboardInterrupt, EOFError\n    return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-d) %s\" % unconf_msg)\n\nworks fine.","commit_id":"979e43ec890f0e585369796707c56fe48090b7ef"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"950af6f8d608a0b45bdd69a1559f7055234961c4","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"                ).lower()"},{"line_number":1166,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1167,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(unconf_msg)"},{"line_number":1168,"context_line":"        except KeyboardInterrupt:  # ctrl-c"},{"line_number":1169,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1170,"context_line":"                                                            unconf_msg)"},{"line_number":1171,"context_line":"        except EOFError:  # ctrl-d"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_a2a072a5","line":1168,"in_reply_to":"5f7c97a3_7a68ccf1","updated":"2018-08-01 22:14:22.000000000","message":"Except the messaging is different depending on the exception. I think this is technically more correct even if it is more verbose.","commit_id":"979e43ec890f0e585369796707c56fe48090b7ef"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"43b0ac53f1bf675bee6650e79a1e87b31b69c1c9","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"                ).lower()"},{"line_number":1166,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1167,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(unconf_msg)"},{"line_number":1168,"context_line":"        except KeyboardInterrupt:  # ctrl-c"},{"line_number":1169,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1170,"context_line":"                                                            unconf_msg)"},{"line_number":1171,"context_line":"        except EOFError:  # ctrl-d"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_b7d98981","line":1168,"in_reply_to":"5f7c97a3_a2a072a5","updated":"2018-08-02 12:00:54.000000000","message":"Yea if we want to print the ctrl-c / ctrl-d in the message, we probably do need to fork. I\u0027d also be fine not printing that info at all in this case, and just using exceptions.UndercloudUpgradeNotConfirmed(unconf_msg). Not a blocker from my point of view.","commit_id":"979e43ec890f0e585369796707c56fe48090b7ef"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"548888c8e2ed63f7006044b7e4e8fcb246cec442","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"                ).lower()"},{"line_number":1166,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1167,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(unconf_msg)"},{"line_number":1168,"context_line":"        except KeyboardInterrupt:  # ctrl-c"},{"line_number":1169,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1170,"context_line":"                                                            unconf_msg)"},{"line_number":1171,"context_line":"        except EOFError:  # ctrl-d"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_9247bba4","line":1168,"in_reply_to":"5f7c97a3_b7d98981","updated":"2018-08-02 12:56:47.000000000","message":"I prefer to leave it as it was, and if you consider that it\u0027s really needed to join them back or remove the differentiation of Exception I can add it in a follow up patch.","commit_id":"979e43ec890f0e585369796707c56fe48090b7ef"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"43b0ac53f1bf675bee6650e79a1e87b31b69c1c9","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1167,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(unconf_msg)"},{"line_number":1168,"context_line":"        except KeyboardInterrupt:  # ctrl-c"},{"line_number":1169,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1170,"context_line":"                                                            unconf_msg)"},{"line_number":1171,"context_line":"        except EOFError:  # ctrl-d"},{"line_number":1172,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-d) %s\" %"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_77d1b155","line":1169,"range":{"start_line":1169,"start_character":12,"end_line":1169,"end_character":18},"updated":"2018-08-02 12:00:54.000000000","message":"raise","commit_id":"979e43ec890f0e585369796707c56fe48090b7ef"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"548888c8e2ed63f7006044b7e4e8fcb246cec442","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1167,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(unconf_msg)"},{"line_number":1168,"context_line":"        except KeyboardInterrupt:  # ctrl-c"},{"line_number":1169,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1170,"context_line":"                                                            unconf_msg)"},{"line_number":1171,"context_line":"        except EOFError:  # ctrl-d"},{"line_number":1172,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-d) %s\" %"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_b242f791","line":1169,"range":{"start_line":1169,"start_character":12,"end_line":1169,"end_character":18},"in_reply_to":"5f7c97a3_77d1b155","updated":"2018-08-02 12:56:47.000000000","message":"Thanks, done.","commit_id":"979e43ec890f0e585369796707c56fe48090b7ef"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"43b0ac53f1bf675bee6650e79a1e87b31b69c1c9","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1170,"context_line":"                                                            unconf_msg)"},{"line_number":1171,"context_line":"        except EOFError:  # ctrl-d"},{"line_number":1172,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-d) %s\" %"},{"line_number":1173,"context_line":"                                                            unconf_msg)"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        if parsed_args.standalone:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_17c4fd92","line":1172,"range":{"start_line":1172,"start_character":12,"end_line":1172,"end_character":18},"updated":"2018-08-02 12:00:54.000000000","message":"raise","commit_id":"979e43ec890f0e585369796707c56fe48090b7ef"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"548888c8e2ed63f7006044b7e4e8fcb246cec442","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1170,"context_line":"                                                            unconf_msg)"},{"line_number":1171,"context_line":"        except EOFError:  # ctrl-d"},{"line_number":1172,"context_line":"            return exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-d) %s\" %"},{"line_number":1173,"context_line":"                                                            unconf_msg)"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        if parsed_args.standalone:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_52c36306","line":1172,"range":{"start_line":1172,"start_character":12,"end_line":1172,"end_character":18},"in_reply_to":"5f7c97a3_17c4fd92","updated":"2018-08-02 12:56:47.000000000","message":"Done","commit_id":"979e43ec890f0e585369796707c56fe48090b7ef"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"84fd47ced075df70f30f6b11a2894f878364db06","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"                ).lower()"},{"line_number":1197,"context_line":"                if not prompt_response.startswith(\u0027y\u0027):"},{"line_number":1198,"context_line":"                    raise exceptions.UndercloudUpgradeNotConfirmed(unconf_msg)"},{"line_number":1199,"context_line":"        except KeyboardInterrupt:  # ctrl-c"},{"line_number":1200,"context_line":"            raise exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-c) %s\" %"},{"line_number":1201,"context_line":"                                                           unconf_msg)"},{"line_number":1202,"context_line":"        except EOFError:  # ctrl-d"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_c29305b0","line":1199,"updated":"2018-08-03 11:24:49.000000000","message":"except KeyboardInterrupt, EOFError:\n\nand delete 1202-1204","commit_id":"b8e970ac8706e4da357374de0c7bf7fa62988821"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"992c9acb7310419008423b034864298ec1d0b969","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"            else:"},{"line_number":1205,"context_line":"                # ctrl-d"},{"line_number":1206,"context_line":"                raise exceptions.UndercloudUpgradeNotConfirmed(\"(ctrl-d) %s\" %"},{"line_number":1207,"context_line":"                                                               unconf_msg)"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"        if parsed_args.standalone:"},{"line_number":1210,"context_line":"            if self._standalone_deploy(parsed_args) !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_adba80db","line":1207,"updated":"2018-08-06 10:33:41.000000000","message":"Personally i think this is worse than before :D but i don\u0027t think it matters much.","commit_id":"ed1fc90365672d3e0bcfe1526be322ee6a0ef098"}],"tripleoclient/v1/undercloud.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7722cf71dd9af4a9525016e0491ecf20b82d32c5","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                    \u0027~/stackrc\u0027"},{"line_number":156,"context_line":"                    ))"},{"line_number":157,"context_line":"            except Exception as e:"},{"line_number":158,"context_line":"                self.log.error(UNDERCLOUD_FAILURE_MESSAGE)"},{"line_number":159,"context_line":"                self.log.error(e)"},{"line_number":160,"context_line":"                raise exceptions.DeploymentError(e)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f81c2915","line":158,"range":{"start_line":158,"start_character":31,"end_line":158,"end_character":57},"updated":"2018-07-30 08:25:34.000000000","message":"can you add a note about this in the commit? I don\u0027t follow why we now no longer need to provide the .format here please","commit_id":"df80f6f91110f20b14cf27c65e247a874d6f285c"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"dbeb9062ddfaf5eaca070359439140e5f39e0c33","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                    \u0027~/stackrc\u0027"},{"line_number":156,"context_line":"                    ))"},{"line_number":157,"context_line":"            except Exception as e:"},{"line_number":158,"context_line":"                self.log.error(UNDERCLOUD_FAILURE_MESSAGE)"},{"line_number":159,"context_line":"                self.log.error(e)"},{"line_number":160,"context_line":"                raise exceptions.DeploymentError(e)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d778e0f7","line":158,"range":{"start_line":158,"start_character":31,"end_line":158,"end_character":57},"in_reply_to":"5f7c97a3_f81c2915","updated":"2018-08-01 12:26:14.000000000","message":"If you realize, the UNDERCLOUD_FAILURE_MESSAGE at https://review.openstack.org/#/c/586249/3/tripleoclient/v1/undercloud.py@32 doesn\u0027t have any string substitution ({0},{1}) as UNDERCLOUD_COMPLETION_MESSAGE has, for example. It\u0027s just a simple string, so why to use the .format method on it when we\u0027re not formatting anything? Also, this class doesn\u0027t contain any self.heat_launch_install_tmp property, so we were obtaining an exception when this part of the code was being called.","commit_id":"df80f6f91110f20b14cf27c65e247a874d6f285c"}]}