)]}'
{"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"1fe36f6e850ccb3909dca10f4e2a244e6a1a513f","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"                    if rc !\u003d 0:"},{"line_number":1163,"context_line":"                        raise exceptions.DeploymentError(\u0027Upgrade failed\u0027)"},{"line_number":1164,"context_line":"                    rc \u003d self._launch_ansible_deploy(self.ansible_dir)"},{"line_number":1165,"context_line":"                    # Run Post Upgrade tasks before the deployment"},{"line_number":1166,"context_line":"                    rc \u003d self._launch_ansible_post_upgrade(self.ansible_dir)"},{"line_number":1167,"context_line":"                    if rc !\u003d 0:"},{"line_number":1168,"context_line":"                        raise exceptions.DeploymentError(\u0027Post Upgrade failed\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0059fc27","line":1165,"updated":"2018-10-31 07:44:05.000000000","message":"This comment suggest that _launch_ansible_deploy should be after _launch_ansible_post_upgrade. Also If this is correct flow (and I assume that is), this can be simplyfied to:\nif parsed_args.upgrade:\n  # Run Upgrade tasks before the deployment\n  rc \u003d self._launch_ansible_upgrade(self.ansible_dir)\n  if rc !\u003d 0:\n    raise exceptions.DeploymentError(\u0027Upgrade failed\u0027)\n  # Run Post Upgrade tasks before the deployment\n  rc \u003d self._launch_ansible_post_upgrade(self.ansible_dir)\n  if rc !\u003d 0:\n    raise exceptions.DeploymentError(\u0027Post Upgrade failed\u0027)\nrc \u003d self._launch_ansible_deploy(self.ansible_dir)","commit_id":"138d2e978e69d65aeff215aa9ea33c73f6639365"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"8fb9c4de6d35256d660119964eef311ef57d20e7","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"                    rc \u003d self._launch_ansible_upgrade(self.ansible_dir)"},{"line_number":1162,"context_line":"                    if rc !\u003d 0:"},{"line_number":1163,"context_line":"                        raise exceptions.DeploymentError(\u0027Upgrade failed\u0027)"},{"line_number":1164,"context_line":"                    rc \u003d self._launch_ansible_deploy(self.ansible_dir)"},{"line_number":1165,"context_line":"                    # Run Post Upgrade tasks after the deployment"},{"line_number":1166,"context_line":"                    rc \u003d self._launch_ansible_post_upgrade(self.ansible_dir)"},{"line_number":1167,"context_line":"                    if rc !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_de43d96a","line":1164,"range":{"start_line":1164,"start_character":14,"end_line":1164,"end_character":70},"updated":"2018-10-31 16:43:03.000000000","message":"Wrong indentation, this has to go back 4 chars or else deployment will happen only on upgrade.\n\nThen readd the if parsed_args.upgrade for the post_upgrade tasks.","commit_id":"a14a85a5a0f2a4fa0b2fbba046a615a3c077bbba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2f153fb3f79a21c59560f2dbf3e26c8bc59b1213","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"                    rc \u003d self._launch_ansible_upgrade(self.ansible_dir)"},{"line_number":1162,"context_line":"                    if rc !\u003d 0:"},{"line_number":1163,"context_line":"                        raise exceptions.DeploymentError(\u0027Upgrade failed\u0027)"},{"line_number":1164,"context_line":"                    rc \u003d self._launch_ansible_deploy(self.ansible_dir)"},{"line_number":1165,"context_line":"                    # Run Post Upgrade tasks after the deployment"},{"line_number":1166,"context_line":"                    rc \u003d self._launch_ansible_post_upgrade(self.ansible_dir)"},{"line_number":1167,"context_line":"                    if rc !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_bfbe05ff","line":1164,"range":{"start_line":1164,"start_character":14,"end_line":1164,"end_character":70},"in_reply_to":"3f79a3b5_de43d96a","updated":"2018-11-01 16:05:32.000000000","message":"Done","commit_id":"a14a85a5a0f2a4fa0b2fbba046a615a3c077bbba"}]}