)]}'
{"id":"openstack%2Fpython-tripleoclient~617035","triplet_id":"openstack%2Fpython-tripleoclient~master~I58da6f699fe8257e3ddb89cd3516889944c4ad92","project":"openstack/python-tripleoclient","branch":"master","topic":"bug/1802592","hashtags":[],"change_id":"I58da6f699fe8257e3ddb89cd3516889944c4ad92","subject":"Only return plans if available from the message","status":"MERGED","created":"2018-11-09 21:19:26.000000000","updated":"2018-11-12 15:51:41.000000000","submitted":"2018-11-12 05:12:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"617035-1541999550853-b43482ff","meta_rev_id":"c2517e79ec13ce28d2d8af07d918f4863fe92ffa","_number":617035,"virtual_id_number":617035,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2018-11-12 05:12:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},{"value":0,"date":"2018-11-09 21:31:42.000000000","_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"value":0,"date":"2018-11-10 00:50:40.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-11-09 21:22:53.000000000","_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},{"value":0,"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},{"value":0,"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2018-11-12 02:05:57.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-11-09 21:22:53.000000000","updated_by":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"reviewer":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"state":"REVIEWER"},{"updated":"2018-11-09 21:31:42.000000000","updated_by":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"reviewer":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"state":"REVIEWER"},{"updated":"2018-11-12 02:05:57.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2018-11-12 05:12:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9047068821811ae0ee38a286189a5520050feb73","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2018-11-09 21:19:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d3c2776fd4f29830a4cd4dd5734db9a476c55821","author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"date":"2018-11-09 21:22:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"164853e20ca8823f584e166273d1485d43568a95","author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"date":"2018-11-09 21:31:42.000000000","message":"Patch Set 1:\n\nhttps://review.openstack.org/#/c/605520/ might a better fix for that issue. I looked the CI logs though, and I can\u0027t see how that happens in that particular case.","accounts_in_message":[],"_revision_number":1},{"id":"08a43b3a4e76ed46c4f23e6ae8520083407ebaff","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2018-11-09 21:48:14.000000000","message":"Patch Set 1:\n\nyou might be right. I shall fixup that other set of patches while slagle is out","accounts_in_message":[],"_revision_number":1},{"id":"81c662fa4039c838b6b6956ffa08bdf3b2eb8ed3","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2018-11-09 21:48:40.000000000","message":"Patch Set 1:\n\nThough i also believe we should check for existence of a key before trying to access it :D","accounts_in_message":[],"_revision_number":1},{"id":"0daf1b07d4354f359b6feff82866713c7c758859","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-10 00:39:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-undercloud-containers/e711448/ : SUCCESS in 1h 42m 55s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/1ec2294/ : SUCCESS in 2h 03m 10s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-containers-multinode/8524805/ : FAILURE in 1h 00m 11s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/3ba4c0c/ : SUCCESS in 2h 39m 25s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/aff18ab/ : SUCCESS in 1h 56m 39s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-standalone/d551553/ : SUCCESS in 1h 13m 20s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/35/617035/1/check/tripleo-ci-fedora-28-standalone/c9f5ed8/ : FAILURE in 19m 50s (non-voting)\n- tripleo-buildimage-overcloud-full-centos-7 http://logs.openstack.org/35/617035/1/check/tripleo-buildimage-overcloud-full-centos-7/a0aba9d/ : SUCCESS in 23m 31s\n- openstack-tox-pep8 http://logs.openstack.org/35/617035/1/check/openstack-tox-pep8/84325dc/ : SUCCESS in 4m 17s\n- openstack-tox-py27 http://logs.openstack.org/35/617035/1/check/openstack-tox-py27/4fa5ce2/ : SUCCESS in 4m 58s\n- openstack-tox-py35 http://logs.openstack.org/35/617035/1/check/openstack-tox-py35/fb374f8/ : SUCCESS in 3m 53s\n- openstack-tox-py36 http://logs.openstack.org/35/617035/1/check/openstack-tox-py36/dab5024/ : SUCCESS in 5m 03s\n- openstackclient-check-plugins http://logs.openstack.org/35/617035/1/check/openstackclient-check-plugins/083759d/ : SUCCESS in 5m 40s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/35/617035/1/check/openstack-tox-docs/15cba57/html/ : SUCCESS in 4m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/35/617035/1/check/openstack-tox-lower-constraints/c9ba6d7/ : SUCCESS in 5m 29s","accounts_in_message":[],"_revision_number":1},{"id":"d8bd6288f2ec82065243f0e3d7c3cb51e98ea6ff","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2018-11-10 00:50:40.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"a4047ee9611d0ac6802a12a48bbf3d55cecdf366","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-10 03:33:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-undercloud-containers/342724d/ : SUCCESS in 2h 01m 22s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/a159cdb/ : SUCCESS in 2h 00m 23s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-containers-multinode/69b5f63/ : SUCCESS in 2h 38m 19s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/641a48b/ : SUCCESS in 2h 24m 16s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/6901e10/ : SUCCESS in 1h 58m 40s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/35/617035/1/check/tripleo-ci-centos-7-standalone/03cab51/ : SUCCESS in 1h 17m 29s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/35/617035/1/check/tripleo-ci-fedora-28-standalone/310126b/ : FAILURE in 14m 40s (non-voting)\n- tripleo-buildimage-overcloud-full-centos-7 http://logs.openstack.org/35/617035/1/check/tripleo-buildimage-overcloud-full-centos-7/db97a68/ : SUCCESS in 25m 22s\n- openstack-tox-pep8 http://logs.openstack.org/35/617035/1/check/openstack-tox-pep8/9db0903/ : SUCCESS in 3m 54s\n- openstack-tox-py27 http://logs.openstack.org/35/617035/1/check/openstack-tox-py27/23f9429/ : SUCCESS in 4m 06s\n- openstack-tox-py35 http://logs.openstack.org/35/617035/1/check/openstack-tox-py35/58a951a/ : SUCCESS in 3m 16s\n- openstack-tox-py36 http://logs.openstack.org/35/617035/1/check/openstack-tox-py36/dc581ff/ : SUCCESS in 3m 02s\n- openstackclient-check-plugins http://logs.openstack.org/35/617035/1/check/openstackclient-check-plugins/63794bd/ : SUCCESS in 4m 42s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/35/617035/1/check/openstack-tox-docs/995b05a/html/ : SUCCESS in 2m 38s\n- openstack-tox-lower-constraints http://logs.openstack.org/35/617035/1/check/openstack-tox-lower-constraints/abec051/ : SUCCESS in 4m 49s","accounts_in_message":[],"_revision_number":1},{"id":"f274be7cdf9e31eeef0465d58ab02d660a613fcc","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-11-12 02:05:57.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b61a99a40a83e9a71825904836a2c7ed38e7b3ae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-12 02:06:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0e26e2ff37c2efa68daad079c82c0bad13f5c2e6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-12 05:12:30.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/35/617035/1/gate/tripleo-ci-centos-7-containers-multinode/31a3e8c/ : SUCCESS in 2h 44m 35s\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/35/617035/1/gate/tripleo-ci-centos-7-standalone/f5e63de/ : SUCCESS in 1h 30m 58s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/35/617035/1/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/866184d/ : SUCCESS in 2h 43m 19s\n- tripleo-buildimage-overcloud-full-centos-7 http://logs.openstack.org/35/617035/1/gate/tripleo-buildimage-overcloud-full-centos-7/e86257b/ : SUCCESS in 26m 22s\n- openstack-tox-pep8 http://logs.openstack.org/35/617035/1/gate/openstack-tox-pep8/d794833/ : SUCCESS in 3m 29s\n- openstack-tox-py27 http://logs.openstack.org/35/617035/1/gate/openstack-tox-py27/f09f718/ : SUCCESS in 4m 13s\n- openstack-tox-py35 http://logs.openstack.org/35/617035/1/gate/openstack-tox-py35/3e9c497/ : SUCCESS in 3m 05s\n- openstack-tox-py36 http://logs.openstack.org/35/617035/1/gate/openstack-tox-py36/8d0f15b/ : SUCCESS in 3m 16s\n- openstack-tox-docs http://logs.openstack.org/35/617035/1/gate/openstack-tox-docs/50327ae/html/ : SUCCESS in 3m 10s\n- openstack-tox-lower-constraints http://logs.openstack.org/35/617035/1/gate/openstack-tox-lower-constraints/3e655d3/ : SUCCESS in 4m 50s","accounts_in_message":[],"_revision_number":1},{"id":"4cc33098455f9d9e2d9351a16eb9527d338d3a40","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-12 05:12:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a3ae072b2db302ba7a10a7aa7a5910e9c26c2b0a","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2018-11-12 15:51:41.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 5047cf5cd04b51c0daab1ff68987706eac1a1ceb","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"82ace31be5fcd5e28a8d253cda3b221d8dabf140","revisions":{"82ace31be5fcd5e28a8d253cda3b221d8dabf140":{"kind":"REWORK","_number":1,"created":"2018-11-09 21:19:26.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/35/617035/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/35/617035/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/35/617035/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/35/617035/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/35/617035/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/35/617035/1"}}},"commit":{"parents":[{"commit":"e716376089c50a31509defd76798178f97a1ee6a","subject":"Merge \"Undercloud: Disable persisting VIPs in /etc/hosts\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/e716376089c50a31509defd76798178f97a1ee6a"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2018-11-09 21:18:08.000000000","tz":-420},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2018-11-09 21:18:08.000000000","tz":-420},"subject":"Only return plans if available from the message","message":"Only return plans if available from the message\n\nThere appears to be a race condition in the list_deployment_plans such\nthat if another message is recieved before the plan results, we attempt\nto return the plans payload which may not exist. This change adds a\ncheck to ensure the payload contains plans before trying to return the\nvalues.\n\nChange-Id: I58da6f699fe8257e3ddb89cd3516889944c4ad92\nCloses-Bug: #1802592\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/82ace31be5fcd5e28a8d253cda3b221d8dabf140"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/82ace31be5fcd5e28a8d253cda3b221d8dabf140"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"e716376089c50a31509defd76798178f97a1ee6a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}