)]}'
{"tripleoclient/config/standalone.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c91da2ee21191b344e867cf585a6d41ef4aafbf","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                           \u0027Relative paths get computed inside of $HOME. \u0027"},{"line_number":132,"context_line":"                           \u0027Must be in the json format.\u0027"},{"line_number":133,"context_line":"                           \u0027Its content overrides anything in t-h-t \u0027"},{"line_number":134,"context_line":"                           \u0027\u003crole\u003eNetConfigOverride. The processed \u0027"},{"line_number":135,"context_line":"                           \u0027template is then passed in Heat via the \u0027"},{"line_number":136,"context_line":"                           \u0027generated parameters file created in \u0027"},{"line_number":137,"context_line":"                           \u0027output_dir and used to configure the networking \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fb8cfa7_94b3ae4d","line":134,"range":{"start_line":134,"start_character":29,"end_line":134,"end_character":33},"updated":"2019-06-21 13:25:14.000000000","message":"transforming this one into a generic deployment mechanism looks really cool! :)","commit_id":"af91bfb626db0318f4ee152905197c17b319c1cf"}],"tripleoclient/v1/minion_config.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c91da2ee21191b344e867cf585a6d41ef4aafbf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from tripleoclient import utils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Provides mappings for some of the instack_env tags to undercloud heat"},{"line_number":44,"context_line":"# params or undercloud.conf opts known here (as a fallback), needed to maintain"},{"line_number":45,"context_line":"# feature parity with instack net config override templates."},{"line_number":46,"context_line":"# TODO(bogdando): all of the needed mappings should be wired-in, eventually"},{"line_number":47,"context_line":"INSTACK_NETCONF_MAPPING \u003d {"},{"line_number":48,"context_line":"    \u0027LOCAL_INTERFACE\u0027: \u0027minion_local_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_746dda96","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":60},"updated":"2019-06-21 13:25:14.000000000","message":"this seems not applicable to minions? not sure","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a6e249b361ef0bc3c7f2fe35f11b9833635d447d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from tripleoclient import utils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Provides mappings for some of the instack_env tags to undercloud heat"},{"line_number":44,"context_line":"# params or undercloud.conf opts known here (as a fallback), needed to maintain"},{"line_number":45,"context_line":"# feature parity with instack net config override templates."},{"line_number":46,"context_line":"# TODO(bogdando): all of the needed mappings should be wired-in, eventually"},{"line_number":47,"context_line":"INSTACK_NETCONF_MAPPING \u003d {"},{"line_number":48,"context_line":"    \u0027LOCAL_INTERFACE\u0027: \u0027minion_local_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_b4559252","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":60},"in_reply_to":"9fb8cfa7_746dda96","updated":"2019-06-21 13:46:29.000000000","message":"It\u0027s still used in the custom network config (and documented as such)","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c91da2ee21191b344e867cf585a6d41ef4aafbf","unresolved":false,"context_lines":[{"line_number":120,"context_line":"def prepare_minion_deploy(upgrade\u003dFalse, no_validations\u003dFalse,"},{"line_number":121,"context_line":"                          verbose_level\u003d1, yes\u003dFalse,"},{"line_number":122,"context_line":"                          force_stack_update\u003dFalse, dry_run\u003dFalse):"},{"line_number":123,"context_line":"    \"\"\"Prepare Undercloud deploy command based on undercloud.conf\"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    env_data \u003d {}"},{"line_number":126,"context_line":"    registry_overwrites \u003d {}"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_f4f22a06","line":123,"updated":"2019-06-21 13:25:14.000000000","message":"is it for Minion deploy based on minion.conf?","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a6e249b361ef0bc3c7f2fe35f11b9833635d447d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"def prepare_minion_deploy(upgrade\u003dFalse, no_validations\u003dFalse,"},{"line_number":121,"context_line":"                          verbose_level\u003d1, yes\u003dFalse,"},{"line_number":122,"context_line":"                          force_stack_update\u003dFalse, dry_run\u003dFalse):"},{"line_number":123,"context_line":"    \"\"\"Prepare Undercloud deploy command based on undercloud.conf\"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    env_data \u003d {}"},{"line_number":126,"context_line":"    registry_overwrites \u003d {}"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_349522e5","line":123,"in_reply_to":"9fb8cfa7_f4f22a06","updated":"2019-06-21 13:46:29.000000000","message":"Done","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c91da2ee21191b344e867cf585a6d41ef4aafbf","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        if param_key in CONF.keys():"},{"line_number":147,"context_line":"            env_data[param_value] \u003d CONF[param_key]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    # Parse the undercloud.conf options to include necessary args and"},{"line_number":150,"context_line":"    # yaml files for undercloud deploy command"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if CONF.get(\u0027minion_enable_selinux\u0027):"},{"line_number":153,"context_line":"        env_data[\u0027SELinuxMode\u0027] \u003d \u0027enforcing\u0027"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_94e16e2d","line":150,"range":{"start_line":149,"start_character":0,"end_line":150,"end_character":46},"updated":"2019-06-21 13:25:14.000000000","message":"sed s/undercloud/minion","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a6e249b361ef0bc3c7f2fe35f11b9833635d447d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        if param_key in CONF.keys():"},{"line_number":147,"context_line":"            env_data[param_value] \u003d CONF[param_key]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    # Parse the undercloud.conf options to include necessary args and"},{"line_number":150,"context_line":"    # yaml files for undercloud deploy command"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if CONF.get(\u0027minion_enable_selinux\u0027):"},{"line_number":153,"context_line":"        env_data[\u0027SELinuxMode\u0027] \u003d \u0027enforcing\u0027"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_5498d619","line":150,"range":{"start_line":149,"start_character":0,"end_line":150,"end_character":46},"in_reply_to":"9fb8cfa7_94e16e2d","updated":"2019-06-21 13:46:29.000000000","message":"Done","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c91da2ee21191b344e867cf585a6d41ef4aafbf","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    else:"},{"line_number":163,"context_line":"        env_data[\u0027TimeZone\u0027] \u003d utils.get_local_timezone()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # TODO(aschultz): fix this logic, look it up out of undercloud-outputs.yaml"},{"line_number":166,"context_line":"    env_data[\u0027DockerInsecureRegistryAddress\u0027] \u003d ["},{"line_number":167,"context_line":"        \u0027%s:8787\u0027 % CONF[\u0027minion_local_ip\u0027].split(\u0027/\u0027)[0]]"},{"line_number":168,"context_line":"    env_data[\u0027DockerInsecureRegistryAddress\u0027].extend("}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_94bace07","line":165,"updated":"2019-06-21 13:25:14.000000000","message":"does this still look relevant here? should it be tripleo-minion-outputs.yaml or something?","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a6e249b361ef0bc3c7f2fe35f11b9833635d447d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    else:"},{"line_number":163,"context_line":"        env_data[\u0027TimeZone\u0027] \u003d utils.get_local_timezone()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # TODO(aschultz): fix this logic, look it up out of undercloud-outputs.yaml"},{"line_number":166,"context_line":"    env_data[\u0027DockerInsecureRegistryAddress\u0027] \u003d ["},{"line_number":167,"context_line":"        \u0027%s:8787\u0027 % CONF[\u0027minion_local_ip\u0027].split(\u0027/\u0027)[0]]"},{"line_number":168,"context_line":"    env_data[\u0027DockerInsecureRegistryAddress\u0027].extend("}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_d4504661","line":165,"in_reply_to":"9fb8cfa7_94bace07","updated":"2019-06-21 13:46:29.000000000","message":"it\u0027s still relevant but we don\u0027t have that info yet, hence the todo.  It\u0027s not really necessary at the moment, it would be a nice to have so I\u0027d rather TODO this and land the minion install and fix this up in a follow up.","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c91da2ee21191b344e867cf585a6d41ef4aafbf","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            \u0027--upgrade\u0027,"},{"line_number":210,"context_line":"            \u0027-e\u0027, os.path.join("},{"line_number":211,"context_line":"                tht_templates,"},{"line_number":212,"context_line":"                \"environments/lifecycle/undercloud-upgrade-prepare.yaml\")]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    if not CONF.get(\u0027heat_native\u0027, False):"},{"line_number":215,"context_line":"        deploy_args.append(\u0027--heat-native\u003dFalse\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_f440ea09","line":212,"updated":"2019-06-21 13:25:14.000000000","message":"just to be sure, we want to reuse the same file here for minion upgrade prepare?","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a6e249b361ef0bc3c7f2fe35f11b9833635d447d","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            \u0027--upgrade\u0027,"},{"line_number":210,"context_line":"            \u0027-e\u0027, os.path.join("},{"line_number":211,"context_line":"                tht_templates,"},{"line_number":212,"context_line":"                \"environments/lifecycle/undercloud-upgrade-prepare.yaml\")]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    if not CONF.get(\u0027heat_native\u0027, False):"},{"line_number":215,"context_line":"        deploy_args.append(\u0027--heat-native\u003dFalse\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_34c76215","line":212,"in_reply_to":"9fb8cfa7_f440ea09","updated":"2019-06-21 13:46:29.000000000","message":"it\u0027s the same upgrade environment file because we\u0027re reusing the UndercloudUpgrade service","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c91da2ee21191b344e867cf585a6d41ef4aafbf","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    deploy_args.append(\u0027--log-file\u003d%s\u0027 % CONF[\u0027minion_log_file\u0027])"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    # Always add a drop-in for the ephemeral undercloud heat stack"},{"line_number":343,"context_line":"    # virtual state tracking (the actual file will be created later)"},{"line_number":344,"context_line":"    stack_vstate_dropin \u003d os.path.join("},{"line_number":345,"context_line":"        tht_templates, \u0027minion-stack-vstate-dropin.yaml\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_5463f6b1","line":342,"range":{"start_line":342,"start_character":45,"end_line":342,"end_character":55},"updated":"2019-06-21 13:25:14.000000000","message":"minion","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a6e249b361ef0bc3c7f2fe35f11b9833635d447d","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    deploy_args.append(\u0027--log-file\u003d%s\u0027 % CONF[\u0027minion_log_file\u0027])"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    # Always add a drop-in for the ephemeral undercloud heat stack"},{"line_number":343,"context_line":"    # virtual state tracking (the actual file will be created later)"},{"line_number":344,"context_line":"    stack_vstate_dropin \u003d os.path.join("},{"line_number":345,"context_line":"        tht_templates, \u0027minion-stack-vstate-dropin.yaml\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_14a25e4c","line":342,"range":{"start_line":342,"start_character":45,"end_line":342,"end_character":55},"in_reply_to":"9fb8cfa7_5463f6b1","updated":"2019-06-21 13:46:29.000000000","message":"Done","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c91da2ee21191b344e867cf585a6d41ef4aafbf","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            constants.STANDALONE_EPHEMERAL_STACK_VSTATE,"},{"line_number":360,"context_line":"            \u0027update_mark_minion\u0027)"},{"line_number":361,"context_line":"        if os.path.isfile(stack_update_mark) or force_stack_update:"},{"line_number":362,"context_line":"            LOG.warning(_(\u0027The heat stack undercloud virtual state/action \u0027"},{"line_number":363,"context_line":"                          \u0027 would be UPDATE\u0027))"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    return cmd"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_944f2e33","line":362,"range":{"start_line":362,"start_character":42,"end_line":362,"end_character":52},"updated":"2019-06-21 13:25:14.000000000","message":"minion...","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a6e249b361ef0bc3c7f2fe35f11b9833635d447d","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            constants.STANDALONE_EPHEMERAL_STACK_VSTATE,"},{"line_number":360,"context_line":"            \u0027update_mark_minion\u0027)"},{"line_number":361,"context_line":"        if os.path.isfile(stack_update_mark) or force_stack_update:"},{"line_number":362,"context_line":"            LOG.warning(_(\u0027The heat stack undercloud virtual state/action \u0027"},{"line_number":363,"context_line":"                          \u0027 would be UPDATE\u0027))"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    return cmd"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_b48832c6","line":362,"range":{"start_line":362,"start_character":42,"end_line":362,"end_character":52},"in_reply_to":"9fb8cfa7_944f2e33","updated":"2019-06-21 13:46:29.000000000","message":"Done","commit_id":"d07e1b1a5fb305e1067361d14525306d70dd952a"}],"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c9f92e22be791eb20d1b1e810abe334061062d39","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        if hosts:"},{"line_number":880,"context_line":"            outputs[\u0027ExtraHostFileEntries\u0027] \u003d hosts"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"        globalcfg \u003d utils.get_stack_output_item(stack, \u0027GlocalConfig\u0027)"},{"line_number":883,"context_line":"        if globalcfg:"},{"line_number":884,"context_line":"            outputs[\u0027GlobalConfigExtraMapData\u0027] \u003d globalcfg"},{"line_number":885,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9fb8cfa7_bd196ed7","line":882,"range":{"start_line":882,"start_character":56,"end_line":882,"end_character":62},"updated":"2019-06-14 12:38:25.000000000","message":"Glo*c*al or Global?","commit_id":"af91bfb626db0318f4ee152905197c17b319c1cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1bf8e815d3201a2d0cedea0a9cc62a69649e9168","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        if hosts:"},{"line_number":880,"context_line":"            outputs[\u0027ExtraHostFileEntries\u0027] \u003d hosts"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"        globalcfg \u003d utils.get_stack_output_item(stack, \u0027GlocalConfig\u0027)"},{"line_number":883,"context_line":"        if globalcfg:"},{"line_number":884,"context_line":"            outputs[\u0027GlobalConfigExtraMapData\u0027] \u003d globalcfg"},{"line_number":885,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9fb8cfa7_5853a06b","line":882,"range":{"start_line":882,"start_character":56,"end_line":882,"end_character":62},"in_reply_to":"9fb8cfa7_bd196ed7","updated":"2019-06-14 13:27:38.000000000","message":"is a new word. Glocal, it\u0027s up to you to figure it out :D\n\nwill fix","commit_id":"af91bfb626db0318f4ee152905197c17b319c1cf"}]}