)]}'
{"tripleoclient/v1/tripleo_validator.py":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"df9aa8e047756084a498ef6a69fb776eb35b6a63","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        LOG.debug(_(\u0027Runnning the validations\u0027))"},{"line_number":171,"context_line":"        output \u003d validations.run_validations(clients, workflow_input)"},{"line_number":172,"context_line":"        for out in output:"},{"line_number":173,"context_line":"            print(\u0027[{}] - {}\\n{}\u0027.format("},{"line_number":174,"context_line":"                out.get(\u0027status\u0027),"},{"line_number":175,"context_line":"                out.get(\u0027validation_name\u0027),"},{"line_number":176,"context_line":"                oooutils.indent(out.get(\u0027stdout\u0027))))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def take_action(self, parsed_args):"},{"line_number":179,"context_line":"        self._run_validator_run(parsed_args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_4b66f92b","line":176,"range":{"start_line":171,"start_character":0,"end_line":176,"end_character":52},"updated":"2019-06-21 10:07:45.000000000","message":"Any example of the new output? I am a git concerned that you may miss some fields or even make it fail in the future if the format changes. Why not just using pprint json approach? \nThere are multiple ways to display json in a friendly way.","commit_id":"2aa75a274a06b93a1893a4b63cac8f7830b16405"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"4f3ee3f79ff3ccebeb95638109f09552cabf03cd","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            print(\u0027[{}] - {}\\n{}\u0027.format("},{"line_number":174,"context_line":"                out.get(\u0027status\u0027),"},{"line_number":175,"context_line":"                out.get(\u0027validation_name\u0027),"},{"line_number":176,"context_line":"                oooutils.indent(out.get(\u0027stdout\u0027))))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def take_action(self, parsed_args):"},{"line_number":179,"context_line":"        self._run_validator_run(parsed_args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_eee6dbe8","line":176,"updated":"2019-06-21 11:01:50.000000000","message":"You will find an example here http://paste.openstack.org/show/753253/\nThe way I used is probably not the most friendly way to do it but I wanted readibility when running multiple validations and identify quickly which ones failed or not.","commit_id":"2aa75a274a06b93a1893a4b63cac8f7830b16405"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"24636879debe2370e415c70ce1e12ad330be773b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            print(\u0027[{}] - {}\\n{}\u0027.format("},{"line_number":174,"context_line":"                out.get(\u0027status\u0027),"},{"line_number":175,"context_line":"                out.get(\u0027validation_name\u0027),"},{"line_number":176,"context_line":"                oooutils.indent(out.get(\u0027stdout\u0027))))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def take_action(self, parsed_args):"},{"line_number":179,"context_line":"        self._run_validator_run(parsed_args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_ae6c6336","line":176,"updated":"2019-06-21 11:08:57.000000000","message":"with oooutils.get_validations_json function, you can get this http://paste.openstack.org/raw/753255/","commit_id":"2aa75a274a06b93a1893a4b63cac8f7830b16405"}],"tripleoclient/workflows/validations.py":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"70dfd0f7dc1d7098ec4124dec9ea1d9ba10b96ec","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        for payload in base.wait_for_messages(workflow_client, ws, execution):"},{"line_number":63,"context_line":"            if \u0027message\u0027 in payload:"},{"line_number":64,"context_line":"                if payload[\u0027status\u0027] \u003d\u003d \u0027SUCCESS\u0027:"},{"line_number":65,"context_line":"                    if payload[\u0027message\u0027] is None:"},{"line_number":66,"context_line":"                        return payload[\u0027stdout\u0027]"},{"line_number":67,"context_line":"                    else:"},{"line_number":68,"context_line":"                        return payload[\u0027message\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_37cd9484","line":65,"updated":"2019-05-31 12:31:33.000000000","message":"(nit) this can be simplified:\nif \u0027message\u0027 in payload:\n  msg \u003d {}\n  if payload[\u0027message\u0027] is None:\n    msg \u003d payload[\u0027stdout\u0027]\n  else:\n    msg \u003d payload[\u0027message\u0027]\n  if payload[\u0027status\u0027] \u003d\u003d \u0027SUCCESS\u0027:\n    return msg\n  elif payload[\u0027status\u0027] \u003d\u003d \u0027FAILED\u0027:\n    raise exceptions.RegisterOrUpdateError(\n      \u0027Exception running validations:\\n\\n{}\u0027.format(msg))","commit_id":"7634e05925f646cdab7986c72d698885e655c0dc"}]}