)]}'
{"releasenotes/notes/overcloud-cloud-yaml-support-fae7585c46eda8e8.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1a3db707fe48ba0480374073eab52f564c07026","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OpenStack overcloud services cli and api is currently access through"},{"line_number":5,"context_line":"    overcloudrc and clouds.yaml."},{"line_number":6,"context_line":"    There is no support for overcloud clouds.yaml currently. It adds the"},{"line_number":7,"context_line":"    support for `overcloud` OS_CLOUD."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_d4057d11","line":4,"updated":"2019-06-25 07:43:03.000000000","message":"accessed","commit_id":"6350ad124107dc7b5c90d1969fb38dde231ba82b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1a3db707fe48ba0480374073eab52f564c07026","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OpenStack overcloud services cli and api is currently access through"},{"line_number":5,"context_line":"    overcloudrc and clouds.yaml."},{"line_number":6,"context_line":"    There is no support for overcloud clouds.yaml currently. It adds the"},{"line_number":7,"context_line":"    support for `overcloud` OS_CLOUD."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_9413855c","line":7,"range":{"start_line":6,"start_character":7,"end_line":7,"end_character":37},"updated":"2019-06-25 07:43:03.000000000","message":"consider reversing these like \"this adds support for overcloud clouds.yaml file generation after deployment. The file can be found at /etc/openstack/clouds.yaml","commit_id":"6350ad124107dc7b5c90d1969fb38dde231ba82b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"665550e1274014397e0da64e10fc281fc1488c74","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    OpenStack overcloud services cli and api is currently accessed through"},{"line_number":5,"context_line":"    overcloudrc and clouds.yaml."},{"line_number":6,"context_line":"    This adds support for overcloud clouds.yaml file generation after"},{"line_number":7,"context_line":"    deployment. The file can be found at ~/.config/openstack/clouds.yaml."}],"source_content_type":"text/x-yaml","patch_set":47,"id":"7faddb67_0b069d1e","line":7,"updated":"2019-07-12 07:53:22.000000000","message":"and /etc/openstack/clouds.yaml","commit_id":"98b1f9c951320b37fe08891bc5e1d6d5575417e5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56fdf36a78fd47ed314dcd43eed4aa29c777252b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    OpenStack overcloud services cli and api is currently accessed through"},{"line_number":5,"context_line":"    overcloudrc and clouds.yaml."},{"line_number":6,"context_line":"    This adds support for overcloud clouds.yaml file generation after"},{"line_number":7,"context_line":"    deployment. The file can be found at ~/.config/openstack/clouds.yaml."}],"source_content_type":"text/x-yaml","patch_set":47,"id":"7faddb67_d5e56d0a","line":7,"in_reply_to":"7faddb67_0b069d1e","updated":"2019-07-15 06:10:43.000000000","message":"Done","commit_id":"98b1f9c951320b37fe08891bc5e1d6d5575417e5"}],"tripleoclient/clouds_yaml.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f18683ac02469fa0df3a2c15e9f63e9c28bb769e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import subprocess"},{"line_number":19,"context_line":"import yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if os.getenv(\"SUDO_USER\"):"},{"line_number":22,"context_line":"    USER \u003d os.getenv(\"SUDO_USER\")"},{"line_number":23,"context_line":"else:"},{"line_number":24,"context_line":"    USER \u003d os.getenv(\"USER\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"HOME_DIR \u003d os.path.abspath(os.path.expanduser(\"~{0}\".format(USER)))"},{"line_number":27,"context_line":"CONFIG_DIR \u003d os.path.join(HOME_DIR, \u0027.config\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_aae7ebe2","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":28},"updated":"2019-07-01 06:55:18.000000000","message":"USER \u003d os.getenv(\u0027sudo_user\u0027, os.getenv(\u0027user\u0027))","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"bbd2fa0fb565de80c798014ab1cc20b14a7141ed","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import subprocess"},{"line_number":19,"context_line":"import yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if os.getenv(\"SUDO_USER\"):"},{"line_number":22,"context_line":"    USER \u003d os.getenv(\"SUDO_USER\")"},{"line_number":23,"context_line":"else:"},{"line_number":24,"context_line":"    USER \u003d os.getenv(\"USER\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"HOME_DIR \u003d os.path.abspath(os.path.expanduser(\"~{0}\".format(USER)))"},{"line_number":27,"context_line":"CONFIG_DIR \u003d os.path.join(HOME_DIR, \u0027.config\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_4494238b","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":28},"in_reply_to":"9fb8cfa7_aae7ebe2","updated":"2019-07-01 09:45:03.000000000","message":"Done","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f18683ac02469fa0df3a2c15e9f63e9c28bb769e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            os.chown(OS_DIR, user_id, group_id)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if not os.path.isfile(USER_CLOUDS_YAML):"},{"line_number":98,"context_line":"            _create_clouds_yaml(USER_CLOUDS_YAML)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        user_clouds \u003d _read_clouds_yaml(USER_CLOUDS_YAML)"},{"line_number":101,"context_line":"        user_clouds[\u0027clouds\u0027].update(CLOUD)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_ea2f23f3","line":98,"range":{"start_line":98,"start_character":32,"end_line":98,"end_character":48},"updated":"2019-07-01 06:55:18.000000000","message":"as this is a global variable no need to pass it from here.","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"bbd2fa0fb565de80c798014ab1cc20b14a7141ed","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            os.chown(OS_DIR, user_id, group_id)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if not os.path.isfile(USER_CLOUDS_YAML):"},{"line_number":98,"context_line":"            _create_clouds_yaml(USER_CLOUDS_YAML)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        user_clouds \u003d _read_clouds_yaml(USER_CLOUDS_YAML)"},{"line_number":101,"context_line":"        user_clouds[\u0027clouds\u0027].update(CLOUD)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_2499efc2","line":98,"range":{"start_line":98,"start_character":32,"end_line":98,"end_character":48},"in_reply_to":"9fb8cfa7_ea2f23f3","updated":"2019-07-01 09:45:03.000000000","message":"https://review.opendev.org/#/c/664586/28/tripleoclient/clouds_yaml.py@70 all these above functions are called twice for USER and GLOBAL vars otherwise it will not work.","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f18683ac02469fa0df3a2c15e9f63e9c28bb769e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if not os.path.isfile(USER_CLOUDS_YAML):"},{"line_number":98,"context_line":"            _create_clouds_yaml(USER_CLOUDS_YAML)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        user_clouds \u003d _read_clouds_yaml(USER_CLOUDS_YAML)"},{"line_number":101,"context_line":"        user_clouds[\u0027clouds\u0027].update(CLOUD)"},{"line_number":102,"context_line":"        _write_clouds_yaml(USER_CLOUDS_YAML, user_clouds)"},{"line_number":103,"context_line":"        os.chown(USER_CLOUDS_YAML, user_id, group_id)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_8a32275d","line":100,"range":{"start_line":100,"start_character":40,"end_line":100,"end_character":56},"updated":"2019-07-01 06:55:18.000000000","message":"ditto","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f18683ac02469fa0df3a2c15e9f63e9c28bb769e","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        user_clouds \u003d _read_clouds_yaml(USER_CLOUDS_YAML)"},{"line_number":101,"context_line":"        user_clouds[\u0027clouds\u0027].update(CLOUD)"},{"line_number":102,"context_line":"        _write_clouds_yaml(USER_CLOUDS_YAML, user_clouds)"},{"line_number":103,"context_line":"        os.chown(USER_CLOUDS_YAML, user_id, group_id)"},{"line_number":104,"context_line":"        print(\"The clouds.yaml file is at {0}\".format(USER_CLOUDS_YAML))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_4a40afa5","line":102,"range":{"start_line":102,"start_character":27,"end_line":102,"end_character":43},"updated":"2019-07-01 06:55:18.000000000","message":"ditto","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f18683ac02469fa0df3a2c15e9f63e9c28bb769e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        user_clouds[\u0027clouds\u0027].update(CLOUD)"},{"line_number":102,"context_line":"        _write_clouds_yaml(USER_CLOUDS_YAML, user_clouds)"},{"line_number":103,"context_line":"        os.chown(USER_CLOUDS_YAML, user_id, group_id)"},{"line_number":104,"context_line":"        print(\"The clouds.yaml file is at {0}\".format(USER_CLOUDS_YAML))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # Undercloud deployment is done as a root user and overcloud"},{"line_number":107,"context_line":"        # deployment is done as a normal user. So clouds.yaml creation"}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_aa35ab46","line":104,"range":{"start_line":104,"start_character":54,"end_line":104,"end_character":70},"updated":"2019-07-01 06:55:18.000000000","message":"ditto","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f18683ac02469fa0df3a2c15e9f63e9c28bb769e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            os.makedirs(GLOBAL_OS_DIR)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if not os.path.isfile(GLOBAL_CLOUDS_YAML):"},{"line_number":117,"context_line":"            _create_clouds_yaml(GLOBAL_CLOUDS_YAML)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        if os.geteuid() \u003d\u003d 0:"},{"line_number":120,"context_line":"            global_clouds \u003d _read_clouds_yaml(GLOBAL_CLOUDS_YAML)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_0a4637c1","line":117,"range":{"start_line":117,"start_character":32,"end_line":117,"end_character":50},"updated":"2019-07-01 06:55:18.000000000","message":"ditto","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f18683ac02469fa0df3a2c15e9f63e9c28bb769e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            _create_clouds_yaml(GLOBAL_CLOUDS_YAML)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        if os.geteuid() \u003d\u003d 0:"},{"line_number":120,"context_line":"            global_clouds \u003d _read_clouds_yaml(GLOBAL_CLOUDS_YAML)"},{"line_number":121,"context_line":"            global_clouds[\u0027clouds\u0027].update(CLOUD)"},{"line_number":122,"context_line":"            _write_clouds_yaml(GLOBAL_CLOUDS_YAML, global_clouds)"},{"line_number":123,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_ca157f9d","line":120,"range":{"start_line":120,"start_character":46,"end_line":120,"end_character":64},"updated":"2019-07-01 06:55:18.000000000","message":"ditto","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f18683ac02469fa0df3a2c15e9f63e9c28bb769e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        if os.geteuid() \u003d\u003d 0:"},{"line_number":120,"context_line":"            global_clouds \u003d _read_clouds_yaml(GLOBAL_CLOUDS_YAML)"},{"line_number":121,"context_line":"            global_clouds[\u0027clouds\u0027].update(CLOUD)"},{"line_number":122,"context_line":"            _write_clouds_yaml(GLOBAL_CLOUDS_YAML, global_clouds)"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            _copy_file(USER_CLOUDS_YAML, GLOBAL_CLOUDS_YAML)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_ea1883d3","line":122,"range":{"start_line":122,"start_character":31,"end_line":122,"end_character":49},"updated":"2019-07-01 06:55:18.000000000","message":"ditto","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f18683ac02469fa0df3a2c15e9f63e9c28bb769e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            global_clouds[\u0027clouds\u0027].update(CLOUD)"},{"line_number":122,"context_line":"            _write_clouds_yaml(GLOBAL_CLOUDS_YAML, global_clouds)"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            _copy_file(USER_CLOUDS_YAML, GLOBAL_CLOUDS_YAML)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        print(\"The clouds.yaml file is at {0}\".format(GLOBAL_CLOUDS_YAML))"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_8a0b077b","line":124,"range":{"start_line":124,"start_character":23,"end_line":124,"end_character":58},"updated":"2019-07-01 06:55:18.000000000","message":"ditto","commit_id":"a34916ac5cd37404a1e0fa2672e8f665db671642"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9f5b64a995ed89c54081ce1b1c2db3752cccc9e5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            global_clouds \u003d _read_clouds_yaml(GLOBAL_CLOUDS_YAML)"},{"line_number":117,"context_line":"            global_clouds[\u0027clouds\u0027].update(CLOUD)"},{"line_number":118,"context_line":"            _write_clouds_yaml(GLOBAL_CLOUDS_YAML, global_clouds)"},{"line_number":119,"context_line":"        else:"},{"line_number":120,"context_line":"            _copy_file(USER_CLOUDS_YAML, GLOBAL_CLOUDS_YAML)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        print(\"The clouds.yaml file is at {0}\".format(GLOBAL_CLOUDS_YAML))"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_c7cb351b","line":120,"range":{"start_line":119,"start_character":8,"end_line":120,"end_character":60},"updated":"2019-07-01 11:14:29.000000000","message":"We should\u0027nt copy the file. It would overwrite the admin users version for the file with the users file. Do we need to add the overcloud to /etc/openstack/clouds.yaml at all?","commit_id":"62354faed54880de9584e8a8b8d2785bd2bb764f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cb2bcbb0626157e44e0c0b8fda6b7b0dda39ab98","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            global_clouds \u003d _read_clouds_yaml(GLOBAL_CLOUDS_YAML)"},{"line_number":117,"context_line":"            global_clouds[\u0027clouds\u0027].update(CLOUD)"},{"line_number":118,"context_line":"            _write_clouds_yaml(GLOBAL_CLOUDS_YAML, global_clouds)"},{"line_number":119,"context_line":"        else:"},{"line_number":120,"context_line":"            _copy_file(USER_CLOUDS_YAML, GLOBAL_CLOUDS_YAML)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        print(\"The clouds.yaml file is at {0}\".format(GLOBAL_CLOUDS_YAML))"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_6db82374","line":120,"range":{"start_line":119,"start_character":8,"end_line":120,"end_character":60},"in_reply_to":"9fb8cfa7_4e5c3a4a","updated":"2019-07-01 16:59:40.000000000","message":"Why does os_tempest run as root?\n\nCan os_tempest, which is running as root copy the file from $user_home to it\u0027s current working directory? Or, since we have sudo, we could also change the permissions/ownership on \u0027/etc/openstack/clouds.yaml\u0027, update it and then change it back to the previous owner, a bit hacky but I\u0027d be more happy with that than the copying.\n\n\nI typically use my undercloud as the node where I operate on rdocloud as well. In my $user_home clouds.yaml, it looks like this:\n\nclouds:\n  undercloud:\n    auth:\n      auth_url: https://192.168.24.2:13000\n      password: \u003cnothing_to_see_here\u003e\n      project_domain_name: Default\n      project_name: admin\n      user_domain_name: Default\n      username: admin\n    identity_api_version: \u00273\u0027\n    region_name: regionOne\n  rdocloud:\n    auth:\n      auth_url: https://cloud.example.com:13000\n      username: \u003cuser\u003e\n      project_name: \u003cproject\u003e\n      password: \u003cpasswd\u003e\n    region_name: \u003cregion\u003e\n\nI don\u0027t want that rdocloud entry going into the global file.","commit_id":"62354faed54880de9584e8a8b8d2785bd2bb764f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5520d5e5a299b1fd2352815bacd8185373ffc5bd","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            global_clouds \u003d _read_clouds_yaml(GLOBAL_CLOUDS_YAML)"},{"line_number":117,"context_line":"            global_clouds[\u0027clouds\u0027].update(CLOUD)"},{"line_number":118,"context_line":"            _write_clouds_yaml(GLOBAL_CLOUDS_YAML, global_clouds)"},{"line_number":119,"context_line":"        else:"},{"line_number":120,"context_line":"            _copy_file(USER_CLOUDS_YAML, GLOBAL_CLOUDS_YAML)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        print(\"The clouds.yaml file is at {0}\".format(GLOBAL_CLOUDS_YAML))"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_4e5c3a4a","line":120,"range":{"start_line":119,"start_character":8,"end_line":120,"end_character":60},"in_reply_to":"9fb8cfa7_c7cb351b","updated":"2019-07-01 15:33:12.000000000","message":"Since os_tempest runs as root, so we either need to copy this to /etc/openstack/ or /root/.config/openstack folder otherwise it will not work. I am seeing no other option instead of copying the file or will I just copy the stuff to /root/.config/openstack there so that os_tempest should work?","commit_id":"62354faed54880de9584e8a8b8d2785bd2bb764f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8e4c0f5f1fac86f07281dca926497cadb156bb62","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        yaml.safe_dump(clouds, f, default_flow_style\u003dFalse)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def create(CLOUD\u003dNone):"},{"line_number":66,"context_line":"    \"\"\"Generates clouds.yaml file"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    :param CLOUD: dict containing cloud data"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fb8cfa7_2abaff6d","line":65,"updated":"2019-07-02 15:15:08.000000000","message":"This should be in tripleo-common but the folder/users could be a param. I dont\u0027 think passing this information in via an environment vars is correct for this","commit_id":"f2c62cabe92a2694dcc4501fea47010151e84419"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"461af404e4e5e8eed8358d9cd26977f2c4c05ff3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        yaml.safe_dump(clouds, f, default_flow_style\u003dFalse)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def create(CLOUD\u003dNone):"},{"line_number":66,"context_line":"    \"\"\"Generates clouds.yaml file"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    :param CLOUD: dict containing cloud data"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fb8cfa7_b0c3be57","line":65,"in_reply_to":"9fb8cfa7_2abaff6d","updated":"2019-07-02 16:23:54.000000000","message":"The values are pass here https://review.opendev.org/#/c/664586/32/tripleoclient/v1/overcloud_deploy.py@991 in tripleoclient itself.\n\nThe actions are defined in tripleo-common.\n\nFor undercloud and standalone, we are passing the vars from env vars.https://github.com/openstack/tripleo-heat-templates/blob/master/extraconfig/post_deploy/standalone_post.yaml#L72\n\nThe script is tweaked in such a way so that it should work at both places for undercloud as well as overcloud and standalone","commit_id":"f2c62cabe92a2694dcc4501fea47010151e84419"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f0737dbc89ee3d64a0029bd5028c8788abf237ef","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        yaml.safe_dump(clouds, f, default_flow_style\u003dFalse)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def create(CLOUD\u003dNone):"},{"line_number":66,"context_line":"    \"\"\"Generates clouds.yaml file"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    :param CLOUD: dict containing cloud data"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fb8cfa7_70ba26c1","line":65,"in_reply_to":"9fb8cfa7_b0c3be57","updated":"2019-07-02 16:29:40.000000000","message":"The problem is the inclusion of this in tripleo-heat-template. There\u0027s no reason this can\u0027t live elsewhere except you\u0027re assuming it\u0027s run with environment variables. I\u0027d rather the environment vars \u0026 defines end up being converted into proper parameters and we only do the lookup in the expected places (the tripleoclient call itself)","commit_id":"f2c62cabe92a2694dcc4501fea47010151e84419"}],"tripleoclient/tests/v1/overcloud_deploy/test_overcloud_deploy.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"20df60b95cafdf1da0b2726a27120e3101859a0d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from osc_lib.tests import utils"},{"line_number":27,"context_line":"from swiftclient.exceptions import ClientException as ObjectClientException"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from tripleoclient import constants"},{"line_number":31,"context_line":"from tripleoclient import exceptions"},{"line_number":32,"context_line":"from tripleoclient.tests.fixture_data import deployment"}],"source_content_type":"text/x-python","patch_set":38,"id":"7faddb67_be94bf45","line":29,"updated":"2019-07-08 07:47:24.000000000","message":"random space added","commit_id":"8ebf4ed62706368eafb77d7518870f1f5ee5a4e7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8786a7479df34b6a13f371be4c21b9f64f296bb5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from osc_lib.tests import utils"},{"line_number":27,"context_line":"from swiftclient.exceptions import ClientException as ObjectClientException"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from tripleoclient import constants"},{"line_number":31,"context_line":"from tripleoclient import exceptions"},{"line_number":32,"context_line":"from tripleoclient.tests.fixture_data import deployment"}],"source_content_type":"text/x-python","patch_set":38,"id":"7faddb67_2cd3c53a","line":29,"in_reply_to":"7faddb67_be94bf45","updated":"2019-07-08 09:50:02.000000000","message":"Done","commit_id":"8ebf4ed62706368eafb77d7518870f1f5ee5a4e7"}],"tripleoclient/v1/mock_clouds_yaml.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"665550e1274014397e0da64e10fc281fc1488c74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"7faddb67_8b112d55","updated":"2019-07-12 07:53:22.000000000","message":"TODO remove me once tripleo-common released","commit_id":"98b1f9c951320b37fe08891bc5e1d6d5575417e5"}],"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"20df60b95cafdf1da0b2726a27120e3101859a0d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from tripleo_common import update"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# FIXME(chkumar246): Once https://review.opendev.org/664568 gets merged"},{"line_number":37,"context_line":"# and new version of tripleo-common gots released, remove it."},{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    from tripleo_common.utils import clouds_yaml"},{"line_number":40,"context_line":"except ImportError:"}],"source_content_type":"text/x-python","patch_set":38,"id":"7faddb67_3e8a0f1b","line":37,"updated":"2019-07-08 07:47:24.000000000","message":"This will need a version bump in requirements.txt once the tripleo-common patch lands","commit_id":"8ebf4ed62706368eafb77d7518870f1f5ee5a4e7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8786a7479df34b6a13f371be4c21b9f64f296bb5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from tripleo_common import update"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# FIXME(chkumar246): Once https://review.opendev.org/664568 gets merged"},{"line_number":37,"context_line":"# and new version of tripleo-common gots released, remove it."},{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    from tripleo_common.utils import clouds_yaml"},{"line_number":40,"context_line":"except ImportError:"}],"source_content_type":"text/x-python","patch_set":38,"id":"7faddb67_0ce28904","line":37,"in_reply_to":"7faddb67_3e8a0f1b","updated":"2019-07-08 09:50:02.000000000","message":"Updated the fixme comment.","commit_id":"8ebf4ed62706368eafb77d7518870f1f5ee5a4e7"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"675912e324c4ce9fc8ee093af36fd0b06e2babff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# FIXME(chkumar246): Once https://review.opendev.org/664568 gets merged"},{"line_number":37,"context_line":"# and new version of tripleo-common gots released, It requires a version"},{"line_number":38,"context_line":"# bump in requirements.txt."},{"line_number":39,"context_line":"try:"},{"line_number":40,"context_line":"    from tripleo_common.utils import clouds_yaml"},{"line_number":41,"context_line":"except ImportError:"},{"line_number":42,"context_line":"    from tripleoclient.v1 import mock_clouds_yaml as clouds_yaml"}],"source_content_type":"text/x-python","patch_set":39,"id":"7faddb67_52e25ad7","line":39,"updated":"2019-07-08 12:37:59.000000000","message":"IMO we should do this at once instead create additional patch","commit_id":"e40e8c2aab8c9036095d2981235dabb2b30dadb9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"273c487c2be5735e7db356ab34bc57d6bef64432","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# FIXME(chkumar246): Once https://review.opendev.org/664568 gets merged"},{"line_number":37,"context_line":"# and new version of tripleo-common gots released, It requires a version"},{"line_number":38,"context_line":"# bump in requirements.txt."},{"line_number":39,"context_line":"try:"},{"line_number":40,"context_line":"    from tripleo_common.utils import clouds_yaml"},{"line_number":41,"context_line":"except ImportError:"},{"line_number":42,"context_line":"    from tripleoclient.v1 import mock_clouds_yaml as clouds_yaml"}],"source_content_type":"text/x-python","patch_set":39,"id":"7faddb67_1d2867e0","line":39,"in_reply_to":"7faddb67_52e25ad7","updated":"2019-07-09 06:31:47.000000000","message":"In order to make the stuff working, we are monkey patching it, once the new tripleo-common gets available we will remove it.","commit_id":"e40e8c2aab8c9036095d2981235dabb2b30dadb9"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"675912e324c4ce9fc8ee093af36fd0b06e2babff","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        # Create overcloud clouds.yaml"},{"line_number":1012,"context_line":"        cloud_data \u003d deployment.create_cloudsyaml("},{"line_number":1013,"context_line":"            self.clients, container\u003dstack.stack_name)"},{"line_number":1014,"context_line":"        clouds_yaml.create(cloud_data)"},{"line_number":1015,"context_line":"        rcpath \u003d utils.write_overcloudrc(stack.stack_name, overcloudrcs)"},{"line_number":1016,"context_line":"        utils.create_tempest_deployer_input()"},{"line_number":1017,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"7faddb67_92f0d292","line":1014,"updated":"2019-07-08 12:37:59.000000000","message":"Here we should catch error from tripleo_common and log reasone what failed","commit_id":"e40e8c2aab8c9036095d2981235dabb2b30dadb9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"273c487c2be5735e7db356ab34bc57d6bef64432","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        # Create overcloud clouds.yaml"},{"line_number":1012,"context_line":"        cloud_data \u003d deployment.create_cloudsyaml("},{"line_number":1013,"context_line":"            self.clients, container\u003dstack.stack_name)"},{"line_number":1014,"context_line":"        clouds_yaml.create(cloud_data)"},{"line_number":1015,"context_line":"        rcpath \u003d utils.write_overcloudrc(stack.stack_name, overcloudrcs)"},{"line_number":1016,"context_line":"        utils.create_tempest_deployer_input()"},{"line_number":1017,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"7faddb67_dd764f07","line":1014,"in_reply_to":"7faddb67_92f0d292","updated":"2019-07-09 06:31:47.000000000","message":"the clouds_yaml.py script is shared for undercloud overcloud and standalone deployment, so we are keeping the print message in clouds_yaml.py itself it gets printed in deploy logs.","commit_id":"e40e8c2aab8c9036095d2981235dabb2b30dadb9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"665550e1274014397e0da64e10fc281fc1488c74","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"            cloud\u003dcloud_data,"},{"line_number":1018,"context_line":"            cloud_yaml_dir\u003dcloud_yaml_dir,"},{"line_number":1019,"context_line":"            user_id\u003d1000,"},{"line_number":1020,"context_line":"            group_id\u003d1000)"},{"line_number":1021,"context_line":"        rcpath \u003d utils.write_overcloudrc(stack.stack_name, overcloudrcs)"},{"line_number":1022,"context_line":"        utils.create_tempest_deployer_input()"},{"line_number":1023,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"7faddb67_4b3015e9","line":1020,"updated":"2019-07-12 07:53:22.000000000","message":"why hard code these you already have CLOUD_USER can\u0027t we find the ID from the name","commit_id":"98b1f9c951320b37fe08891bc5e1d6d5575417e5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"56fdf36a78fd47ed314dcd43eed4aa29c777252b","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"            cloud\u003dcloud_data,"},{"line_number":1018,"context_line":"            cloud_yaml_dir\u003dcloud_yaml_dir,"},{"line_number":1019,"context_line":"            user_id\u003d1000,"},{"line_number":1020,"context_line":"            group_id\u003d1000)"},{"line_number":1021,"context_line":"        rcpath \u003d utils.write_overcloudrc(stack.stack_name, overcloudrcs)"},{"line_number":1022,"context_line":"        utils.create_tempest_deployer_input()"},{"line_number":1023,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"7faddb67_15e0e5f9","line":1020,"in_reply_to":"7faddb67_36ee5ded","updated":"2019-07-15 06:10:43.000000000","message":"Done","commit_id":"98b1f9c951320b37fe08891bc5e1d6d5575417e5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c21042a8f71ec7ec0cde410880ff3020d7c4376a","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"            cloud\u003dcloud_data,"},{"line_number":1018,"context_line":"            cloud_yaml_dir\u003dcloud_yaml_dir,"},{"line_number":1019,"context_line":"            user_id\u003d1000,"},{"line_number":1020,"context_line":"            group_id\u003d1000)"},{"line_number":1021,"context_line":"        rcpath \u003d utils.write_overcloudrc(stack.stack_name, overcloudrcs)"},{"line_number":1022,"context_line":"        utils.create_tempest_deployer_input()"},{"line_number":1023,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"7faddb67_36ee5ded","line":1020,"in_reply_to":"7faddb67_4b3015e9","updated":"2019-07-12 13:07:52.000000000","message":"Yes don\u0027t hard code this, please lookup the correct id\u0027s. I don\u0027t use a stack user so this likely wouldn\u0027t work for me.","commit_id":"98b1f9c951320b37fe08891bc5e1d6d5575417e5"}],"tripleoclient/workflows/deployment.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3b6d0d27e82e9b89e928bce737ce08f2cda2d083","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                return payload.get(\u0027message\u0027)"},{"line_number":151,"context_line":"            else:"},{"line_number":152,"context_line":"                raise exceptions.WorkflowServiceError("},{"line_number":153,"context_line":"                    \u0027Exception creating overcloud cloudyaml: {}\u0027.format("},{"line_number":154,"context_line":"                        payload.get(\u0027message\u0027)))"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_b5d2eccf","line":153,"range":{"start_line":153,"start_character":50,"end_line":153,"end_character":59},"updated":"2019-06-14 07:09:35.000000000","message":"since this is an error message might be clearer to say \"... clouds.yaml file\"","commit_id":"a848bbbd47f31e3e395ddb43445fa38bd94531f3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"624973ea489149a7fe20e06f9213c7fb9c6b302a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                return payload.get(\u0027message\u0027)"},{"line_number":151,"context_line":"            else:"},{"line_number":152,"context_line":"                raise exceptions.WorkflowServiceError("},{"line_number":153,"context_line":"                    \u0027Exception creating overcloud cloudyaml: {}\u0027.format("},{"line_number":154,"context_line":"                        payload.get(\u0027message\u0027)))"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_c72d7595","line":153,"range":{"start_line":153,"start_character":50,"end_line":153,"end_character":59},"in_reply_to":"9fb8cfa7_b5d2eccf","updated":"2019-06-14 09:50:28.000000000","message":"Done","commit_id":"a848bbbd47f31e3e395ddb43445fa38bd94531f3"}]}