)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3f06dc90599589e5dc363ad85a6782a309a4dea9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t seem to send the execution object anymore after"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/630291/. Though we\u0027ve"},{"line_number":11,"context_line":"execution_id, it probably does not make sense to make"},{"line_number":12,"context_line":"mistral api call to get the created/updated timestamps."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I11f500165026455d8d41fd07901357fc91d8a359"},{"line_number":15,"context_line":"Closes-Bug: #1832511"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_d078ce90","line":12,"range":{"start_line":11,"start_character":43,"end_line":12,"end_character":16},"updated":"2019-06-14 07:36:29.000000000","message":"not sure about that. I mean this is wired up as the \"openstack overcloud status\" command so the created/updated might be useful/necessary info","commit_id":"7bd6a5206612f6d4818c891860e58d2281d0f27a"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"826bcd5eea7b8fb32019a1b97c5c1085dbd5b369","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t seem to send the execution object anymore after"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/630291/. Though we\u0027ve"},{"line_number":11,"context_line":"execution_id, it probably does not make sense to make"},{"line_number":12,"context_line":"mistral api call to get the created/updated timestamps."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I11f500165026455d8d41fd07901357fc91d8a359"},{"line_number":15,"context_line":"Closes-Bug: #1832511"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_a4087f91","line":12,"range":{"start_line":11,"start_character":43,"end_line":12,"end_character":16},"in_reply_to":"9fb8cfa7_d078ce90","updated":"2019-06-14 09:13:52.000000000","message":"Well, AFAIU \u0027overcloud status\u0027 command is meant to check the current deployment status.\n\nUnless the user wants to know (using this command) when config download was last run (started and finished), though updated timestamp is misleading (same as created) until the execution finishes, IMO, we don\u0027t need these timestamps.\n\nAlso every deployment creates a new mistral execution. Therefore the old timestamps don\u0027t exist when a new deployment is started (which is not possible until the old one is finished).\n\nI would possibly agree that changing the cli/user interface behavior (right or wrong) is something we should avoid. \n\nIf we still think that \u0027overcloud status\u0027 was meant to provide additional information (other than the status i.e deploying/deployed), we could change the workbook to include these timestamps along with execution_id/root_execution_id.","commit_id":"7bd6a5206612f6d4818c891860e58d2281d0f27a"}],"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3f06dc90599589e5dc363ad85a6782a309a4dea9","unresolved":false,"context_lines":[{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        payload \u003d status[\u0027workflow_status\u0027][\u0027payload\u0027]"},{"line_number":1032,"context_line":"        table \u003d PrettyTable("},{"line_number":1033,"context_line":"            [\u0027Plan Name\u0027, \u0027Deployment Status\u0027])"},{"line_number":1034,"context_line":"        table.add_row([payload[\u0027plan_name\u0027],"},{"line_number":1035,"context_line":"                       payload[\u0027deployment_status\u0027]])"},{"line_number":1036,"context_line":"        print(table, file\u003dself.app.stdout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d09d2ebc","line":1033,"updated":"2019-06-14 07:36:29.000000000","message":"i think its at least worth a TODO: use payload[\u0027execution_id\u0027] to get time +bug/1832511 \nif its a blocker/urgent\notherwise imo the time info is relevant","commit_id":"7bd6a5206612f6d4818c891860e58d2281d0f27a"}]}