)]}'
{"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"cb60a07f0db8cf054ddbb92684e5842d680a6bb9","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                    if not os.path.isfile(env_file.replace(\".yaml\","},{"line_number":548,"context_line":"                                                           \".j2.yaml\")):"},{"line_number":549,"context_line":"                        nonexisting_envs.append(env_file)"},{"line_number":550,"context_line":"            # Check networks_file existance"},{"line_number":551,"context_line":"            if parsed_args.networks_file:"},{"line_number":552,"context_line":"                if parsed_args.networks_file.endswith(\".j2.yaml\"):"},{"line_number":553,"context_line":"                    jinja2_envs.append(parsed_args.networks_file)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7c8a611b","line":550,"updated":"2019-06-26 10:41:59.000000000","message":"s/existance/existence/","commit_id":"d20326e2fce76d56652175e8d677c4a1ece390fb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7364716ca26e51eb7668eb439dee2161fca7ee76","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                        nonexisting_envs.append(env_file)"},{"line_number":550,"context_line":"            # Check networks_file existance"},{"line_number":551,"context_line":"            if parsed_args.networks_file:"},{"line_number":552,"context_line":"                if parsed_args.networks_file.endswith(\".j2.yaml\"):"},{"line_number":553,"context_line":"                    jinja2_envs.append(parsed_args.networks_file)"},{"line_number":554,"context_line":"                elif not os.path.isfile(parsed_args.networks_file):"},{"line_number":555,"context_line":"                    if not os.path.isfile("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_c88dc77c","line":552,"updated":"2019-06-26 13:53:35.000000000","message":"We shouldn\u0027t get a .j2.yaml file passed in here. The reference should always be whatever.yaml when passed as arguments.  The process-templates handles the generating of the .yaml and it will always be filename.j2.yaml \u003d\u003e filename.yaml (as far as I know).","commit_id":"d20326e2fce76d56652175e8d677c4a1ece390fb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"20afda58e9ad74ca7a85afe3d3ced796a7f1d2ab","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                        nonexisting_envs.append(env_file)"},{"line_number":550,"context_line":"            # Check networks_file existance"},{"line_number":551,"context_line":"            if parsed_args.networks_file:"},{"line_number":552,"context_line":"                if parsed_args.networks_file.endswith(\".j2.yaml\"):"},{"line_number":553,"context_line":"                    jinja2_envs.append(parsed_args.networks_file)"},{"line_number":554,"context_line":"                elif not os.path.isfile(parsed_args.networks_file):"},{"line_number":555,"context_line":"                    if not os.path.isfile("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_57d38a01","line":552,"in_reply_to":"9fb8cfa7_34ee14ed","updated":"2019-06-28 12:44:14.000000000","message":"parsed_args.networks_file is what is passed in using the \u0027-n\u0027 option, it is\u0027nt a Heat environment file.\n\nIf you where to try to jinja template that file it would very likely crash, as yaml.safe_load is used to read that file here: https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/templates.py#L193\n\nA j2.yaml file with actual jinja2 template content would cause that yaml.safe_load to raise an exception because the jinja2 content would be invalid yaml.","commit_id":"d20326e2fce76d56652175e8d677c4a1ece390fb"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"998aabb11d0294f2be6308b87919b4ddf64ec34a","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                        nonexisting_envs.append(env_file)"},{"line_number":550,"context_line":"            # Check networks_file existance"},{"line_number":551,"context_line":"            if parsed_args.networks_file:"},{"line_number":552,"context_line":"                if parsed_args.networks_file.endswith(\".j2.yaml\"):"},{"line_number":553,"context_line":"                    jinja2_envs.append(parsed_args.networks_file)"},{"line_number":554,"context_line":"                elif not os.path.isfile(parsed_args.networks_file):"},{"line_number":555,"context_line":"                    if not os.path.isfile("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_34ee14ed","line":552,"in_reply_to":"9fb8cfa7_ad2e3c89","updated":"2019-06-28 11:13:31.000000000","message":"there are some .j2.yaml files in both \"environment/network\" and \"network\" trees - but I\u0027m not sure any of those are the right files to pass as \"networks-file\".. Hence the questions/discussions :).\n\nIf we never get a generated file, fine for the easy way - else we\u0027ll need to take into account the fact we might pass a .yaml referencing a .j2.yaml.","commit_id":"d20326e2fce76d56652175e8d677c4a1ece390fb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"90c3247f6c19200913a821bb5e70f5bd06aa55d2","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                        nonexisting_envs.append(env_file)"},{"line_number":550,"context_line":"            # Check networks_file existance"},{"line_number":551,"context_line":"            if parsed_args.networks_file:"},{"line_number":552,"context_line":"                if parsed_args.networks_file.endswith(\".j2.yaml\"):"},{"line_number":553,"context_line":"                    jinja2_envs.append(parsed_args.networks_file)"},{"line_number":554,"context_line":"                elif not os.path.isfile(parsed_args.networks_file):"},{"line_number":555,"context_line":"                    if not os.path.isfile("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_ad2e3c89","line":552,"in_reply_to":"9fb8cfa7_c88dc77c","updated":"2019-06-28 08:23:56.000000000","message":"I agree with Alex, we should never get a .j2.yaml file passed in as \u0027networks_file\u0027. network_data and role_data is what is used as input for the jinja processing of templates.\n\nI don\u0027t understand, why do we need anything more than:\n  if parsed_args.networks_file:\n      if not os.path.isfile(parsed_args.networks_file):\n          nonexisting_envs.append(parsed_args.networks_file)\n\n?","commit_id":"d20326e2fce76d56652175e8d677c4a1ece390fb"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2a3d9aa547565f03dbf9af5fbcbc184b85367bb3","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                elif not os.path.isfile(parsed_args.networks_file):"},{"line_number":555,"context_line":"                    if not os.path.isfile("},{"line_number":556,"context_line":"                            parsed_args.networks_file.replace("},{"line_number":557,"context_line":"                                \".yaml\", \".j2.yaml\")):"},{"line_number":558,"context_line":"                        nonexisting_envs.append(parsed_args.networks_file)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"            # check plan_environment_file existance"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_bc73f94d","line":557,"updated":"2019-06-26 10:42:23.000000000","message":"does that establish a 1:1 mapping between a missing yaml file and its j2 predecessor? So that we assume foo.yaml is a nonexisting env file, if there is no foo.j2.yaml matching it?\n\nIs that OK for any network generated files? I\u0027m not sure the composable networks always fit into such 1:1 mappings...","commit_id":"d20326e2fce76d56652175e8d677c4a1ece390fb"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"8fbb0557bfd788262f5d78dba259a78d82495ac3","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                elif not os.path.isfile(parsed_args.networks_file):"},{"line_number":555,"context_line":"                    if not os.path.isfile("},{"line_number":556,"context_line":"                            parsed_args.networks_file.replace("},{"line_number":557,"context_line":"                                \".yaml\", \".j2.yaml\")):"},{"line_number":558,"context_line":"                        nonexisting_envs.append(parsed_args.networks_file)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"            # check plan_environment_file existance"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7c06e188","line":557,"in_reply_to":"9fb8cfa7_bc73f94d","updated":"2019-06-26 10:48:04.000000000","message":"Not sure if we can pass a j2 for that one :s.","commit_id":"d20326e2fce76d56652175e8d677c4a1ece390fb"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"cb60a07f0db8cf054ddbb92684e5842d680a6bb9","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                                \".yaml\", \".j2.yaml\")):"},{"line_number":558,"context_line":"                        nonexisting_envs.append(parsed_args.networks_file)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"            # check plan_environment_file existance"},{"line_number":561,"context_line":"            if parsed_args.plan_environment_file:"},{"line_number":562,"context_line":"                if not os.path.isfile(parsed_args.plan_environment_file):"},{"line_number":563,"context_line":"                    nonexisting_envs.append(parsed_args.plan_environment_file)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_9c8f1529","line":560,"updated":"2019-06-26 10:41:59.000000000","message":"ditto","commit_id":"d20326e2fce76d56652175e8d677c4a1ece390fb"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"cb60a07f0db8cf054ddbb92684e5842d680a6bb9","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                if not os.path.isfile(parsed_args.plan_environment_file):"},{"line_number":563,"context_line":"                    nonexisting_envs.append(parsed_args.plan_environment_file)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"            # check answers_file existance"},{"line_number":566,"context_line":"            if parsed_args.answers_file:"},{"line_number":567,"context_line":"                if not os.path.isfile(parsed_args.answers_file):"},{"line_number":568,"context_line":"                    nonexisting_envs.append(parsed_args.answers_file)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_3c8069f7","line":565,"updated":"2019-06-26 10:41:59.000000000","message":"ditto","commit_id":"d20326e2fce76d56652175e8d677c4a1ece390fb"}]}