)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"256985a6c58d4cb828e70de3ff1fb29ebbf6092e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"By design the legacy instack passwords file should only be used when doing upgrades from instack undercloud to containerized undercloud. And it probably should not fail, but only warning? So new passwords will be generated in the upgrade process."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While currently, the undercloud install command fails the pre-flight checks, when there is no undercloud-passwords.conf file."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Icfb64e052814055d183dcecc1e9ca06fe3dbab7c"},{"line_number":12,"context_line":"Closes-Bug: #1796101"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_dae25bd5","line":10,"updated":"2019-06-27 08:38:19.000000000","message":"Please can you limit your commit message to 72 characters per row.","commit_id":"abbe239ad4b04c60c67f7c4165daaf5721d75bbe"}],"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"1ea274a10ddeef9040f7924d2061919415dde79e","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                        k \u003d \u0027\u0027.join(i.capitalize() for i in k.split(\u0027_\u0027)[1:])"},{"line_number":388,"context_line":"                    legacy_env[k] \u003d v"},{"line_number":389,"context_line":"            else:"},{"line_number":390,"context_line":"                open(undercloud_pw_file, \u0027a\u0027).close()"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"            # Get the keystone keys before upgrade"},{"line_number":393,"context_line":"            keystone_fernet_repo \u003d \u0027/etc/keystone/fernet-keys/\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_2efa5c74","line":390,"range":{"start_line":390,"start_character":16,"end_line":390,"end_character":53},"updated":"2019-06-27 09:28:31.000000000","message":"Might be replaced by one of those two:\n\nfrom pathlib import Path\nPath(undercloud_pw_file).touch()\n\nor:\nimport os\nos.mknod(undercloud_pw_file)\n\nThe advantages: less I/O, and cleaner. Not 100% sure pathlib is available though, and can still be a follow-up later.","commit_id":"82be85d3a7ba5a5d445fe118cd6ff84bfbbaa428"}]}