)]}'
{"id":"openstack%2Fpython-tripleoclient~667778","triplet_id":"openstack%2Fpython-tripleoclient~master~Ibaf24f89d15e8423679eef45f1691a1a660c71a3","project":"openstack/python-tripleoclient","branch":"master","hashtags":[],"change_id":"Ibaf24f89d15e8423679eef45f1691a1a660c71a3","subject":"mock kernel_arch() in tests.","status":"MERGED","created":"2019-06-27 03:05:39.000000000","updated":"2019-07-01 15:36:25.000000000","submitted":"2019-07-01 15:36:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"667778-1561995385386-b2b03a6a","meta_rev_id":"cf4639eda6bdd7df45d1943d325c2061f7432dbe","_number":667778,"virtual_id_number":667778,"owner":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2019-07-01 15:36:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-27 05:54:10.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-06-28 14:40:15.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-01 12:50:39.000000000","_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-01 12:50:39.000000000","_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-27 05:54:10.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-28 14:40:15.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-07-01 12:50:39.000000000","updated_by":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"reviewer":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"state":"REVIEWER"},{"updated":"2019-07-01 15:36:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e2af9f78d2a3d62b4037d1145bc873bf864a0285","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-06-27 03:05:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"37e8e8aaddfe94e39e62aed0eddb03330a43fa0f","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-06-27 05:54:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/78/667778/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/2301955/ : SUCCESS in 2h 37m 20s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/78/667778/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/8c4ef62/ : SUCCESS in 2h 47m 17s\n- tripleo-ci-centos-7-multinode-1ctlr-featureset010 http://logs.rdoproject.org/78/667778/1/openstack-check/tripleo-ci-centos-7-multinode-1ctlr-featureset010/565ba84/ : SUCCESS in 1h 25m 51s","accounts_in_message":[],"_revision_number":1},{"id":"556a406064cc2b022893dba44483d7575e3eb2a8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-27 06:19:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/78/667778/1/check/openstack-tox-lower-constraints/59027c9/ : SUCCESS in 4m 45s\n- openstackclient-check-plugins http://logs.openstack.org/78/667778/1/check/openstackclient-check-plugins/c0ad21b/ : SUCCESS in 3m 55s (non-voting)\n- openstack-tox-pep8 http://logs.openstack.org/78/667778/1/check/openstack-tox-pep8/efc3030/ : SUCCESS in 3m 26s\n- openstack-tox-py27 http://logs.openstack.org/78/667778/1/check/openstack-tox-py27/b5cfeb5/ : SUCCESS in 4m 28s\n- openstack-tox-py35 http://logs.openstack.org/78/667778/1/check/openstack-tox-py35/f09c123/ : SUCCESS in 3m 55s\n- openstack-tox-py36 http://logs.openstack.org/78/667778/1/check/openstack-tox-py36/91d4a5a/ : SUCCESS in 3m 27s\n- openstack-tox-py37 http://logs.openstack.org/78/667778/1/check/openstack-tox-py37/31ba4ec/ : SUCCESS in 3m 41s\n- openstack-tox-docs http://logs.openstack.org/78/667778/1/check/openstack-tox-docs/618200a/html/ : SUCCESS in 4m 16s\n- tripleo-buildimage-overcloud-full-centos-7 http://logs.openstack.org/78/667778/1/check/tripleo-buildimage-overcloud-full-centos-7/62963f8/ : SUCCESS in 24m 41s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-containers-multinode/7d6219a/ : SUCCESS in 2h 09m 01s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-undercloud-containers/5ede974/ : SUCCESS in 1h 36m 31s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/5699de6/ : SUCCESS in 2h 07m 10s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/7d653bb/ : SUCCESS in 2h 42m 36s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-standalone/d6a8ff6/ : SUCCESS in 1h 54m 30s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/78/667778/1/check/tripleo-ci-fedora-28-standalone/78f2be9/ : SUCCESS in 1h 51m 28s (non-voting)\n- tripleo-ci-centos-7-standalone-upgrade http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-standalone-upgrade/86128f9/ : SUCCESS in 2h 17m 35s (non-voting)\n- tripleo-ci-centos-7-standalone-upgrade-stein http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-standalone-upgrade-stein/ec1784e/ : SUCCESS in 2h 04m 01s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/0bfb159/ : FAILURE in 1h 20m 28s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/4e8a6de/ : SUCCESS in 2h 15m 36s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container http://logs.openstack.org/78/667778/1/check/tripleo-ci-centos-7-scenario009-multinode-oooq-container/4b744fc/ : SUCCESS in 2h 14m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"39c1e70239fd8295bfd65d72937599e9f8f24954","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-06-28 14:40:15.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8bdbd6ce1649b461174012390f4d31c8b9032e9c","author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"date":"2019-07-01 12:50:39.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"fdc7e6d4046a0d1995af2dd4cff7afa30f223562","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 12:51:18.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ffbfe41902a6166db14b697907e0c8cf926deb2b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 15:36:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"cf4639eda6bdd7df45d1943d325c2061f7432dbe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 15:36:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/78/667778/1/gate/openstack-tox-lower-constraints/ac273d1/ : SUCCESS in 5m 12s\n- openstack-tox-pep8 http://logs.openstack.org/78/667778/1/gate/openstack-tox-pep8/d453a2f/ : SUCCESS in 3m 30s\n- openstack-tox-py27 http://logs.openstack.org/78/667778/1/gate/openstack-tox-py27/1f567ee/ : SUCCESS in 3m 59s\n- openstack-tox-py35 http://logs.openstack.org/78/667778/1/gate/openstack-tox-py35/971c687/ : SUCCESS in 4m 08s\n- openstack-tox-py36 http://logs.openstack.org/78/667778/1/gate/openstack-tox-py36/9392b27/ : SUCCESS in 3m 48s\n- openstack-tox-py37 http://logs.openstack.org/78/667778/1/gate/openstack-tox-py37/eaa6f05/ : SUCCESS in 4m 21s\n- openstack-tox-docs http://logs.openstack.org/78/667778/1/gate/openstack-tox-docs/b223322/html/ : SUCCESS in 3m 22s\n- tripleo-buildimage-overcloud-full-centos-7 http://logs.openstack.org/78/667778/1/gate/tripleo-buildimage-overcloud-full-centos-7/a0f4af0/ : SUCCESS in 22m 59s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/78/667778/1/gate/tripleo-ci-centos-7-containers-multinode/268599e/ : SUCCESS in 2h 11m 04s\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/78/667778/1/gate/tripleo-ci-centos-7-standalone/67ab03e/ : SUCCESS in 2h 00m 02s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/78/667778/1/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/58864ba/ : SUCCESS in 2h 26m 24s\n- tripleo-ci-centos-7-standalone-upgrade-stein http://logs.openstack.org/78/667778/1/gate/tripleo-ci-centos-7-standalone-upgrade-stein/844c8e7/ : SUCCESS in 2h 06m 13s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/78/667778/1/gate/tripleo-ci-centos-7-undercloud-containers/7d69aeb/ : SUCCESS in 1h 43m 54s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f05cbe322b358195744e43db1be29cc69894cde1","revisions":{"f05cbe322b358195744e43db1be29cc69894cde1":{"kind":"REWORK","_number":1,"created":"2019-06-27 03:05:39.000000000","uploader":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"ref":"refs/changes/78/667778/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/78/667778/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/78/667778/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/78/667778/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/78/667778/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/78/667778/1"}}},"commit":{"parents":[{"commit":"02a4a829ad9a651a8251c6da9e7220a310476a4e","subject":"Merge \"Bump keystone middleware version to 4.18\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/02a4a829ad9a651a8251c6da9e7220a310476a4e"}]}],"author":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-06-27 03:02:43.000000000","tz":600},"committer":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-06-27 03:02:43.000000000","tz":600},"subject":"mock kernel_arch() in tests.","message":"mock kernel_arch() in tests.\n\nWhen running unit tests on non x86_64 systems (for example s390x) the\nunit tests fail with:\n\ntripleoclient.tests.v1.overcloud_image.test_overcloud_image.TestUploadOvercloudImageFullMultiArch.test_overcloud_create_images_with_arch\n----------------------------------------------------------------------------------------------------------------------------------------\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    b\u0027Traceback (most recent call last):\u0027\n    b\u0027  File \"/usr/lib/python3.6/site-packages/mock/mock.py\", line 1305, in patched\u0027\n    b\u0027    return func(*args, **keywargs)\u0027\n    b\u0027  File \"/builddir/build/BUILD/python-tripleoclient-12.0.1.dev32/tripleoclient/tests/v1/overcloud_image/test_overcloud_image.py\", line 671, in test_overcloud_create_images_with_arch\u0027\n    b\"    mock.call(11, hw_architecture\u003d\u0027ppc64le\u0027),\"\n    b\u0027  File \"/usr/lib/python3.6/site-packages/mock/mock.py\", line 969, in assert_has_calls\u0027\n    b\u0027    ), cause)\u0027\n    b\u0027  File \"\u003cstring\u003e\", line 3, in raise_from\u0027\n    b\u0027AssertionError: Calls not found.\u0027\n    b\"Expected: [call(10, hw_architecture\u003d\u0027x86_64\u0027), call(11, hw_architecture\u003d\u0027ppc64le\u0027)]\"\n    b\"Actual: [call(10, hw_architecture\u003d\u0027s390x\u0027), call(11, hw_architecture\u003d\u0027ppc64le\u0027)]\"\n    b\u0027\u0027\n\nSo we need to mock the call to kernel_arch() so that regardless of where\nwe\u0027re running the unit tests we always appear to be x86_64.\n\nChange-Id: Ibaf24f89d15e8423679eef45f1691a1a660c71a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/f05cbe322b358195744e43db1be29cc69894cde1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/f05cbe322b358195744e43db1be29cc69894cde1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}