)]}'
{"tripleoclient/utils.py":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"d9c40e5dff496b45876d822165b25177462de00a","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"    return val"},{"line_number":1871,"context_line":""},{"line_number":1872,"context_line":""},{"line_number":1873,"context_line":"def get_param_field_name(validations_data\u003d{}):"},{"line_number":1874,"context_line":"    \"\"\"Get the current parameters field name in a Dict"},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"    Returns either \u0027parameters\u0027 or \u0027metadata\u0027."}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_90fdc3b2","line":1873,"updated":"2019-07-15 08:11:55.000000000","message":"Please don\u0027t use dictionary as a default param you should use pattern like:\ndef get_param_field_name(validations_data\u003dNone):\n  if validations_data is None:\n    validations_data \u003d {}\n\ntake a look here: https://docs.python-guide.org/writing/gotchas/#what-you-should-do-instead","commit_id":"ca75aef6e515e241f49adf10e934f4daaeb9abfc"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"d9c40e5dff496b45876d822165b25177462de00a","unresolved":false,"context_lines":[{"line_number":1878,"context_line":"    \"\"\""},{"line_number":1879,"context_line":"    # TODO(gchamoul): Added for backwards compatibility and will be"},{"line_number":1880,"context_line":"    # removed for Train release."},{"line_number":1881,"context_line":"    if \u0027metadata\u0027 in validations_data[\u0027validations\u0027][0]:"},{"line_number":1882,"context_line":"        return \u0027metadata\u0027"},{"line_number":1883,"context_line":"    return \u0027parameters\u0027"},{"line_number":1884,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_f0b3d708","line":1881,"updated":"2019-07-15 08:11:55.000000000","message":"if validations_data will be a empty dict this will couse error, this should be:\nif \u0027metadata\u0027 in validations_dataget(\u0027validations\u0027, [[]])[0]\n\nAlso please add unit test for this case","commit_id":"ca75aef6e515e241f49adf10e934f4daaeb9abfc"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"d9c40e5dff496b45876d822165b25177462de00a","unresolved":false,"context_lines":[{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"def get_validations_parameters(validations_data,"},{"line_number":1887,"context_line":"                               validation_name\u003d[],"},{"line_number":1888,"context_line":"                               groups\u003d[]):"},{"line_number":1889,"context_line":"    params \u003d {}"},{"line_number":1890,"context_line":"    param_field_name \u003d get_param_field_name(validations_data)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_10b9d3e7","line":1887,"updated":"2019-07-15 08:11:55.000000000","message":"please avoid empty list as a default parameter, use the same pattern like with dict.","commit_id":"ca75aef6e515e241f49adf10e934f4daaeb9abfc"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"d9c40e5dff496b45876d822165b25177462de00a","unresolved":false,"context_lines":[{"line_number":1892,"context_line":"    for val in validations_data[\u0027validations\u0027]:"},{"line_number":1893,"context_line":"        wanted_validation \u003d False"},{"line_number":1894,"context_line":"        wanted_group \u003d False"},{"line_number":1895,"context_line":"        if validation_name:"},{"line_number":1896,"context_line":"            if val.get(\u0027id\u0027) in validation_name:"},{"line_number":1897,"context_line":"                wanted_validation \u003d True"},{"line_number":1898,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_109c735b","line":1895,"updated":"2019-07-15 08:11:55.000000000","message":"we don\u0027t need this statement, default value for validation_name is always empty list so this can be simply:\nif val.get(\u0027id\u0027) in validation_name:\n                wanted_validation \u003d True","commit_id":"ca75aef6e515e241f49adf10e934f4daaeb9abfc"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"d9c40e5dff496b45876d822165b25177462de00a","unresolved":false,"context_lines":[{"line_number":1896,"context_line":"            if val.get(\u0027id\u0027) in validation_name:"},{"line_number":1897,"context_line":"                wanted_validation \u003d True"},{"line_number":1898,"context_line":""},{"line_number":1899,"context_line":"        if groups:"},{"line_number":1900,"context_line":"            for grp in groups:"},{"line_number":1901,"context_line":"                if grp in val.get(\u0027groups\u0027):"},{"line_number":1902,"context_line":"                    wanted_group \u003d True"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_b0a47fa7","line":1899,"updated":"2019-07-15 08:11:55.000000000","message":"groups is a empty list so we don\u0027t need this if statement","commit_id":"ca75aef6e515e241f49adf10e934f4daaeb9abfc"}],"tripleoclient/v1/tripleo_validator.py":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"bbb332cb01c63a7ae27f28c7b289c46b844567da","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        return parser"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _check_if_file_already_exists(self, file):"},{"line_number":118,"context_line":"        msg \u003d \"\"\"The file %s already exists on the filesystem,"},{"line_number":119,"context_line":"do you still want to continue [y/N] \"\"\""},{"line_number":120,"context_line":"        if os.path.exists(file):"},{"line_number":121,"context_line":"            confirm \u003d oooutils.prompt_user_for_confirmation("},{"line_number":122,"context_line":"                message\u003dmsg % file, logger\u003dLOG)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_f025175d","line":119,"range":{"start_line":118,"start_character":14,"end_line":119,"end_character":39},"updated":"2019-07-15 07:58:11.000000000","message":"I think the common way for that is using\nmsg \u003d (\u0027foo\u0027\n       \u0027bar\u0027)\nor something like that, that keeps the indentation clean.","commit_id":"ca75aef6e515e241f49adf10e934f4daaeb9abfc"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"962e65567b76cbfb144f0b756adf2b057662fff1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        return parser"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _create_variables_file(self, data, varsfile):"},{"line_number":118,"context_line":"        msg \u003d (_(\"The file %s already exists on the filesystem, \""},{"line_number":119,"context_line":"                 \"do you still want to continue [y/N] \"))"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        if varsfile[0] not in [\u0027json\u0027, \u0027yaml\u0027]:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_2026fa16","line":118,"range":{"start_line":118,"start_character":14,"end_line":118,"end_character":15},"updated":"2019-07-15 11:36:10.000000000","message":"not sure we have to enclose it as a tuple? _(\u0027foo\u0027 \u0027bar\u0027 \u0027...\u0027) should be enough.. ?","commit_id":"02b12197631086f841a43a68ff40e5a7d2f5b6fc"}]}