)]}'
{"tripleoclient/utils.py":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5a7d75e96e282d966d0dfbbd4255a12fd25bdaa2","unresolved":false,"context_lines":[{"line_number":1222,"context_line":"def cleanup_tripleo_ansible_inventory_file(path):"},{"line_number":1223,"context_line":"    \"\"\"Remove the static tripleo-ansible-inventory file from disk\"\"\""},{"line_number":1224,"context_line":"    if os.path.exists(path):"},{"line_number":1225,"context_line":"        processutils.execute(\u0027/usr/bin/rm\u0027, \u0027-f\u0027, path)"},{"line_number":1226,"context_line":""},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"def process_multiple_environments(created_env_files, tht_root,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_6a7208e6","line":1225,"updated":"2019-07-24 05:27:08.000000000","message":"hm, why not os.unlink directly?","commit_id":"66698a1c0c842314af76c7bd709c1b8611ed1e91"}],"tripleoclient/v1/tripleo_validator.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ea87b672430f623114c2859f96f36d24bb9a6907","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                    playbook, oooutils.indent(output)))"},{"line_number":360,"context_line":"            except Exception as e:"},{"line_number":361,"context_line":"                print(\u0027[FAILED] - {}\\n{}\u0027.format("},{"line_number":362,"context_line":"                    playbook, oooutils.indent(e.args[0])))"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        LOG(_(\u0027Removing static tripleo ansible inventory file\u0027))"},{"line_number":365,"context_line":"        oooutils.cleanup_tripleo_ansible_inventory_file(static_inventory)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_03c12181","line":362,"updated":"2019-07-22 13:19:09.000000000","message":"I just noticed this but we should probably end this function in an error if we had failed checks. This would mean we should have a finally for the cleanup.","commit_id":"8ef27869a39fecb9c8e2bcf7dbe8374689ec6675"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c2d385579defb8b19ed27cae8abfd7d143e50726","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                                                  oooutils.indent(output)))"},{"line_number":362,"context_line":"            except Exception as e:"},{"line_number":363,"context_line":"                failed_val \u003d True"},{"line_number":364,"context_line":"                print(\u0027[FAILED] - {}\\n{}\u0027.format(playbook,"},{"line_number":365,"context_line":"                                                 oooutils.indent(e.args[0])))"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        LOG.debug(_(\u0027Removing static tripleo ansible inventory file\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_ca66aa2a","line":364,"range":{"start_line":364,"start_character":16,"end_line":364,"end_character":21},"updated":"2019-07-23 13:18:10.000000000","message":"If you need to respin this, this should be a LOG.error. openstack client only shows LOG.warn or higher but in this instance LOG.error would be appropriate","commit_id":"fd7ecd2b2633bb23f03e9b25ef1afb8ddd344c51"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c2d385579defb8b19ed27cae8abfd7d143e50726","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            static_inventory)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        if failed_val:"},{"line_number":372,"context_line":"            LOG.debug(_(\u0027One or more validations have failed!\u0027))"},{"line_number":373,"context_line":"            sys.exit(1)"},{"line_number":374,"context_line":"        sys.exit(0)"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_8a70b2de","line":372,"range":{"start_line":372,"start_character":16,"end_line":372,"end_character":21},"updated":"2019-07-23 13:18:10.000000000","message":"error","commit_id":"fd7ecd2b2633bb23f03e9b25ef1afb8ddd344c51"}]}