)]}'
{"id":"openstack%2Fpython-tripleoclient~673756","triplet_id":"openstack%2Fpython-tripleoclient~stable%2Fstein~Idff6bcebc041db483d64396249b040e6bdd778bd","project":"openstack/python-tripleoclient","branch":"stable/stein","topic":"bp/validation-framework-stable/stein","hashtags":[],"change_id":"Idff6bcebc041db483d64396249b040e6bdd778bd","subject":"Allow running validations with custom extra variables","status":"MERGED","created":"2019-07-31 08:35:52.000000000","updated":"2019-07-31 17:40:30.000000000","submitted":"2019-07-31 17:40:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673756-1564594830071-3342d8ab","meta_rev_id":"e0a20f15a3d339eea7146e4aa2537f56a79f9c90","_number":673756,"virtual_id_number":673756,"owner":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":2,"date":"2019-07-31 17:40:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-31 11:24:20.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":2,"date":"2019-07-31 13:55:32.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"date":"2019-07-31 08:36:10.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-07-31 08:36:14.000000000","_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":1,"date":"2019-07-31 13:55:32.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2019-07-31 08:36:04.000000000","_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-31 08:36:00.000000000","_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-31 08:36:00.000000000","updated_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"reviewer":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"state":"REVIEWER"},{"updated":"2019-07-31 08:36:04.000000000","updated_by":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"reviewer":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"state":"REVIEWER"},{"updated":"2019-07-31 08:36:10.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-07-31 08:36:14.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"state":"REVIEWER"},{"updated":"2019-07-31 11:24:20.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-31 13:55:32.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-07-31 17:40:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"81d6e44aa18307ac52c7c4ffb5e3330140cb888b","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2019-07-31 08:35:52.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"56472ba686e93998473528c09a4be4dea0068737","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-07-31 11:24:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/56/673756/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/8743e83/ : SUCCESS in 2h 46m 23s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/56/673756/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/a75472e/ : SUCCESS in 2h 46m 55s","accounts_in_message":[],"_revision_number":1},{"id":"7a0e491c1243537a9843b31c8646aa069f6f093b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 13:32:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/56/673756/1/check/openstack-tox-lower-constraints/0c37cb1/ : SUCCESS in 6m 09s\n- openstackclient-check-plugins http://logs.openstack.org/56/673756/1/check/openstackclient-check-plugins/9d35529/ : SUCCESS in 5m 21s (non-voting)\n- openstack-tox-pep8 http://logs.openstack.org/56/673756/1/check/openstack-tox-pep8/ab2edef/ : SUCCESS in 5m 14s\n- openstack-tox-py27 http://logs.openstack.org/56/673756/1/check/openstack-tox-py27/ebdfccf/ : SUCCESS in 4m 56s\n- openstack-tox-py35 http://logs.openstack.org/56/673756/1/check/openstack-tox-py35/90ea597/ : SUCCESS in 6m 00s\n- openstack-tox-py36 http://logs.openstack.org/56/673756/1/check/openstack-tox-py36/225b043/ : SUCCESS in 3m 20s\n- openstack-tox-py37 http://logs.openstack.org/56/673756/1/check/openstack-tox-py37/47c24a3/ : SUCCESS in 4m 00s\n- openstack-tox-docs http://logs.openstack.org/56/673756/1/check/openstack-tox-docs/f923ef0/html/ : SUCCESS in 4m 10s\n- build-openstack-releasenotes http://logs.openstack.org/56/673756/1/check/build-openstack-releasenotes/3c4257a/html/ : SUCCESS in 3m 42s\n- tripleo-buildimage-overcloud-full-centos-7 http://logs.openstack.org/56/673756/1/check/tripleo-buildimage-overcloud-full-centos-7/d82825c/ : SUCCESS in 23m 12s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/56/673756/1/check/tripleo-ci-centos-7-containers-multinode/00c7cac/ : SUCCESS in 2h 12m 01s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/56/673756/1/check/tripleo-ci-centos-7-undercloud-containers/74623a2/ : SUCCESS in 1h 39m 41s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/56/673756/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/ee607a8/ : SUCCESS in 2h 25m 57s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/56/673756/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/05d43b9/ : SUCCESS in 2h 54m 10s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/56/673756/1/check/tripleo-ci-centos-7-standalone/72886a0/ : SUCCESS in 1h 56m 44s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/56/673756/1/check/tripleo-ci-fedora-28-standalone/b5c043d/ : SUCCESS in 1h 31m 07s (non-voting)\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/56/673756/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/6a1454a/ : FAILURE in 1h 36m 57s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container http://logs.openstack.org/56/673756/1/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/d93eb7e/ : SUCCESS in 2h 25m 17s (non-voting)\n- tripleo-ci-centos-7-scenario008-multinode-oooq-container http://logs.openstack.org/56/673756/1/check/tripleo-ci-centos-7-scenario008-multinode-oooq-container/be0db47/ : FAILURE in 1h 27m 34s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container http://logs.openstack.org/56/673756/1/check/tripleo-ci-centos-7-scenario009-multinode-oooq-container/cf1af2c/ : SUCCESS in 2h 20m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8ef6ff0aa2408af1aea4baf517d32ed826fb9e58","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-07-31 13:55:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"315b03abb117c66a38d5f4f2efdb6abaf79256f2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 13:55:55.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"036e31f7f24089c76bd0d64898ca448eb9ab6c49","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 17:40:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/56/673756/1/gate/openstack-tox-lower-constraints/ab25210/ : SUCCESS in 5m 37s\n- openstack-tox-pep8 http://logs.openstack.org/56/673756/1/gate/openstack-tox-pep8/881516b/ : SUCCESS in 4m 10s\n- openstack-tox-py27 http://logs.openstack.org/56/673756/1/gate/openstack-tox-py27/499bba5/ : SUCCESS in 4m 40s\n- openstack-tox-py35 http://logs.openstack.org/56/673756/1/gate/openstack-tox-py35/4c188cf/ : SUCCESS in 4m 22s\n- openstack-tox-py36 http://logs.openstack.org/56/673756/1/gate/openstack-tox-py36/b62da57/ : SUCCESS in 4m 50s\n- openstack-tox-py37 http://logs.openstack.org/56/673756/1/gate/openstack-tox-py37/e1c6e55/ : SUCCESS in 5m 10s\n- openstack-tox-docs http://logs.openstack.org/56/673756/1/gate/openstack-tox-docs/0690e36/html/ : SUCCESS in 4m 35s\n- build-openstack-releasenotes http://logs.openstack.org/56/673756/1/gate/build-openstack-releasenotes/9968bb6/html/ : SUCCESS in 3m 22s\n- tripleo-buildimage-overcloud-full-centos-7 http://logs.openstack.org/56/673756/1/gate/tripleo-buildimage-overcloud-full-centos-7/7923634/ : SUCCESS in 27m 02s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/56/673756/1/gate/tripleo-ci-centos-7-containers-multinode/bf2d9ec/ : SUCCESS in 2h 25m 55s\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/56/673756/1/gate/tripleo-ci-centos-7-standalone/c2437a4/ : SUCCESS in 2h 02m 46s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/56/673756/1/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/faae388/ : SUCCESS in 2h 35m 21s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/56/673756/1/gate/tripleo-ci-centos-7-undercloud-containers/65cb13a/ : SUCCESS in 1h 34m 04s","accounts_in_message":[],"_revision_number":1},{"id":"8d7cdc724d3993c831142aeae9f151b3ed15e760","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 17:40:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f42e42629a0e1aa55ac82eb6486e34987e414ac2","revisions":{"f42e42629a0e1aa55ac82eb6486e34987e414ac2":{"kind":"REWORK","_number":1,"created":"2019-07-31 08:35:52.000000000","uploader":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"ref":"refs/changes/56/673756/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/56/673756/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/56/673756/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/56/673756/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/56/673756/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/56/673756/1"}}},"commit":{"parents":[{"commit":"e9b7f02095bdd7089099bfad06f4f62f46b30655","subject":"Add extra_vars parameter to run_ansible_playbook function","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/e9b7f02095bdd7089099bfad06f4f62f46b30655"}]}],"author":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2019-07-10 15:15:56.000000000","tz":120},"committer":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2019-07-31 08:35:52.000000000","tz":0},"subject":"Allow running validations with custom extra variables","message":"Allow running validations with custom extra variables\n\nThis patch adds the ability to pass extra variables to the validations\nexecution through Mistral and \u0027ansible-playbook\u0027.\n\nBy default, the CLI is running the validations through\n\u0027ansible-playbook\u0027, then the operator will have two possible ways to\nprocess it;\n\nEither passing a Dict with the new --extra-vars argument\n\n```\n$ openstack tripleo validator run \\\n    --extra-vars \u0027{\"min_undercloud_ram_gb\": 2}\u0027\n    --validation-name undercloud-ram\n```\n\nor passing the absolute path of a JSON/YAML file using --extra-vars-file\nargument.\n\n```\n$ cat /home/stack/vars.json\n{\n  \"volumes\": [\n    {\"min_size\": 10, \"mount\": \"/var/lib/docker\"},\n    {\"min_size\": 3,  \"mount\": \"/var/lib/config-data\"},\n    {\"min_size\": 3,  \"mount\": \"/var/log\"},\n    {\"min_size\": 5,  \"mount\": \"/usr\"},\n    {\"min_size\": 20, \"mount\": \"/var\"},\n    {\"min_size\": 25, \"mount\": \"/\"}\n  ]\n}\n$ openstack tripleo validator run \\\n    --extra-vars-file /home/stack/vars.json\n    --validation-name undercloud-disk-space\n```\n\nIf the operator wants to use Mistral, she/he will just need to add the\n--use-mistral argument to the command line in the previous\nexamples.\n\nNote that Mistral will only support a valid JSON file as input.\n\nChange-Id: Idff6bcebc041db483d64396249b040e6bdd778bd\nSigned-off-by: Gael Chamoulaud \u003cgchamoul@redhat.com\u003e\n(cherry picked from commit d13a7d501eba4b25091f16cb9edc374b40ceb8ce)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/f42e42629a0e1aa55ac82eb6486e34987e414ac2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/f42e42629a0e1aa55ac82eb6486e34987e414ac2"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}